René's URL Explorer Experiment


Title: gh-159184: Make the marshal order of set elements with equal dumps stable by gpshead · Pull Request #159197 · python/cpython · GitHub

Open Graph Title: gh-159184: Make the marshal order of set elements with equal dumps stable by gpshead · Pull Request #159197 · python/cpython

X Title: gh-159184: Make the marshal order of set elements with equal dumps stable by gpshead · Pull Request #159197 · python/cpython

Description: This is the second half of gh-159184. The first half, #159196 (merged), stopped marshal from comparing set elements, which fixed the TypeError for complex NaNs. This PR fixes the order such elements are written in. Set elements with the same dump are NaNs that are distinct objects. marshal leaves them in set iteration order, which is the order of their addresses. That is invisible unless one of them is also referenced elsewhere in the dump; then the reference lands at a different place among them from run to run: >>> nans = [float('nan') for _ in range(3)] >>> len({marshal.dumps([n, set(nans)]) for n in nans}) 3 # the same value every time; 1 with this PR Change flowchart TB subgraph before["main"] direction TB b1["list of (dump, index, element)"] --> b2["PyList_Sort()"] b2 --> b3{"run of equal dumps?"} b3 -- no --> b4["ordered by dump"] b3 -- yes --> b5["left in set order
= address order"] end subgraph after["this PR"] direction TB a1["array of {element, dump}"] --> a2["qsort() on the dump bytes"] a2 --> a3{"run of equal dumps?"} a3 -- no --> a4["ordered by dump"] a3 -- yes --> a5["w_same_set_items()"] a5 --> a6["already written in this dump:
first, in the order written"] a5 --> a7["floats and complex not written yet:
interchangeable; which one is which
is decided when one is referenced again"] end Loading For a run of elements with equal dumps, the order is a function of what the writer has already output, never of addresses. This uses the exact reference bookkeeping added by #159192 (merged). The set code moves out of w_complex_object() into w_set_items(). It keeps the checks for a set whose size changes while it is marshalled (#159195, merged). No tuples or list are allocated any more, so ordinary sets are marshalled faster. A set made only of distinct NaN objects is 10-24% slower. Not covered Elements that are containers with equal dumps, not written before the set (for example {(nan1,), (nan2,)} with one of the NaNs also used elsewhere), are still written in set order. A canonical order for that case amounts to graph canonisation. The compiler cannot produce it: every folded NaN is a new object. Tests ReferenceTestCase.test_nan_in_set_order checks exact bytes for sets of float and complex NaNs with references before, after and through other sets. test_nan_in_set also covers complex NaNs. test_nan_constants_in_code compiles source whose constant folding produces NaNs (1e999 - 1e999) as a plain constant, in a tuple constant and in a frozenset constant (x in {...}, the only kind of set the compiler creates), and checks that the code can be marshalled and gives the same bytes in other processes. The compiler cannot make a NaN which is in a set and also referenced elsewhere, so the order fixed here is not observable from compiled code; the test documents that and would not be part of a backport. Authored using Claude, reviewed by me. Issue: gh-159184

Open Graph Description: This is the second half of gh-159184. The first half, #159196 (merged), stopped marshal from comparing set elements, which fixed the TypeError for complex NaNs. This PR fixes the order such eleme...

X Description: This is the second half of gh-159184. The first half, #159196 (merged), stopped marshal from comparing set elements, which fixed the TypeError for complex NaNs. This PR fixes the order such eleme...

Opengraph URL: https://github.com/python/cpython/pull/159197

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:45e7d0d3-6580-6298-a0c9-eb7747beca53
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC758:2BE220:35E90A7:47DDDC4:6B020C69
html-safe-noncebe4e9b003190043c2ca856023d8cd292774c45694a5da983f16117e28333b8ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzU4OjJCRTIyMDozNUU5MEE3OjQ3REREQzQ6NkIwMjBDNjkiLCJ2aXNpdG9yX2lkIjoiMTMwMTYzNjA2NzU4MTEwMzIwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0358820f9034076ac4ffba558828802036a372c9b60d110a32eaab814fcfc89c
hovercard-subject-tagpull_request:4822265163
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159197/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altThis is the second half of gh-159184. The first half, #159196 (merged), stopped marshal from comparing set elements, which fixed the TypeError for complex NaNs. This PR fixes the order such eleme...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159197/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159197%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159197%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159197/files
Reloadhttps://github.com/python/cpython/pull/159197/files
Reloadhttps://github.com/python/cpython/pull/159197/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:marshal-set-tie-orderhttps://github.com/gpshead/cpython/tree/marshal-set-tie-order
Conversation 7 https://github.com/python/cpython/pull/159197
Commits 4 https://github.com/python/cpython/pull/159197/commits
Checks 62 https://github.com/python/cpython/pull/159197/checks
Files changed 3 https://github.com/python/cpython/pull/159197/files
gh-159184: Make the marshal order of set elements with equal dumps stable https://github.com/python/cpython/pull/159197/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/159197/files
b3dea86 gh-159184: Make the marshal order of set elements with equal dumps st… gpshead Oct 11, 2026 https://github.com/python/cpython/pull/159197/commits/b3dea86b74fba41bdf21da08c68cecc55d66f21b
154f14c Test marshalling of the NaN constants the compiler can produce gpshead Oct 31, 2026 https://github.com/python/cpython/pull/159197/commits/154f14c1d5495c82c37ee1dc8db97dd1b2234636
0ebff0e Do not assume a set element has been remembered for references gpshead Oct 31, 2026 https://github.com/python/cpython/pull/159197/commits/0ebff0ec6e0fc9f31d3fbe84886dc3af76723e9c
114bec5 Clarify two comments in the set writing code and its test gpshead Oct 31, 2026 https://github.com/python/cpython/pull/159197/commits/114bec57478effa71c6f16e45498fa6d36506944
Clear filters https://github.com/python/cpython/pull/159197/files
Please reload this pagehttps://github.com/python/cpython/pull/159197/files
Please reload this pagehttps://github.com/python/cpython/pull/159197/files
test_marshal.py https://github.com/python/cpython/pull/159197/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
2026-10-11-08-42-00.gh-issue-159184.Tq2nSe.rst https://github.com/python/cpython/pull/159197/files#diff-475910322a87cc5f67e2efa45f3a63f49907945199395e8efce8e32c81f0acc5
marshal.c https://github.com/python/cpython/pull/159197/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
Lib/test/test_marshal.pyhttps://github.com/python/cpython/pull/159197/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
View file https://github.com/gpshead/cpython/blob/114bec57478effa71c6f16e45498fa6d36506944/Lib/test/test_marshal.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159197/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159197/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/159197/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/159197/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/159197/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/159197/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/159197/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/159197/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/159197/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
Misc/NEWS.d/next/Library/2026-10-11-08-42-00.gh-issue-159184.Tq2nSe.rsthttps://github.com/python/cpython/pull/159197/files#diff-475910322a87cc5f67e2efa45f3a63f49907945199395e8efce8e32c81f0acc5
View file https://github.com/gpshead/cpython/blob/114bec57478effa71c6f16e45498fa6d36506944/Misc/NEWS.d/next/Library/2026-10-11-08-42-00.gh-issue-159184.Tq2nSe.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159197/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/159197/files
Please reload this pagehttps://github.com/python/cpython/pull/159197/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.