René's URL Explorer Experiment


Title: gh-159184: Make the marshal order of set elements with equal dumps stable by gpshead · Pull Request #159197 · python/cpython · GitHub

Open Graph Title: gh-159184: Make the marshal order of set elements with equal dumps stable by gpshead · Pull Request #159197 · python/cpython

X Title: gh-159184: Make the marshal order of set elements with equal dumps stable by gpshead · Pull Request #159197 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This is the second half of gh-159184. The first half, #159196 (merged), stopped marshal from comparing set elements, which fixed the TypeError for complex NaNs. This PR fixes the order such eleme...

X Description: This is the second half of gh-159184. The first half, #159196 (merged), stopped marshal from comparing set elements, which fixed the TypeError for complex NaNs. This PR fixes the order such eleme...

Opengraph URL: https://github.com/python/cpython/pull/159197

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8ea5a07f-8610-2a67-26d2-0a71f0203768
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD470:3E4205:345C37C:45F3E2B:6B020673
html-safe-nonce578fde429a070bef1e82c1691052febe945d8220d10f2fe60e432303532a7d52
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDcwOjNFNDIwNTozNDVDMzdDOjQ1RjNFMkI6NkIwMjA2NzMiLCJ2aXNpdG9yX2lkIjoiNjIyMzg5NTgzOTgxMTcwMDMzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac30e3268cba39f2976c3e1f0382d4ea8e49b06f0ef43b0e401e2fdfe460ba543a
hovercard-subject-tagpull_request:4822265163
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/159197/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8a64c0bec99f61f33753d7f234627cdcc2000a30029ebdb848ac1bc8cee5308e/python/cpython/pull/159197
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8a64c0bec99f61f33753d7f234627cdcc2000a30029ebdb848ac1bc8cee5308e/python/cpython/pull/159197
og:image:altThis is the second half of gh-159184. The first half, #159196 (merged), stopped marshal from comparing set elements, which fixed the TypeError for complex NaNs. This PR fixes the order such eleme...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegpshead
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/159197#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159197
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159197
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159197
Reloadhttps://github.com/python/cpython/pull/159197
Reloadhttps://github.com/python/cpython/pull/159197
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:marshal-set-tie-orderhttps://github.com/gpshead/cpython/tree/marshal-set-tie-order
Conversationhttps://github.com/python/cpython/pull/159197
Commits4 (4)https://github.com/python/cpython/pull/159197/commits
Checkshttps://github.com/python/cpython/pull/159197/checks
Files changedhttps://github.com/python/cpython/pull/159197/files
gh-159184: Make the marshal order of set elements with equal dumps stablehttps://github.com/python/cpython/pull/159197#top
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:marshal-set-tie-orderhttps://github.com/gpshead/cpython/tree/marshal-set-tie-order
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Oct 11, 2026https://github.com/python/cpython/pull/159197#issue-5805087186
Please reload this pagehttps://github.com/python/cpython/pull/159197
gh-159184https://github.com/python/cpython/issues/159184
#159196https://github.com/python/cpython/pull/159196
gh-129724: gh-156504: Make marshal output independent of reference counts #159192https://github.com/python/cpython/pull/159192
gh-159185: Fix marshalling of a set modified while its elements are marshalled #159195https://github.com/python/cpython/pull/159195
marshal.dumps() raises TypeError for a set containing several complex NaNs #159184https://github.com/python/cpython/issues/159184
Please reload this pagehttps://github.com/python/cpython/pull/159197
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Oct 11, 2026https://github.com/python/cpython/pull/159197#event-33003277478
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 11, 2026 https://github.com/python/cpython/pull/159197#ref-issue-5803459096
marshal.dumps() raises TypeError for a set containing several complex NaNs #159184 https://github.com/python/cpython/issues/159184
https://github.com/apps/read-the-docs-community
read-the-docs-communityhttps://github.com/apps/read-the-docs-community
Oct 11, 2026https://github.com/python/cpython/pull/159197#issuecomment-6113663172
Please reload this pagehttps://github.com/python/cpython/pull/159197
cpython-previewshttps://app.readthedocs.org/projects/cpython-previews/
#35080091https://app.readthedocs.org/projects/cpython-previews/builds/35080091/
a4b8ab9https://github.com/python/cpython/commit/a4b8ab907bf5f06ae807a76e3bb3eb9d7607bd36
mainhttps://cpython-previews.readthedocs.io/en/main/
e878e1ehttps://github.com/python/cpython/commit/e878e1e9688ebaafbfae700a872fa30a9f86a4c4
  🔍 Preview build   https://cpython-previews--159197.org.readthedocs.build/en/159197/
c-api/marshal.htmlhttps://cpython-previews--159197.org.readthedocs.build/en/159197/c-api/marshal.html
whatsnew/changelog.htmlhttps://cpython-previews--159197.org.readthedocs.build/en/159197/whatsnew/changelog.html
Please reload this pagehttps://github.com/python/cpython/pull/159197
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
force-pushedhttps://github.com/python/cpython/compare/0e892229955b7418cd6424bd43a3f0d0a85f710a..a4b8ab907bf5f06ae807a76e3bb3eb9d7607bd36
0e89222https://github.com/python/cpython/commit/0e892229955b7418cd6424bd43a3f0d0a85f710a
a4b8ab9https://github.com/python/cpython/commit/a4b8ab907bf5f06ae807a76e3bb3eb9d7607bd36
Compare https://github.com/python/cpython/compare/0e892229955b7418cd6424bd43a3f0d0a85f710a..a4b8ab907bf5f06ae807a76e3bb3eb9d7607bd36
October 11, 2026 23:05https://github.com/python/cpython/pull/159197#event-33007777361
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Oct 11, 2026 https://github.com/python/cpython/pull/159197#ref-pullrequest-5804198883
gh-129724: gh-156504: Make marshal output independent of reference counts #159192 https://github.com/python/cpython/pull/159192
https://github.com/gpshead
pythongh-159184https://github.com/python/cpython/issues/159184
: Make the marshal order of set elements with equal du…https://github.com/python/cpython/pull/159197/commits/b3dea86b74fba41bdf21da08c68cecc55d66f21b
b3dea86https://github.com/python/cpython/pull/159197/commits/b3dea86b74fba41bdf21da08c68cecc55d66f21b
pythongh-129724https://github.com/python/cpython/issues/129724
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
force-pushedhttps://github.com/python/cpython/compare/a4b8ab907bf5f06ae807a76e3bb3eb9d7607bd36..b3dea86b74fba41bdf21da08c68cecc55d66f21b
a4b8ab9https://github.com/python/cpython/commit/a4b8ab907bf5f06ae807a76e3bb3eb9d7607bd36
b3dea86https://github.com/python/cpython/commit/b3dea86b74fba41bdf21da08c68cecc55d66f21b
Compare https://github.com/python/cpython/compare/a4b8ab907bf5f06ae807a76e3bb3eb9d7607bd36..b3dea86b74fba41bdf21da08c68cecc55d66f21b
October 13, 2026 04:41https://github.com/python/cpython/pull/159197#event-33101942920
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
October 13, 2026 04:43https://github.com/python/cpython/pull/159197#event-33102030349
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 13, 2026https://github.com/python/cpython/pull/159197#event-33102032729
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
October 13, 2026 04:47https://github.com/python/cpython/pull/159197#event-33102229630
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 13, 2026https://github.com/python/cpython/pull/159197#event-33102232101
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
October 13, 2026 05:01https://github.com/python/cpython/pull/159197#event-33102855953
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 13, 2026https://github.com/python/cpython/pull/159197#event-33102858518
https://github.com/khmyznikov
khmyznikovhttps://github.com/khmyznikov
Oct 15, 2026 https://github.com/python/cpython/pull/159197#ref-pullrequest-5261928878
Pip install performance improvements on Windows pypa/pip#14286 https://github.com/pypa/pip/pull/14286
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
methanehttps://github.com/methane
October 25, 2026 07:30https://github.com/python/cpython/pull/159197#event-34170324875
https://github.com/methane
methanehttps://github.com/methane
Oct 26, 2026 https://github.com/python/cpython/pull/159197#pullrequestreview-5650741524
View reviewed changes https://github.com/python/cpython/pull/159197/files/b3dea86b74fba41bdf21da08c68cecc55d66f21b
Python/marshal.chttps://github.com/python/cpython/pull/159197/files/b3dea86b74fba41bdf21da08c68cecc55d66f21b#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
Please reload this pagehttps://github.com/python/cpython/pull/159197
gpsheadhttps://github.com/gpshead
October 31, 2026 21:39https://github.com/python/cpython/pull/159197#commits-pushed-154f14c
https://github.com/gpshead
Test marshalling of the NaN constants the compiler can producehttps://github.com/python/cpython/pull/159197/commits/154f14c1d5495c82c37ee1dc8db97dd1b2234636
154f14chttps://github.com/python/cpython/pull/159197/commits/154f14c1d5495c82c37ee1dc8db97dd1b2234636
https://github.com/gpshead
Do not assume a set element has been remembered for referenceshttps://github.com/python/cpython/pull/159197/commits/0ebff0ec6e0fc9f31d3fbe84886dc3af76723e9c
0ebff0ehttps://github.com/python/cpython/pull/159197/commits/0ebff0ec6e0fc9f31d3fbe84886dc3af76723e9c
pythonGH-159197https://github.com/python/cpython/pull/159197
https://github.com/gpshead
Clarify two comments in the set writing code and its testhttps://github.com/python/cpython/pull/159197/commits/114bec57478effa71c6f16e45498fa6d36506944
114bec5https://github.com/python/cpython/pull/159197/commits/114bec57478effa71c6f16e45498fa6d36506944
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
3c23ebfhttps://github.com/python/cpython/commit/3c23ebfdf7750cff757e50e6e8c753f89ce849c6
Nov 1, 2026https://github.com/python/cpython/pull/159197#event-34811711410
Please reload this pagehttps://github.com/python/cpython/pull/159197
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 1, 2026https://github.com/python/cpython/pull/159197#event-34811713721
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
November 1, 2026 03:22https://github.com/python/cpython/pull/159197#event-34811714354
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Nov 1, 2026https://github.com/python/cpython/pull/159197#event-34811747039
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 1, 2026https://github.com/python/cpython/pull/159197#issuecomment-6552840312
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/159197
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 1, 2026https://github.com/python/cpython/pull/159197#issuecomment-6552840341
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/159197
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 1, 2026https://github.com/python/cpython/pull/159197#issuecomment-6552840796
@gpsheadhttps://github.com/gpshead
cherry_pickerhttps://pypi.org/project/cherry-picker/
devguidehttps://devguide.python.org/getting-started/git-boot-camp/#backporting-merged-changes
Please reload this pagehttps://github.com/python/cpython/pull/159197
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 1, 2026https://github.com/python/cpython/pull/159197#issuecomment-6552841354
@gpsheadhttps://github.com/gpshead
cherry_pickerhttps://pypi.org/project/cherry-picker/
devguidehttps://devguide.python.org/getting-started/git-boot-camp/#backporting-merged-changes
Please reload this pagehttps://github.com/python/cpython/pull/159197
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Nov 1, 2026https://github.com/python/cpython/pull/159197#event-34811757800
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Nov 1, 2026https://github.com/python/cpython/pull/159197#event-34811757825
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Nov 2, 2026 https://github.com/python/cpython/pull/159197#ref-issue-6164895432
unused variable compiler warning in marshal.c #161187 https://github.com/python/cpython/issues/161187
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159197
https://github.com/methane
methane https://github.com/methane
https://github.com/python/cpython/pull/159197/files/b3dea86b74fba41bdf21da08c68cecc55d66f21b
Please reload this pagehttps://github.com/python/cpython/pull/159197
https://github.com/gpshead
gpshead https://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/159197
https://github.com/gpshead
https://github.com/methane
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.