René's URL Explorer Experiment


Title: gh-159185: Fix marshalling of a set modified while its elements are marshalled by gpshead · Pull Request #159195 · python/cpython · GitHub

Open Graph Title: gh-159185: Fix marshalling of a set modified while its elements are marshalled by gpshead · Pull Request #159195 · python/cpython

X Title: gh-159185: Fix marshalling of a set modified while its elements are marshalled by gpshead · Pull Request #159195 · python/cpython

Description: To order the elements of a set, marshal marshals each element on its own. That can run Python code (an element's __buffer__(), an audit hook), and that code can change the set. The number of elements was read once, before the loop. class Item: def __hash__(self): return 0 def __buffer__(self, flags): s.update(range(1000, 1400)) # or: s.difference_update(range(1, 60)) return memoryview(b'abc') s = {Item()} s.update(range(1, 60)) marshal.dumps(s) on main release build debug build set grows no error; writes past the end of the list PyList_SET_ITEM: Assertion 'index < list->allocated' failed set shrinks segmentation fault w_complex_object: Assertion `i == n' failed With this PR both raise RuntimeError: set changed size during iteration, as iterating the set would. Change flowchart TB subgraph before["main"] direction TB b1["n = size of the set"] --> b2["list of n slots"] b2 --> b3["for each element:
marshal it (may run Python code)
store in slot i++"] b3 -- "set grew" --> b4["writes past slot n"] b3 -- "set shrank" --> b5["slots left NULL,
then sorted"] end subgraph after["this PR"] direction TB a1["n = size of the set"] --> a2["list of n slots"] a2 --> a3["for each element:
stop if i == n
marshal it, store in slot i++"] a3 --> a4{"stopped early,
or i != n?"} a4 -- yes --> a5["RuntimeError"] a4 -- no --> a6["sort and write"] end Loading The change is two checks around the existing loop in w_complex_object(). On the free-threaded build the same checks cover another thread changing the set between the size being read and the critical section being entered. A set that is changed without changing its size is not detected; that is memory safe, and the output is whatever was iterated. This touches the same block as the PR for gh-159184; whichever is merged second needs a one-line conflict resolved. Tests test_set_changed_size: grow and shrink, all marshal versions. Issue: gh-159185

Open Graph Description: To order the elements of a set, marshal marshals each element on its own. That can run Python code (an element's __buffer__(), an audit hook), and that code can change the set. The number of ...

X Description: To order the elements of a set, marshal marshals each element on its own. That can run Python code (an element&#39;s __buffer__(), an audit hook), and that code can change the set. The number...

Opengraph URL: https://github.com/python/cpython/pull/159195

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c9007cfd-9abc-502a-e06e-de75b8b90672
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8416:34DB8F:34F174E:46BE98A:6B0210D2
html-safe-noncebd95846323e22e0120b17e5b0d7b5b534f02e37d029d105fdd6f9d47795b39e3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDE2OjM0REI4RjozNEYxNzRFOjQ2QkU5OEE6NkIwMjEwRDIiLCJ2aXNpdG9yX2lkIjoiNzg2Njc0Mzg5NDUwNjA4MjUxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac53127c1a854554830dbbab0c7caf5c9ba15f0760ad9ad51d1a4ef4ba40c8f21e
hovercard-subject-tagpull_request:4822162720
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159195/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altTo order the elements of a set, marshal marshals each element on its own. That can run Python code (an element's __buffer__(), an audit hook), and that code can change the set. The number of ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159195/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159195%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159195%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159195/files
Reloadhttps://github.com/python/cpython/pull/159195/files
Reloadhttps://github.com/python/cpython/pull/159195/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:marshal-set-changed-sizehttps://github.com/gpshead/cpython/tree/marshal-set-changed-size
Conversation 5 https://github.com/python/cpython/pull/159195
Commits 1 https://github.com/python/cpython/pull/159195/commits
Checks 65 https://github.com/python/cpython/pull/159195/checks
Files changed 3 https://github.com/python/cpython/pull/159195/files
gh-159185: Fix marshalling of a set modified while its elements are marshalled https://github.com/python/cpython/pull/159195/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/159195/files
379943f gh-159185: Fix marshalling of a set modified while its elements are m… gpshead Oct 11, 2026 https://github.com/python/cpython/pull/159195/commits/379943fbaeec9f7194ccd7d16942e57079ad2a9e
Clear filters https://github.com/python/cpython/pull/159195/files
Please reload this pagehttps://github.com/python/cpython/pull/159195/files
Please reload this pagehttps://github.com/python/cpython/pull/159195/files
test_marshal.py https://github.com/python/cpython/pull/159195/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
2026-10-11-08-40-00.gh-issue-159185.Sq7cZd.rst https://github.com/python/cpython/pull/159195/files#diff-fc9d0b6c9572baf9eff1679e05df73ff4e020637c495f7b37f7e1d42a34da2e6
marshal.c https://github.com/python/cpython/pull/159195/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
Lib/test/test_marshal.pyhttps://github.com/python/cpython/pull/159195/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
View file https://github.com/gpshead/cpython/blob/379943fbaeec9f7194ccd7d16942e57079ad2a9e/Lib/test/test_marshal.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159195/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159195/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/159195/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
Misc/NEWS.d/next/Library/2026-10-11-08-40-00.gh-issue-159185.Sq7cZd.rsthttps://github.com/python/cpython/pull/159195/files#diff-fc9d0b6c9572baf9eff1679e05df73ff4e020637c495f7b37f7e1d42a34da2e6
View file https://github.com/gpshead/cpython/blob/379943fbaeec9f7194ccd7d16942e57079ad2a9e/Misc/NEWS.d/next/Library/2026-10-11-08-40-00.gh-issue-159185.Sq7cZd.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159195/{{ revealButtonHref }}
Python/marshal.chttps://github.com/python/cpython/pull/159195/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
View file https://github.com/gpshead/cpython/blob/379943fbaeec9f7194ccd7d16942e57079ad2a9e/Python/marshal.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159195/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159195/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
https://github.com/python/cpython/pull/159195/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
https://github.com/python/cpython/pull/159195/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
Please reload this pagehttps://github.com/python/cpython/pull/159195/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.