René's URL Explorer Experiment


Title: gh-129724: gh-156504: Make marshal output independent of reference counts by gpshead · Pull Request #159192 · python/cpython · GitHub

Open Graph Title: gh-129724: gh-156504: Make marshal output independent of reference counts by gpshead · Pull Request #159192 · python/cpython

X Title: gh-129724: gh-156504: Make marshal output independent of reference counts by gpshead · Pull Request #159192 · python/cpython

Description: marshal.dumps() could give different bytes for the same value, because the writer used the reference count of each object to decide whether a later occurrence may refer back to it (FLAG_REF). The count depends on what else in the process holds a reference to the object, and on the free-threaded build on which thread owns it. This is the cause of gh-156504 and one of the two causes of gh-129724 (the other is in the compiler: see the companion PR gh-159193). FLAG_REF is now set on exactly the objects that are written more than once in the dump. Example >>> x = float('1.5') >>> marshal.dumps([float('1.5')]).hex(' ') # refcount 1 '5b 01 00 00 00 67 00 00 00 00 00 00 f8 3f' >>> marshal.dumps([x]).hex(' ') # refcount 2: main sets FLAG_REF (0x80) '5b 01 00 00 00 e7 00 00 00 00 00 00 f8 3f' With this PR both calls return the first form. Where an object really is written twice, the index of the reference no longer counts objects that were flagged for nothing: value: [a, b, b] a = 1.5 and b = 2.5, both also referenced from elsewhere main: [ 3 FLOAT|REF 1.5 FLOAT|REF 2.5 REF #1 ] a is flagged for nothing, so b is #1 this PR: [ 3 FLOAT 1.5 FLOAT|REF 2.5 REF #0 ] only b is flagged, so b is #0 How The reader numbers the flagged objects in the order it meets them, so the writer cannot know the index of a reference until it knows which earlier objects end up flagged. It still makes a single pass over the objects, and fixes up the output at the end. flowchart TB subgraph before["main"] direction TB b1["w_ref(obj)"] --> b2{"refcount == 1?"} b2 -- yes --> b3["write object
no flag"] b2 -- no --> b4{"seen before?"} b4 -- no --> b5["write object + FLAG_REF
index = number flagged so far"] b4 -- yes --> b6["write TYPE_REF index"] end subgraph after["this PR"] direction TB a1["w_ref(obj)"] --> a2{"refcount == 1?"} a2 -- yes --> a3["write object
(cannot occur twice)"] a2 -- no --> a4{"seen before?"} a4 -- no --> a5["write object, no flag yet
remember offset of its type byte"] a4 -- yes --> a6["mark object shared
write TYPE_REF + provisional index
remember its position"] a5 --> a7 a6 --> a7["w_resolve_refs(), once, at the end:
set FLAG_REF on shared objects,
number them, rewrite TYPE_REF indexes"] end Loading A reference count of 1 is still used, but only as a shortcut to skip the hash table: such an object cannot occur twice, so the result is the same without it. Interned strings are no longer flagged unconditionally. The reader is unchanged and the format version is not bumped. Old and new readers load old and new output. PyMarshal_WriteObjectToFile() now builds the data in memory and writes it with one fwrite(), since the flags are only known at the end. Nothing is written if the object cannot be marshalled. Documented in Doc/c-api/marshal.rst. Compatibility The bytes of every .pyc change (fewer flags), which is why Programs/test_frozenmain.h is regenerated. marshal.loads() gives the same objects with the same sharing. The generated pycs can be loaded by prior Python versions, but this kind of change might be considered disruptive for some when considering a backport. Realistically: prior versions are all "broken" by not producing stable output in real world scenarios, so any bug fixes going in that stabilize how things work are going to lead to some newly generated bytecode changing vs what was seen in the past, as already happens between runs compiling the same source file under different process state today. Related: #159197 is stacked on top of this. Performance Release builds, not PGO, compared with main: default (GIL) free-threaded dumps of the code objects of the stdlib 3.7% slower 4.3% slower dumps dominated by references (millions of TYPE_REF) 5-9% slower dumps of unshared data (1M distinct floats) 32% faster loads of the new output 3-5% faster Writer memory grows by 8 bytes per object with a reference count above 1. Tests ReferenceTestCase in test_marshal checks exact bytes: single occurrences are not flagged whatever their reference count, interned strings, references at every buffer offset, objects seen before and after the ones they share with, NaNs in sets. test_capi.test_marshal checks that nothing is written on error. drafted using Claude, reviewed & iterated upon by me. Fixes #156504

Open Graph Description: marshal.dumps() could give different bytes for the same value, because the writer used the reference count of each object to decide whether a later occurrence may refer back to it (FLAG_REF). The ...

X Description: marshal.dumps() could give different bytes for the same value, because the writer used the reference count of each object to decide whether a later occurrence may refer back to it (FLAG_REF). The ...

Opengraph URL: https://github.com/python/cpython/pull/159192

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0e4a13e6-2a4c-aca8-ca99-701fbd4eec90
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB6A:A71F9:32E04B9:4067B55:6B020AED
html-safe-nonce7d4c4a3e749713e7494919cee7fb1cbebb1a78ca8a07936653504e8e17158e4c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjZBOkE3MUY5OjMyRTA0Qjk6NDA2N0I1NTo2QjAyMEFFRCIsInZpc2l0b3JfaWQiOiI2MTQ2OTkyODgyNzEzNzU4NDQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac31f499d034e390bc1ea8bcd5fe9c5a50ae6caafd836d5667172c4f26ab92a1d1
hovercard-subject-tagpull_request:4821554667
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159192/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altmarshal.dumps() could give different bytes for the same value, because the writer used the reference count of each object to decide whether a later occurrence may refer back to it (FLAG_REF). The ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159192/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159192%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159192%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159192/files
Reloadhttps://github.com/python/cpython/pull/159192/files
Reloadhttps://github.com/python/cpython/pull/159192/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:marshal-exact-refshttps://github.com/gpshead/cpython/tree/marshal-exact-refs
Conversation 6 https://github.com/python/cpython/pull/159192
Commits 2 https://github.com/python/cpython/pull/159192/commits
Checks 53 https://github.com/python/cpython/pull/159192/checks
Files changed 7 https://github.com/python/cpython/pull/159192/files
gh-129724: gh-156504: Make marshal output independent of reference counts https://github.com/python/cpython/pull/159192/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/159192/files
7893950 gh-129724: Make marshal output independent of reference counts gpshead Oct 11, 2026 https://github.com/python/cpython/pull/159192/commits/78939500b81313474d6030da0cb4f3fdc516553e
d69021e Merge the gh-156504 NEWS entry into the gh-129724 one gpshead Oct 13, 2026 https://github.com/python/cpython/pull/159192/commits/d69021ed3d5b4dad860e32d15c1e53ca8b54b3ac
Clear filters https://github.com/python/cpython/pull/159192/files
Please reload this pagehttps://github.com/python/cpython/pull/159192/files
Please reload this pagehttps://github.com/python/cpython/pull/159192/files
marshal.rst https://github.com/python/cpython/pull/159192/files#diff-9552e29b14533f455241dfb30a7a184a94f7d1600c6c0f52807dc1f7b6083d4e
test_marshal.py https://github.com/python/cpython/pull/159192/files#diff-1fe4807b1dca21cdea56d77bb55db8e2639506879b3aab04bcefbab5ef0f9cb0
test_marshal.py https://github.com/python/cpython/pull/159192/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
2026-10-11-06-20-11.gh-issue-129724.Wq3nTb.rst https://github.com/python/cpython/pull/159192/files#diff-2f93a9f619df538d1567ba46ca400224c951a4a73c0704115feccc7b76d138f4
2026-10-11-06-00-00.gh-issue-129724.mRsh1x.rst https://github.com/python/cpython/pull/159192/files#diff-2dfd9c6cc222c242b5abd150193492a70584eec11a93913813a551ba61b0d049
test_frozenmain.h https://github.com/python/cpython/pull/159192/files#diff-dcbbf153f77c69fb3a08746516bb9baaf46b9465c941221d1d495123e92cc862
marshal.c https://github.com/python/cpython/pull/159192/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L114
Doc/c-api/marshal.rsthttps://github.com/python/cpython/pull/159192/files#diff-9552e29b14533f455241dfb30a7a184a94f7d1600c6c0f52807dc1f7b6083d4e
View file https://github.com/gpshead/cpython/blob/d69021ed3d5b4dad860e32d15c1e53ca8b54b3ac/Doc/c-api/marshal.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159192/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159192/files#diff-9552e29b14533f455241dfb30a7a184a94f7d1600c6c0f52807dc1f7b6083d4e
https://github.com/python/cpython/pull/159192/files#diff-9552e29b14533f455241dfb30a7a184a94f7d1600c6c0f52807dc1f7b6083d4e
https://github.com/python/cpython/pull/159192/files#diff-9552e29b14533f455241dfb30a7a184a94f7d1600c6c0f52807dc1f7b6083d4e
Lib/test/test_capi/test_marshal.pyhttps://github.com/python/cpython/pull/159192/files#diff-1fe4807b1dca21cdea56d77bb55db8e2639506879b3aab04bcefbab5ef0f9cb0
View file https://github.com/gpshead/cpython/blob/d69021ed3d5b4dad860e32d15c1e53ca8b54b3ac/Lib/test/test_capi/test_marshal.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159192/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159192/files#diff-1fe4807b1dca21cdea56d77bb55db8e2639506879b3aab04bcefbab5ef0f9cb0
https://github.com/python/cpython/pull/159192/files#diff-1fe4807b1dca21cdea56d77bb55db8e2639506879b3aab04bcefbab5ef0f9cb0
Please reload this pagehttps://github.com/python/cpython/pull/159192/files
Please reload this pagehttps://github.com/python/cpython/pull/159192/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.