René's URL Explorer Experiment


Title: [3.8] bpo-37409: fix relative import with no parent (GH-14956) by brettcannon · Pull Request #15913 · python/cpython · GitHub

Open Graph Title: [3.8] bpo-37409: fix relative import with no parent (GH-14956) by brettcannon · Pull Request #15913 · python/cpython

X Title: [3.8] bpo-37409: fix relative import with no parent (GH-14956) by brettcannon · Pull Request #15913 · python/cpython

Description: Relative imports use resolve_name to get the absolute target name, which first seeks the current module's absolute package name from the globals: If package (and spec.parent) are missing then import uses name, truncating the last segment if the module is a submodule rather than a package init.py (which it guesses from whether path is defined). The name attempt should fail if there is no parent package (top level modules), if name is 'main' (-m entry points), or both (scripts). That is, if both name has no subcomponents and the module does not seem to be a package init module then import should fail.. (cherry picked from commit 92420b3) Co-authored-by: Ben Lewis benjimin@users.noreply.github.com https://bugs.python.org/issue37409 Automerge-Triggered-By: @brettcannon

Open Graph Description: Relative imports use resolve_name to get the absolute target name, which first seeks the current module's absolute package name from the globals: If package (and spec.parent) are missing then i...

X Description: Relative imports use resolve_name to get the absolute target name, which first seeks the current module's absolute package name from the globals: If package (and spec.parent) are missing th...

Opengraph URL: https://github.com/python/cpython/pull/15913

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e84ec862-3d80-cee9-2e97-557609266777
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA234:3819A0:ADF84B:EEC34F:6A55B7E9
html-safe-noncef0597905cd473b92c463d0ca937c599187b66160981014ea07c6136196c3b8f0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjM0OjM4MTlBMDpBREY4NEI6RUVDMzRGOjZBNTVCN0U5IiwidmlzaXRvcl9pZCI6IjMwNDAwODU2MjMyMTIxOTM3NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4d79df43b155ef3962c227906a3bf864294057a79f6571a254f285716dad734c
hovercard-subject-tagpull_request:316383542
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/15913/files
twitter:imagehttps://avatars.githubusercontent.com/u/54418?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/54418?s=400&v=4
og:image:altRelative imports use resolve_name to get the absolute target name, which first seeks the current module's absolute package name from the globals: If package (and spec.parent) are missing then i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release64b9ae238e18eb87ead1f9fe37a7cc81d67d85aa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/15913/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15913%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15913%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/15913/files
Reloadhttps://github.com/python/cpython/pull/15913/files
Reloadhttps://github.com/python/cpython/pull/15913/files
Please reload this pagehttps://github.com/python/cpython/pull/15913/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/15913/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
brettcannonhttps://github.com/brettcannon
python:3.8https://github.com/python/cpython/tree/3.8
brettcannon:backport-92420b3-3.8https://github.com/brettcannon/cpython/tree/backport-92420b3-3.8
Conversation 2 https://github.com/python/cpython/pull/15913
Commits 1 https://github.com/python/cpython/pull/15913/commits
Checks 0 https://github.com/python/cpython/pull/15913/checks
Files changed https://github.com/python/cpython/pull/15913/files
Please reload this pagehttps://github.com/python/cpython/pull/15913/files
[3.8] bpo-37409: fix relative import with no parent (GH-14956) https://github.com/python/cpython/pull/15913/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/15913/files
54f405f [3.8] bpo-37409: fix relative import with no parent (GH-14956) benjimin Sep 11, 2019 https://github.com/python/cpython/pull/15913/commits/54f405f8a2e27d94c541105ba601e29d8e67dda8
Clear filters https://github.com/python/cpython/pull/15913/files
Please reload this pagehttps://github.com/python/cpython/pull/15913/files
Please reload this pagehttps://github.com/python/cpython/pull/15913/files
test_builtin.py https://github.com/python/cpython/pull/15913/files#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
__init__.py https://github.com/python/cpython/pull/15913/files#diff-ea25b7196846cae64e3ed2b3fb2e1ee420961442fcd801a07bcd9000178bbd58
ACKS https://github.com/python/cpython/pull/15913/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
2019-08-06-23-39-05.bpo-37409.1qwzn2.rst https://github.com/python/cpython/pull/15913/files#diff-b18fe024538e950697dca124e56aa4ba1fcacf45bcffb6b2a808f711eb35ff7c
import.c https://github.com/python/cpython/pull/15913/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
Lib/test/test_builtin.pyhttps://github.com/python/cpython/pull/15913/files#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
View file https://github.com/brettcannon/cpython/blob/54f405f8a2e27d94c541105ba601e29d8e67dda8/Lib/test/test_builtin.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15913/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15913/files#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
https://github.com/python/cpython/pull/15913/files#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
Lib/test/test_import/__init__.pyhttps://github.com/python/cpython/pull/15913/files#diff-ea25b7196846cae64e3ed2b3fb2e1ee420961442fcd801a07bcd9000178bbd58
View file https://github.com/brettcannon/cpython/blob/54f405f8a2e27d94c541105ba601e29d8e67dda8/Lib/test/test_import/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15913/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15913/files#diff-ea25b7196846cae64e3ed2b3fb2e1ee420961442fcd801a07bcd9000178bbd58
https://github.com/python/cpython/pull/15913/files#diff-ea25b7196846cae64e3ed2b3fb2e1ee420961442fcd801a07bcd9000178bbd58
Misc/ACKShttps://github.com/python/cpython/pull/15913/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
View file https://github.com/brettcannon/cpython/blob/54f405f8a2e27d94c541105ba601e29d8e67dda8/Misc/ACKS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15913/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15913/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/pull/15913/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
Misc/NEWS.d/next/Core and Builtins/2019-08-06-23-39-05.bpo-37409.1qwzn2.rsthttps://github.com/python/cpython/pull/15913/files#diff-b18fe024538e950697dca124e56aa4ba1fcacf45bcffb6b2a808f711eb35ff7c
View file https://github.com/brettcannon/cpython/blob/54f405f8a2e27d94c541105ba601e29d8e67dda8/Misc/NEWS.d/next/Core%20and%20Builtins/2019-08-06-23-39-05.bpo-37409.1qwzn2.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15913/{{ revealButtonHref }}
https://github.com/python/cpython/blob/3.8/.github/CODEOWNERS#L35
Python/import.chttps://github.com/python/cpython/pull/15913/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
View file https://github.com/brettcannon/cpython/blob/54f405f8a2e27d94c541105ba601e29d8e67dda8/Python/import.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15913/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15913/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/15913/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/15913/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.