René's URL Explorer Experiment


Title: gh-88037 - Move port validation logic to parsing time by orsenthil · Pull Request #159122 · python/cpython · GitHub

Open Graph Title: gh-88037 - Move port validation logic to parsing time by orsenthil · Pull Request #159122 · python/cpython

X Title: gh-88037 - Move port validation logic to parsing time by orsenthil · Pull Request #159122 · python/cpython

Description: Currently urlsplit()/urlparse() accept a netloc with an invalid port without complaint, the error only surfaces later, and only if something actually reads .port: >>> p = urllib.parse.urlsplit("http://example.com:oracle/") >>> p.netloc # parses "successfully" 'example.com:oracle' >>> p.path '/' >>> p.port # ... raises, but only now, and only if you ask ValueError: Port could not be cast to integer value as 'oracle' This moves that validation to parse time, so urlsplit()/urlparse() raise immediately on a malformed port instead of returning a result that looks valid until .port happens to be accessed. This in conformance with the RFC expectations. RFC 3986 3.2: authority = [ userinfo "@" ] host [ ":" port ] host = IP-literal / IPv4address / reg-name reg-name = *( unreserved / pct-encoded / sub-delims ) ; sub-delims includes "," port = *DIGIT Supersedes #25774 - Rebase of the old branch wasn't suitable: Lib/urllib/parse.py has seen significant changes since 2021 (WHATWG-compliance work, bracketed IPv6 host validation) that the original patch's diff didn't account for. The original commit is kept in-tact. I was curious on performance of moving this lazy validation to eager, I let the claude run in tiny benchmark. Benchmark Measured with timeit (best of 5 runs) on a local ./python build of this branch (3.16.0a0), comparing the real, unmodified Lib/urllib/parse.py from main (lazy validation) against this branch's version (eager, parse-time validation). _checknetloc in isolation (500k calls each): netloc lazy (main) eager (this PR) delta ASCII, no port 54.0 ns 288.4 ns +234.5 ns ASCII, with port 53.2 ns 468.2 ns +415.0 ns Bracketed IPv6 53.6 ns 575.6 ns +522.0 ns Public urlsplit(), which is @functools.lru_cache-wrapped (128 entries): scenario lazy (main) eager (this PR) delta cache hit (same URL reparsed) 124.1 ns 124.2 ns +0.1 ns (+0.08%) cache miss (unique URL each call) 2626.8 ns 3131.9 ns +505.1 ns (+19.2%) Takeaways: When a URL has already been parsed once, the cache absorbs the difference entirely — effectively zero added cost. For a never-before-seen URL, the added cost is ~500 ns, sub-microsecond in absolute terms and negligible next to any I/O the parsed result is normally used for (DNS/connect/TLS are milliseconds; this is nanoseconds). Issue: gh-88037

Open Graph Description: Currently urlsplit()/urlparse() accept a netloc with an invalid port without complaint, the error only surfaces later, and only if something actually reads .port: >>> p = urllib.parse...

X Description: Currently urlsplit()/urlparse() accept a netloc with an invalid port without complaint, the error only surfaces later, and only if something actually reads .port: >>> p = ...

Opengraph URL: https://github.com/python/cpython/pull/159122

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c1c3c217-4db1-982d-716d-6af3b2675f25
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4FA:2E7EBB:4AFD98B:5EAB511:6B0245EC
html-safe-nonce46726dbcdf70b21768008ec950566af7f9a863da2d7b265006485cc0573c1fa8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEZBOjJFN0VCQjo0QUZEOThCOjVFQUI1MTE6NkIwMjQ1RUMiLCJ2aXNpdG9yX2lkIjoiNjM0NjI2NDU4NjI2NTcwODAxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfd1c73fd7dd57bcee38eb1a2d34841fc205e7230352d308d846adba3cdbd6d09
hovercard-subject-tagpull_request:4811680350
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159122/files
twitter:imagehttps://avatars.githubusercontent.com/u/332330?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/332330?s=400&v=4
og:image:altCurrently urlsplit()/urlparse() accept a netloc with an invalid port without complaint, the error only surfaces later, and only if something actually reads .port: >>> p = urllib.parse...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159122/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159122%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159122%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159122/files
Reloadhttps://github.com/python/cpython/pull/159122/files
Reloadhttps://github.com/python/cpython/pull/159122/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
orsenthilhttps://github.com/orsenthil
python:mainhttps://github.com/python/cpython/tree/main
orsenthil:gh-88037-port-validationhttps://github.com/orsenthil/cpython/tree/gh-88037-port-validation
Conversation 15 https://github.com/python/cpython/pull/159122
Commits 2 https://github.com/python/cpython/pull/159122/commits
Checks 62 https://github.com/python/cpython/pull/159122/checks
Files changed https://github.com/python/cpython/pull/159122/files
Please reload this pagehttps://github.com/python/cpython/pull/159122/files
gh-88037 - Move port validation logic to parsing time https://github.com/python/cpython/pull/159122/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/159122/files
315747a Move port validation logic to parsing time miguendes Apr 30, 2021 https://github.com/python/cpython/pull/159122/commits/315747ac0591764f12b7e3a584b575cb3e5ce4ff
32c6255 Fix CI. Handle the special case of file://C:\\ parsed by url2pathname orsenthil Oct 12, 2026 https://github.com/python/cpython/pull/159122/commits/32c625530aa84ad5a1bfba1766a30928f778eaed
Clear filters https://github.com/python/cpython/pull/159122/files
Please reload this pagehttps://github.com/python/cpython/pull/159122/files
Please reload this pagehttps://github.com/python/cpython/pull/159122/files
test_urllib.py https://github.com/python/cpython/pull/159122/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
test_urllib2.py https://github.com/python/cpython/pull/159122/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
test_urlparse.py https://github.com/python/cpython/pull/159122/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
parse.py https://github.com/python/cpython/pull/159122/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
request.py https://github.com/python/cpython/pull/159122/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
2026-10-11-13-08-07.gh-issue-88037.CzKcxh.rst https://github.com/python/cpython/pull/159122/files#diff-9152f528afd7e3e9ab08193b47e4cfeadc03dd30f10f566467e27848163efc00
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L644
Lib/test/test_urllib.pyhttps://github.com/python/cpython/pull/159122/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
View file https://github.com/orsenthil/cpython/blob/32c625530aa84ad5a1bfba1766a30928f778eaed/Lib/test/test_urllib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159122/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159122/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/159122/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/159122/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/159122/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/159122/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/159122/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L644
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/159122/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
View file https://github.com/orsenthil/cpython/blob/32c625530aa84ad5a1bfba1766a30928f778eaed/Lib/test/test_urllib2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159122/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159122/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
https://github.com/python/cpython/pull/159122/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
Lib/test/test_urlparse.pyhttps://github.com/python/cpython/pull/159122/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
View file https://github.com/orsenthil/cpython/blob/32c625530aa84ad5a1bfba1766a30928f778eaed/Lib/test/test_urlparse.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159122/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159122/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
https://github.com/python/cpython/pull/159122/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
https://github.com/python/cpython/pull/159122/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
https://github.com/python/cpython/pull/159122/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
https://github.com/python/cpython/pull/159122/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
https://github.com/python/cpython/pull/159122/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L643
Lib/urllib/parse.pyhttps://github.com/python/cpython/pull/159122/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
View file https://github.com/orsenthil/cpython/blob/32c625530aa84ad5a1bfba1766a30928f778eaed/Lib/urllib/parse.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159122/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159122/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/159122/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/159122/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/159122/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/159122/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/159122/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/159122/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/159122/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
Please reload this pagehttps://github.com/python/cpython/pull/159122/files
https://github.com/python/cpython/pull/159122/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L643
Lib/urllib/request.pyhttps://github.com/python/cpython/pull/159122/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
View file https://github.com/orsenthil/cpython/blob/32c625530aa84ad5a1bfba1766a30928f778eaed/Lib/urllib/request.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159122/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159122/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
https://github.com/python/cpython/pull/159122/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
https://github.com/python/cpython/pull/159122/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
https://github.com/python/cpython/pull/159122/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
Misc/NEWS.d/next/Library/2026-10-11-13-08-07.gh-issue-88037.CzKcxh.rsthttps://github.com/python/cpython/pull/159122/files#diff-9152f528afd7e3e9ab08193b47e4cfeadc03dd30f10f566467e27848163efc00
View file https://github.com/orsenthil/cpython/blob/32c625530aa84ad5a1bfba1766a30928f778eaed/Misc/NEWS.d/next/Library/2026-10-11-13-08-07.gh-issue-88037.CzKcxh.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159122/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/159122/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.