René's URL Explorer Experiment


Title: gh-159071: Fix utf-8-sig decode error offsets by hetaozdh · Pull Request #159082 · python/cpython · GitHub

Open Graph Title: gh-159071: Fix utf-8-sig decode error offsets by hetaozdh · Pull Request #159082 · python/cpython

X Title: gh-159071: Fix utf-8-sig decode error offsets by hetaozdh · Pull Request #159082 · python/cpython

Description: Fixes #159071. Problem utf-8-sig strips the BOM before decoding. If exception, the resulting UnicodeDecodeError refers to the stripped input: start and end are both small by 3, and object no longer contains the BOM. For example, b'\xef\xbb\xbf\xff'.decode('utf-8-sig') reports position 0, while the invalid byte is at position 3. The utf-16 and utf-32 codecs already report offsets relative to the original input. Fix Add _fix_decode_error() to restore the original input and correct the offsets. It was used in decode(), IncrementalDecoder._buffer_decode() and StreamReader.decode(). The exception is adjusted in place to preserve its traceback. Incremental decoding uses the buffered input as the base, so offsets remain correct even when the BOM is split across chunks. The helper also handles memoryview inputs, converting them to bytes when needed. Tests Add tests for the codec API, incremental decoding and stream readers, including invalid bytes, truncated sequences and a BOM split across chunks. All three tests fail without the fix, and test_codecs passes with it. Notes Custom error handlers still see offsets relative to the BOM-stripped input, since they run before the exception reaches the caller. Fixing that would require wrapping the handler and is outside this PR's scope. No documentation changes are needed. AI tools were used in preparing this change. /cc @alicederyn Thanks to Alice.

Open Graph Description: Fixes #159071. Problem utf-8-sig strips the BOM before decoding. If exception, the resulting UnicodeDecodeError refers to the stripped input: start and end are both small by 3, and object no longer...

X Description: Fixes #159071. Problem utf-8-sig strips the BOM before decoding. If exception, the resulting UnicodeDecodeError refers to the stripped input: start and end are both small by 3, and object no longer...

Opengraph URL: https://github.com/python/cpython/pull/159082

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a33678a4-e18a-64cb-5d8f-c3f5948c604d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8078:1B6327:61C1DC:86C018:6AFDEB99
html-safe-noncea91d46f0b7abe4793bffad521f03ad702906e76768809cf42b73876ec4a22f72
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDc4OjFCNjMyNzo2MUMxREM6ODZDMDE4OjZBRkRFQjk5IiwidmlzaXRvcl9pZCI6IjgzMjkxNDQzNjQyNjU0OTk1NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9226a059a404884c8b8d34583dc613ea879e666c7531897b1202d47a3adc03e6
hovercard-subject-tagpull_request:4804748115
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159082/files
twitter:imagehttps://avatars.githubusercontent.com/u/53343436?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/53343436?s=400&v=4
og:image:altFixes #159071. Problem utf-8-sig strips the BOM before decoding. If exception, the resulting UnicodeDecodeError refers to the stripped input: start and end are both small by 3, and object no longer...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonedd812ec581ecac95855f5ec917ef9827506c39a9da1443f43ddb4179a46471eb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release32ac708bac264dafdc28e10ff49b4d137f0c34a7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159082/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159082%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159082%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159082/files
Reloadhttps://github.com/python/cpython/pull/159082/files
Reloadhttps://github.com/python/cpython/pull/159082/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
hetaozdhhttps://github.com/hetaozdh
python:mainhttps://github.com/python/cpython/tree/main
hetaozdh:gh-159071-utf8sig-bom-error-offsetshttps://github.com/hetaozdh/cpython/tree/gh-159071-utf8sig-bom-error-offsets
Conversation 0 https://github.com/python/cpython/pull/159082
Commits 1 https://github.com/python/cpython/pull/159082/commits
Checks 53 https://github.com/python/cpython/pull/159082/checks
Files changed https://github.com/python/cpython/pull/159082/files
Please reload this pagehttps://github.com/python/cpython/pull/159082/files
gh-159071: Fix utf-8-sig decode error offsets https://github.com/python/cpython/pull/159082/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/159082/files
11fc1e9 gh-159071: Fix utf-8-sig decode error offsets hetaozdh Oct 9, 2026 https://github.com/python/cpython/pull/159082/commits/11fc1e95e9919bafb48b19587537fa922ab488ef
Clear filters https://github.com/python/cpython/pull/159082/files
Please reload this pagehttps://github.com/python/cpython/pull/159082/files
Please reload this pagehttps://github.com/python/cpython/pull/159082/files
utf_8_sig.py https://github.com/python/cpython/pull/159082/files#diff-2162caa6548b81916ff048a2a193a33d3b9a6d9bbcac54b83782fca90e6eb67a
test_codecs.py https://github.com/python/cpython/pull/159082/files#diff-a71f034c62318430dc94a9f744b5333e7d8eec577d3a23ab0b76a781872c9b96
2026-10-09-12-50-00.gh-issue-159071.kL7ZqR.rst https://github.com/python/cpython/pull/159082/files#diff-e068b7ad29c17faacf8c57c9559e25a5d0280c12730bbc8280393ce466576bac
Lib/encodings/utf_8_sig.pyhttps://github.com/python/cpython/pull/159082/files#diff-2162caa6548b81916ff048a2a193a33d3b9a6d9bbcac54b83782fca90e6eb67a
View file https://github.com/hetaozdh/cpython/blob/11fc1e95e9919bafb48b19587537fa922ab488ef/Lib/encodings/utf_8_sig.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159082/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159082/files#diff-2162caa6548b81916ff048a2a193a33d3b9a6d9bbcac54b83782fca90e6eb67a
https://github.com/python/cpython/pull/159082/files#diff-2162caa6548b81916ff048a2a193a33d3b9a6d9bbcac54b83782fca90e6eb67a
https://github.com/python/cpython/pull/159082/files#diff-2162caa6548b81916ff048a2a193a33d3b9a6d9bbcac54b83782fca90e6eb67a
https://github.com/python/cpython/pull/159082/files#diff-2162caa6548b81916ff048a2a193a33d3b9a6d9bbcac54b83782fca90e6eb67a
https://github.com/python/cpython/pull/159082/files#diff-2162caa6548b81916ff048a2a193a33d3b9a6d9bbcac54b83782fca90e6eb67a
https://github.com/python/cpython/pull/159082/files#diff-2162caa6548b81916ff048a2a193a33d3b9a6d9bbcac54b83782fca90e6eb67a
Lib/test/test_codecs.pyhttps://github.com/python/cpython/pull/159082/files#diff-a71f034c62318430dc94a9f744b5333e7d8eec577d3a23ab0b76a781872c9b96
View file https://github.com/hetaozdh/cpython/blob/11fc1e95e9919bafb48b19587537fa922ab488ef/Lib/test/test_codecs.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159082/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159082/files#diff-a71f034c62318430dc94a9f744b5333e7d8eec577d3a23ab0b76a781872c9b96
https://github.com/python/cpython/pull/159082/files#diff-a71f034c62318430dc94a9f744b5333e7d8eec577d3a23ab0b76a781872c9b96
Misc/NEWS.d/next/Library/2026-10-09-12-50-00.gh-issue-159071.kL7ZqR.rsthttps://github.com/python/cpython/pull/159082/files#diff-e068b7ad29c17faacf8c57c9559e25a5d0280c12730bbc8280393ce466576bac
View file https://github.com/hetaozdh/cpython/blob/11fc1e95e9919bafb48b19587537fa922ab488ef/Misc/NEWS.d/next/Library/2026-10-09-12-50-00.gh-issue-159071.kL7ZqR.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159082/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/159082/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.