René's URL Explorer Experiment


Title: [3.15] gh-158824: Fix `__getattr__` blocking reification of lazy imports (GH-158825) by miss-islington · Pull Request #159022 · python/cpython · GitHub

Open Graph Title: [3.15] gh-158824: Fix `__getattr__` blocking reification of lazy imports (GH-158825) by miss-islington · Pull Request #159022 · python/cpython

X Title: [3.15] gh-158824: Fix `__getattr__` blocking reification of lazy imports (GH-158825) by miss-islington · Pull Request #159022 · python/cpython

Description: When a module attribute was a lazy import placeholder, module attribute lookup called the module's getattr before resolving it. This was needed while lazy from-imports published placeholders on the source module. That no longer happens, so the check only affected the module's own lazy imports: a catch-all getattr hid them, unlike eager imports. Resolve the placeholder directly. (cherry picked from commit 56f9837) Co-authored-by: Brittany Reynoso breynoso@meta.com Issue: gh-158824

Open Graph Description: When a module attribute was a lazy import placeholder, module attribute lookup called the module's getattr before resolving it. This was needed while lazy from-imports published placeholders on...

X Description: When a module attribute was a lazy import placeholder, module attribute lookup called the module's getattr before resolving it. This was needed while lazy from-imports published placeholder...

Opengraph URL: https://github.com/python/cpython/pull/159022

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:20b654ff-b4de-d8ef-b55f-5ddf572ff440
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8DE4:31D532:1075186:15E193A:6B01E151
html-safe-nonceefc779b2f6f6a05d0e6e665fe40f637a0ebaf4623316470ae26bb4330b786c0c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REU0OjMxRDUzMjoxMDc1MTg2OjE1RTE5M0E6NkIwMUUxNTEiLCJ2aXNpdG9yX2lkIjoiNDY0NDY4MjMxNjkyNzU5MDczOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfd47020b6256a4c99b5ed462267922d1f299e4e4423a9b7103118b8068ea726e
hovercard-subject-tagpull_request:4787083830
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159022/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altWhen a module attribute was a lazy import placeholder, module attribute lookup called the module's getattr before resolving it. This was needed while lazy from-imports published placeholders on...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159022/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159022%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159022%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159022/files
Reloadhttps://github.com/python/cpython/pull/159022/files
Reloadhttps://github.com/python/cpython/pull/159022/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:3.15https://github.com/python/cpython/tree/3.15
miss-islington:backport-56f9837-3.15https://github.com/miss-islington/cpython/tree/backport-56f9837-3.15
Conversation 0 https://github.com/python/cpython/pull/159022
Commits 1 https://github.com/python/cpython/pull/159022/commits
Checks 52 https://github.com/python/cpython/pull/159022/checks
Files changed https://github.com/python/cpython/pull/159022/files
Please reload this pagehttps://github.com/python/cpython/pull/159022/files
[3.15] gh-158824: Fix __getattr__ blocking reification of lazy imports (GH-158825) https://github.com/python/cpython/pull/159022/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/159022/files
174b6a5 gh-158824: Fix `__getattr__` blocking reification of lazy imports (GH… brittanyrey Oct 8, 2026 https://github.com/python/cpython/pull/159022/commits/174b6a5559d2ed44eb5e82a2fc83496b3b7f00f3
Clear filters https://github.com/python/cpython/pull/159022/files
Please reload this pagehttps://github.com/python/cpython/pull/159022/files
Please reload this pagehttps://github.com/python/cpython/pull/159022/files
__init__.py https://github.com/python/cpython/pull/159022/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
module_with_lazy_import_and_getattr.py https://github.com/python/cpython/pull/159022/files#diff-1ee9b15ed076cf80cb1f07e2ed9b463f8e3295e57be5f5cf8c673b85e9709b92
2026-10-05-03-25-30.gh-issue-158824.h-hJj7.rst https://github.com/python/cpython/pull/159022/files#diff-cc2131acd6d25bc62189fb3797320a8fc7477e407a146b3c2f699f6105c36da3
moduleobject.c https://github.com/python/cpython/pull/159022/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5
https://github.com/python/cpython/blob/3.15/.github/CODEOWNERS#L297
Lib/test/test_lazy_import/__init__.pyhttps://github.com/python/cpython/pull/159022/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
View file https://github.com/miss-islington/cpython/blob/174b6a5559d2ed44eb5e82a2fc83496b3b7f00f3/Lib/test/test_lazy_import/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159022/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159022/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/python/cpython/pull/159022/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/python/cpython/blob/3.15/.github/CODEOWNERS#L297
Lib/test/test_lazy_import/data/module_with_lazy_import_and_getattr.pyhttps://github.com/python/cpython/pull/159022/files#diff-1ee9b15ed076cf80cb1f07e2ed9b463f8e3295e57be5f5cf8c673b85e9709b92
View file https://github.com/miss-islington/cpython/blob/174b6a5559d2ed44eb5e82a2fc83496b3b7f00f3/Lib/test/test_lazy_import/data/module_with_lazy_import_and_getattr.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159022/{{ revealButtonHref }}
Misc/NEWS.d/next/Core_and_Builtins/2026-10-05-03-25-30.gh-issue-158824.h-hJj7.rsthttps://github.com/python/cpython/pull/159022/files#diff-cc2131acd6d25bc62189fb3797320a8fc7477e407a146b3c2f699f6105c36da3
View file https://github.com/miss-islington/cpython/blob/174b6a5559d2ed44eb5e82a2fc83496b3b7f00f3/Misc/NEWS.d/next/Core_and_Builtins/2026-10-05-03-25-30.gh-issue-158824.h-hJj7.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159022/{{ revealButtonHref }}
https://github.com/python/cpython/blob/3.15/.github/CODEOWNERS#L266
Objects/moduleobject.chttps://github.com/python/cpython/pull/159022/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5
View file https://github.com/miss-islington/cpython/blob/174b6a5559d2ed44eb5e82a2fc83496b3b7f00f3/Objects/moduleobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159022/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159022/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5
https://github.com/python/cpython/pull/159022/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5
Please reload this pagehttps://github.com/python/cpython/pull/159022/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.