René's URL Explorer Experiment


Title: gh-158907: Do not send proxy credentials to a direct origin on 407 by rajorin · Pull Request #158956 · python/cpython · GitHub

Open Graph Title: gh-158907: Do not send proxy credentials to a direct origin on 407 by rajorin · Pull Request #158956 · python/cpython

X Title: gh-158907: Do not send proxy credentials to a direct origin on 407 by rajorin · Pull Request #158956 · python/cpython

Description: ProxyBasicAuthHandler.http_error_407() looked up passwords with req.host, which has no scheme. HTTPPasswordMgr treats a scheme-less lookup as a match for any scheme, so a direct HTTP origin that returns 407 could receive credentials stored for https://HOST/ and the handler would retry in cleartext with Proxy-Authorization. A 407 is now ignored unless the request is actually going through a proxy (Request.has_proxy(), or an HTTPS tunnel via _tunnel_host). Genuine proxy authentication, including HTTPS tunnels, still sends Proxy-Authorization. Closes Issue: gh-158907

Open Graph Description: ProxyBasicAuthHandler.http_error_407() looked up passwords with req.host, which has no scheme. HTTPPasswordMgr treats a scheme-less lookup as a match for any scheme, so a direct HTTP origin that re...

X Description: ProxyBasicAuthHandler.http_error_407() looked up passwords with req.host, which has no scheme. HTTPPasswordMgr treats a scheme-less lookup as a match for any scheme, so a direct HTTP origin that re...

Opengraph URL: https://github.com/python/cpython/pull/158956

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dcc3a8cb-efc8-5425-a9a6-c976e5281d56
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCAC0:7A60E:463C4AF:59D9E6E:6B023F49
html-safe-nonce847bb2225143658d0cec244a77f4c1c6c7102e2882df0f526e744090f3461345
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUMwOjdBNjBFOjQ2M0M0QUY6NTlEOUU2RTo2QjAyM0Y0OSIsInZpc2l0b3JfaWQiOiI2MTA4NjE3ODY1MzIwMDg3MzY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7a644030435005f7de994d4a5c5e87936d07d79638ac4f2a01c5b41e39d63a16
hovercard-subject-tagpull_request:4769932916
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/158956/files
twitter:imagehttps://avatars.githubusercontent.com/u/167426833?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/167426833?s=400&v=4
og:image:altProxyBasicAuthHandler.http_error_407() looked up passwords with req.host, which has no scheme. HTTPPasswordMgr treats a scheme-less lookup as a match for any scheme, so a direct HTTP origin that re...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/158956/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158956%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158956%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/158956/files
Reloadhttps://github.com/python/cpython/pull/158956/files
Reloadhttps://github.com/python/cpython/pull/158956/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
orsenthilhttps://github.com/orsenthil
python:mainhttps://github.com/python/cpython/tree/main
rajorin:gh-158907-proxy-auth-direct-407https://github.com/rajorin/cpython/tree/gh-158907-proxy-auth-direct-407
Conversation 23 https://github.com/python/cpython/pull/158956
Commits 4 https://github.com/python/cpython/pull/158956/commits
Checks 76 https://github.com/python/cpython/pull/158956/checks
Files changed 3 https://github.com/python/cpython/pull/158956/files
gh-158907: Do not send proxy credentials to a direct origin on 407 https://github.com/python/cpython/pull/158956/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/158956/files
158dbce gh-158907: Do not send proxy credentials to a direct origin on 407 rajorin Oct 7, 2026 https://github.com/python/cpython/pull/158956/commits/158dbce89c2b0a336828093f0158cadd1a2ff6a5
d56aa42 gh-158907: Shorten the handler comment and drop the tunnel test rajorin Oct 7, 2026 https://github.com/python/cpython/pull/158956/commits/d56aa4241deaf22415182efb734e84e667623cd9
f8671ac Merge changes from main. orsenthil Nov 12, 2026 https://github.com/python/cpython/pull/158956/commits/f8671ac0fdaec61c7a23d08987a47730e0f4be9f
034a971 Extend Proxy check for http_error_407 for urllib.request.ProxyDigestA… orsenthil Nov 13, 2026 https://github.com/python/cpython/pull/158956/commits/034a971b25c1d8220debe07e311bf8d173d62e6e
Clear filters https://github.com/python/cpython/pull/158956/files
Please reload this pagehttps://github.com/python/cpython/pull/158956/files
Please reload this pagehttps://github.com/python/cpython/pull/158956/files
test_urllib2.py https://github.com/python/cpython/pull/158956/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
request.py https://github.com/python/cpython/pull/158956/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
2026-10-07-13-30-00.gh-issue-158907.k4Qm2p.rst https://github.com/python/cpython/pull/158956/files#diff-cd029bd04a9a1378deb02a85a5ec1ed657d01316a7b7dde029db5da7afeb595d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L644
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/158956/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
View file https://github.com/rajorin/cpython/blob/034a971b25c1d8220debe07e311bf8d173d62e6e/Lib/test/test_urllib2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158956/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158956/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
https://github.com/python/cpython/pull/158956/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L643
Lib/urllib/request.pyhttps://github.com/python/cpython/pull/158956/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
View file https://github.com/rajorin/cpython/blob/034a971b25c1d8220debe07e311bf8d173d62e6e/Lib/urllib/request.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158956/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158956/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
https://github.com/python/cpython/pull/158956/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
https://github.com/python/cpython/pull/158956/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
https://github.com/python/cpython/pull/158956/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
Misc/NEWS.d/next/Security/2026-10-07-13-30-00.gh-issue-158907.k4Qm2p.rsthttps://github.com/python/cpython/pull/158956/files#diff-cd029bd04a9a1378deb02a85a5ec1ed657d01316a7b7dde029db5da7afeb595d
View file https://github.com/rajorin/cpython/blob/034a971b25c1d8220debe07e311bf8d173d62e6e/Misc/NEWS.d/next/Security/2026-10-07-13-30-00.gh-issue-158907.k4Qm2p.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158956/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/158956/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.