René's URL Explorer Experiment


Title: bpo-35381 Remove all static state from posixmodule by eduardo-elizondo · Pull Request #15892 · python/cpython · GitHub

Open Graph Title: bpo-35381 Remove all static state from posixmodule by eduardo-elizondo · Pull Request #15892 · python/cpython

X Title: bpo-35381 Remove all static state from posixmodule by eduardo-elizondo · Pull Request #15892 · python/cpython

Description: After #9665, this moves the remaining types in posixmodule to be heap-allocated to make it compatible with PEP384 as well as modifying all the type accessors to fully make the type opaque. The original PR that got messed up a rebase: #10854. All the issues in that commit have now been addressed since #11661 got committed. This change also removes any state from the data segment and onto the module state itself. https://bugs.python.org/issue35381 Automerge-Triggered-By: @encukou

Open Graph Description: After #9665, this moves the remaining types in posixmodule to be heap-allocated to make it compatible with PEP384 as well as modifying all the type accessors to fully make the type opaque. The orig...

X Description: After #9665, this moves the remaining types in posixmodule to be heap-allocated to make it compatible with PEP384 as well as modifying all the type accessors to fully make the type opaque. The orig...

Opengraph URL: https://github.com/python/cpython/pull/15892

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c826824b-682b-c6b7-ee11-dd3105d7913f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBCE:26A866:678493:9163A8:696A1C70
html-safe-noncefcaa7e04fc1dcdf1407fab43747460a5dc48f7bc8c6077114919577453ce1f9e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkNFOjI2QTg2Njo2Nzg0OTM6OTE2M0E4OjY5NkExQzcwIiwidmlzaXRvcl9pZCI6IjI5OTE3MDYyMTgyMjE0MTE0NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac65c5767d04a3b2c09258f613997244f737dcc37ffdbba4272de7d0cd770e7c1f
hovercard-subject-tagpull_request:316275329
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/15892/files
twitter:imagehttps://avatars.githubusercontent.com/u/5315899?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5315899?s=400&v=4
og:image:altAfter #9665, this moves the remaining types in posixmodule to be heap-allocated to make it compatible with PEP384 as well as modifying all the type accessors to fully make the type opaque. The orig...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/15892/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15892%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15892%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/15892/files
Reloadhttps://github.com/python/cpython/pull/15892/files
Reloadhttps://github.com/python/cpython/pull/15892/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/15892/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/15892/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
miss-islingtonhttps://github.com/miss-islington
python:masterhttps://github.com/python/cpython/tree/master
eduardo-elizondo:posixmodule-fromspechttps://github.com/eduardo-elizondo/cpython/tree/posixmodule-fromspec
Conversation 33 https://github.com/python/cpython/pull/15892
Commits 45 https://github.com/python/cpython/pull/15892/commits
Checks 0 https://github.com/python/cpython/pull/15892/checks
Files changed https://github.com/python/cpython/pull/15892/files
Please reload this pagehttps://github.com/python/cpython/pull/15892/files
bpo-35381 Remove all static state from posixmodule https://github.com/python/cpython/pull/15892/files#top
Show all changes 45 commits https://github.com/python/cpython/pull/15892/files
e09cf81 Make Posixmodule use PyType_FromSpec eduardo-elizondo Dec 3, 2018 https://github.com/python/cpython/pull/15892/commits/e09cf818c459214ed2b133088e2fd595675e8de4
40f0ff4 Added NEWS eduardo-elizondo Dec 3, 2018 https://github.com/python/cpython/pull/15892/commits/40f0ff45f1baee07f416d496c7ddf31b2b706dce
5be18a1 Updated hash eduardo-elizondo Dec 3, 2018 https://github.com/python/cpython/pull/15892/commits/5be18a1550de63d2d8b5e1a51e35f7f0b2301eb1
9479848 Addressed PR Issues eduardo-elizondo Jan 19, 2019 https://github.com/python/cpython/pull/15892/commits/9479848307c2ab7c97f94405f7978bb42d02f7d8
d31df5f Rebased eduardo-elizondo Jan 19, 2019 https://github.com/python/cpython/pull/15892/commits/d31df5f69167f12e5e6b6e9a74624807241aa793
c84689c Ran argument clinic eduardo-elizondo Jan 19, 2019 https://github.com/python/cpython/pull/15892/commits/c84689c5ef6949107f645153c3b11ee35f826135
796a8d7 Added NEWS eduardo-elizondo Jan 19, 2019 https://github.com/python/cpython/pull/15892/commits/796a8d7b601a9cdf0f22cf4ecb28199f57535b19
b7cae5b Remove INCREF from GenericAlloc eduardo-elizondo Jan 19, 2019 https://github.com/python/cpython/pull/15892/commits/b7cae5b7ab330465b468d489cfbf0eeb52f05d5d
5fa6e46 Make Posixmodule use PyType_FromSpec eduardo-elizondo Dec 3, 2018 https://github.com/python/cpython/pull/15892/commits/5fa6e46543066f5fd37b933d589534d4bffe2423
df178b4 Added NEWS eduardo-elizondo Dec 3, 2018 https://github.com/python/cpython/pull/15892/commits/df178b45c50ba9093909cccefb6ee329f2ef6fd7
e59208f Updated hash eduardo-elizondo Dec 3, 2018 https://github.com/python/cpython/pull/15892/commits/e59208fe89f6754d792240aca680573252cb3124
def6467 Addressed PR Issues eduardo-elizondo Jan 19, 2019 https://github.com/python/cpython/pull/15892/commits/def6467746cbbb17cf87657adb94e3de884fed79
bb2ead8 Ran argument clinic eduardo-elizondo Jan 19, 2019 https://github.com/python/cpython/pull/15892/commits/bb2ead84acd9955e33f5cf72099505f8bcb88ee3
427c772 Added NEWS eduardo-elizondo Jan 19, 2019 https://github.com/python/cpython/pull/15892/commits/427c77251409e93a6e315276dc17676b7c4c0162
7b9b85f Merged to master eduardo-elizondo Sep 11, 2019 https://github.com/python/cpython/pull/15892/commits/7b9b85f86e43bfe59e129b4d9a54b767e14d9d84
9e8fb83 Merge branch 'master' into posixmodule-fromspec eduardo-elizondo Sep 11, 2019 https://github.com/python/cpython/pull/15892/commits/9e8fb8305c3a668ef00bc1af2380b24c2c2db2d4
99d5c26 Cleaned up slot acces eduardo-elizondo Sep 11, 2019 https://github.com/python/cpython/pull/15892/commits/99d5c26baae5afb8e87f04445623b8df9546046c
ca19f51 Cleaned up more slot accesses eduardo-elizondo Sep 11, 2019 https://github.com/python/cpython/pull/15892/commits/ca19f515f2bd009c8aa57ddd472778eaf153e66a
8af0c4e Nits eduardo-elizondo Sep 11, 2019 https://github.com/python/cpython/pull/15892/commits/8af0c4ea74905e2b13243f71c75ba9f1cebd948a
cee2cd9 Fixes eduardo-elizondo Sep 11, 2019 https://github.com/python/cpython/pull/15892/commits/cee2cd99dc053aeeb26d03912d637f73a1df9a9d
a8d2f56 Run clinic eduardo-elizondo Sep 11, 2019 https://github.com/python/cpython/pull/15892/commits/a8d2f5661f1df219c34ae3f881f3699b0b07f106
5e4d2ab Run clinic eduardo-elizondo Sep 11, 2019 https://github.com/python/cpython/pull/15892/commits/5e4d2ab2bc4429bb939a042b6472a263b288eb8d
c42ec45 Improve error handling encukou Sep 11, 2019 https://github.com/python/cpython/pull/15892/commits/c42ec45b0967bdd67451987dc9f06826fdc8ec36
d27a547 Remove static from posixmodule.c eduardo-elizondo Sep 12, 2019 https://github.com/python/cpython/pull/15892/commits/d27a5479d191adb1f4c92423b00e745cb714cd28
6af98a9 Merge branch 'posixmodule-fromspec' of https://github.com/eduardo-eli… eduardo-elizondo Sep 12, 2019 https://github.com/python/cpython/pull/15892/commits/6af98a953c0528cb916ba005f90dbbbe0da56826
a723d1c Address Comments eduardo-elizondo Sep 12, 2019 https://github.com/python/cpython/pull/15892/commits/a723d1cc4b33a445acc2b872b59ecbed496b4949
e91096a Address Comments eduardo-elizondo Sep 12, 2019 https://github.com/python/cpython/pull/15892/commits/e91096a9268f675a98f6ac0bc53a2fe5fd706795
3cf259e Fix Windows build eduardo-elizondo Sep 12, 2019 https://github.com/python/cpython/pull/15892/commits/3cf259e6fcd574f5fb01a0c4f2ad08016d0e56a2
925a41e Use interned strings for constants in module state encukou Sep 13, 2019 https://github.com/python/cpython/pull/15892/commits/925a41e9725fb2d131d052b16ad7854fa0e5dc11
ad7359b Use descriptor directly, rather than look it up by name encukou Sep 13, 2019 https://github.com/python/cpython/pull/15892/commits/ad7359b66e57cd509a338bafb9aa488d235bb36f
5de545d Bring _Py_IDENTIFIER(__fspath__) back encukou Sep 13, 2019 https://github.com/python/cpython/pull/15892/commits/5de545dad772680af53c93e5a8064ddb4edb0614
3ada298 Use the tp_free slot directly encukou Sep 13, 2019 https://github.com/python/cpython/pull/15892/commits/3ada29818a428fb373fba7156e5794c539295047
4c80b06 Remove duplicate function encukou Sep 13, 2019 https://github.com/python/cpython/pull/15892/commits/4c80b065976a44e43f0b32e71b0f7493ced6b223
6e505ac Use tp_new directly encukou Sep 13, 2019 https://github.com/python/cpython/pull/15892/commits/6e505ac8e73a40ff11369cda494114368c23d74e
b9a49aa Don't call PyState_AddModule encukou Sep 13, 2019 https://github.com/python/cpython/pull/15892/commits/b9a49aa33fc722c36e9624b90f179c7577139dc6
c1a6d03 Add __new__ changes eduardo-elizondo Sep 17, 2019 https://github.com/python/cpython/pull/15892/commits/c1a6d030b199aba4fb7599ff8bc5191ffbdc7e37
bbe887f Merge branch 'master' into posixmodule-fromspec eduardo-elizondo Sep 17, 2019 https://github.com/python/cpython/pull/15892/commits/bbe887f0ff0819c91dd54bc794aa6bc685b6c682
4a6d4ec Regenerate clinic eduardo-elizondo Sep 18, 2019 https://github.com/python/cpython/pull/15892/commits/4a6d4ec581394c0e8de208152d416e02df44d2f0
138ffb6 Nits eduardo-elizondo Sep 23, 2019 https://github.com/python/cpython/pull/15892/commits/138ffb6894caaf3b90c60a51b3cf099324478683
78fbed3 Merge to master eduardo-elizondo Nov 3, 2019 https://github.com/python/cpython/pull/15892/commits/78fbed35b2214436ddc5c5cb580e01b0fa79e1fb
1b57f3a Revert tp_new changes eduardo-elizondo Nov 3, 2019 https://github.com/python/cpython/pull/15892/commits/1b57f3a76b48a58514c7175f49857d05bf694288
e7e9634 Rerun argument clinit eduardo-elizondo Nov 3, 2019 https://github.com/python/cpython/pull/15892/commits/e7e96344cad1be1279d797d8d47acc7561772103
3bf99bf More fixes eduardo-elizondo Nov 3, 2019 https://github.com/python/cpython/pull/15892/commits/3bf99bf1c388498df0cbee3dbb0a140cba497dd9
afb249c Re-add newlines and fix docstring for os.sched_param.__new__ encukou Nov 5, 2019 https://github.com/python/cpython/pull/15892/commits/afb249c4ba9dbc1568c76fc4e3bfa3aea68de33f
187b5d4 Code style nitpicks encukou Nov 5, 2019 https://github.com/python/cpython/pull/15892/commits/187b5d4d7c0a93d7cc944d87bbebaff8a37b350f
Clear filters https://github.com/python/cpython/pull/15892/files
Please reload this pagehttps://github.com/python/cpython/pull/15892/files
Please reload this pagehttps://github.com/python/cpython/pull/15892/files
test_os.py https://github.com/python/cpython/pull/15892/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
2019-01-18-17-05-26.bpo-35381.9CbeW3.rst https://github.com/python/cpython/pull/15892/files#diff-6ce68d81a234d80d519ab8f0402103bf117e1966f115e5627f482c5b21fd13e6
posixmodule.c.h https://github.com/python/cpython/pull/15892/files#diff-f4ec448d9bc73d373452e97931de916ca83058ae93bce4a5853b8ac18c9d2cfa
posixmodule.c https://github.com/python/cpython/pull/15892/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
Lib/test/test_os.pyhttps://github.com/python/cpython/pull/15892/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
View file https://github.com/eduardo-elizondo/cpython/blob/187b5d4d7c0a93d7cc944d87bbebaff8a37b350f/Lib/test/test_os.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15892/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15892/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/15892/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/15892/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/15892/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
Misc/NEWS.d/next/C API/2019-01-18-17-05-26.bpo-35381.9CbeW3.rsthttps://github.com/python/cpython/pull/15892/files#diff-6ce68d81a234d80d519ab8f0402103bf117e1966f115e5627f482c5b21fd13e6
View file https://github.com/eduardo-elizondo/cpython/blob/187b5d4d7c0a93d7cc944d87bbebaff8a37b350f/Misc/NEWS.d/next/C%20API/2019-01-18-17-05-26.bpo-35381.9CbeW3.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15892/{{ revealButtonHref }}
Modules/clinic/posixmodule.c.hhttps://github.com/python/cpython/pull/15892/files#diff-f4ec448d9bc73d373452e97931de916ca83058ae93bce4a5853b8ac18c9d2cfa
View file https://github.com/eduardo-elizondo/cpython/blob/187b5d4d7c0a93d7cc944d87bbebaff8a37b350f/Modules/clinic/posixmodule.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/15892/files
Please reload this pagehttps://github.com/python/cpython/pull/15892/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.