Title: gh-158868: Reduce ASLR in the MSan CI job by StanFromIreland · Pull Request #158872 · python/cpython · GitHub
Open Graph Title: gh-158868: Reduce ASLR in the MSan CI job by StanFromIreland · Pull Request #158872 · python/cpython
X Title: gh-158868: Reduce ASLR in the MSan CI job by StanFromIreland · Pull Request #158872 · python/cpython
Description: This fixes the bug reported in #158868, rather than skipping the job. To reproduce this locally: $ sudo sysctl vm.mmap_rnd_bits vm.mmap_rnd_bits = 28 $ for i in $(seq 300); do MSAN_OPTIONS=verbosity=1 ./python -m test test_os.test_posix -m test_fexecve 2>&1 \ | grep -E 'execve failed|incompatible' && { echo "failed on run $i"; break; } done $ sudo sysctl -w vm.mmap_rnd_bits=32 vm.mmap_rnd_bits = 32 $ for i in $(seq 300); do MSAN_OPTIONS=verbosity=1 ./python -m test test_os.test_posix -m test_fexecve 2>&1 | grep -E 'execve failed|incompatible' && { echo "$i"; break; }; done ==35706==WARNING: MemorySanitizer: memory layout is incompatible, possibly due to high-entropy ASLR. execve failed, errno 2 4 We actually already do this for the TSan job, it seems we got unlucky on the PR that added MSan: cpython/.github/workflows/reusable-san.yml Line 49 in 508db6d sudo sysctl -w vm.mmap_rnd_bits=28 # Reduce ASLR to avoid TSan crashing In the test, the mappings of the exec'd child sometimes land where MSan needs its shadow memory, so the MSan runtime disables ASLR and re-executes the process at startup, which fails because the child was started from a close-on-exec file descriptor.
Open Graph Description: This fixes the bug reported in #158868, rather than skipping the job. To reproduce this locally: $ sudo sysctl vm.mmap_rnd_bits vm.mmap_rnd_bits = 28 $ for i in $(seq 300); do MSAN_OPTIONS=verbos...
X Description: This fixes the bug reported in #158868, rather than skipping the job. To reproduce this locally: $ sudo sysctl vm.mmap_rnd_bits vm.mmap_rnd_bits = 28 $ for i in $(seq 300); do MSAN_OPTIONS=verbos...
Opengraph URL: https://github.com/python/cpython/pull/158872
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:cdbd15d5-dcee-3dd3-c970-3e06d9f34dfd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E1B2:39FDE1:DF0842:117CA20:6B0231E2 |
| html-safe-nonce | 835759182de72ac929e1082006445f5721732b972284ecfdc3627ca33d003a31 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUIyOjM5RkRFMTpERjA4NDI6MTE3Q0EyMDo2QjAyMzFFMiIsInZpc2l0b3JfaWQiOiI1NDMwODk0ODMyMjg3NjI1Njk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8979702216e4103d2dda67bb375ffe84ea4faa22bc5447ff25e116b098f97353 |
| hovercard-subject-tag | pull_request:4747670995 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/158872/files |
| twitter:image | https://avatars.githubusercontent.com/u/89152624?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/89152624?s=400&v=4 |
| og:image:alt | This fixes the bug reported in #158868, rather than skipping the job. To reproduce this locally: $ sudo sysctl vm.mmap_rnd_bits vm.mmap_rnd_bits = 28 $ for i in $(seq 300); do MSAN_OPTIONS=verbos... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width