René's URL Explorer Experiment


Title: gh-153569: Simplify tokenizer source views and reader ownership by pablogsal · Pull Request #158849 · python/cpython · GitHub

Open Graph Title: gh-153569: Simplify tokenizer source views and reader ownership by pablogsal · Pull Request #158849 · python/cpython

X Title: gh-153569: Simplify tokenizer source views and reader ownership by pablogsal · Pull Request #158849 · python/cpython

Description: Move byte access, searches, and span views into the source API. Keep comment and trailing-statement scanning on offsets, copy formatted-string expression segments through span views, and use logical line spans for _tokenize column calculations. Move the borrowed file handle and owned encoding into the reader so input state and its cleanup live together. Reuse the codec helper to create incremental decoders. Follow-up to #153569. Issue: gh-153569

Open Graph Description: Move byte access, searches, and span views into the source API. Keep comment and trailing-statement scanning on offsets, copy formatted-string expression segments through span views, and use logica...

X Description: Move byte access, searches, and span views into the source API. Keep comment and trailing-statement scanning on offsets, copy formatted-string expression segments through span views, and use logica...

Opengraph URL: https://github.com/python/cpython/pull/158849

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d449b786-a20a-f0b3-edfe-c3e57f138b03
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC842:B1B84:2F2E323:3C0AA13:6B01FBCE
html-safe-nonceb5c78d52e1a62e638852789c8c583cf8747711b24ccee47c3b191aef87857300
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODQyOkIxQjg0OjJGMkUzMjM6M0MwQUExMzo2QjAxRkJDRSIsInZpc2l0b3JfaWQiOiI3MDcwMzE0MzY5MjA4NDE3MjMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac62267137c863e26176275e68820b4ef726a046c31d597a717d79f996ef159374
hovercard-subject-tagpull_request:4746128042
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/158849/files
twitter:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
og:image:altMove byte access, searches, and span views into the source API. Keep comment and trailing-statement scanning on offsets, copy formatted-string expression segments through span views, and use logica...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/158849/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158849%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158849%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/158849/files
Reloadhttps://github.com/python/cpython/pull/158849/files
Reloadhttps://github.com/python/cpython/pull/158849/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:tokenizer-source-api-cleanuphttps://github.com/pablogsal/cpython/tree/tokenizer-source-api-cleanup
Conversation 0 https://github.com/python/cpython/pull/158849
Commits 7 https://github.com/python/cpython/pull/158849/commits
Checks 50 https://github.com/python/cpython/pull/158849/checks
Files changed https://github.com/python/cpython/pull/158849/files
Please reload this pagehttps://github.com/python/cpython/pull/158849/files
gh-153569: Simplify tokenizer source views and reader ownership https://github.com/python/cpython/pull/158849/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/158849/files
8f7e822 gh-153569: Move tokenizer source access into the source API pablogsal Oct 5, 2026 https://github.com/python/cpython/pull/158849/commits/8f7e822f6b2e1bb9ecff82253776988d63f5e6c4
2b46f42 gh-153569: Use logical spans in tokenizer views and column calculations pablogsal Oct 5, 2026 https://github.com/python/cpython/pull/158849/commits/2b46f42c865d1e812022672d25310307b72e54e3
1cfbc93 gh-153569: Move tokenizer input state and encoding ownership into the… pablogsal Oct 5, 2026 https://github.com/python/cpython/pull/158849/commits/1cfbc932fbf4364d364e5300f0d194ed767188bc
e60d602 gh-153569: Keep tokenizer source scans and copies on offsets and spans pablogsal Oct 5, 2026 https://github.com/python/cpython/pull/158849/commits/e60d602e6beb7fcd379b1da6548189beab487897
ffb781d gh-153569: Remove redundant tokenizer views and simplify reader branc… pablogsal Oct 5, 2026 https://github.com/python/cpython/pull/158849/commits/ffb781d20a91aea10b7542fddff0475ddf0c8eef
33d219c gh-153569: Reuse the incremental decoder factory helper pablogsal Oct 5, 2026 https://github.com/python/cpython/pull/158849/commits/33d219cabc8ad50f1a78d396b4f69d924caba304
d386e50 gh-153569: Export incremental decoder helper for parser generator tests pablogsal Oct 13, 2026 https://github.com/python/cpython/pull/158849/commits/d386e50c1adf53ff0a5dec11cfd9448ce23f5cdb
Clear filters https://github.com/python/cpython/pull/158849/files
Please reload this pagehttps://github.com/python/cpython/pull/158849/files
Please reload this pagehttps://github.com/python/cpython/pull/158849/files
pycore_codecs.h https://github.com/python/cpython/pull/158849/files#diff-64732a285a457a53f5e0a3d0911bd0dc79bba0410c5942d43009124a597fef85
lexer.c https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
lexer_internal.h https://github.com/python/cpython/pull/158849/files#diff-8b0f5e75070e787646998b2177e239a0048aa5adce6e2068ad6bbfca1dc46eda
state.c https://github.com/python/cpython/pull/158849/files#diff-d320456c1594700fd4ea3c33fbfc5f7fd74d4fd45fd225354ea8db7135c04045
state.h https://github.com/python/cpython/pull/158849/files#diff-9efe28cd84a24747de9e363846c7d9255a3d3a7073896547f570bf91b4fd3667
string.c https://github.com/python/cpython/pull/158849/files#diff-c8bf656bc09ae7acf6bc1c311f93e578b1df1efab51aa5dcfec00aacbb8425f7
api.c https://github.com/python/cpython/pull/158849/files#diff-4aed35731bef9e03b57991e87f1560266654a140343fb6cace980e611993aabc
decoder.c https://github.com/python/cpython/pull/158849/files#diff-20b697a19ba8581bf383b48255bb0cc3bc160c264aeaeeea96be6e2daf471741
helpers.c https://github.com/python/cpython/pull/158849/files#diff-2f9c676ca7974a32907e7c98153e5942c869a80c67d2fd075acb5b589b45eddb
reader.c https://github.com/python/cpython/pull/158849/files#diff-ee1ccf9c461ad2982f27a89c79c7ea2e5868fef86dbd8d8d1d873e1624208590
reader_internal.h https://github.com/python/cpython/pull/158849/files#diff-b0bf3853f60d9c70ce122af7b63f26d886e22d2bf72e06c5a04402dc26b5a494
source.h https://github.com/python/cpython/pull/158849/files#diff-033fac2d1c68ebec297cd0aaf7ee48c836b7ebab03362fcecc53cedcdac043d1
tokenizer.h https://github.com/python/cpython/pull/158849/files#diff-be88e98f60aa508893fa57029c0cafd698c2b1ad66dc1d532919fc8fd0373dd8
Python-tokenize.c https://github.com/python/cpython/pull/158849/files#diff-68d96c581022a408dbcf0f48df1126c3a43154ed2dd20b166aa5269ab27f3dcb
Include/internal/pycore_codecs.hhttps://github.com/python/cpython/pull/158849/files#diff-64732a285a457a53f5e0a3d0911bd0dc79bba0410c5942d43009124a597fef85
View file https://github.com/pablogsal/cpython/blob/d386e50c1adf53ff0a5dec11cfd9448ce23f5cdb/Include/internal/pycore_codecs.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158849/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158849/files#diff-64732a285a457a53f5e0a3d0911bd0dc79bba0410c5942d43009124a597fef85
https://github.com/python/cpython/pull/158849/files#diff-64732a285a457a53f5e0a3d0911bd0dc79bba0410c5942d43009124a597fef85
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/lexer/lexer.chttps://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
View file https://github.com/pablogsal/cpython/blob/d386e50c1adf53ff0a5dec11cfd9448ce23f5cdb/Parser/lexer/lexer.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158849/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/pull/158849/files#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/lexer/lexer_internal.hhttps://github.com/python/cpython/pull/158849/files#diff-8b0f5e75070e787646998b2177e239a0048aa5adce6e2068ad6bbfca1dc46eda
View file https://github.com/pablogsal/cpython/blob/d386e50c1adf53ff0a5dec11cfd9448ce23f5cdb/Parser/lexer/lexer_internal.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158849/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158849/files#diff-8b0f5e75070e787646998b2177e239a0048aa5adce6e2068ad6bbfca1dc46eda
https://github.com/python/cpython/pull/158849/files#diff-8b0f5e75070e787646998b2177e239a0048aa5adce6e2068ad6bbfca1dc46eda
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/lexer/state.chttps://github.com/python/cpython/pull/158849/files#diff-d320456c1594700fd4ea3c33fbfc5f7fd74d4fd45fd225354ea8db7135c04045
View file https://github.com/pablogsal/cpython/blob/d386e50c1adf53ff0a5dec11cfd9448ce23f5cdb/Parser/lexer/state.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158849/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158849/files#diff-d320456c1594700fd4ea3c33fbfc5f7fd74d4fd45fd225354ea8db7135c04045
https://github.com/python/cpython/pull/158849/files#diff-d320456c1594700fd4ea3c33fbfc5f7fd74d4fd45fd225354ea8db7135c04045
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/lexer/state.hhttps://github.com/python/cpython/pull/158849/files#diff-9efe28cd84a24747de9e363846c7d9255a3d3a7073896547f570bf91b4fd3667
View file https://github.com/pablogsal/cpython/blob/d386e50c1adf53ff0a5dec11cfd9448ce23f5cdb/Parser/lexer/state.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158849/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158849/files#diff-9efe28cd84a24747de9e363846c7d9255a3d3a7073896547f570bf91b4fd3667
https://github.com/python/cpython/pull/158849/files#diff-9efe28cd84a24747de9e363846c7d9255a3d3a7073896547f570bf91b4fd3667
https://github.com/python/cpython/pull/158849/files#diff-9efe28cd84a24747de9e363846c7d9255a3d3a7073896547f570bf91b4fd3667
https://github.com/python/cpython/pull/158849/files#diff-9efe28cd84a24747de9e363846c7d9255a3d3a7073896547f570bf91b4fd3667
https://github.com/python/cpython/pull/158849/files#diff-9efe28cd84a24747de9e363846c7d9255a3d3a7073896547f570bf91b4fd3667
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/lexer/string.chttps://github.com/python/cpython/pull/158849/files#diff-c8bf656bc09ae7acf6bc1c311f93e578b1df1efab51aa5dcfec00aacbb8425f7
View file https://github.com/pablogsal/cpython/blob/d386e50c1adf53ff0a5dec11cfd9448ce23f5cdb/Parser/lexer/string.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158849/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158849/files#diff-c8bf656bc09ae7acf6bc1c311f93e578b1df1efab51aa5dcfec00aacbb8425f7
https://github.com/python/cpython/pull/158849/files#diff-c8bf656bc09ae7acf6bc1c311f93e578b1df1efab51aa5dcfec00aacbb8425f7
https://github.com/python/cpython/pull/158849/files#diff-c8bf656bc09ae7acf6bc1c311f93e578b1df1efab51aa5dcfec00aacbb8425f7
https://github.com/python/cpython/pull/158849/files#diff-c8bf656bc09ae7acf6bc1c311f93e578b1df1efab51aa5dcfec00aacbb8425f7
https://github.com/python/cpython/pull/158849/files#diff-c8bf656bc09ae7acf6bc1c311f93e578b1df1efab51aa5dcfec00aacbb8425f7
https://github.com/python/cpython/pull/158849/files#diff-c8bf656bc09ae7acf6bc1c311f93e578b1df1efab51aa5dcfec00aacbb8425f7
https://github.com/python/cpython/pull/158849/files#diff-c8bf656bc09ae7acf6bc1c311f93e578b1df1efab51aa5dcfec00aacbb8425f7
Please reload this pagehttps://github.com/python/cpython/pull/158849/files
Please reload this pagehttps://github.com/python/cpython/pull/158849/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.