René's URL Explorer Experiment


Title: gh-158824: Fix `__getattr__` blocking reification of lazy imports by brittanyrey · Pull Request #158825 · python/cpython · GitHub

Open Graph Title: gh-158824: Fix `__getattr__` blocking reification of lazy imports by brittanyrey · Pull Request #158825 · python/cpython

X Title: gh-158824: Fix `__getattr__` blocking reification of lazy imports by brittanyrey · Pull Request #158825 · python/cpython

Description: Module attribute lookup called the module's getattr before resolving a lazy import placeholder. That was the fix for gh-144957, needed while lazy from imports put placeholders into the source module. gh-150052 removed that, so the check now only shadows a module's own lazy imports. This fixes that issue and adds a new load bearing test. Issue: gh-158824

Open Graph Description: Module attribute lookup called the module's getattr before resolving a lazy import placeholder. That was the fix for gh-144957, needed while lazy from imports put placeholders into the source m...

X Description: Module attribute lookup called the module's getattr before resolving a lazy import placeholder. That was the fix for gh-144957, needed while lazy from imports put placeholders into the sour...

Opengraph URL: https://github.com/python/cpython/pull/158825

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0ced7a64-cfa1-7982-f04f-5537ee2b0094
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD6F8:A70A9:11DCA11:17A4ECB:6B01E78A
html-safe-nonce41f37b6d292f4bec14fe804a56690a901f05ea4b60d2584cc0ce28b51cc43456
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkY4OkE3MEE5OjExRENBMTE6MTdBNEVDQjo2QjAxRTc4QSIsInZpc2l0b3JfaWQiOiI1OTUyNzU4MjY1MjY2OTU2MTcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd1c8f31b22493c511a979a9bbac0d2cbd4f3ac229a3db3bd05fac2ce6dd029ae
hovercard-subject-tagpull_request:4739778699
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/158825/files
twitter:imagehttps://avatars.githubusercontent.com/u/5497668?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5497668?s=400&v=4
og:image:altModule attribute lookup called the module's getattr before resolving a lazy import placeholder. That was the fix for gh-144957, needed while lazy from imports put placeholders into the source m...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/158825/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158825%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158825%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/158825/files
Reloadhttps://github.com/python/cpython/pull/158825/files
Reloadhttps://github.com/python/cpython/pull/158825/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
brittanyrey:b-lazy-module-getattr-precedencehttps://github.com/brittanyrey/cpython/tree/b-lazy-module-getattr-precedence
Conversation 5 https://github.com/python/cpython/pull/158825
Commits 4 https://github.com/python/cpython/pull/158825/commits
Checks 59 https://github.com/python/cpython/pull/158825/checks
Files changed https://github.com/python/cpython/pull/158825/files
Please reload this pagehttps://github.com/python/cpython/pull/158825/files
gh-158824: Fix __getattr__ blocking reification of lazy imports https://github.com/python/cpython/pull/158825/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/158825/files
9a55b78 Don't let module __getattr__ shadow a module's own lazy imports brittanyrey Oct 5, 2026 https://github.com/python/cpython/pull/158825/commits/9a55b7869a7213edf16ec459c33821801a4122d1
c83d220 📜🤖 Added by blurb_it. blurb-it[bot] Oct 5, 2026 https://github.com/python/cpython/pull/158825/commits/c83d2206223aae13068bb41427373641cf15eb4d
ebcb52c Extend the module __getattr__ test and fix the NEWS entry markup brittanyrey Oct 5, 2026 https://github.com/python/cpython/pull/158825/commits/ebcb52c915db5ee75d38ee45d0524dec5137bcdd
e71c950 Reword the NEWS entry to describe the fix brittanyrey Oct 5, 2026 https://github.com/python/cpython/pull/158825/commits/e71c95070463cf76a6a574d09bb38831472aaa10
Clear filters https://github.com/python/cpython/pull/158825/files
Please reload this pagehttps://github.com/python/cpython/pull/158825/files
Please reload this pagehttps://github.com/python/cpython/pull/158825/files
__init__.py https://github.com/python/cpython/pull/158825/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
module_with_lazy_import_and_getattr.py https://github.com/python/cpython/pull/158825/files#diff-1ee9b15ed076cf80cb1f07e2ed9b463f8e3295e57be5f5cf8c673b85e9709b92
2026-10-05-03-25-30.gh-issue-158824.h-hJj7.rst https://github.com/python/cpython/pull/158825/files#diff-cc2131acd6d25bc62189fb3797320a8fc7477e407a146b3c2f699f6105c36da3
moduleobject.c https://github.com/python/cpython/pull/158825/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L299
Lib/test/test_lazy_import/__init__.pyhttps://github.com/python/cpython/pull/158825/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
View file https://github.com/brittanyrey/cpython/blob/e71c95070463cf76a6a574d09bb38831472aaa10/Lib/test/test_lazy_import/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158825/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158825/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/python/cpython/pull/158825/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L299
Lib/test/test_lazy_import/data/module_with_lazy_import_and_getattr.pyhttps://github.com/python/cpython/pull/158825/files#diff-1ee9b15ed076cf80cb1f07e2ed9b463f8e3295e57be5f5cf8c673b85e9709b92
View file https://github.com/brittanyrey/cpython/blob/e71c95070463cf76a6a574d09bb38831472aaa10/Lib/test/test_lazy_import/data/module_with_lazy_import_and_getattr.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158825/{{ revealButtonHref }}
Misc/NEWS.d/next/Core_and_Builtins/2026-10-05-03-25-30.gh-issue-158824.h-hJj7.rsthttps://github.com/python/cpython/pull/158825/files#diff-cc2131acd6d25bc62189fb3797320a8fc7477e407a146b3c2f699f6105c36da3
View file https://github.com/brittanyrey/cpython/blob/e71c95070463cf76a6a574d09bb38831472aaa10/Misc/NEWS.d/next/Core_and_Builtins/2026-10-05-03-25-30.gh-issue-158824.h-hJj7.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158825/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L267
Objects/moduleobject.chttps://github.com/python/cpython/pull/158825/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5
View file https://github.com/brittanyrey/cpython/blob/e71c95070463cf76a6a574d09bb38831472aaa10/Objects/moduleobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158825/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158825/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5
https://github.com/python/cpython/pull/158825/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5
Please reload this pagehttps://github.com/python/cpython/pull/158825/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.