René's URL Explorer Experiment


Title: gh-158820: Add null checks to avoid segfaults with lazy imports at shutdown by brittanyrey · Pull Request #158821 · python/cpython · GitHub

Open Graph Title: gh-158820: Add null checks to avoid segfaults with lazy imports at shutdown by brittanyrey · Pull Request #158821 · python/cpython

X Title: gh-158820: Add null checks to avoid segfaults with lazy imports at shutdown by brittanyrey · Pull Request #158821 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Additional finalizers can run after finalize_modules() has cleared the interpreter's lazy_modules set and lazy_pending_submodules dict. In the perfect storm, this can lead to a seg fault when a...

X Description: Additional finalizers can run after finalize_modules() has cleared the interpreter's lazy_modules set and lazy_pending_submodules dict. In the perfect storm, this can lead to a seg fault wh...

Opengraph URL: https://github.com/python/cpython/pull/158821

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:02fc65e6-4cea-7552-022e-769bd52b91f8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB25C:2C69FC:12AF399:18DB676:6B01EF15
html-safe-nonce7471d1c44fd3973d68de23d9af0bb352864d8577e881c11202f654b3349a623b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjVDOjJDNjlGQzoxMkFGMzk5OjE4REI2NzY6NkIwMUVGMTUiLCJ2aXNpdG9yX2lkIjoiMjkxNDIzMzU4OTU3Mjk1NTkyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaad0c00015b6b71c26c011ee572c86cdcae044964a777a994e07922ad5b1bc6a
hovercard-subject-tagpull_request:4739272679
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/158821/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2c4d08397b4163e4b47630352d5e39d1d4c30a90a3057771442cc4041d32e586/python/cpython/pull/158821
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2c4d08397b4163e4b47630352d5e39d1d4c30a90a3057771442cc4041d32e586/python/cpython/pull/158821
og:image:altAdditional finalizers can run after finalize_modules() has cleared the interpreter's lazy_modules set and lazy_pending_submodules dict. In the perfect storm, this can lead to a seg fault when a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrittanyrey
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/158821#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158821
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158821
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/158821
Reloadhttps://github.com/python/cpython/pull/158821
Reloadhttps://github.com/python/cpython/pull/158821
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
brittanyrey:b-lazy-fini-null-statehttps://github.com/brittanyrey/cpython/tree/b-lazy-fini-null-state
Conversationhttps://github.com/python/cpython/pull/158821
Commits4 (4)https://github.com/python/cpython/pull/158821/commits
Checkshttps://github.com/python/cpython/pull/158821/checks
Files changedhttps://github.com/python/cpython/pull/158821/files
gh-158820: Add null checks to avoid segfaults with lazy imports at shutdownhttps://github.com/python/cpython/pull/158821#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
brittanyrey:b-lazy-fini-null-statehttps://github.com/brittanyrey/cpython/tree/b-lazy-fini-null-state
https://github.com/brittanyrey
brittanyreyhttps://github.com/brittanyrey
Oct 5, 2026https://github.com/python/cpython/pull/158821#issue-5705335776
Please reload this pagehttps://github.com/python/cpython/pull/158821
Segfault when a finalizer declares or resolves a lazy import during shutdown #158820https://github.com/python/cpython/issues/158820
Please reload this pagehttps://github.com/python/cpython/pull/158821
brittanyreyhttps://github.com/brittanyrey
October 4, 2026 18:41https://github.com/python/cpython/pull/158821#commits-pushed-0b5852c
https://github.com/brittanyrey
Fix crash when a destructor uses lazy imports during shutdownhttps://github.com/python/cpython/pull/158821/commits/0b5852c5140085bb756e0a23fa37231a53afed87
0b5852chttps://github.com/python/cpython/pull/158821/commits/0b5852c5140085bb756e0a23fa37231a53afed87
https://github.com/brittanyrey
Remove comments on the lazy import state NULL checkshttps://github.com/python/cpython/pull/158821/commits/cc628a401795c621ad69a6c33daf94bd428d0f5d
cc628a4https://github.com/python/cpython/pull/158821/commits/cc628a401795c621ad69a6c33daf94bd428d0f5d
https://github.com/brittanyrey
brittanyreyhttps://github.com/brittanyrey
DinoVhttps://github.com/DinoV
FFY00https://github.com/FFY00
Yhg1shttps://github.com/Yhg1s
brettcannonhttps://github.com/brettcannon
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
kumaraditya303https://github.com/kumaraditya303
ncoghlanhttps://github.com/ncoghlan
pablogsalhttps://github.com/pablogsal
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/5fecd448bb120378978a37dde65dfce233d88c0d/.github/CODEOWNERS#L296
October 5, 2026 01:57https://github.com/python/cpython/pull/158821#event-32471343806
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 5, 2026https://github.com/python/cpython/pull/158821#event-32471347654
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 5, 2026 https://github.com/python/cpython/pull/158821#ref-issue-5705301054
Segfault when a finalizer declares or resolves a lazy import during shutdown #158820 https://github.com/python/cpython/issues/158820
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/158821/commits/a13e2d55af425c87e991850adcba7f11ca408666
a13e2d5https://github.com/python/cpython/pull/158821/commits/a13e2d55af425c87e991850adcba7f11ca408666
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 5, 2026 https://github.com/python/cpython/pull/158821#pullrequestreview-5412783491
View reviewed changes https://github.com/python/cpython/pull/158821/files/a13e2d55af425c87e991850adcba7f11ca408666
Python/import.chttps://github.com/python/cpython/pull/158821/files/a13e2d55af425c87e991850adcba7f11ca408666#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
Please reload this pagehttps://github.com/python/cpython/pull/158821
Misc/NEWS.d/next/Core_and_Builtins/2026-10-05-01-59-22.gh-issue-158820.3KLyOT.rsthttps://github.com/python/cpython/pull/158821/files/a13e2d55af425c87e991850adcba7f11ca408666#diff-8c5d50e9ed0c25686fae7f5d80639b720b7f2c142511e031c7abc9530d33792d
Please reload this pagehttps://github.com/python/cpython/pull/158821
Python/import.chttps://github.com/python/cpython/pull/158821/files/a13e2d55af425c87e991850adcba7f11ca408666#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
Please reload this pagehttps://github.com/python/cpython/pull/158821
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 5, 2026https://github.com/python/cpython/pull/158821#event-32496652482
https://github.com/brittanyrey
Test _imp._set_lazy_attributes() at shutdown, add a comment and rewor…https://github.com/python/cpython/pull/158821/commits/b1651ea5e422c1a6137c0bab552ec6e41563390b
b1651eahttps://github.com/python/cpython/pull/158821/commits/b1651ea5e422c1a6137c0bab552ec6e41563390b
https://github.com/brittanyrey
brittanyreyhttps://github.com/brittanyrey
Oct 5, 2026https://github.com/python/cpython/pull/158821#issuecomment-6002250150
Please reload this pagehttps://github.com/python/cpython/pull/158821
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
October 5, 2026 21:18https://github.com/python/cpython/pull/158821#event-32545554659
https://github.com/encukou
encukouhttps://github.com/encukou
a6e6361https://github.com/python/cpython/commit/a6e636148e96dc3430b50b40e5b3e92173337130
Oct 9, 2026https://github.com/python/cpython/pull/158821#event-32872219636
Please reload this pagehttps://github.com/python/cpython/pull/158821
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 9, 2026https://github.com/python/cpython/pull/158821#event-32872223169
https://github.com/encukou
encukouhttps://github.com/encukou
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Oct 9, 2026https://github.com/python/cpython/pull/158821#event-32872225397
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Oct 9, 2026https://github.com/python/cpython/pull/158821#issuecomment-6080375711
@brittanyreyhttps://github.com/brittanyrey
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/158821
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 9, 2026https://github.com/python/cpython/pull/158821#issuecomment-6080379515
GH-159062https://github.com/python/cpython/pull/159062
3.15 branchhttps://github.com/python/cpython/tree/3.15
Please reload this pagehttps://github.com/python/cpython/pull/158821
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Oct 9, 2026https://github.com/python/cpython/pull/158821#event-32872244790
https://github.com/brittanyrey
brittanyreyhttps://github.com/brittanyrey
October 9, 2026 13:38https://github.com/python/cpython/pull/158821#event-32879456383
JelleZijlstrahttps://github.com/JelleZijlstra
Oct 9, 2026 https://github.com/python/cpython/pull/158821#ref-commit-f8375c2
https://github.com/miss-islington
https://github.com/brittanyrey
[3.15]https://github.com/python/cpython/commit/f8375c23b9470496473bf2139dbe4be2e2b59b07
gh-158820https://github.com/python/cpython/issues/158820
: Add null checks to avoid segfaults with lazy import…https://github.com/python/cpython/commit/f8375c23b9470496473bf2139dbe4be2e2b59b07
f8375c2https://github.com/python/cpython/commit/f8375c23b9470496473bf2139dbe4be2e2b59b07
GH-158821https://github.com/python/cpython/pull/158821
#159062https://github.com/python/cpython/pull/159062
gh-158820https://github.com/python/cpython/issues/158820
GH-158821https://github.com/python/cpython/pull/158821
a6e6361https://github.com/python/cpython/commit/a6e636148e96dc3430b50b40e5b3e92173337130
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 9, 2026 https://github.com/python/cpython/pull/158821#ref-issue-5785862370
Request for Python triage membership: Brittany Reynoso python/core-workflow#609 https://github.com/python/core-workflow/issues/609
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158821
https://github.com/StanFromIreland
StanFromIreland https://github.com/StanFromIreland
https://github.com/python/cpython/pull/158821/files/a13e2d55af425c87e991850adcba7f11ca408666
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
https://github.com/python/cpython/pull/158821/files/a13e2d55af425c87e991850adcba7f11ca408666
https://github.com/Yhg1s
Yhg1s https://github.com/Yhg1s
https://github.com/DinoV
DinoV https://github.com/DinoV
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/warsaw
warsaw https://github.com/warsaw
https://github.com/FFY00
FFY00 https://github.com/FFY00
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
Please reload this pagehttps://github.com/python/cpython/pull/158821
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Please reload this pagehttps://github.com/python/cpython/pull/158821
https://github.com/brittanyrey
https://github.com/pablogsal
https://github.com/StanFromIreland
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.