René's URL Explorer Experiment


Title: gh-158195: Defer critical section restoration after STW by nascheme · Pull Request #158678 · python/cpython · GitHub

Open Graph Title: gh-158195: Defer critical section restoration after STW by nascheme · Pull Request #158678 · python/cpython

X Title: gh-158195: Defer critical section restoration after STW by nascheme · Pull Request #158678 · python/cpython

Description: In the free-threaded build, a thread that holds a critical section and requests a stop-the-world (STW) pause can deadlock against a thread that waits for STW while holding a lock that is not released on detach. An example of a deadlock: T1 holds TYPE_LOCK and requests STW (atomic GC, etc). The STW mutex is held by someone else, T1 parks and detaches, which releases TYPE_LOCK. T2 acquires TYPE_LOCK, pins it and requests STW. It parks behind T1. T1 acquires the STW mutex, when STW is finished, _PyThreadState_Attach() resumes T1's critical section and blocks on TYPE_LOCK T1 is waiting on TYPE_LOCK, T2 is waiting on the STW mutex. Deadlock. This PR fixes the deadlock by resuming the critical section after the STW mutex is released. With this change, T1 will block reacquiring TYPE_LOCK, letting T2 complete its STW work first. This is a change in behavior of the STW APIs. On the contended path, stop_the_world() already released the requester's critical sections (parking detaches). After this PR, they are released until start_the_world() returns rather than being re-acquired when stop_the_world() returns. This is observable to code that takes a critical section itself, calls STW directly, and relies on continuous ownership after the restart. Note: this PR was created with the assistance of AI agents (Claude and GPT models). Issue: gh-158195

Open Graph Description: In the free-threaded build, a thread that holds a critical section and requests a stop-the-world (STW) pause can deadlock against a thread that waits for STW while holding a lock that is not releas...

X Description: In the free-threaded build, a thread that holds a critical section and requests a stop-the-world (STW) pause can deadlock against a thread that waits for STW while holding a lock that is not releas...

Opengraph URL: https://github.com/python/cpython/pull/158678

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:72bf948e-a8bf-9aa7-2971-8569d3e96bec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id94AC:AFBD9:18F1639:20DAC6D:6B0210CC
html-safe-nonce2624b5522722101581f9a7e5c00445177d349ca0e9aa4248c3c6315903859e31
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEFDOkFGQkQ5OjE4RjE2Mzk6MjBEQUM2RDo2QjAyMTBDQyIsInZpc2l0b3JfaWQiOiI3ODAxNTg0MzI3MTgzMTc1ODg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5a2a3880e122f9146573d66374d9266fad2de40e97ee03e983bbc1f17724d88f
hovercard-subject-tagpull_request:4729118818
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/158678/files
twitter:imagehttps://avatars.githubusercontent.com/u/690853?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/690853?s=400&v=4
og:image:altIn the free-threaded build, a thread that holds a critical section and requests a stop-the-world (STW) pause can deadlock against a thread that waits for STW while holding a lock that is not releas...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/158678/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158678%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158678%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/158678/files
Reloadhttps://github.com/python/cpython/pull/158678/files
Reloadhttps://github.com/python/cpython/pull/158678/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
naschemehttps://github.com/nascheme
python:mainhttps://github.com/python/cpython/tree/main
nascheme:gh-158195-defer-cs-acquire-after-stwhttps://github.com/nascheme/cpython/tree/gh-158195-defer-cs-acquire-after-stw
Conversation 2 https://github.com/python/cpython/pull/158678
Commits 1 https://github.com/python/cpython/pull/158678/commits
Checks 81 https://github.com/python/cpython/pull/158678/checks
Files changed https://github.com/python/cpython/pull/158678/files
Please reload this pagehttps://github.com/python/cpython/pull/158678/files
gh-158195: Defer critical section restoration after STW https://github.com/python/cpython/pull/158678/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/158678/files
c17f28a gh-158195: Defer critical section restoration after STW nascheme Oct 2, 2026 https://github.com/python/cpython/pull/158678/commits/c17f28ab831844bee06d124b24b5c85b6ad3c8c2
Clear filters https://github.com/python/cpython/pull/158678/files
Please reload this pagehttps://github.com/python/cpython/pull/158678/files
Please reload this pagehttps://github.com/python/cpython/pull/158678/files
pycore_interp_structs.h https://github.com/python/cpython/pull/158678/files#diff-6075b6142803c1eccc213aa150704fd639443c65311d5999f69a5ea77cb76756
2026-10-02-12-00-00.gh-issue-158195.Hn4kTq.rst https://github.com/python/cpython/pull/158678/files#diff-8f7615f66dbe9c93311a1692c6f3ffb74c016c5c9efd7a100054e7ee6cb2cf63
test_critical_sections.c https://github.com/python/cpython/pull/158678/files#diff-902110173393c3f9b7f311a058506a57b9c77fb0c1cb853aeb63ad19d53479a9
pystate.c https://github.com/python/cpython/pull/158678/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
Include/internal/pycore_interp_structs.hhttps://github.com/python/cpython/pull/158678/files#diff-6075b6142803c1eccc213aa150704fd639443c65311d5999f69a5ea77cb76756
View file https://github.com/nascheme/cpython/blob/c17f28ab831844bee06d124b24b5c85b6ad3c8c2/Include/internal/pycore_interp_structs.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158678/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158678/files#diff-6075b6142803c1eccc213aa150704fd639443c65311d5999f69a5ea77cb76756
https://github.com/python/cpython/pull/158678/files#diff-6075b6142803c1eccc213aa150704fd639443c65311d5999f69a5ea77cb76756
Misc/NEWS.d/next/Core_and_Builtins/2026-10-02-12-00-00.gh-issue-158195.Hn4kTq.rsthttps://github.com/python/cpython/pull/158678/files#diff-8f7615f66dbe9c93311a1692c6f3ffb74c016c5c9efd7a100054e7ee6cb2cf63
View file https://github.com/nascheme/cpython/blob/c17f28ab831844bee06d124b24b5c85b6ad3c8c2/Misc/NEWS.d/next/Core_and_Builtins/2026-10-02-12-00-00.gh-issue-158195.Hn4kTq.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158678/{{ revealButtonHref }}
Modules/_testinternalcapi/test_critical_sections.chttps://github.com/python/cpython/pull/158678/files#diff-902110173393c3f9b7f311a058506a57b9c77fb0c1cb853aeb63ad19d53479a9
View file https://github.com/nascheme/cpython/blob/c17f28ab831844bee06d124b24b5c85b6ad3c8c2/Modules/_testinternalcapi/test_critical_sections.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158678/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158678/files#diff-902110173393c3f9b7f311a058506a57b9c77fb0c1cb853aeb63ad19d53479a9
https://github.com/python/cpython/pull/158678/files#diff-902110173393c3f9b7f311a058506a57b9c77fb0c1cb853aeb63ad19d53479a9
https://github.com/python/cpython/pull/158678/files#diff-902110173393c3f9b7f311a058506a57b9c77fb0c1cb853aeb63ad19d53479a9
https://github.com/python/cpython/pull/158678/files#diff-902110173393c3f9b7f311a058506a57b9c77fb0c1cb853aeb63ad19d53479a9
https://github.com/python/cpython/pull/158678/files#diff-902110173393c3f9b7f311a058506a57b9c77fb0c1cb853aeb63ad19d53479a9
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L319
Python/pystate.chttps://github.com/python/cpython/pull/158678/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
View file https://github.com/nascheme/cpython/blob/c17f28ab831844bee06d124b24b5c85b6ad3c8c2/Python/pystate.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158678/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158678/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/158678/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/158678/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/158678/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/158678/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/158678/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
Please reload this pagehttps://github.com/python/cpython/pull/158678/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.