René's URL Explorer Experiment


Title: gh-158550: `_remote_debugging`: Do not advance `prev_timestamp` when `write_sample` fails by maurycy · Pull Request #158551 · python/cpython · GitHub

Open Graph Title: gh-158550: `_remote_debugging`: Do not advance `prev_timestamp` when `write_sample` fails by maurycy · Pull Request #158551 · python/cpython

X Title: gh-158550: `_remote_debugging`: Do not advance `prev_timestamp` when `write_sample` fails by maurycy · Pull Request #158551 · python/cpython

Description: See #158550 for more details. maurycy@gimel cpython (fix-remote-debugging-writer-prev-timestamp e867c1d?) % cat repro.py import _remote_debugging w = _remote_debugging.BinaryWriter("/tmp/o.bin", 1000, 0) try: w.write_sample([(0, [(1, 0, [(42, None, "f", None)])])], 5000) except TypeError: pass w.write_sample([(0, [(1, 0, [("a.py", None, "f", None)])])], 6000) w.finalize() class C: def collect(self, frames, timestamps_us=None, **kw): print(timestamps_us) _remote_debugging.BinaryReader("/tmp/o.bin").replay(C()) maurycy@gimel cpython (fix-remote-debugging-writer-prev-timestamp e867c1d?) % ./python.exe repro.py [6000] Present in 3.15. Fixes #158550 Issue: gh-158550

Open Graph Description: See #158550 for more details. maurycy@gimel cpython (fix-remote-debugging-writer-prev-timestamp e867c1d?) % cat repro.py import _remote_debugging w = _remote_debugging.BinaryWriter("/tmp/o.b...

X Description: See #158550 for more details. maurycy@gimel cpython (fix-remote-debugging-writer-prev-timestamp e867c1d?) % cat repro.py import _remote_debugging w = _remote_debugging.BinaryWriter("/tmp...

Opengraph URL: https://github.com/python/cpython/pull/158551

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:577ca33e-32a1-517d-0a28-bdf6c1f18fa0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC7F6:842EC:376373C:49D0C3D:6B0215B3
html-safe-nonce3141b5f47689097f76c85310919015617e2208b375c6bd200cfa678ef764a11f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0Y2Ojg0MkVDOjM3NjM3M0M6NDlEMEMzRDo2QjAyMTVCMyIsInZpc2l0b3JfaWQiOiI3OTg2MzY2MjExMjM3NzQ2MTAwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb008688d8360baf50c5e66a6d0317458944bdd8b4b73c6714470d9517b729908
hovercard-subject-tagpull_request:4700499593
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/158551/files
twitter:imagehttps://avatars.githubusercontent.com/u/5383?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5383?s=400&v=4
og:image:altSee #158550 for more details. maurycy@gimel cpython (fix-remote-debugging-writer-prev-timestamp e867c1d?) % cat repro.py import _remote_debugging w = _remote_debugging.BinaryWriter("/tmp/o.b...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/158551/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158551%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158551%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/158551/files
Reloadhttps://github.com/python/cpython/pull/158551/files
Reloadhttps://github.com/python/cpython/pull/158551/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
maurycyhttps://github.com/maurycy
python:mainhttps://github.com/python/cpython/tree/main
maurycy:fix-remote-debugging-writer-prev-timestamphttps://github.com/maurycy/cpython/tree/fix-remote-debugging-writer-prev-timestamp
Conversation 1 https://github.com/python/cpython/pull/158551
Commits 3 https://github.com/python/cpython/pull/158551/commits
Checks 100 https://github.com/python/cpython/pull/158551/checks
Files changed 3 https://github.com/python/cpython/pull/158551/files
gh-158550: _remote_debugging: Do not advance prev_timestamp when write_sample fails https://github.com/python/cpython/pull/158551/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/158551/files
8f14f0c banal fix maurycy Sep 27, 2026 https://github.com/python/cpython/pull/158551/commits/8f14f0c1562b6dc887f2d4df54460d32ed7e6b0a
e867c1d test maurycy Sep 27, 2026 https://github.com/python/cpython/pull/158551/commits/e867c1d398ccb9a98ddbd532716625e36b3dfc3f
89f6e7c news maurycy Oct 1, 2026 https://github.com/python/cpython/pull/158551/commits/89f6e7cf019277bde30f9c6c047cbc2be4d8fab9
Clear filters https://github.com/python/cpython/pull/158551/files
Please reload this pagehttps://github.com/python/cpython/pull/158551/files
Please reload this pagehttps://github.com/python/cpython/pull/158551/files
test_binary_format.py https://github.com/python/cpython/pull/158551/files#diff-bd4b914717c4ce7ddb2e29a91a71fdba550983ce9cea09b1ee06847b128d71b6
2026-10-01-09-17-11.gh-issue-158550.cRIHW-.rst https://github.com/python/cpython/pull/158551/files#diff-fbe7d6ef39a7213e40c0bf87f736f16d08dd8e57ca788768010941761b921730
binary_io_writer.c https://github.com/python/cpython/pull/158551/files#diff-0874163bd266558e3cba125b8511bf1614fcd01c94e99fc14d81daac38390847
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L568
Lib/test/test_profiling/test_sampling_profiler/test_binary_format.pyhttps://github.com/python/cpython/pull/158551/files#diff-bd4b914717c4ce7ddb2e29a91a71fdba550983ce9cea09b1ee06847b128d71b6
View file https://github.com/maurycy/cpython/blob/89f6e7cf019277bde30f9c6c047cbc2be4d8fab9/Lib/test/test_profiling/test_sampling_profiler/test_binary_format.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158551/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158551/files#diff-bd4b914717c4ce7ddb2e29a91a71fdba550983ce9cea09b1ee06847b128d71b6
https://github.com/python/cpython/pull/158551/files#diff-bd4b914717c4ce7ddb2e29a91a71fdba550983ce9cea09b1ee06847b128d71b6
Misc/NEWS.d/next/Library/2026-10-01-09-17-11.gh-issue-158550.cRIHW-.rsthttps://github.com/python/cpython/pull/158551/files#diff-fbe7d6ef39a7213e40c0bf87f736f16d08dd8e57ca788768010941761b921730
View file https://github.com/maurycy/cpython/blob/89f6e7cf019277bde30f9c6c047cbc2be4d8fab9/Misc/NEWS.d/next/Library/2026-10-01-09-17-11.gh-issue-158550.cRIHW-.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158551/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L336
Modules/_remote_debugging/binary_io_writer.chttps://github.com/python/cpython/pull/158551/files#diff-0874163bd266558e3cba125b8511bf1614fcd01c94e99fc14d81daac38390847
View file https://github.com/maurycy/cpython/blob/89f6e7cf019277bde30f9c6c047cbc2be4d8fab9/Modules/_remote_debugging/binary_io_writer.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158551/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158551/files#diff-0874163bd266558e3cba125b8511bf1614fcd01c94e99fc14d81daac38390847
https://github.com/python/cpython/pull/158551/files#diff-0874163bd266558e3cba125b8511bf1614fcd01c94e99fc14d81daac38390847
https://github.com/python/cpython/pull/158551/files#diff-0874163bd266558e3cba125b8511bf1614fcd01c94e99fc14d81daac38390847
https://github.com/python/cpython/pull/158551/files#diff-0874163bd266558e3cba125b8511bf1614fcd01c94e99fc14d81daac38390847
Please reload this pagehttps://github.com/python/cpython/pull/158551/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.