René's URL Explorer Experiment


Title: gh-158336: Fix race in lock_tests test_set_and_clear by matthiasgoergens · Pull Request #158337 · python/cpython · GitHub

Open Graph Title: gh-158336: Fix race in lock_tests test_set_and_clear by matthiasgoergens · Pull Request #158337 · python/cpython

X Title: gh-158336: Fix race in lock_tests test_set_and_clear by matthiasgoergens · Pull Request #158337 · python/cpython

Description: Instead of sleeping for 50 ms, wait until all five threads are registered as waiters on the event's condition before calling set() and clear(). Condition.wait() appends the waiter to _waiters while holding the lock, and notify_all() wakes every waiter in that list, so set() then wakes all of them. With the reproducer from the issue, the test failed in 0 of 40 runs, against 9 of 40 before. The test still catches gh-57711 about as often as before: with Event.wait() changed back to return the flag after waking, it failed in 8 of 20 runs, against 7 of 20 without this change. The other callers of wait_threads_blocked() are not affected, because a thread that arrives late still finds the lock released, the semaphore available or the event set. This PR was prepared with the help of an AI assistant (Claude Code) and reviewed by me. Issue: gh-158336

Open Graph Description: Instead of sleeping for 50 ms, wait until all five threads are registered as waiters on the event's condition before calling set() and clear(). Condition.wait() appends the waiter to _waiters w...

X Description: Instead of sleeping for 50 ms, wait until all five threads are registered as waiters on the event's condition before calling set() and clear(). Condition.wait() appends the waiter to _waite...

Opengraph URL: https://github.com/python/cpython/pull/158337

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5b37efe9-b351-f327-a383-edd2ca912dc2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84E2:AFBD9:202D4CA:2A3FE5C:6B023B27
html-safe-nonce045a3883a7d0756559a17cfbcbdb39f47db4246036ca17ab7efd5d0e67233cef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEUyOkFGQkQ5OjIwMkQ0Q0E6MkEzRkU1Qzo2QjAyM0IyNyIsInZpc2l0b3JfaWQiOiI1ODYzMTM4MDYwMzI5NDMzODk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4b0259d2059f349a06ade753ee00cca0056b5fc2de2cca539cfed9e9c34860dd
hovercard-subject-tagpull_request:4663133611
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/158337/files
twitter:imagehttps://avatars.githubusercontent.com/u/57026?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/57026?s=400&v=4
og:image:altInstead of sleeping for 50 ms, wait until all five threads are registered as waiters on the event's condition before calling set() and clear(). Condition.wait() appends the waiter to _waiters w...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/158337/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158337%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158337%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/158337/files
Reloadhttps://github.com/python/cpython/pull/158337/files
Reloadhttps://github.com/python/cpython/pull/158337/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
matthiasgoergens:fix-test-set-and-clear-flakehttps://github.com/matthiasgoergens/cpython/tree/fix-test-set-and-clear-flake
Conversation 23 https://github.com/python/cpython/pull/158337
Commits 4 https://github.com/python/cpython/pull/158337/commits
Checks 56 https://github.com/python/cpython/pull/158337/checks
Files changed https://github.com/python/cpython/pull/158337/files
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
gh-158336: Fix race in lock_tests test_set_and_clear https://github.com/python/cpython/pull/158337/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/158337/files
146eedb gh-158336: Fix race in lock_tests test_set_and_clear matthiasgoergens Sep 28, 2026 https://github.com/python/cpython/pull/158337/commits/146eedbbfecd69f76acff0d3f65bf688cbbf597f
67a224f Apply suggestion from @vstinner vstinner Nov 9, 2026 https://github.com/python/cpython/pull/158337/commits/67a224f1d106e4b237173c360fb4faa903011033
106d1fa Update Lib/test/lock_tests.py vstinner Nov 9, 2026 https://github.com/python/cpython/pull/158337/commits/106d1fa042a39eb88b52a150b60357fc3493932e
484dfbf Merge branch 'main' into fix-test-set-and-clear-flake vstinner Nov 9, 2026 https://github.com/python/cpython/pull/158337/commits/484dfbff62c8cb4a51948d722b16830e8f4e9aea
Clear filters https://github.com/python/cpython/pull/158337/files
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
Lib/test/lock_tests.pyhttps://github.com/python/cpython/pull/158337/files#diff-1d04f1b4512c48ecc14e3eae5713be5dea3bdbeba07f9d77bb08089103c880db
View file https://github.com/matthiasgoergens/cpython/blob/484dfbff62c8cb4a51948d722b16830e8f4e9aea/Lib/test/lock_tests.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158337/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158337/files#diff-1d04f1b4512c48ecc14e3eae5713be5dea3bdbeba07f9d77bb08089103c880db
https://github.com/python/cpython/pull/158337/files#diff-1d04f1b4512c48ecc14e3eae5713be5dea3bdbeba07f9d77bb08089103c880db
vstinnerhttps://github.com/vstinner
Sep 30, 2026https://github.com/python/cpython/pull/158337/files#r4146597269
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
YvesDuphttps://github.com/YvesDup
Oct 2, 2026https://github.com/python/cpython/pull/158337/files#r4166603604
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
vstinnerhttps://github.com/vstinner
Oct 2, 2026https://github.com/python/cpython/pull/158337/files#r4166763737
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
YvesDuphttps://github.com/YvesDup
Oct 2, 2026https://github.com/python/cpython/pull/158337/files#r4167446147
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
YvesDuphttps://github.com/YvesDup
Oct 5, 2026https://github.com/python/cpython/pull/158337/files#r4182566020
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
vstinnerhttps://github.com/vstinner
Oct 5, 2026https://github.com/python/cpython/pull/158337/files#r4184083290
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
YvesDuphttps://github.com/YvesDup
Oct 5, 2026https://github.com/python/cpython/pull/158337/files#r4186478279
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
YvesDuphttps://github.com/YvesDup
Nov 9, 2026https://github.com/python/cpython/pull/158337/files#r4513191788
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
vstinnerhttps://github.com/vstinner
Nov 9, 2026https://github.com/python/cpython/pull/158337/files#r4514900941
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
https://github.com/python/cpython/pull/158337/files#diff-1d04f1b4512c48ecc14e3eae5713be5dea3bdbeba07f9d77bb08089103c880db
Please reload this pagehttps://github.com/python/cpython/pull/158337/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.