René's URL Explorer Experiment


Title: bpo-37251: Removes __code__ check from _is_async_obj. by lisroach · Pull Request #15830 · python/cpython · GitHub

Open Graph Title: bpo-37251: Removes __code__ check from _is_async_obj. by lisroach · Pull Request #15830 · python/cpython

X Title: bpo-37251: Removes __code__ check from _is_async_obj. by lisroach · Pull Request #15830 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: It should be possible that an awaitable object does not have a __code__, so technically checking for the __code__ attribute in _is_async_obj is incorrect. This faulty code check is also why things ...

X Description: It should be possible that an awaitable object does not have a __code__, so technically checking for the __code__ attribute in _is_async_obj is incorrect. This faulty code check is also why things ...

Opengraph URL: https://github.com/python/cpython/pull/15830

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d5ace0fe-c6d4-dda7-6888-9c149273b34d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB66C:33B84F:1B752D3:24AC100:6A544C32
html-safe-nonce0ab01126f84dcf28375e9b270b5e20e132dd43898144935a0b617e28e39eb23c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjZDOjMzQjg0RjoxQjc1MkQzOjI0QUMxMDA6NkE1NDRDMzIiLCJ2aXNpdG9yX2lkIjoiMTI1NDU5ODUwOTE2MTg5MjkxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5c74b06261742e9a5f0bb6ab7e04d86a288c1b516250bcdc7dc97ef9ac066459
hovercard-subject-tagpull_request:315911937
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/15830/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/425efba3033bb92d88beef28c57a53b9d3bdb4bc23657b722dd966b836bfa008/python/cpython/pull/15830
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/425efba3033bb92d88beef28c57a53b9d3bdb4bc23657b722dd966b836bfa008/python/cpython/pull/15830
og:image:altIt should be possible that an awaitable object does not have a __code__, so technically checking for the __code__ attribute in _is_async_obj is incorrect. This faulty code check is also why things ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelisroach
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/15830#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15830
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15830
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/15830
Reloadhttps://github.com/python/cpython/pull/15830
Reloadhttps://github.com/python/cpython/pull/15830
Please reload this pagehttps://github.com/python/cpython/pull/15830
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/15830
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
lisroachhttps://github.com/lisroach
python:masterhttps://github.com/python/cpython/tree/master
lisroach:asyncmock_objhttps://github.com/lisroach/cpython/tree/asyncmock_obj
Conversationhttps://github.com/python/cpython/pull/15830
Commits4 (4)https://github.com/python/cpython/pull/15830/commits
Checkshttps://github.com/python/cpython/pull/15830/checks
Files changedhttps://github.com/python/cpython/pull/15830/files
bpo-37251: Removes __code__ check from _is_async_obj.https://github.com/python/cpython/pull/15830#top
lisroachhttps://github.com/lisroach
python:masterhttps://github.com/python/cpython/tree/master
lisroach:asyncmock_objhttps://github.com/lisroach/cpython/tree/asyncmock_obj
https://github.com/lisroach
lisroachhttps://github.com/lisroach
Sep 10, 2019https://github.com/python/cpython/pull/15830#issue-491571460
Please reload this pagehttps://github.com/python/cpython/pull/15830
https://bugs.python.org/issue37251https://bugs.python.org/issue37251
Please reload this pagehttps://github.com/python/cpython/pull/15830
https://github.com/lisroach
Removes __code__ check from _is_async_obj.https://github.com/python/cpython/pull/15830/commits/cabfb5a84fe03cb4b6f527a52bcdfbfcebabc727
cabfb5ahttps://github.com/python/cpython/pull/15830/commits/cabfb5a84fe03cb4b6f527a52bcdfbfcebabc727
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 10, 2019https://github.com/python/cpython/pull/15830#event-2621646228
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 10, 2019https://github.com/python/cpython/pull/15830#event-2621646298
lisroachhttps://github.com/lisroach
September 10, 2019 11:00https://github.com/python/cpython/pull/15830#commits-pushed-dccaaf6
https://github.com/lisroach
Adds news blurb.https://github.com/python/cpython/pull/15830/commits/dccaaf61288999d4b5215d2d272e0ae3b984851e
dccaaf6https://github.com/python/cpython/pull/15830/commits/dccaaf61288999d4b5215d2d272e0ae3b984851e
https://github.com/lisroach
Fixes typo in news blurb.https://github.com/python/cpython/pull/15830/commits/2099348f367759dcb7ccee00f57e19603f4bc2eb
2099348https://github.com/python/cpython/pull/15830/commits/2099348f367759dcb7ccee00f57e19603f4bc2eb
https://github.com/lisroach
lisroachhttps://github.com/lisroach
asvetlovhttps://github.com/asvetlov
September 10, 2019 10:09https://github.com/python/cpython/pull/15830#event-2621685828
https://github.com/tirkarthi
tirkarthihttps://github.com/tirkarthi
Sep 10, 2019 https://github.com/python/cpython/pull/15830#pullrequestreview-286048344
View reviewed changes https://github.com/python/cpython/pull/15830/files/2099348f367759dcb7ccee00f57e19603f4bc2eb
Misc/NEWS.d/next/Library/2019-09-10-10-59-50.bpo-37251.8zn2o3.rsthttps://github.com/python/cpython/pull/15830/files/2099348f367759dcb7ccee00f57e19603f4bc2eb#diff-79bf263c52c4ed437072f2a44f6aa4e59d9213b4789710db40cdd06b2bf07c3f
Please reload this pagehttps://github.com/python/cpython/pull/15830
https://github.com/tirkarthi
tirkarthihttps://github.com/tirkarthi
Sep 10, 2019 https://github.com/python/cpython/pull/15830#pullrequestreview-286051376
View reviewed changes https://github.com/python/cpython/pull/15830/files/2099348f367759dcb7ccee00f57e19603f4bc2eb
tirkarthihttps://github.com/tirkarthi
https://github.com/python/cpython/pull/15830#pullrequestreview-286051376
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/15830
https://github.com/lisroach
https://github.com/tirkarthi
Update Misc/NEWS.d/next/Library/2019-09-10-10-59-50.bpo-37251.8zn2o3.rsthttps://github.com/python/cpython/pull/15830/commits/dc9fc73a2a9843dfb9fc3b4b66999f438bb05a5a
dc9fc73https://github.com/python/cpython/pull/15830/commits/dc9fc73a2a9843dfb9fc3b4b66999f438bb05a5a
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
Sep 10, 2019 https://github.com/python/cpython/pull/15830#pullrequestreview-286061574
View reviewed changes https://github.com/python/cpython/pull/15830/files/dc9fc73a2a9843dfb9fc3b4b66999f438bb05a5a
asvetlovhttps://github.com/asvetlov
https://github.com/python/cpython/pull/15830#pullrequestreview-286061574
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/15830
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Sep 10, 2019https://github.com/python/cpython/pull/15830#event-2621788775
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
Sep 10, 2019https://github.com/python/cpython/pull/15830#issuecomment-529880332
Please reload this pagehttps://github.com/python/cpython/pull/15830
https://github.com/lisroach
lisroachhttps://github.com/lisroach
f1a297ahttps://github.com/python/cpython/commit/f1a297acb60b88917712450ebd3cfa707e6efd6b
Sep 10, 2019https://github.com/python/cpython/pull/15830#event-2621870198
https://github.com/lisroach
lisroachhttps://github.com/lisroach
September 10, 2019 11:18https://github.com/python/cpython/pull/15830#event-2621870242
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 10, 2019https://github.com/python/cpython/pull/15830#issuecomment-529889329
@lisroachhttps://github.com/lisroach
Please reload this pagehttps://github.com/python/cpython/pull/15830
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 10, 2019https://github.com/python/cpython/pull/15830#event-2621870286
miss-islingtonhttps://github.com/miss-islington
Sep 10, 2019 https://github.com/python/cpython/pull/15830#ref-commit-435768a
https://github.com/lisroach
https://github.com/miss-islington
bpo-37251: Removes __code__ check from _is_async_obj. (https://github.com/miss-islington/cpython/commit/435768a870721232319a167d2b0e15c6b08ce1f1
pythonGH-15830https://github.com/python/cpython/pull/15830
)https://github.com/miss-islington/cpython/commit/435768a870721232319a167d2b0e15c6b08ce1f1
435768ahttps://github.com/miss-islington/cpython/commit/435768a870721232319a167d2b0e15c6b08ce1f1
f1a297ahttps://github.com/miss-islington/cpython/commit/f1a297acb60b88917712450ebd3cfa707e6efd6b
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Sep 10, 2019https://github.com/python/cpython/pull/15830#event-2621870599
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 10, 2019https://github.com/python/cpython/pull/15830#issuecomment-529889360
GH-15837https://github.com/python/cpython/pull/15837
3.8 branchhttps://github.com/python/cpython/tree/3.8
Please reload this pagehttps://github.com/python/cpython/pull/15830
miss-islingtonhttps://github.com/miss-islington
Sep 10, 2019 https://github.com/python/cpython/pull/15830#ref-commit-c3008dd
https://github.com/miss-islington
https://github.com/lisroach
bpo-37251https://bugs.python.org/issue?@action=redirect&bpo=37251
: Removes __code__ check from _is_async_obj. (https://github.com/python/cpython/commit/c3008dd480d645678409273eecbfd24bbc9669d7
GH-15830https://github.com/python/cpython/pull/15830
)https://github.com/python/cpython/commit/c3008dd480d645678409273eecbfd24bbc9669d7
c3008ddhttps://github.com/python/cpython/commit/c3008dd480d645678409273eecbfd24bbc9669d7
f1a297ahttps://github.com/python/cpython/commit/f1a297acb60b88917712450ebd3cfa707e6efd6b
https://github.com/tirkarthi
tirkarthihttps://github.com/tirkarthi
Sep 11, 2019 https://github.com/python/cpython/pull/15830#ref-pullrequest-456553971
bpo-37251: MagicMock with function spec used as a spec in mock.patch should return a MagicMock #14117 https://github.com/python/cpython/pull/14117
websurfer5https://github.com/websurfer5
Jul 20, 2020 https://github.com/python/cpython/pull/15830#ref-commit-037dbf6
https://github.com/lisroach
https://github.com/websurfer5
bpo-37251: Removes __code__ check from _is_async_obj. (https://github.com/websurfer5/cpython/commit/037dbf6898bfe29ef6b6a76ce1fb4ee92969566c
pythonGH-15830https://github.com/python/cpython/pull/15830
)https://github.com/websurfer5/cpython/commit/037dbf6898bfe29ef6b6a76ce1fb4ee92969566c
037dbf6https://github.com/websurfer5/cpython/commit/037dbf6898bfe29ef6b6a76ce1fb4ee92969566c
https://github.com/python/cpython/pull/15830
jeremyclinehttps://github.com/python/cpython/pull/15830
Apr 10, 2022 https://github.com/python/cpython/pull/15830#ref-issue-1199014094
Mocking a MagicMock with a function spec results in an AsyncMock #81432 https://github.com/python/cpython/issues/81432
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15830
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/python/cpython/pull/15830/files/dc9fc73a2a9843dfb9fc3b4b66999f438bb05a5a
https://github.com/tirkarthi
tirkarthi https://github.com/tirkarthi
https://github.com/python/cpython/pull/15830/files/2099348f367759dcb7ccee00f57e19603f4bc2eb
Please reload this pagehttps://github.com/python/cpython/pull/15830
https://github.com/lisroach
https://github.com/asvetlov
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/tirkarthi
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.