René's URL Explorer Experiment


Title: gh-142349: Simplify lazy import resolution by pablogsal · Pull Request #158282 · python/cpython · GitHub

Open Graph Title: gh-142349: Simplify lazy import resolution by pablogsal · Pull Request #158282 · python/cpython

X Title: gh-142349: Simplify lazy import resolution by pablogsal · Pull Request #158282 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The current implementation has some problems. The eval loop and module attribute lookup repeat the code that resolves a lazy import and replaces its placeholder. These copies behave differently. We...

X Description: The current implementation has some problems. The eval loop and module attribute lookup repeat the code that resolves a lazy import and replaces its placeholder. These copies behave differently. We...

Opengraph URL: https://github.com/python/cpython/pull/158282

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:9da2502f-6e6d-7cf6-3130-d587da671583
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEE36:21AC3F:410E43A:52509E1:6B01FEEE
html-safe-nonceda7ecec5f362dad92cbe2b653d750a2bfdcbcd4343efe93a4780e2d026584598
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRTM2OjIxQUMzRjo0MTBFNDNBOjUyNTA5RTE6NkIwMUZFRUUiLCJ2aXNpdG9yX2lkIjoiMTQ1NDU2MDkwNzg5MDkxNzEwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0c3666b30a630732ce1cb8aae3227d7bd0047d243ef52a847d30af92020e0af6
hovercard-subject-tagpull_request:4654430493
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/158282/commits
twitter:imagehttps://opengraph.githubassets.com/d53beec6c41ec264f08454b706cb52b4c2071910dceace6bfc1e82d4f06aca75/python/cpython/pull/158282
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d53beec6c41ec264f08454b706cb52b4c2071910dceace6bfc1e82d4f06aca75/python/cpython/pull/158282
og:image:altThe current implementation has some problems. The eval loop and module attribute lookup repeat the code that resolves a lazy import and replaces its placeholder. These copies behave differently. We...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepablogsal
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/158282/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158282%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158282%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/158282/commits
Reloadhttps://github.com/python/cpython/pull/158282/commits
Reloadhttps://github.com/python/cpython/pull/158282/commits
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:simplify-lazy-imports-chttps://github.com/pablogsal/cpython/tree/simplify-lazy-imports-c
Conversationhttps://github.com/python/cpython/pull/158282
Commits19 (19)https://github.com/python/cpython/pull/158282/commits
Checkshttps://github.com/python/cpython/pull/158282/checks
Files changedhttps://github.com/python/cpython/pull/158282/files
gh-142349: Simplify lazy import resolutionhttps://github.com/python/cpython/pull/158282/commits#top
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:simplify-lazy-imports-chttps://github.com/pablogsal/cpython/tree/simplify-lazy-imports-c
Move lazy resolution next to the placeholderhttps://github.com/python/cpython/pull/158282/commits/67ed53598bf82329edfd5ae599e8b36f5a275d71
https://github.com/pablogsal
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
67ed535https://github.com/python/cpython/pull/158282/commits/67ed53598bf82329edfd5ae599e8b36f5a275d71
https://github.com/python/cpython/tree/67ed53598bf82329edfd5ae599e8b36f5a275d71
Track lazy resolution per threadhttps://github.com/python/cpython/pull/158282/commits/ac89dd0892cba39599bb730dba33b90040436c11
https://github.com/pablogsal
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
ac89dd0https://github.com/python/cpython/pull/158282/commits/ac89dd0892cba39599bb730dba33b90040436c11
https://github.com/python/cpython/tree/ac89dd0892cba39599bb730dba33b90040436c11
Keep the original lazy import error chainhttps://github.com/python/cpython/pull/158282/commits/846f93497ae013ab48eced32d79222dbb31ca5c9
https://github.com/pablogsal
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
846f934https://github.com/python/cpython/pull/158282/commits/846f93497ae013ab48eced32d79222dbb31ca5c9
https://github.com/python/cpython/tree/846f93497ae013ab48eced32d79222dbb31ca5c9
Avoid waiting in the lazy from shortcuthttps://github.com/python/cpython/pull/158282/commits/dd01552d2a7fb2f5870e402b5ab5abf27df7fbd3
https://github.com/pablogsal
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
dd01552https://github.com/python/cpython/pull/158282/commits/dd01552d2a7fb2f5870e402b5ab5abf27df7fbd3
https://github.com/python/cpython/tree/dd01552d2a7fb2f5870e402b5ab5abf27df7fbd3
Simplify lazy import declarationshttps://github.com/python/cpython/pull/158282/commits/b78ebc9c8927084c69e90940827633fc0b30c6f4
https://github.com/pablogsal
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
b78ebc9https://github.com/python/cpython/pull/158282/commits/b78ebc9c8927084c69e90940827633fc0b30c6f4
https://github.com/python/cpython/tree/b78ebc9c8927084c69e90940827633fc0b30c6f4
Handle lazy module hooks and children togetherhttps://github.com/python/cpython/pull/158282/commits/917df44c277a86162011a11fcaf629928da1986e
https://github.com/pablogsal
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
917df44https://github.com/python/cpython/pull/158282/commits/917df44c277a86162011a11fcaf629928da1986e
https://github.com/python/cpython/tree/917df44c277a86162011a11fcaf629928da1986e
Share lazy import rebindinghttps://github.com/python/cpython/pull/158282/commits/4dc64c864178c326ad98cd57039787dba5f0fb61
https://github.com/pablogsal
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
4dc64c8https://github.com/python/cpython/pull/158282/commits/4dc64c864178c326ad98cd57039787dba5f0fb61
https://github.com/python/cpython/tree/4dc64c864178c326ad98cd57039787dba5f0fb61
Keep imported attributes on their parent packagehttps://github.com/python/cpython/pull/158282/commits/ad34faea95935c9cedfb940930e3c377322a4e09
https://github.com/pablogsal
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
ad34faehttps://github.com/python/cpython/pull/158282/commits/ad34faea95935c9cedfb940930e3c377322a4e09
https://github.com/python/cpython/tree/ad34faea95935c9cedfb940930e3c377322a4e09
Add/move assertions to replace_valuehttps://github.com/python/cpython/pull/158282/commits/047f4d45271b714dbb664e3650b5e6f9891feb1e
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
047f4d4https://github.com/python/cpython/pull/158282/commits/047f4d45271b714dbb664e3650b5e6f9891feb1e
https://github.com/python/cpython/tree/047f4d45271b714dbb664e3650b5e6f9891feb1e
Replace BPO issue number with GHhttps://github.com/python/cpython/pull/158282/commits/3612cf928e7e5adf76029e831158a5797087f88b
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
3612cf9https://github.com/python/cpython/pull/158282/commits/3612cf928e7e5adf76029e831158a5797087f88b
https://github.com/python/cpython/tree/3612cf928e7e5adf76029e831158a5797087f88b
Switch matches to Py_ssize_thttps://github.com/python/cpython/pull/158282/commits/c5068e02139a065414f383851f73081ee33d8e54
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
c5068e0https://github.com/python/cpython/pull/158282/commits/c5068e02139a065414f383851f73081ee33d8e54
https://github.com/python/cpython/tree/c5068e02139a065414f383851f73081ee33d8e54
PEP 257https://github.com/python/cpython/pull/158282/commits/d7a24822d5788547292e102510ac92085169e269
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
d7a2482https://github.com/python/cpython/pull/158282/commits/d7a24822d5788547292e102510ac92085169e269
https://github.com/python/cpython/tree/d7a24822d5788547292e102510ac92085169e269
Expand asserts for readability & better error reportinghttps://github.com/python/cpython/pull/158282/commits/456a83f10ba94660b7b54b8cae34f7b16e3e067a
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
456a83fhttps://github.com/python/cpython/pull/158282/commits/456a83f10ba94660b7b54b8cae34f7b16e3e067a
https://github.com/python/cpython/tree/456a83f10ba94660b7b54b8cae34f7b16e3e067a
Update lazyimportobject.chttps://github.com/python/cpython/pull/158282/commits/3dae4a6b6a25375f9b3f0b1f999c556cc06cf352
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
encukouhttps://github.com/python/cpython/commits?author=encukou
3dae4a6https://github.com/python/cpython/pull/158282/commits/3dae4a6b6a25375f9b3f0b1f999c556cc06cf352
https://github.com/python/cpython/tree/3dae4a6b6a25375f9b3f0b1f999c556cc06cf352
Add noteshttps://github.com/python/cpython/pull/158282/commits/88146d081263dd42bbd844e52c0db576975f5922
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
88146d0https://github.com/python/cpython/pull/158282/commits/88146d081263dd42bbd844e52c0db576975f5922
https://github.com/python/cpython/tree/88146d081263dd42bbd844e52c0db576975f5922
Add test for adding notes to chained exceptionshttps://github.com/python/cpython/pull/158282/commits/e3b48f586154519748563ff5da98c8fd74078e2a
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
e3b48f5https://github.com/python/cpython/pull/158282/commits/e3b48f586154519748563ff5da98c8fd74078e2a
https://github.com/python/cpython/tree/e3b48f586154519748563ff5da98c8fd74078e2a
Add test for fromlist type checkinghttps://github.com/python/cpython/pull/158282/commits/523fa99e93cb27a25acc02edabd3ce67f12037c0
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
523fa99https://github.com/python/cpython/pull/158282/commits/523fa99e93cb27a25acc02edabd3ce67f12037c0
https://github.com/python/cpython/tree/523fa99e93cb27a25acc02edabd3ce67f12037c0
Apply batched suggestions from code reviewhttps://github.com/python/cpython/pull/158282/commits/e44cc181f05cbdbb8bad3c9ad5e74a0c99dfdaa0
encukouhttps://github.com/python/cpython/commits?author=encukou
hugovkhttps://github.com/python/cpython/commits?author=hugovk
e44cc18https://github.com/python/cpython/pull/158282/commits/e44cc181f05cbdbb8bad3c9ad5e74a0c99dfdaa0
https://github.com/python/cpython/tree/e44cc181f05cbdbb8bad3c9ad5e74a0c99dfdaa0
Merge pull request #145 from encukou/simplify-lazy-imports-chttps://github.com/python/cpython/pull/158282/commits/b09a509f21007615140172fbf9ffafc122c8b1d7
https://github.com/pablogsal
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
b09a509https://github.com/python/cpython/pull/158282/commits/b09a509f21007615140172fbf9ffafc122c8b1d7
https://github.com/python/cpython/tree/b09a509f21007615140172fbf9ffafc122c8b1d7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.