René's URL Explorer Experiment


Title: gh-158031, gh-158033: Fix UAF in iter/aiter sentinel comparison by iliasabk · Pull Request #158145 · python/cpython · GitHub

Open Graph Title: gh-158031, gh-158033: Fix UAF in iter/aiter sentinel comparison by iliasabk · Pull Request #158145 · python/cpython

X Title: gh-158031, gh-158033: Fix UAF in iter/aiter sentinel comparison by iliasabk · Pull Request #158145 · python/cpython

Description: Issues Fixes #158031, fixes #158033 — two same-class heap-use-after-free reports in the callable-with-sentinel iterators added by gh-98469. Root cause Both calliter_iternext() (sync iter(callable, sentinel)) and acallawaitable_handle_error() (async aiter(callable, sentinel)) compare it->it_sentinel against the produced value with PyObject_RichCompareBool() while holding only a borrowed reference. The comparison can run arbitrary Python code via a custom __eq__, and that code can release the sentinel mid-comparison: sync: Sentinel.__eq__ calls it.__setstate__(((), StopIteration)), which does Py_XSETREF(it->it_sentinel, NULL); once the __eq__ frame is torn down the last reference is gone and do_richcompare() continues with a freed v (ASan: UAF read at iterobject.c:285). async: Sentinel.__eq__ drives ait.__anext__().__await__().send(None), which reaches acallawaitable_start → callable raises StopAsyncIteration → acalliter_exhaust() → Py_CLEAR(it->it_sentinel); same freed-v continuation (ASan: UAF read at iterobject.c:644). Fix Hold a strong reference to the sentinel across the PyObject_RichCompareBool() call in both functions — the same pattern already used elsewhere for callbacks that can mutate the iterator (see the ordering note in calliter_reduce, gh-101765). No behavior change: the in-flight comparison still uses the sentinel that was current when the comparison started, and subsequent state (calliter_exhaust, _PyGen_SetStopIterationValue) reads the post-mutation fields as before. Tests test_calliter_sentinel_reentrant_setstate in test_iter.py — __eq__ re-entrantly calls __setstate__ during next(). test_aiter_callable_sentinel_reentrant_exhaustion in test_asyncgen.py — __eq__ re-entrantly exhausts the iterator via a nested __anext__() send. Verification (local, ASan, --without-pymalloc, arm64 macOS) Both reporter PoCs: heap-use-after-free inside do_richcompare before the fix; clean run and correct semantics after (sync: next() returns the result; async: StopIteration with the produced value). New regression tests pass; test_iter.py and test_asyncgen.py suites unchanged otherwise. This PR was prepared with AI-agent assistance; the changes are small, reviewed line-by-line, and covered by the added regression tests. Issue: gh-158031

Open Graph Description: Issues Fixes #158031, fixes #158033 — two same-class heap-use-after-free reports in the callable-with-sentinel iterators added by gh-98469. Root cause Both calliter_iternext() (sync iter(callable, ...

X Description: Issues Fixes #158031, fixes #158033 — two same-class heap-use-after-free reports in the callable-with-sentinel iterators added by gh-98469. Root cause Both calliter_iternext() (sync iter(callable, ...

Opengraph URL: https://github.com/python/cpython/pull/158145

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1a7afc7a-e181-88ae-9fe2-0d8229e75323
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB0C0:A950:2019C1:2A0CAD:6B023444
html-safe-noncea83325ab139f2987068a047fde7f3b7dc2f0de0fb90124742d602ae852d68e3c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEMwOkE5NTA6MjAxOUMxOjJBMENBRDo2QjAyMzQ0NCIsInZpc2l0b3JfaWQiOiIxMDQ2MzM2MTg5MjM1MzQ0NDUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf0cf01e672466f635f6c0e5aa85eab8f6dda79feea90b5c370923615e6b36a0f
hovercard-subject-tagpull_request:4632378246
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/158145/files
twitter:imagehttps://avatars.githubusercontent.com/u/286468824?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/286468824?s=400&v=4
og:image:altIssues Fixes #158031, fixes #158033 — two same-class heap-use-after-free reports in the callable-with-sentinel iterators added by gh-98469. Root cause Both calliter_iternext() (sync iter(callable, ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/158145/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158145%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158145%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/158145/files
Reloadhttps://github.com/python/cpython/pull/158145/files
Reloadhttps://github.com/python/cpython/pull/158145/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
iliasabkhttps://github.com/iliasabk
python:mainhttps://github.com/python/cpython/tree/main
iliasabk:fix-iter-sentinel-uafhttps://github.com/iliasabk/cpython/tree/fix-iter-sentinel-uaf
Conversation 4 https://github.com/python/cpython/pull/158145
Commits 1 https://github.com/python/cpython/pull/158145/commits
Checks 51 https://github.com/python/cpython/pull/158145/checks
Files changed https://github.com/python/cpython/pull/158145/files
Please reload this pagehttps://github.com/python/cpython/pull/158145/files
gh-158031, gh-158033: Fix UAF in iter/aiter sentinel comparison https://github.com/python/cpython/pull/158145/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/158145/files
fbaa55b gh-158031, gh-158033: Fix UAF in iter/aiter sentinel comparison iliasabk Sep 25, 2026 https://github.com/python/cpython/pull/158145/commits/fbaa55bc980b101051481155dcc1ff10e48cdaa2
Clear filters https://github.com/python/cpython/pull/158145/files
Please reload this pagehttps://github.com/python/cpython/pull/158145/files
Please reload this pagehttps://github.com/python/cpython/pull/158145/files
test_asyncgen.py https://github.com/python/cpython/pull/158145/files#diff-1da5f0220b91e20c669b0e63724b978d4cf603373c850fbdc705abb2d5937f40
test_iter.py https://github.com/python/cpython/pull/158145/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
2026-09-23-23-45-00.gh-issue-158031.itSentUaf.rst https://github.com/python/cpython/pull/158145/files#diff-b20e1c05592b14f43c55f0e2cf5924b5c38dec6c9ea2849d02fa51bb4d4fa8fa
iterobject.c https://github.com/python/cpython/pull/158145/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
Lib/test/test_asyncgen.pyhttps://github.com/python/cpython/pull/158145/files#diff-1da5f0220b91e20c669b0e63724b978d4cf603373c850fbdc705abb2d5937f40
View file https://github.com/iliasabk/cpython/blob/fbaa55bc980b101051481155dcc1ff10e48cdaa2/Lib/test/test_asyncgen.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158145/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158145/files#diff-1da5f0220b91e20c669b0e63724b978d4cf603373c850fbdc705abb2d5937f40
https://github.com/python/cpython/pull/158145/files#diff-1da5f0220b91e20c669b0e63724b978d4cf603373c850fbdc705abb2d5937f40
Lib/test/test_iter.pyhttps://github.com/python/cpython/pull/158145/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
View file https://github.com/iliasabk/cpython/blob/fbaa55bc980b101051481155dcc1ff10e48cdaa2/Lib/test/test_iter.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158145/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158145/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
https://github.com/python/cpython/pull/158145/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
...NEWS.d/next/Core_and_Builtins/2026-09-23-23-45-00.gh-issue-158031.itSentUaf.rsthttps://github.com/python/cpython/pull/158145/files#diff-b20e1c05592b14f43c55f0e2cf5924b5c38dec6c9ea2849d02fa51bb4d4fa8fa
View file https://github.com/iliasabk/cpython/blob/fbaa55bc980b101051481155dcc1ff10e48cdaa2/Misc/NEWS.d/next/Core_and_Builtins/2026-09-23-23-45-00.gh-issue-158031.itSentUaf.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158145/{{ revealButtonHref }}
Objects/iterobject.chttps://github.com/python/cpython/pull/158145/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
View file https://github.com/iliasabk/cpython/blob/fbaa55bc980b101051481155dcc1ff10e48cdaa2/Objects/iterobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158145/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158145/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/158145/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/158145/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/158145/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
Please reload this pagehttps://github.com/python/cpython/pull/158145/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.