René's URL Explorer Experiment


Title: gh-156026: Document that the 'tar' filter does not bound link targets by drengir1 · Pull Request #158038 · python/cpython · GitHub

Open Graph Title: gh-156026: Document that the 'tar' filter does not bound link targets by drengir1 · Pull Request #158038 · python/cpython

X Title: gh-156026: Document that the 'tar' filter does not bound link targets by drengir1 · Pull Request #158038 · python/cpython

Description: Documentation only. No behaviour change. tar_filter does not check TarInfo.linkname, so a symbolic link member whose target is absolute, or relative and climbing outside the destination, is extracted as given. Only data_filter refuses those. That is consistent with PEP 706 and I am not proposing to change it — but the docs never say it, and the containment bullet of tar_filter reads as though they do: Refuse to extract files whose absolute path (after following symlinks) would end up outside the destination. "(after following symlinks)" describes realpath() on the member's own destination path, not the link target the member creates. Today the non-guarantee is derivable only by noticing that data_filter says "In addition to what tar_filter does" and that link-target containment appears only in that second list. The recently added normalization bullet sharpens this rather than covering it: it now warns that removing internal .. components "may change the meaning of the name if it traverses symbolic links", so the section does discuss symlinks — but only as they affect a member's own name. linkname is still never mentioned. This adds two things: One clause in the 'tar' entry of the filter list, since that list is where the choice between 'tar' and 'data' is actually made. A .. warning:: on tar_filter stating the non-guarantee positively and pointing at data_filter. It is placed before the existing .. versionchanged:: note so version history stays last. Motivation and the measured behaviour (with controls, and with the scope limited to symbolic links, which is what I verified) are in #156026. Briefly: five independent projects picked 'tar' in code whose stated purpose is safe extraction — unstructured-ingest, container-inspector, portage, poetry, and Samba's safe_tarfile.py, whose comment "which prevents escape" is close to a verbatim restatement of the bullet above. No Misc/NEWS.d entry — docs-only change, so this should carry skip news. Happy to reword any of it; I care that the fact is stated somewhere in the tar_filter section, not about the phrasing. Issue: gh-156026

Open Graph Description: Documentation only. No behaviour change. tar_filter does not check TarInfo.linkname, so a symbolic link member whose target is absolute, or relative and climbing outside the destination, is extract...

X Description: Documentation only. No behaviour change. tar_filter does not check TarInfo.linkname, so a symbolic link member whose target is absolute, or relative and climbing outside the destination, is extract...

Opengraph URL: https://github.com/python/cpython/pull/158038

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fdbe7c37-a30c-b78c-fe9a-ab4ae4c80d2d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB698:24645:256C305:31104DE:6B025886
html-safe-noncea8470a5c6dbbae3ed511eb3e5959356c5a97755157c5cd927ffdef93e6818dcb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjk4OjI0NjQ1OjI1NkMzMDU6MzExMDRERTo2QjAyNTg4NiIsInZpc2l0b3JfaWQiOiI4Mjg5MjAwNzg2MTYwOTAwMjMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9ecd358551bb99441ba7639b6f1c6c4158ee4e730f4852ee66411fb6d3c33d8a
hovercard-subject-tagpull_request:4619174665
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/158038/files
twitter:imagehttps://avatars.githubusercontent.com/u/198132210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/198132210?s=400&v=4
og:image:altDocumentation only. No behaviour change. tar_filter does not check TarInfo.linkname, so a symbolic link member whose target is absolute, or relative and climbing outside the destination, is extract...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/158038/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158038%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F158038%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/158038/files
Reloadhttps://github.com/python/cpython/pull/158038/files
Reloadhttps://github.com/python/cpython/pull/158038/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
drengir1https://github.com/drengir1
python:mainhttps://github.com/python/cpython/tree/main
drengir1:mainhttps://github.com/drengir1/cpython/tree/main
Conversation 4 https://github.com/python/cpython/pull/158038
Commits 1 https://github.com/python/cpython/pull/158038/commits
Checks 35 https://github.com/python/cpython/pull/158038/checks
Files changed https://github.com/python/cpython/pull/158038/files
Please reload this pagehttps://github.com/python/cpython/pull/158038/files
gh-156026: Document that the 'tar' filter does not bound link targets https://github.com/python/cpython/pull/158038/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/158038/files
8bfc405 gh-156026: Document that the 'tar' filter does not bound link targets drengir1 Sep 23, 2026 https://github.com/python/cpython/pull/158038/commits/8bfc40580056f5a467e953f933a23b26268e6ceb
Clear filters https://github.com/python/cpython/pull/158038/files
Please reload this pagehttps://github.com/python/cpython/pull/158038/files
Please reload this pagehttps://github.com/python/cpython/pull/158038/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L610
Doc/library/tarfile.rsthttps://github.com/python/cpython/pull/158038/files#diff-130eff7d2ababf1fb3d3b179e70d48e4c3ad8f7dc32d15a5267fde82a664928c
View file https://github.com/drengir1/cpython/blob/8bfc40580056f5a467e953f933a23b26268e6ceb/Doc/library/tarfile.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/158038/{{ revealButtonHref }}
https://github.com/python/cpython/pull/158038/files#diff-130eff7d2ababf1fb3d3b179e70d48e4c3ad8f7dc32d15a5267fde82a664928c
https://github.com/python/cpython/pull/158038/files#diff-130eff7d2ababf1fb3d3b179e70d48e4c3ad8f7dc32d15a5267fde82a664928c
https://github.com/python/cpython/pull/158038/files#diff-130eff7d2ababf1fb3d3b179e70d48e4c3ad8f7dc32d15a5267fde82a664928c
https://github.com/python/cpython/pull/158038/files#diff-130eff7d2ababf1fb3d3b179e70d48e4c3ad8f7dc32d15a5267fde82a664928c
Please reload this pagehttps://github.com/python/cpython/pull/158038/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.