René's URL Explorer Experiment


Title: gh-119048: Use shutil._use_fd_functions in test_rmtree_uses_safe_fd_v… by vasiliyk · Pull Request #157912 · python/cpython · GitHub

Open Graph Title: gh-119048: Use shutil._use_fd_functions in test_rmtree_uses_safe_fd_v… by vasiliyk · Pull Request #157912 · python/cpython

X Title: gh-119048: Use shutil._use_fd_functions in test_rmtree_uses_safe_fd_v… by vasiliyk · Pull Request #157912 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The test recomputed the fd-functions flag with os.listdir in os.supports_fd, but shutil switched its own check to os.scandir, so the copy in the test went stale. Use shutil._use_fd_functions direct...

X Description: The test recomputed the fd-functions flag with os.listdir in os.supports_fd, but shutil switched its own check to os.scandir, so the copy in the test went stale. Use shutil._use_fd_functions direct...

Opengraph URL: https://github.com/python/cpython/pull/157912

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:ab384e38-02bc-66dd-f278-b48b43019fa4
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idE7B8:299992:1B812CD:243DCE1:6B021CBA
html-safe-nonced012a4007f4707ca7821b05db0aeeb26b72da78a010f7dd91a36bd02c5f62041
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0I4OjI5OTk5MjoxQjgxMkNEOjI0M0RDRTE6NkIwMjFDQkEiLCJ2aXNpdG9yX2lkIjoiMjI5NTAzODI2OTE1NjYyOTY5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1a185b55ee8503a875c69b79c0139079b2043e43e80220fc34dfad540c62fd4b
hovercard-subject-tagpull_request:4592199395
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157912/checks
twitter:imagehttps://opengraph.githubassets.com/d00dd8bb55fd25534ac2b12e4d17c797407e0984688a915e8033b15dbac9aa99/python/cpython/pull/157912
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d00dd8bb55fd25534ac2b12e4d17c797407e0984688a915e8033b15dbac9aa99/python/cpython/pull/157912
og:image:altThe test recomputed the fd-functions flag with os.listdir in os.supports_fd, but shutil switched its own check to os.scandir, so the copy in the test went stale. Use shutil._use_fd_functions direct...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevasiliyk
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/157912/checks#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157912%2Fchecks
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157912%2Fchecks
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157912/checks
Reloadhttps://github.com/python/cpython/pull/157912/checks
Reloadhttps://github.com/python/cpython/pull/157912/checks
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
vasiliyk:gh-119048-shutilhttps://github.com/vasiliyk/cpython/tree/gh-119048-shutil
Conversationhttps://github.com/python/cpython/pull/157912
Commits1 (1)https://github.com/python/cpython/pull/157912/commits
Checkshttps://github.com/python/cpython/pull/157912/checks
Files changedhttps://github.com/python/cpython/pull/157912/files
gh-119048: Use shutil._use_fd_functions in test_rmtree_uses_safe_fd_v…https://github.com/python/cpython/pull/157912/checks#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
vasiliyk:gh-119048-shutilhttps://github.com/vasiliyk/cpython/tree/gh-119048-shutil
Please reload this pagehttps://github.com/python/cpython/pull/157912/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157912%2Fchecks
Check labels on: pull_request https://github.com/python/cpython/actions/runs/35607691209
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/35607691209/job/106358713641?pr=157912
Unresolved review https://github.com/python/cpython/actions/runs/35607691209/job/106358713813?pr=157912
Lint on: pull_request https://github.com/python/cpython/actions/runs/35607691563
lint https://github.com/python/cpython/actions/runs/35607691563/job/106358716319?pr=157912
Tests on: pull_request https://github.com/python/cpython/actions/runs/35607692564
Change detection / Create context from changed files https://github.com/python/cpython/actions/runs/35607692564/job/106358719890?pr=157912
Docs https://github.com/python/cpython/actions/runs/35607692564/job/106358827900?pr=157912
Check if Autoconf files are up to date https://github.com/python/cpython/actions/runs/35607692564/job/106358826042?pr=157912
Check if generated files are up to date https://github.com/python/cpython/actions/runs/35607692564/job/106358825891?pr=157912
C API Docs / Check if all C APIs are documented https://github.com/python/cpython/actions/runs/35607692564/job/106358827019?pr=157912
Windows / Build and test (x64, switch-case) https://github.com/python/cpython/actions/runs/35607692564/job/106358828588?pr=157912
Windows (free-threading) / Build and test (x64, switch-case) https://github.com/python/cpython/actions/runs/35607692564/job/106358828571?pr=157912
Windows / Build and test (Win32, switch-case) https://github.com/python/cpython/actions/runs/35607692564/job/106358828740?pr=157912
Windows / Build and test (arm64, switch-case) https://github.com/python/cpython/actions/runs/35607692564/job/106358828446?pr=157912
Windows (free-threading) / Build and test (arm64, switch-case) https://github.com/python/cpython/actions/runs/35607692564/job/106358828508?pr=157912
Windows / Build and test (x64, tail-call) https://github.com/python/cpython/actions/runs/35607692564/job/106358828631?pr=157912
Windows (free-threading) / Build and test (x64, tail-call) https://github.com/python/cpython/actions/runs/35607692564/job/106358828572?pr=157912
macOS / build and test (macos-26) https://github.com/python/cpython/actions/runs/35607692564/job/106358827685?pr=157912
macOS (free-threading) / build and test (macos-26) https://github.com/python/cpython/actions/runs/35607692564/job/106358827907?pr=157912
macOS / build and test (macos-26-intel) https://github.com/python/cpython/actions/runs/35607692564/job/106358828074?pr=157912
Ubuntu / build and test (ubuntu-26.04) https://github.com/python/cpython/actions/runs/35607692564/job/106358828129?pr=157912
Ubuntu / build and test (ubuntu-26.04-arm) https://github.com/python/cpython/actions/runs/35607692564/job/106358828331?pr=157912
Ubuntu (free-threading) / build and test (ubuntu-26.04) https://github.com/python/cpython/actions/runs/35607692564/job/106358828041?pr=157912
Ubuntu (free-threading) / build and test (ubuntu-26.04-arm) https://github.com/python/cpython/actions/runs/35607692564/job/106358828054?pr=157912
Ubuntu (bolt) / build and test (ubuntu-26.04) https://github.com/python/cpython/actions/runs/35607692564/job/106358828245?pr=157912
Ubuntu (installed) / build, install and test https://github.com/python/cpython/actions/runs/35607692564/job/106358827151?pr=157912
Ubuntu SSL tests (ubuntu-26.04, openssl, 1.1.1w) https://github.com/python/cpython/actions/runs/35607692564/job/106358826538?pr=157912
Ubuntu SSL tests (ubuntu-26.04, openssl, 3.0.22) https://github.com/python/cpython/actions/runs/35607692564/job/106358826430?pr=157912
Ubuntu SSL tests (ubuntu-26.04, openssl, 3.4.7) https://github.com/python/cpython/actions/runs/35607692564/job/106358826675?pr=157912
Ubuntu SSL tests (ubuntu-26.04, openssl, 3.5.8) https://github.com/python/cpython/actions/runs/35607692564/job/106358826415?pr=157912
Ubuntu SSL tests (ubuntu-26.04, openssl, 3.6.4) https://github.com/python/cpython/actions/runs/35607692564/job/106358826459?pr=157912
Ubuntu SSL tests (ubuntu-26.04, openssl, 4.0.2) https://github.com/python/cpython/actions/runs/35607692564/job/106358826444?pr=157912
Ubuntu SSL tests (ubuntu-26.04, aws-lc, 5.5.0) https://github.com/python/cpython/actions/runs/35607692564/job/106358826520?pr=157912
Android (aarch64) https://github.com/python/cpython/actions/runs/35607692564/job/106358826502?pr=157912
Android (x86_64) https://github.com/python/cpython/actions/runs/35607692564/job/106358826489?pr=157912
iOS https://github.com/python/cpython/actions/runs/35607692564/job/106358826316?pr=157912
Emscripten / build and test https://github.com/python/cpython/actions/runs/35607692564/job/106358827509?pr=157912
WASI / build and test https://github.com/python/cpython/actions/runs/35607692564/job/106358827646?pr=157912
Hypothesis tests on Ubuntu https://github.com/python/cpython/actions/runs/35607692564/job/106358826372?pr=157912
Lazy imports enabled / Run Tests with lazy_imports=all https://github.com/python/cpython/actions/runs/35607692564/job/106358827665?pr=157912
Address sanitizer (ubuntu-26.04) https://github.com/python/cpython/actions/runs/35607692564/job/106358826427?pr=157912
Sanitizers / TSan https://github.com/python/cpython/actions/runs/35607692564/job/106358829009?pr=157912
Sanitizers / TSan (free-threading) https://github.com/python/cpython/actions/runs/35607692564/job/106358829147?pr=157912
Sanitizers / UBSan https://github.com/python/cpython/actions/runs/35607692564/job/106358829022?pr=157912
Cross build Linux https://github.com/python/cpython/actions/runs/35607692564/job/106358826616?pr=157912
CIFuzz${{ '' }} https://github.com/python/cpython/actions/runs/35607692564/job/106358829110?pr=157912
All required checks pass https://github.com/python/cpython/actions/runs/35607692564/job/106359946338?pr=157912
Check labels on: pull_request https://github.com/python/cpython/actions/runs/35607705017
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/35607705017/job/106358758303?pr=157912
Unresolved review https://github.com/python/cpython/actions/runs/35607705017/job/106358758100?pr=157912
Check labels on: pull_request https://github.com/python/cpython/actions/runs/35607710614
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/35607710614/job/106358777485?pr=157912
Unresolved review https://github.com/python/cpython/actions/runs/35607710614/job/106358777071?pr=157912
Lint on: pull_request https://github.com/python/cpython/actions/runs/35631528358
lint https://github.com/python/cpython/actions/runs/35631528358/job/106438622188?pr=157912
Check labels on: pull_request https://github.com/python/cpython/actions/runs/35631528443
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/35631528443/job/106438622087?pr=157912
Unresolved review https://github.com/python/cpython/actions/runs/35631528443/job/106438621806?pr=157912
Tests on: pull_request https://github.com/python/cpython/actions/runs/35631528952
Change detection / Create context from changed files https://github.com/python/cpython/actions/runs/35631528952/job/106439246354?pr=157912
Docs https://github.com/python/cpython/actions/runs/35631528952/job/106439363807?pr=157912
Check if Autoconf files are up to date https://github.com/python/cpython/actions/runs/35631528952/job/106439362590?pr=157912
Check if generated files are up to date https://github.com/python/cpython/actions/runs/35631528952/job/106439362550?pr=157912
C API Docs / Check if all C APIs are documented https://github.com/python/cpython/actions/runs/35631528952/job/106439363384?pr=157912
Windows / Build and test (x64, switch-case) https://github.com/python/cpython/actions/runs/35631528952/job/106439364362?pr=157912
Windows (free-threading) / Build and test (x64, switch-case) https://github.com/python/cpython/actions/runs/35631528952/job/106439364535?pr=157912
Windows / Build and test (Win32, switch-case) https://github.com/python/cpython/actions/runs/35631528952/job/106439364396?pr=157912
Windows / Build and test (arm64, switch-case) https://github.com/python/cpython/actions/runs/35631528952/job/106439364470?pr=157912
Windows (free-threading) / Build and test (arm64, switch-case) https://github.com/python/cpython/actions/runs/35631528952/job/106439364534?pr=157912
Windows / Build and test (x64, tail-call) https://github.com/python/cpython/actions/runs/35631528952/job/106439364458?pr=157912
Windows (free-threading) / Build and test (x64, tail-call) https://github.com/python/cpython/actions/runs/35631528952/job/106439364402?pr=157912
macOS / build and test (macos-26) https://github.com/python/cpython/actions/runs/35631528952/job/106439364770?pr=157912
macOS (free-threading) / build and test (macos-26) https://github.com/python/cpython/actions/runs/35631528952/job/106439364598?pr=157912
macOS / build and test (macos-26-intel) https://github.com/python/cpython/actions/runs/35631528952/job/106439364824?pr=157912
Ubuntu / build and test (ubuntu-26.04) https://github.com/python/cpython/actions/runs/35631528952/job/106439364828?pr=157912
Ubuntu / build and test (ubuntu-26.04-arm) https://github.com/python/cpython/actions/runs/35631528952/job/106439364760?pr=157912
Ubuntu (free-threading) / build and test (ubuntu-26.04) https://github.com/python/cpython/actions/runs/35631528952/job/106439365167?pr=157912
Ubuntu (free-threading) / build and test (ubuntu-26.04-arm) https://github.com/python/cpython/actions/runs/35631528952/job/106439364798?pr=157912
Ubuntu (bolt) / build and test (ubuntu-26.04) https://github.com/python/cpython/actions/runs/35631528952/job/106439364924?pr=157912
Ubuntu (installed) / build, install and test https://github.com/python/cpython/actions/runs/35631528952/job/106439364163?pr=157912
Ubuntu SSL tests (ubuntu-26.04, openssl, 1.1.1w) https://github.com/python/cpython/actions/runs/35631528952/job/106439363380?pr=157912
Ubuntu SSL tests (ubuntu-26.04, openssl, 3.0.22) https://github.com/python/cpython/actions/runs/35631528952/job/106439363271?pr=157912
Ubuntu SSL tests (ubuntu-26.04, openssl, 3.4.7) https://github.com/python/cpython/actions/runs/35631528952/job/106439363318?pr=157912
Ubuntu SSL tests (ubuntu-26.04, openssl, 3.5.8) https://github.com/python/cpython/actions/runs/35631528952/job/106439363354?pr=157912
Ubuntu SSL tests (ubuntu-26.04, openssl, 3.6.4) https://github.com/python/cpython/actions/runs/35631528952/job/106439363341?pr=157912
Ubuntu SSL tests (ubuntu-26.04, openssl, 4.0.2) https://github.com/python/cpython/actions/runs/35631528952/job/106439363310?pr=157912
Ubuntu SSL tests (ubuntu-26.04, aws-lc, 5.5.0) https://github.com/python/cpython/actions/runs/35631528952/job/106439363386?pr=157912
Android (aarch64) https://github.com/python/cpython/actions/runs/35631528952/job/106439363381?pr=157912
Android (x86_64) https://github.com/python/cpython/actions/runs/35631528952/job/106439363350?pr=157912
iOS https://github.com/python/cpython/actions/runs/35631528952/job/106439363299?pr=157912
Emscripten / build and test https://github.com/python/cpython/actions/runs/35631528952/job/106439363884?pr=157912
WASI / build and test https://github.com/python/cpython/actions/runs/35631528952/job/106439363908?pr=157912
Hypothesis tests on Ubuntu https://github.com/python/cpython/actions/runs/35631528952/job/106439363122?pr=157912
Lazy imports enabled / Run Tests with lazy_imports=all https://github.com/python/cpython/actions/runs/35631528952/job/106439363907?pr=157912
Address sanitizer (ubuntu-26.04) https://github.com/python/cpython/actions/runs/35631528952/job/106439363106?pr=157912
Sanitizers / TSan https://github.com/python/cpython/actions/runs/35631528952/job/106439364683?pr=157912
Sanitizers / TSan (free-threading) https://github.com/python/cpython/actions/runs/35631528952/job/106439364865?pr=157912
Sanitizers / UBSan https://github.com/python/cpython/actions/runs/35631528952/job/106439364877?pr=157912
Cross build Linux https://github.com/python/cpython/actions/runs/35631528952/job/106439363054?pr=157912
CIFuzz${{ '' }} https://github.com/python/cpython/actions/runs/35631528952/job/106439364449?pr=157912
All required checks pass https://github.com/python/cpython/actions/runs/35631528952/job/106450164752?pr=157912
Check labels on: pull_request https://github.com/python/cpython/actions/runs/35723378944
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/35723378944/job/106731181449?pr=157912
Unresolved review https://github.com/python/cpython/actions/runs/35723378944/job/106731181907?pr=157912
Check labels on: pull_request https://github.com/python/cpython/actions/runs/35723546849
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/35723546849/job/106731723922?pr=157912
Unresolved review https://github.com/python/cpython/actions/runs/35723546849/job/106731723758?pr=157912
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.