René's URL Explorer Experiment


Title: gh-119048: Use shutil._use_fd_functions in test_rmtree_uses_safe_fd_v… by vasiliyk · Pull Request #157912 · python/cpython · GitHub

Open Graph Title: gh-119048: Use shutil._use_fd_functions in test_rmtree_uses_safe_fd_v… by vasiliyk · Pull Request #157912 · python/cpython

X Title: gh-119048: Use shutil._use_fd_functions in test_rmtree_uses_safe_fd_v… by vasiliyk · Pull Request #157912 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The test recomputed the fd-functions flag with os.listdir in os.supports_fd, but shutil switched its own check to os.scandir, so the copy in the test went stale. Use shutil._use_fd_functions direct...

X Description: The test recomputed the fd-functions flag with os.listdir in os.supports_fd, but shutil switched its own check to os.scandir, so the copy in the test went stale. Use shutil._use_fd_functions direct...

Opengraph URL: https://github.com/python/cpython/pull/157912

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1c1c5dc1-046d-f720-293f-09745c0279d6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCBE2:20AA01:401562D:51524AE:6B0205FD
html-safe-nonce71e2d421938649d6a380dae19c82c35219248acc282afdbfa72b8ca0b573b9a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkUyOjIwQUEwMTo0MDE1NjJEOjUxNTI0QUU6NkIwMjA1RkQiLCJ2aXNpdG9yX2lkIjoiNTMzMDc5MjYzOTQwNTA5ODQ5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac78b89e4394ccd6c5aa1d72785aed8f1c3d7e0abd1a20b79cbcc6d7ae2401d10b
hovercard-subject-tagpull_request:4592199395
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/157912/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d00dd8bb55fd25534ac2b12e4d17c797407e0984688a915e8033b15dbac9aa99/python/cpython/pull/157912
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d00dd8bb55fd25534ac2b12e4d17c797407e0984688a915e8033b15dbac9aa99/python/cpython/pull/157912
og:image:altThe test recomputed the fd-functions flag with os.listdir in os.supports_fd, but shutil switched its own check to os.scandir, so the copy in the test went stale. Use shutil._use_fd_functions direct...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevasiliyk
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/157912#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157912
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157912
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157912
Reloadhttps://github.com/python/cpython/pull/157912
Reloadhttps://github.com/python/cpython/pull/157912
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
vasiliyk:gh-119048-shutilhttps://github.com/vasiliyk/cpython/tree/gh-119048-shutil
Conversationhttps://github.com/python/cpython/pull/157912
Commits1 (1)https://github.com/python/cpython/pull/157912/commits
Checkshttps://github.com/python/cpython/pull/157912/checks
Files changedhttps://github.com/python/cpython/pull/157912/files
gh-119048: Use shutil._use_fd_functions in test_rmtree_uses_safe_fd_v…https://github.com/python/cpython/pull/157912#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
vasiliyk:gh-119048-shutilhttps://github.com/vasiliyk/cpython/tree/gh-119048-shutil
https://github.com/vasiliyk
vasiliykhttps://github.com/vasiliyk
Sep 21, 2026https://github.com/python/cpython/pull/157912#issue-5527832409
Please reload this pagehttps://github.com/python/cpython/pull/157912
@encukouhttps://github.com/encukou
Difference in _use_fd_functions in shutil.py and test_shutil.py #119048https://github.com/python/cpython/issues/119048
Please reload this pagehttps://github.com/python/cpython/pull/157912
https://github.com/vasiliyk
pythongh-119048https://github.com/python/cpython/issues/119048
: Use shutil._use_fd_functions in test_rmtree_uses_saf…https://github.com/python/cpython/pull/157912/commits/ddd72aac2945005763e2ff31eaf3fa0f5380c73f
ddd72aahttps://github.com/python/cpython/pull/157912/commits/ddd72aac2945005763e2ff31eaf3fa0f5380c73f
https://github.com/vasiliyk
vasiliykhttps://github.com/vasiliyk
giampaolohttps://github.com/giampaolo
code ownerhttps://github.com/python/cpython/blob/a6ad448237755cfd2d52d6002f7c38f5f67b5ab2/.github/CODEOWNERS#L566
September 21, 2026 13:45https://github.com/python/cpython/pull/157912#event-31532506481
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Sep 21, 2026https://github.com/python/cpython/pull/157912#event-31532515228
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 21, 2026https://github.com/python/cpython/pull/157912#issuecomment-5761513123
require a NEWS entryhttps://devguide.python.org/getting-started/pull-request-lifecycle/#news-entry
blurb_ithttps://blurb-it.herokuapp.com
blurbhttps://pypi.org/project/blurb/
Please reload this pagehttps://github.com/python/cpython/pull/157912
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 21, 2026https://github.com/python/cpython/pull/157912#event-31532518494
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 21, 2026 https://github.com/python/cpython/pull/157912#ref-issue-2296152049
Difference in _use_fd_functions in shutil.py and test_shutil.py #119048 https://github.com/python/cpython/issues/119048
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Sep 21, 2026 https://github.com/python/cpython/pull/157912#pullrequestreview-5268503615
View reviewed changes https://github.com/python/cpython/pull/157912/files
Misc/NEWS.d/next/Tests/2026-09-21-09-48-03.gh-issue-119048.HxrBfO.rsthttps://github.com/python/cpython/pull/157912/files#diff-f64db757ce42d8b5adacf06da6c972f7ea3a137be6649943e6d04ba7ae7bcb57
Please reload this pagehttps://github.com/python/cpython/pull/157912
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
encukouhttps://github.com/encukou
September 21, 2026 15:29https://github.com/python/cpython/pull/157912#event-31539518562
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 21, 2026https://github.com/python/cpython/pull/157912#issuecomment-5764552290
require a NEWS entryhttps://devguide.python.org/getting-started/pull-request-lifecycle/#news-entry
blurb_ithttps://blurb-it.herokuapp.com
blurbhttps://pypi.org/project/blurb/
Please reload this pagehttps://github.com/python/cpython/pull/157912
https://github.com/vasiliyk
vasiliykhttps://github.com/vasiliyk
force-pushedhttps://github.com/python/cpython/compare/64d168b1cbcdbbfeb1e6eb4f8b37cdf469849380..ddd72aac2945005763e2ff31eaf3fa0f5380c73f
64d168bhttps://github.com/python/cpython/commit/64d168b1cbcdbbfeb1e6eb4f8b37cdf469849380
ddd72aahttps://github.com/python/cpython/commit/ddd72aac2945005763e2ff31eaf3fa0f5380c73f
Compare https://github.com/python/cpython/compare/64d168b1cbcdbbfeb1e6eb4f8b37cdf469849380..ddd72aac2945005763e2ff31eaf3fa0f5380c73f
September 21, 2026 17:21https://github.com/python/cpython/pull/157912#event-31546562285
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 21, 2026https://github.com/python/cpython/pull/157912#issuecomment-5764623704
require a NEWS entryhttps://devguide.python.org/getting-started/pull-request-lifecycle/#news-entry
blurb_ithttps://blurb-it.herokuapp.com
blurbhttps://pypi.org/project/blurb/
Please reload this pagehttps://github.com/python/cpython/pull/157912
https://github.com/encukou
encukouhttps://github.com/encukou
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Sep 22, 2026https://github.com/python/cpython/pull/157912#event-31596395737
https://github.com/encukou
encukouhttps://github.com/encukou
9777e8ahttps://github.com/python/cpython/commit/9777e8a67776ce225bfa594b4aedae0f18d2e3be
Sep 22, 2026https://github.com/python/cpython/pull/157912#event-31596496338
Please reload this pagehttps://github.com/python/cpython/pull/157912
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 22, 2026https://github.com/python/cpython/pull/157912#event-31596499606
https://github.com/encukou
encukouhttps://github.com/encukou
Sep 22, 2026https://github.com/python/cpython/pull/157912#issuecomment-5775922872
avoid force-pushinghttps://devguide.python.org/getting-started/quick-reference/#don-t-force-push
Please reload this pagehttps://github.com/python/cpython/pull/157912
https://github.com/aisk
aiskhttps://github.com/aisk
Oct 14, 2026 https://github.com/python/cpython/pull/157912#ref-pullrequest-5829600526
gh-159293: Restore the recursion limit after the free-threading race test #159311 https://github.com/python/cpython/pull/159311
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157912
https://github.com/StanFromIreland
StanFromIreland https://github.com/StanFromIreland
https://github.com/python/cpython/pull/157912/files/64d168b1cbcdbbfeb1e6eb4f8b37cdf469849380
https://github.com/giampaolo
giampaolo https://github.com/giampaolo
https://github.com/encukou
encukou https://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/157912
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/157912
https://github.com/vasiliyk
https://github.com/encukou
https://github.com/StanFromIreland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.