René's URL Explorer Experiment


Title: gh-154060: Fix the `Profile Stats` offsets in the profiling binary format docs and a missing flag by maurycy · Pull Request #157871 · python/cpython · GitHub

Open Graph Title: gh-154060: Fix the `Profile Stats` offsets in the profiling binary format docs and a missing flag by maurycy · Pull Request #157871 · python/cpython

X Title: gh-154060: Fix the `Profile Stats` offsets in the profiling binary format docs and a missing flag by maurycy · Pull Request #157871 · python/cpython

Description: The file layout diagram in: https://github.com/python/cpython/blob/a64b7ecba4db5480504a1a83ae6e80c81472fe16/InternalDocs/profiling_binary_format.md#file-layout says that the Profile Stats section is 32 bytes and starts at file_size - 64, while it's 56 bytes and starts at file_size - 88 (56 + 32 = 88). cpython/Modules/_remote_debugging/binary_io.h Lines 122 to 123 in a64b7ec static_assert(PROFILE_STATS_SIZE == 56, "PROFILE_STATS_SIZE must remain 56"); cpython/Modules/_remote_debugging/binary_io.h Lines 91 to 92 in a64b7ec static_assert(FILE_FOOTER_SIZE == 32, "FILE_FOOTER_SIZE must remain 32"); The test: cpython/Lib/test/test_profiling/test_sampling_profiler/test_binary_format.py Lines 1655 to 1660 in a64b7ec with open(bin_path, "rb") as file: data = file.read() stats = data[-88:-32] footer = bytearray(data[-32:]) old_stats = stats[:16] + b"TACHSTAT" + struct.pack("=II", 1, 32) old_data = bytearray(data[:-88] + old_stats + footer) Even the doc itself says 56 bytes later: New files can store measured duration, sampling rate, error rate, and missed sample percentage in an optional 56-byte extension immediately before the footer. Both the diagram and the section is since 7f0ccd6. While we're at it, adding THREAD_STATUS_MAIN_THREAD flag missed from the docs. Hardly newsworthy, hardly testable but I think would be nice to backport to 3.15. https://github.com/python/cpython/pull/154105/changes#diff-43a2fe1b7de3546d9e026fcf3664cdc0c35608385926a09e8038a84598acba30 addresses another issue in the document (Total sample count is now uint64.) Issue: gh-154060

Open Graph Description: The file layout diagram in: https://github.com/python/cpython/blob/a64b7ecba4db5480504a1a83ae6e80c81472fe16/InternalDocs/profiling_binary_format.md#file-layout says that the Profile Stats section i...

X Description: The file layout diagram in: https://github.com/python/cpython/blob/a64b7ecba4db5480504a1a83ae6e80c81472fe16/InternalDocs/profiling_binary_format.md#file-layout says that the Profile Stats section i...

Opengraph URL: https://github.com/python/cpython/pull/157871

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bd7b6e48-de67-16e8-7ee0-a1e672e1a342
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC12:148EE1:CDD8CB:103171F:6B022D03
html-safe-noncea2dea99e4707602feca2c06cc7b223b1462ce9bc65bd0d0fb6f846b75ebe4b3d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzEyOjE0OEVFMTpDREQ4Q0I6MTAzMTcxRjo2QjAyMkQwMyIsInZpc2l0b3JfaWQiOiIxMTQ0MDE4MjE1MjkxMjAyODIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2730a42883cbc5935edd07f3d1ad7395be06ab9f30f1f922dcd13c24e0bf4749
hovercard-subject-tagpull_request:4585745081
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157871/files
twitter:imagehttps://avatars.githubusercontent.com/u/5383?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5383?s=400&v=4
og:image:altThe file layout diagram in: https://github.com/python/cpython/blob/a64b7ecba4db5480504a1a83ae6e80c81472fe16/InternalDocs/profiling_binary_format.md#file-layout says that the Profile Stats section i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157871/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157871%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157871%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157871/files
Reloadhttps://github.com/python/cpython/pull/157871/files
Reloadhttps://github.com/python/cpython/pull/157871/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
maurycy:tachyon-docs-profiling-formathttps://github.com/maurycy/cpython/tree/tachyon-docs-profiling-format
Conversation 4 https://github.com/python/cpython/pull/157871
Commits 5 https://github.com/python/cpython/pull/157871/commits
Checks 35 https://github.com/python/cpython/pull/157871/checks
Files changed 1 https://github.com/python/cpython/pull/157871/files
gh-154060: Fix the Profile Stats offsets in the profiling binary format docs and a missing flag https://github.com/python/cpython/pull/157871/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/157871/files
78668ca correct profile stats size and paddings maurycy Sep 20, 2026 https://github.com/python/cpython/pull/157871/commits/78668cada3c6d3f17ccd7fd7dac3134febb921d3
237418d missing flag maurycy Sep 20, 2026 https://github.com/python/cpython/pull/157871/commits/237418d0345034be45f0a6f80bcf962f90fc4633
88cf119 Merge branch 'main' into tachyon-docs-profiling-format maurycy Oct 5, 2026 https://github.com/python/cpython/pull/157871/commits/88cf119d32c83b59f9163ecb59698910b2ccd184
fcae891 Merge remote-tracking branch 'upstream/main' into tachyon-land-157871 pablogsal Oct 5, 2026 https://github.com/python/cpython/pull/157871/commits/fcae89133d05e3677e66b41671f3169c063ecf55
8a48a1d gh-154060: Clarify the main-thread status flag pablogsal Oct 5, 2026 https://github.com/python/cpython/pull/157871/commits/8a48a1dcd4fbc430bc65d58b112c9bcae98ae294
Clear filters https://github.com/python/cpython/pull/157871/files
Please reload this pagehttps://github.com/python/cpython/pull/157871/files
Please reload this pagehttps://github.com/python/cpython/pull/157871/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L100
InternalDocs/profiling_binary_format.mdhttps://github.com/python/cpython/pull/157871/files#diff-43a2fe1b7de3546d9e026fcf3664cdc0c35608385926a09e8038a84598acba30
View file https://github.com/maurycy/cpython/blob/8a48a1dcd4fbc430bc65d58b112c9bcae98ae294/InternalDocs/profiling_binary_format.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157871/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157871/files#diff-43a2fe1b7de3546d9e026fcf3664cdc0c35608385926a09e8038a84598acba30
https://github.com/python/cpython/pull/157871/files#diff-43a2fe1b7de3546d9e026fcf3664cdc0c35608385926a09e8038a84598acba30
https://github.com/python/cpython/pull/157871/files#diff-43a2fe1b7de3546d9e026fcf3664cdc0c35608385926a09e8038a84598acba30
https://github.com/python/cpython/pull/157871/files#diff-43a2fe1b7de3546d9e026fcf3664cdc0c35608385926a09e8038a84598acba30
Please reload this pagehttps://github.com/python/cpython/pull/157871/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.