René's URL Explorer Experiment


Title: gh-157605: Accept empty native-thread stacks when sampling by pablogsal · Pull Request #157817 · python/cpython · GitHub

Open Graph Title: gh-157605: Accept empty native-thread stacks when sampling by pablogsal · Pull Request #157817 · python/cpython

X Title: gh-157605: Accept empty native-thread stacks when sampling by pablogsal · Pull Request #157817 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Issue: profiling.sampling incorrectly handles base_frame and native frame as the first frame #157605

X Description: Issue: profiling.sampling incorrectly handles base_frame and native frame as the first frame #157605

Opengraph URL: https://github.com/python/cpython/pull/157817

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:05005d9d-e0dd-7e11-73e4-2e9713ddfba2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6EE:8AE25:18019A1:1FC84FC:6B020DFF
html-safe-nonceca825dd66d223c75fde885653adf5846c78027980f816997b0cc14bb275ea6b6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkVFOjhBRTI1OjE4MDE5QTE6MUZDODRGQzo2QjAyMERGRiIsInZpc2l0b3JfaWQiOiIzNjg0MDAxMDMxNjM4ODc5NzQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb98413970f56dc16a7b34d3fd0753597e1d77ca1850fbf75868fd2c209c80a52
hovercard-subject-tagpull_request:4579594972
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/157817/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3e7a2552a94dc327c7442e728081d0f19f7f04cf99183fb182f67fbf82257eb4/python/cpython/pull/157817
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3e7a2552a94dc327c7442e728081d0f19f7f04cf99183fb182f67fbf82257eb4/python/cpython/pull/157817
og:image:altIssue: profiling.sampling incorrectly handles base_frame and native frame as the first frame #157605
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepablogsal
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/157817#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157817
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157817
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157817
Reloadhttps://github.com/python/cpython/pull/157817
Reloadhttps://github.com/python/cpython/pull/157817
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:fix-157605-empty-stackhttps://github.com/pablogsal/cpython/tree/fix-157605-empty-stack
Conversationhttps://github.com/python/cpython/pull/157817
Commits2 (2)https://github.com/python/cpython/pull/157817/commits
Checkshttps://github.com/python/cpython/pull/157817/checks
Files changedhttps://github.com/python/cpython/pull/157817/files
gh-157605: Accept empty native-thread stacks when samplinghttps://github.com/python/cpython/pull/157817#top
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:fix-157605-empty-stackhttps://github.com/pablogsal/cpython/tree/fix-157605-empty-stack
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Sep 19, 2026https://github.com/python/cpython/pull/157817#issue-5512430849
Please reload this pagehttps://github.com/python/cpython/pull/157817
profiling.sampling incorrectly handles base_frame and native frame as the first frame #157605https://github.com/python/cpython/issues/157605
Please reload this pagehttps://github.com/python/cpython/pull/157817
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 19, 2026 https://github.com/python/cpython/pull/157817#ref-issue-5469752374
profiling.sampling incorrectly handles base_frame and native frame as the first frame #157605 https://github.com/python/cpython/issues/157605
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 19, 2026https://github.com/python/cpython/pull/157817#event-31454417186
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
force-pushedhttps://github.com/python/cpython/compare/d8f78f558742f55bebf2cbe9cb54be4bac252c35..2c982a227e1afd157fd6503e8a9175235a92be7d
d8f78f5https://github.com/python/cpython/commit/d8f78f558742f55bebf2cbe9cb54be4bac252c35
2c982a2https://github.com/python/cpython/commit/2c982a227e1afd157fd6503e8a9175235a92be7d
Compare https://github.com/python/cpython/compare/d8f78f558742f55bebf2cbe9cb54be4bac252c35..2c982a227e1afd157fd6503e8a9175235a92be7d
September 19, 2026 18:02https://github.com/python/cpython/pull/157817#event-31454590444
https://github.com/liuzhijie-0614
liuzhijie-0614https://github.com/liuzhijie-0614
Sep 21, 2026 https://github.com/python/cpython/pull/157817#pullrequestreview-5268469187
View reviewed changes https://github.com/python/cpython/pull/157817/files
Modules/_remote_debugging/frames.chttps://github.com/python/cpython/pull/157817/files#diff-7d46b926220bc5035fbce1ec940bb27482bcd7683fdcbc1f60b1fd2bb9bf6f41
Please reload this pagehttps://github.com/python/cpython/pull/157817
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
force-pushedhttps://github.com/python/cpython/compare/2c982a227e1afd157fd6503e8a9175235a92be7d..fa197507318948294e1a1c2feb3fe06c2c5e6c00
2c982a2https://github.com/python/cpython/commit/2c982a227e1afd157fd6503e8a9175235a92be7d
fa19750https://github.com/python/cpython/commit/fa197507318948294e1a1c2feb3fe06c2c5e6c00
Compare https://github.com/python/cpython/compare/2c982a227e1afd157fd6503e8a9175235a92be7d..fa197507318948294e1a1c2feb3fe06c2c5e6c00
September 22, 2026 20:08https://github.com/python/cpython/pull/157817#event-31628431918
https://github.com/pablogsal
pythongh-157605https://github.com/python/cpython/issues/157605
: Accept empty native-thread stacks when samplinghttps://github.com/python/cpython/pull/157817/commits/8aec82f55795125937b9c1fa24fb343a2c379ec5
8aec82fhttps://github.com/python/cpython/pull/157817/commits/8aec82f55795125937b9c1fa24fb343a2c379ec5
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
force-pushedhttps://github.com/python/cpython/compare/d26597389c1e5fa48453ec7ea5f70c1f5661d022..6cc82bb8389cef99def5f0762566976fa192e255
d265973https://github.com/python/cpython/commit/d26597389c1e5fa48453ec7ea5f70c1f5661d022
6cc82bbhttps://github.com/python/cpython/commit/6cc82bb8389cef99def5f0762566976fa192e255
Compare https://github.com/python/cpython/compare/d26597389c1e5fa48453ec7ea5f70c1f5661d022..6cc82bb8389cef99def5f0762566976fa192e255
September 24, 2026 22:43https://github.com/python/cpython/pull/157817#event-31795852200
https://github.com/pablogsal
pythongh-157605https://github.com/python/cpython/issues/157605
: Distinguish C frames from cleared Python frameshttps://github.com/python/cpython/pull/157817/commits/e37e929b8347bd0bd5fc7f83f9077d6eb68fd0bc
e37e929https://github.com/python/cpython/pull/157817/commits/e37e929b8347bd0bd5fc7f83f9077d6eb68fd0bc
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
force-pushedhttps://github.com/python/cpython/compare/6cc82bb8389cef99def5f0762566976fa192e255..e37e929b8347bd0bd5fc7f83f9077d6eb68fd0bc
6cc82bbhttps://github.com/python/cpython/commit/6cc82bb8389cef99def5f0762566976fa192e255
e37e929https://github.com/python/cpython/commit/e37e929b8347bd0bd5fc7f83f9077d6eb68fd0bc
Compare https://github.com/python/cpython/compare/6cc82bb8389cef99def5f0762566976fa192e255..e37e929b8347bd0bd5fc7f83f9077d6eb68fd0bc
September 24, 2026 23:27https://github.com/python/cpython/pull/157817#event-31797829977
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
80f9aa0https://github.com/python/cpython/commit/80f9aa0b18d96509eec3950a8db4324d5f6dc3a5
Sep 25, 2026https://github.com/python/cpython/pull/157817#event-31799306741
Please reload this pagehttps://github.com/python/cpython/pull/157817
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
September 25, 2026 00:04https://github.com/python/cpython/pull/157817#event-31799308559
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 25, 2026https://github.com/python/cpython/pull/157817#event-31799309048
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 1, 2026 https://github.com/python/cpython/pull/157817#ref-pullrequest-5665562694
Investigate Windows sampling failures in CPython #158552 pablogsal/cpython#146 https://github.com/pablogsal/cpython/pull/146
https://github.com/NekoAsakura
NekoAsakurahttps://github.com/NekoAsakura
Oct 30, 2026 https://github.com/python/cpython/pull/157817#ref-issue-6125660347
test_popping_python_frame_is_not_native fails randomly on buildbots #160986 https://github.com/python/cpython/issues/160986
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Nov 10, 2026https://github.com/python/cpython/pull/157817#event-35737359196
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 10, 2026https://github.com/python/cpython/pull/157817#issuecomment-6781135619
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/157817
https://github.com/hugovk
hugovkhttps://github.com/hugovk
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Nov 15, 2026https://github.com/python/cpython/pull/157817#event-36183621543
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 20, 2026https://github.com/python/cpython/pull/157817#issuecomment-7040703762
eeafc73https://github.com/python/cpython/commit/eeafc73b70f9cff382390cf9d9548b80ea2cefd5
921de8fhttps://github.com/python/cpython/commit/921de8fa82707b14ddcbf1f2e383c71adb727118
Please reload this pagehttps://github.com/python/cpython/pull/157817
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157817
https://github.com/liuzhijie-0614
liuzhijie-0614 https://github.com/liuzhijie-0614
https://github.com/python/cpython/pull/157817/files/2c982a227e1afd157fd6503e8a9175235a92be7d
Please reload this pagehttps://github.com/python/cpython/pull/157817
Please reload this pagehttps://github.com/python/cpython/pull/157817
https://github.com/pablogsal
https://github.com/vstinner
https://github.com/liuzhijie-0614
https://github.com/hugovk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.