René's URL Explorer Experiment


Title: gh-157468: Validate correct builtins used under JIT by johng · Pull Request #157766 · python/cpython · GitHub

Open Graph Title: gh-157468: Validate correct builtins used under JIT by johng · Pull Request #157766 · python/cpython

X Title: gh-157468: Validate correct builtins used under JIT by johng · Pull Request #157766 · python/cpython

Description: This adds the two checks at tracing and at JIT runtime that the builtin dict is the original interpreter's builtins Issue: gh-157468

Open Graph Description: This adds the two checks at tracing and at JIT runtime that the builtin dict is the original interpreter's builtins Issue: gh-157468

X Description: This adds the two checks at tracing and at JIT runtime that the builtin dict is the original interpreter's builtins Issue: gh-157468

Opengraph URL: https://github.com/python/cpython/pull/157766

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:06830da7-1b3e-ec2e-c4e9-1b2d0d5b95f8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB0DA:24555E:4AC99F:63F081:6AED1774
html-safe-nonce7e4485531ca2502afe82ff785c897700a7e196ef1b410ffc829a830e144a8d4c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMERBOjI0NTU1RTo0QUM5OUY6NjNGMDgxOjZBRUQxNzc0IiwidmlzaXRvcl9pZCI6IjQ5MTI1MjE2MzE0NjU1NDM1NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8612b822f95de631fb5dcd79b2f620f354d467e789b5319eb5aebb313027f023
hovercard-subject-tagpull_request:4572373921
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157766/files
twitter:imagehttps://avatars.githubusercontent.com/u/2687652?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2687652?s=400&v=4
og:image:altThis adds the two checks at tracing and at JIT runtime that the builtin dict is the original interpreter's builtins Issue: gh-157468
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157766/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157766%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157766%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157766/files
Reloadhttps://github.com/python/cpython/pull/157766/files
Reloadhttps://github.com/python/cpython/pull/157766/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.3k (2.3k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
johng:gh-builtit-bughttps://github.com/johng/cpython/tree/gh-builtit-bug
Conversation 28 https://github.com/python/cpython/pull/157766
Commits 14 https://github.com/python/cpython/pull/157766/commits
Checks 84 https://github.com/python/cpython/pull/157766/checks
Files changed https://github.com/python/cpython/pull/157766/files
Please reload this pagehttps://github.com/python/cpython/pull/157766/files
gh-157468: Validate correct builtins used under JIT https://github.com/python/cpython/pull/157766/files#top
Show all changes 14 commits https://github.com/python/cpython/pull/157766/files
313396f Expose two possible builtin JIT gaps johng Sep 18, 2026 https://github.com/python/cpython/pull/157766/commits/313396fa86c2dd4aa08b3972c72ef548f6e19621
b3f104f Add trace and runtime guard for builtin dict johng Sep 18, 2026 https://github.com/python/cpython/pull/157766/commits/b3f104fd08e6f4944f63ea8b2ce3f99a77ff62ab
f77395f Blurb entry johng Sep 18, 2026 https://github.com/python/cpython/pull/157766/commits/f77395f0247445cf6bbcdb908c11855b53ec28da
df1e636 Address PR comments johng Sep 20, 2026 https://github.com/python/cpython/pull/157766/commits/df1e636a1ea13e1284fb309a366eb453191b284b
f828617 Apply batched suggestions from code review johng Sep 21, 2026 https://github.com/python/cpython/pull/157766/commits/f8286174954523d29fbbe75f51d660eb9f624445
290838c Check _GUARD_BUILTINS_IS_CANONICAL once per frame johng Sep 21, 2026 https://github.com/python/cpython/pull/157766/commits/290838c1ad5a10a69807fe3a082d97d6590f5d44
e4f54de Merge branch 'main' into gh-builtit-bug johng Sep 21, 2026 https://github.com/python/cpython/pull/157766/commits/e4f54de237b7305dc8eb57784116fe2c4d48bde8
6dde8ad Merge branch 'main' into gh-builtit-bug johng Sep 22, 2026 https://github.com/python/cpython/pull/157766/commits/6dde8ad9e0c43d6e9702d8ac21136d825245f1c0
1a10677 Apply batched suggestions from code review johng Sep 23, 2026 https://github.com/python/cpython/pull/157766/commits/1a10677b793d341989270871babbbdbe91f29fb9
b63f26c Regenerate optimizer cases johng Sep 23, 2026 https://github.com/python/cpython/pull/157766/commits/b63f26c3cf7579dac4a13e8664202baf4d1517da
73c4314 Merge branch 'main' into gh-builtit-bug johng Sep 26, 2026 https://github.com/python/cpython/pull/157766/commits/73c43142dc7725e3f4e23a7673293d8cfd3dba2d
068a3e2 Add check and fix for globals being folded johng Sep 28, 2026 https://github.com/python/cpython/pull/157766/commits/068a3e262c9830b71d7c94af2927c1b5952041a1
1e64dcb Remove comment for testing johng Sep 28, 2026 https://github.com/python/cpython/pull/157766/commits/1e64dcbb0389e385d08acd00b0c04242a555a8a1
5815651 Add do nothing comment johng Sep 30, 2026 https://github.com/python/cpython/pull/157766/commits/5815651a89421f402ded82989b35614560c956e7
Clear filters https://github.com/python/cpython/pull/157766/files
Please reload this pagehttps://github.com/python/cpython/pull/157766/files
Please reload this pagehttps://github.com/python/cpython/pull/157766/files
pycore_optimizer_types.h https://github.com/python/cpython/pull/157766/files#diff-cd178e6d4ba8f18694ab0771162f51bd0ac2415e8d3ce0d43171b2e8c092bcfa
pycore_uop_ids.h https://github.com/python/cpython/pull/157766/files#diff-2a420e4d0d58009249c0f73f7c822167b053bd51cb213b20179bd2aebfc66ff9
pycore_uop_metadata.h https://github.com/python/cpython/pull/157766/files#diff-55e65a72fa31e9b746e03076d2c74b716c0c1171663f36960b2339fcbfae9bab
test_opt.py https://github.com/python/cpython/pull/157766/files#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
2026-09-18-20-24-43.gh-issue-157468.zVIAva.rst https://github.com/python/cpython/pull/157766/files#diff-62efeb2615f70e48e116a4b8e4ce8fc1d8e745a7660ead0ed6b4f22e97124641
dictobject.c https://github.com/python/cpython/pull/157766/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
bytecodes.c https://github.com/python/cpython/pull/157766/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
executor_cases.c.h https://github.com/python/cpython/pull/157766/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
optimizer_bytecodes.c https://github.com/python/cpython/pull/157766/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
optimizer_cases.c.h https://github.com/python/cpython/pull/157766/files#diff-ed4567b3e67709ec57bf4df91ef058cfcbe00d7da11cd2a75e38241fa1ca99d2
optimizer_symbols.c https://github.com/python/cpython/pull/157766/files#diff-b28c00f0aab70992e604ed7c3e9cb4ca39779f33d5ff2c7777de5a044422f095
Include/internal/pycore_optimizer_types.hhttps://github.com/python/cpython/pull/157766/files#diff-cd178e6d4ba8f18694ab0771162f51bd0ac2415e8d3ce0d43171b2e8c092bcfa
View file https://github.com/johng/cpython/blob/5815651a89421f402ded82989b35614560c956e7/Include/internal/pycore_optimizer_types.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157766/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157766/files#diff-cd178e6d4ba8f18694ab0771162f51bd0ac2415e8d3ce0d43171b2e8c092bcfa
https://github.com/python/cpython/pull/157766/files#diff-cd178e6d4ba8f18694ab0771162f51bd0ac2415e8d3ce0d43171b2e8c092bcfa
Include/internal/pycore_uop_ids.hhttps://github.com/python/cpython/pull/157766/files#diff-2a420e4d0d58009249c0f73f7c822167b053bd51cb213b20179bd2aebfc66ff9
View file https://github.com/johng/cpython/blob/5815651a89421f402ded82989b35614560c956e7/Include/internal/pycore_uop_ids.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/157766/files
Include/internal/pycore_uop_metadata.hhttps://github.com/python/cpython/pull/157766/files#diff-55e65a72fa31e9b746e03076d2c74b716c0c1171663f36960b2339fcbfae9bab
View file https://github.com/johng/cpython/blob/5815651a89421f402ded82989b35614560c956e7/Include/internal/pycore_uop_metadata.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/157766/files
Lib/test/test_capi/test_opt.pyhttps://github.com/python/cpython/pull/157766/files#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
View file https://github.com/johng/cpython/blob/5815651a89421f402ded82989b35614560c956e7/Lib/test/test_capi/test_opt.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157766/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157766/files#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
https://github.com/python/cpython/pull/157766/files#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
https://github.com/python/cpython/pull/157766/files#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
Misc/NEWS.d/next/Core_and_Builtins/2026-09-18-20-24-43.gh-issue-157468.zVIAva.rsthttps://github.com/python/cpython/pull/157766/files#diff-62efeb2615f70e48e116a4b8e4ce8fc1d8e745a7660ead0ed6b4f22e97124641
View file https://github.com/johng/cpython/blob/5815651a89421f402ded82989b35614560c956e7/Misc/NEWS.d/next/Core_and_Builtins/2026-09-18-20-24-43.gh-issue-157468.zVIAva.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157766/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L212
Objects/dictobject.chttps://github.com/python/cpython/pull/157766/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
View file https://github.com/johng/cpython/blob/5815651a89421f402ded82989b35614560c956e7/Objects/dictobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157766/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157766/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/157766/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L222
Python/bytecodes.chttps://github.com/python/cpython/pull/157766/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
View file https://github.com/johng/cpython/blob/5815651a89421f402ded82989b35614560c956e7/Python/bytecodes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157766/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157766/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
https://github.com/python/cpython/pull/157766/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
Python/executor_cases.c.hhttps://github.com/python/cpython/pull/157766/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
View file https://github.com/johng/cpython/blob/5815651a89421f402ded82989b35614560c956e7/Python/executor_cases.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/157766/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L304
Python/optimizer_bytecodes.chttps://github.com/python/cpython/pull/157766/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
View file https://github.com/johng/cpython/blob/5815651a89421f402ded82989b35614560c956e7/Python/optimizer_bytecodes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157766/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157766/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
markshannonhttps://github.com/markshannon
Sep 30, 2026https://github.com/python/cpython/pull/157766/files#r4145488124
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/157766/files
Please reload this pagehttps://github.com/python/cpython/pull/157766/files
https://github.com/python/cpython/pull/157766/files#diff-e5bd2b14b0b10f0f47786e26306d689ed1361c3dc3b11dcc3ea52b8a2422ff64
Python/optimizer_cases.c.hhttps://github.com/python/cpython/pull/157766/files#diff-ed4567b3e67709ec57bf4df91ef058cfcbe00d7da11cd2a75e38241fa1ca99d2
View file https://github.com/johng/cpython/blob/5815651a89421f402ded82989b35614560c956e7/Python/optimizer_cases.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/157766/files
Please reload this pagehttps://github.com/python/cpython/pull/157766/files
Please reload this pagehttps://github.com/python/cpython/pull/157766/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.