René's URL Explorer Experiment


Title: gh-157649: Restore safe C++ refcount macro temporaries by sankalpsthakur · Pull Request #157718 · python/cpython · GitHub

Open Graph Title: gh-157649: Restore safe C++ refcount macro temporaries by sankalpsthakur · Pull Request #157718 · python/cpython

X Title: gh-157649: Restore safe C++ refcount macro temporaries by sankalpsthakur · Pull Request #157718 · python/cpython

Description: Fixes #157649. Use the existing memcpy() implementations of Py_CLEAR, Py_SETREF and Py_XSETREF for C++, as suggested in the issue discussion. decltype() can bind their temporary to an array element or reference, so overwriting the destination decrements the wrong pointer. The C paths are unchanged. The C++ regression exercises all three macros with array elements, references, NULL destinations, single evaluation and concrete object pointers. Py_CLEAR() also runs in the limited-API build. Thanks to Lucas Colley for the report/bisection and Victor Stinner for the fallback approach. Validation Original before/after run, Ubuntu x86-64, GCC/g++ 13.3, debug CPython 3.16 built from 8542958: Test-only C++11 regression fails on unchanged headers with the old-object refcount assertion after Py_SETREF. Fixed test_cppext and test_cext: 14 passed, 1 Windows-only C++14 skip. Covers C++03/C++11, limited API, C99/C11 and strict compiler flags. git diff --check passes. That fork run covered only the extension suites. Subsequently, upstream Tests run 35367131812 completed successfully on head a66a922; lint and label checks also pass. The follow-up commit changes only the requested source comment. No NumPy rebuild is claimed. AI assistance: ChatGPT assisted with implementation and validation. Issue: gh-157649

Open Graph Description: Fixes #157649. Use the existing memcpy() implementations of Py_CLEAR, Py_SETREF and Py_XSETREF for C++, as suggested in the issue discussion. decltype() can bind their temporary to an array element...

X Description: Fixes #157649. Use the existing memcpy() implementations of Py_CLEAR, Py_SETREF and Py_XSETREF for C++, as suggested in the issue discussion. decltype() can bind their temporary to an array element...

Opengraph URL: https://github.com/python/cpython/pull/157718

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dcec112d-0f10-faf6-65d1-ec31b599ef91
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED0E:A70A9:17C6EAC:1F6B282:6B0209A9
html-safe-nonceff5100cd48601cd6a440c7928841a925f8805a694d3790b7b521a04f85651ba1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDBFOkE3MEE5OjE3QzZFQUM6MUY2QjI4Mjo2QjAyMDlBOSIsInZpc2l0b3JfaWQiOiIzOTEyNDMyNzQ0NjA5ODk4NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac467655f09426c43540d6f4f48925bc003b9ca3e5373be0bd75a1204eebb21bd1
hovercard-subject-tagpull_request:4564324160
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157718/files
twitter:imagehttps://avatars.githubusercontent.com/u/31366524?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31366524?s=400&v=4
og:image:altFixes #157649. Use the existing memcpy() implementations of Py_CLEAR, Py_SETREF and Py_XSETREF for C++, as suggested in the issue discussion. decltype() can bind their temporary to an array element...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157718/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157718%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157718%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157718/files
Reloadhttps://github.com/python/cpython/pull/157718/files
Reloadhttps://github.com/python/cpython/pull/157718/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
sankalpsthakurhttps://github.com/sankalpsthakur
python:mainhttps://github.com/python/cpython/tree/main
sankalpsthakur:fix/gh157649-cpp-refcount-lvalueshttps://github.com/sankalpsthakur/cpython/tree/fix/gh157649-cpp-refcount-lvalues
Conversation 11 https://github.com/python/cpython/pull/157718
Commits 2 https://github.com/python/cpython/pull/157718/commits
Checks 51 https://github.com/python/cpython/pull/157718/checks
Files changed 3 https://github.com/python/cpython/pull/157718/files
gh-157649: Restore safe C++ refcount macro temporaries https://github.com/python/cpython/pull/157718/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/157718/files
f7d703b gh-157649: Restore safe C++ refcount macro temporaries sankalpsthakur Sep 18, 2026 https://github.com/python/cpython/pull/157718/commits/f7d703b1b47a0da561d746e0808985c448a43c43
a66a922 gh-157649: name Py_SETREF/Py_XSETREF/Py_CLEAR in regression comment sankalpsthakur Sep 18, 2026 https://github.com/python/cpython/pull/157718/commits/a66a92261e06db56f6bbebae5905738b6e82dcae
Clear filters https://github.com/python/cpython/pull/157718/files
Please reload this pagehttps://github.com/python/cpython/pull/157718/files
Please reload this pagehttps://github.com/python/cpython/pull/157718/files
pyport.h https://github.com/python/cpython/pull/157718/files#diff-4832eab2bfe1a8edc0ca7d7661126bd69d8f4e41916624e3ed48389b6ced6b02
extension.cpp https://github.com/python/cpython/pull/157718/files#diff-308999d62ded63640fccd9e19d49331cc2edfbf95d89e95fcfc5a9c2c02d839e
2026-09-18-00-00-00.gh-issue-157649.CppRef.rst https://github.com/python/cpython/pull/157718/files#diff-95679a70c5ab673b8038102db570215257576cea36d9eca7966aeb3553545610
Include/pyport.hhttps://github.com/python/cpython/pull/157718/files#diff-4832eab2bfe1a8edc0ca7d7661126bd69d8f4e41916624e3ed48389b6ced6b02
View file https://github.com/sankalpsthakur/cpython/blob/a66a92261e06db56f6bbebae5905738b6e82dcae/Include/pyport.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157718/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157718/files#diff-4832eab2bfe1a8edc0ca7d7661126bd69d8f4e41916624e3ed48389b6ced6b02
https://github.com/python/cpython/pull/157718/files#diff-4832eab2bfe1a8edc0ca7d7661126bd69d8f4e41916624e3ed48389b6ced6b02
Lib/test/test_cppext/extension.cpphttps://github.com/python/cpython/pull/157718/files#diff-308999d62ded63640fccd9e19d49331cc2edfbf95d89e95fcfc5a9c2c02d839e
View file https://github.com/sankalpsthakur/cpython/blob/a66a92261e06db56f6bbebae5905738b6e82dcae/Lib/test/test_cppext/extension.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157718/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157718/files#diff-308999d62ded63640fccd9e19d49331cc2edfbf95d89e95fcfc5a9c2c02d839e
https://github.com/python/cpython/pull/157718/files#diff-308999d62ded63640fccd9e19d49331cc2edfbf95d89e95fcfc5a9c2c02d839e
https://github.com/python/cpython/pull/157718/files#diff-308999d62ded63640fccd9e19d49331cc2edfbf95d89e95fcfc5a9c2c02d839e
https://github.com/python/cpython/pull/157718/files#diff-308999d62ded63640fccd9e19d49331cc2edfbf95d89e95fcfc5a9c2c02d839e
Misc/NEWS.d/next/C_API/2026-09-18-00-00-00.gh-issue-157649.CppRef.rsthttps://github.com/python/cpython/pull/157718/files#diff-95679a70c5ab673b8038102db570215257576cea36d9eca7966aeb3553545610
View file https://github.com/sankalpsthakur/cpython/blob/a66a92261e06db56f6bbebae5905738b6e82dcae/Misc/NEWS.d/next/C_API/2026-09-18-00-00-00.gh-issue-157649.CppRef.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157718/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/157718/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.