René's URL Explorer Experiment


Title: gh-157605: Accept empty Python frame stack in sampling frame chain parser by aidaodedjl · Pull Request #157657 · python/cpython · GitHub

Open Graph Title: gh-157605: Accept empty Python frame stack in sampling frame chain parser by aidaodedjl · Pull Request #157657 · python/cpython

X Title: gh-157605: Accept empty Python frame stack in sampling frame chain parser by aidaodedjl · Pull Request #157657 · python/cpython

Description: Description A native thread can retain a Python thread state while waiting in C code with no Python functions executing (e.g. after PyGILState_Ensure() + PyEval_SaveThread()). The frame chain of that thread state holds only the base_frame sentinel. process_frame_chain() treated the resulting NULL first frame as a broken chain, raised RuntimeError: Failed to parse initial frame in chain, and failed the entire sampling call — discarding valid stacks from all other threads. With this change, the unparseable-first-frame error is raised only when the first frame is not the base_frame sentinel. When it is the sentinel, the walk stops and the empty Python stack is accepted, so sampling returns results for the remaining threads. The walk stops at the sentinel, so last_frame_visited still equals base_frame_addr and the complete-stack validation in the frame cache keeps working for the empty-stack case. Reproduction / evidence Pre-fix (Linux, cross-process, issue reproducer): pin=1 (native thread retaining an empty-stack thread state) fails 40/40 samples with RuntimeError: Failed to parse initial frame in chain, with and without frame caching; pin=0 baseline succeeds 20/20. Post-fix (same environment): all four pin x cache_frames combinations succeed 20/20 with the target thread's Python frames visible. Test test_external_inspection.py gains a self-contained regression test (TestEmptyPythonStackSampling): compiles a small C helper at runtime that spawns a native thread retaining a Python thread state with an empty frame stack (loaded via ctypes); asserts same-process sampling succeeds and the target thread's Python frames stay visible, across pin x cache_frames combinations; skips gracefully when no C compiler is configured (including Windows, where CC is not set) and fails loudly if the helper itself fails to compile. On this machine (macOS, 3.16 debug build) the test reproduces the failure before the fix ({'failure': 5}) and passes after (1.1 s). Issue: gh-157605

Open Graph Description: Description A native thread can retain a Python thread state while waiting in C code with no Python functions executing (e.g. after PyGILState_Ensure() + PyEval_SaveThread()). The frame chain of th...

X Description: Description A native thread can retain a Python thread state while waiting in C code with no Python functions executing (e.g. after PyGILState_Ensure() + PyEval_SaveThread()). The frame chain of th...

Opengraph URL: https://github.com/python/cpython/pull/157657

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1c70872a-57c7-8c59-4b55-12e1856171a1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC2E2:22DB35:466850C:59A51F8:6B022F7F
html-safe-nonce20d145c9c249cb633d15ab33e265d178a42f1b7f50295238a3faa9766d6f3fc0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkUyOjIyREIzNTo0NjY4NTBDOjU5QTUxRjg6NkIwMjJGN0YiLCJ2aXNpdG9yX2lkIjoiNTg1Mjc3Mzk3MzUzMTcwMTExOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4f121e092f064aabe41bb59312df0c61bb7876241323e769c16815aff43dd67f
hovercard-subject-tagpull_request:4554744201
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157657/files
twitter:imagehttps://avatars.githubusercontent.com/u/55816803?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55816803?s=400&v=4
og:image:altDescription A native thread can retain a Python thread state while waiting in C code with no Python functions executing (e.g. after PyGILState_Ensure() + PyEval_SaveThread()). The frame chain of th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157657/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157657%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157657%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157657/files
Reloadhttps://github.com/python/cpython/pull/157657/files
Reloadhttps://github.com/python/cpython/pull/157657/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
aidaodedjlhttps://github.com/aidaodedjl
python:mainhttps://github.com/python/cpython/tree/main
aidaodedjl:gh-157605-sampling-empty-native-stackhttps://github.com/aidaodedjl/cpython/tree/gh-157605-sampling-empty-native-stack
Conversation 13 https://github.com/python/cpython/pull/157657
Commits 6 https://github.com/python/cpython/pull/157657/commits
Checks 51 https://github.com/python/cpython/pull/157657/checks
Files changed https://github.com/python/cpython/pull/157657/files
Please reload this pagehttps://github.com/python/cpython/pull/157657/files
gh-157605: Accept empty Python frame stack in sampling frame chain parser https://github.com/python/cpython/pull/157657/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/157657/files
840933b gh-157605: Accept empty Python frame stack in sampling frame chain pa… aidaodedjl Sep 17, 2026 https://github.com/python/cpython/pull/157657/commits/840933b6efaa4086f947496f40e6871a68d1a056
1a923f1 gh-157605: Fix regression test include dirs for out-of-tree builds aidaodedjl Sep 17, 2026 https://github.com/python/cpython/pull/157657/commits/1a923f1bb9c40a0f7853928334b9fd290ae988b1
c39b4bc gh-157605: Handle a native first frame like a mid-chain native frame aidaodedjl Sep 18, 2026 https://github.com/python/cpython/pull/157657/commits/c39b4bcb6a98d454dfa02017c05ff78abdc07e70
ddcd747 gh-157605: Cover native-first frames with a regression test aidaodedjl Sep 18, 2026 https://github.com/python/cpython/pull/157657/commits/ddcd747a48752c80a1390bf2550c5cb28cfefeaa
c3a0016 gh-157605: Discriminate code-less frames by owner field aidaodedjl Sep 19, 2026 https://github.com/python/cpython/pull/157657/commits/c3a001665556332fce5faf44c158a700ddb03621
2c58f57 gh-157605: Skip dropped frames and keep walking the live caller chain aidaodedjl Sep 19, 2026 https://github.com/python/cpython/pull/157657/commits/2c58f5715e89909ecc27863e5c38f083f6d95067
Clear filters https://github.com/python/cpython/pull/157657/files
Please reload this pagehttps://github.com/python/cpython/pull/157657/files
Please reload this pagehttps://github.com/python/cpython/pull/157657/files
test_external_inspection.py https://github.com/python/cpython/pull/157657/files#diff-e23d1425a6f43944cb282709edbeacfa2398f4cd4c109e59dd49366dac46f2d7
2026-09-17-12-28-39.gh-issue-157605.nv7Qz8.rst https://github.com/python/cpython/pull/157657/files#diff-863be2eddcb1332288c71fb252632193f64c6febc23390906188627e7cd5b148
_remote_debugging.h https://github.com/python/cpython/pull/157657/files#diff-a6ce0bef7825b17047f05fdec7aa610bc1d2d2b368e72b6871a79c3b1d2dfaf9
asyncio.c https://github.com/python/cpython/pull/157657/files#diff-d3a9f5049ca6c549a4feb928b6d06a7dbce8486745bb06f6b8254cddce207e32
frames.c https://github.com/python/cpython/pull/157657/files#diff-7d46b926220bc5035fbce1ec940bb27482bcd7683fdcbc1f60b1fd2bb9bf6f41
Please reload this pagehttps://github.com/python/cpython/pull/157657/files
Please reload this pagehttps://github.com/python/cpython/pull/157657/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.