René's URL Explorer Experiment


Title: gh-157614: Fix `lazy import a.b as c` incorrectly binding `a.b.b` by grgalex · Pull Request #157626 · python/cpython · GitHub

Open Graph Title: gh-157614: Fix `lazy import a.b as c` incorrectly binding `a.b.b` by grgalex · Pull Request #157626 · python/cpython

X Title: gh-157614: Fix `lazy import a.b as c` incorrectly binding `a.b.b` by grgalex · Pull Request #157626 · python/cpython

Description: lazy import a.b as c binds c to a.b.b instead of the module a.b when a.b is already in sys.modules and has an attribute named b. Root cause import a.b as c compiles to IMPORT_NAME a.b followed by IMPORT_FROM b. For a lazy import, IMPORT_NAME returns a placeholder with lz_from = "a.b". _PyEval_LazyImportFrom() has a fast path for modules already in sys.modules. It looks up lz_from directly and gets name from that module. In this case that means looking up b on a.b, producing a.b.b, instead of looking up b on the base module a. Fix Compute the base module before the sys.modules fast path and perform the lookup against it. The fast path must also be limited to the last IMPORT_FROM identifiable from the placeholder. Longer dotted names compile to multiple IMPORT_FROM instructions, and resolving an intermediate step would make the rest of the import eager. Eight existing test_lazy_import tests cover this. Two-component imports and from imports remain eligible for the fast path. Test Adds MixedLazyEagerImportTests.test_eager_dotted_import_before_lazy_resolves_to_same_module() alongside the existing single-name test. It creates a package a with a/b.py defining an attribute b, then checks: import a.b as c lazy import a.b as lazy_c assert lazy_c is c The test fails on main because lazy_c resolves to a.b.b and passes with the fix. test_lazy_import, test_import, and test_importlib also pass. Commits Move the lazy import subprocess helpers to LazyImportTestCase so the regression test can reuse them. No behavior change. Fix _PyEval_LazyImportFrom(), with the regression test and NEWS entry. Future Work / Not Addressed If package a itself has an attribute b shadowing submodule a.b, the lazy import can still reify to that attribute rather than the submodule. This is a separate mechanism, already tracked in gh-151208. The same mechanism makes lazy import math.pi as x bind the float where the eager statement raises; gh-155194 fixed the bare lazy import math.pi form only. For names with three or more components, an already-loaded module still resolves on first use rather than at the import statement because later IMPORT_FROM steps cannot tell whether they are the last one. Fixing that would require additional compiler or placeholder information and is only an optimization. Closes gh-157614.

Open Graph Description: lazy import a.b as c binds c to a.b.b instead of the module a.b when a.b is already in sys.modules and has an attribute named b. Root cause import a.b as c compiles to IMPORT_NAME a.b followed by I...

X Description: lazy import a.b as c binds c to a.b.b instead of the module a.b when a.b is already in sys.modules and has an attribute named b. Root cause import a.b as c compiles to IMPORT_NAME a.b followed by I...

Opengraph URL: https://github.com/python/cpython/pull/157626

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f44124ba-4330-bd95-61c4-d95f632c89b7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id883C:25F5AB:3285D8:40610B:6B020A71
html-safe-nonce2f689c7104ef0c0591a03c17eaaba95493853fa6b683622f254699cf5dd2dfe0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODNDOjI1RjVBQjozMjg1RDg6NDA2MTBCOjZCMDIwQTcxIiwidmlzaXRvcl9pZCI6IjMxMTUyODY4NzU2MjQwNDkyNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace89504a9a944e4f4d171b8ddc94c203937ea8070ddf035c894ae2783d30d04e2
hovercard-subject-tagpull_request:4548749704
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157626/files
twitter:imagehttps://avatars.githubusercontent.com/u/62315387?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/62315387?s=400&v=4
og:image:altlazy import a.b as c binds c to a.b.b instead of the module a.b when a.b is already in sys.modules and has an attribute named b. Root cause import a.b as c compiles to IMPORT_NAME a.b followed by I...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157626/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157626%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157626%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157626/files
Reloadhttps://github.com/python/cpython/pull/157626/files
Reloadhttps://github.com/python/cpython/pull/157626/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
grgalexhttps://github.com/grgalex
python:mainhttps://github.com/python/cpython/tree/main
grgalex:fix-issue-157614https://github.com/grgalex/cpython/tree/fix-issue-157614
Conversation 4 https://github.com/python/cpython/pull/157626
Commits 2 https://github.com/python/cpython/pull/157626/commits
Checks 61 https://github.com/python/cpython/pull/157626/checks
Files changed 3 https://github.com/python/cpython/pull/157626/files
gh-157614: Fix lazy import a.b as c incorrectly binding a.b.b https://github.com/python/cpython/pull/157626/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/157626/files
cfba96e gh-157614: Make the lazy import subprocess test helper reusable grgalex Sep 16, 2026 https://github.com/python/cpython/pull/157626/commits/cfba96e4545ba990655a7ecb705b35118695502c
3398871 gh-157614: Fix lazy import a.b as c binding a.b.b instead of the module grgalex Sep 16, 2026 https://github.com/python/cpython/pull/157626/commits/33988718f35c5c2bbe0c85516a221c61bd62c11a
Clear filters https://github.com/python/cpython/pull/157626/files
Please reload this pagehttps://github.com/python/cpython/pull/157626/files
Please reload this pagehttps://github.com/python/cpython/pull/157626/files
__init__.py https://github.com/python/cpython/pull/157626/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
2026-09-16-13-45-00.gh-issue-157614.IPhxHy.rst https://github.com/python/cpython/pull/157626/files#diff-bb6f8d4de6cadd7f0eb3c07bd41c1b6c8657ebe2745d71be084a5de2258c4247
ceval.c https://github.com/python/cpython/pull/157626/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L299
Lib/test/test_lazy_import/__init__.pyhttps://github.com/python/cpython/pull/157626/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
View file https://github.com/python/cpython/blob/33988718f35c5c2bbe0c85516a221c61bd62c11a/Lib/test/test_lazy_import/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157626/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157626/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/python/cpython/pull/157626/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/python/cpython/pull/157626/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/python/cpython/pull/157626/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/python/cpython/pull/157626/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/python/cpython/pull/157626/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
Misc/NEWS.d/next/Core_and_Builtins/2026-09-16-13-45-00.gh-issue-157614.IPhxHy.rsthttps://github.com/python/cpython/pull/157626/files#diff-bb6f8d4de6cadd7f0eb3c07bd41c1b6c8657ebe2745d71be084a5de2258c4247
View file https://github.com/python/cpython/blob/33988718f35c5c2bbe0c85516a221c61bd62c11a/Misc/NEWS.d/next/Core_and_Builtins/2026-09-16-13-45-00.gh-issue-157614.IPhxHy.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157626/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L223
Python/ceval.chttps://github.com/python/cpython/pull/157626/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
View file https://github.com/python/cpython/blob/33988718f35c5c2bbe0c85516a221c61bd62c11a/Python/ceval.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157626/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157626/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com/python/cpython/pull/157626/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com/python/cpython/pull/157626/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
Please reload this pagehttps://github.com/python/cpython/pull/157626/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.