Title: gh-157614: Fix `lazy import a.b as c` incorrectly binding `a.b.b` by grgalex · Pull Request #157626 · python/cpython · GitHub
Open Graph Title: gh-157614: Fix `lazy import a.b as c` incorrectly binding `a.b.b` by grgalex · Pull Request #157626 · python/cpython
X Title: gh-157614: Fix `lazy import a.b as c` incorrectly binding `a.b.b` by grgalex · Pull Request #157626 · python/cpython
Description: lazy import a.b as c binds c to a.b.b instead of the module a.b when a.b is already in sys.modules and has an attribute named b. Root cause import a.b as c compiles to IMPORT_NAME a.b followed by IMPORT_FROM b. For a lazy import, IMPORT_NAME returns a placeholder with lz_from = "a.b". _PyEval_LazyImportFrom() has a fast path for modules already in sys.modules. It looks up lz_from directly and gets name from that module. In this case that means looking up b on a.b, producing a.b.b, instead of looking up b on the base module a. Fix Compute the base module before the sys.modules fast path and perform the lookup against it. The fast path must also be limited to the last IMPORT_FROM identifiable from the placeholder. Longer dotted names compile to multiple IMPORT_FROM instructions, and resolving an intermediate step would make the rest of the import eager. Eight existing test_lazy_import tests cover this. Two-component imports and from imports remain eligible for the fast path. Test Adds MixedLazyEagerImportTests.test_eager_dotted_import_before_lazy_resolves_to_same_module() alongside the existing single-name test. It creates a package a with a/b.py defining an attribute b, then checks: import a.b as c lazy import a.b as lazy_c assert lazy_c is c The test fails on main because lazy_c resolves to a.b.b and passes with the fix. test_lazy_import, test_import, and test_importlib also pass. Commits Move the lazy import subprocess helpers to LazyImportTestCase so the regression test can reuse them. No behavior change. Fix _PyEval_LazyImportFrom(), with the regression test and NEWS entry. Future Work / Not Addressed If package a itself has an attribute b shadowing submodule a.b, the lazy import can still reify to that attribute rather than the submodule. This is a separate mechanism, already tracked in gh-151208. The same mechanism makes lazy import math.pi as x bind the float where the eager statement raises; gh-155194 fixed the bare lazy import math.pi form only. For names with three or more components, an already-loaded module still resolves on first use rather than at the import statement because later IMPORT_FROM steps cannot tell whether they are the last one. Fixing that would require additional compiler or placeholder information and is only an optimization. Closes gh-157614.
Open Graph Description: lazy import a.b as c binds c to a.b.b instead of the module a.b when a.b is already in sys.modules and has an attribute named b. Root cause import a.b as c compiles to IMPORT_NAME a.b followed by I...
X Description: lazy import a.b as c binds c to a.b.b instead of the module a.b when a.b is already in sys.modules and has an attribute named b. Root cause import a.b as c compiles to IMPORT_NAME a.b followed by I...
Opengraph URL: https://github.com/python/cpython/pull/157626
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f44124ba-4330-bd95-61c4-d95f632c89b7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 883C:25F5AB:3285D8:40610B:6B020A71 |
| html-safe-nonce | 2f689c7104ef0c0591a03c17eaaba95493853fa6b683622f254699cf5dd2dfe0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODNDOjI1RjVBQjozMjg1RDg6NDA2MTBCOjZCMDIwQTcxIiwidmlzaXRvcl9pZCI6IjMxMTUyODY4NzU2MjQwNDkyNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e89504a9a944e4f4d171b8ddc94c203937ea8070ddf035c894ae2783d30d04e2 |
| hovercard-subject-tag | pull_request:4548749704 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/157626/files |
| twitter:image | https://avatars.githubusercontent.com/u/62315387?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/62315387?s=400&v=4 |
| og:image:alt | lazy import a.b as c binds c to a.b.b instead of the module a.b when a.b is already in sys.modules and has an attribute named b. Root cause import a.b as c compiles to IMPORT_NAME a.b followed by I... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width