René's URL Explorer Experiment


Title: gh-153568: Share expression parsing with assignment targets by pablogsal · Pull Request #157450 · python/cpython · GitHub

Open Graph Title: gh-153568: Share expression parsing with assignment targets by pablogsal · Pull Request #157450 · python/cpython

X Title: gh-153568: Share expression parsing with assignment targets by pablogsal · Pull Request #157450 · python/cpython

Description: The grammar has two versions of almost the same parser: primary for expressions and t_primary for assignment and deletion targets. For factory().field[index], both walk through the call, attribute and subscript. When we try an assignment and then fall back to an expression, that means doing the same work through a different set of rules. This lets targets use primary too. Parse the expression once, check that its shape is allowed as a target, then copy it into Store or Del context. For factory().field[index] = value, only the outer subscript changes context. The call, attribute and index stay Load, as does the cached expression. That removes t_primary, star_atom, del_t_atom and the separate target list and tuple rules. It also folds the comparison forwarding rules into their parent, shares the keyword-argument prefix, and gives display items shorter names next to the list, tuple and set rules. There are 15 fewer grammar rules in total. On my machine, this makes parsing the full standard library and twenty repositories about 9.1% faster overall. Codebase Python files Parsing speed Standard library 2,061 10.5% faster Django 2,932 10.5% faster pandas 1,527 9.4% faster NumPy 495 9.8% faster SciPy 999 9.8% faster scikit-learn 1,036 10.0% faster SymPy 1,607 7.8% faster Transformers 4,884 8.7% faster PyTorch 4,890 8.7% faster Home Assistant 18,731 7.6% faster mypy 442 9.5% faster Requests 37 9.5% faster Flask 83 9.0% faster FastAPI 1,138 7.0% faster SQLAlchemy 673 8.6% faster Black 345 5.5% faster pytest 274 9.2% faster Ansible 1,853 8.9% faster Scrapy 491 8.7% faster Celery 428 10.4% faster Sphinx 774 9.8% faster The table compares this change against main at fb46c67d56, using release builds without PGO or LTO. Each result is the median of five paired runs. The timings include tokenization, building the AST and cleanup, without compiling bytecode or running the files. Part of #153568. Issue: gh-153568

Open Graph Description: The grammar has two versions of almost the same parser: primary for expressions and t_primary for assignment and deletion targets. For factory().field[index], both walk through the call, attribute ...

X Description: The grammar has two versions of almost the same parser: primary for expressions and t_primary for assignment and deletion targets. For factory().field[index], both walk through the call, attribute ...

Opengraph URL: https://github.com/python/cpython/pull/157450

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:58d6104b-dc9d-e936-af86-ee3818002110
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE8D4:D4E59:A6D18A:D25EFA:6B0216A4
html-safe-nonce85318fc5971ddbc7e93b4f67bec86ecd7d9defea9f8a21b4a9e94c303e49bdb3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEQ0OkQ0RTU5OkE2RDE4QTpEMjVFRkE6NkIwMjE2QTQiLCJ2aXNpdG9yX2lkIjoiODE3ODA2NjEwMjE5NTE5NzYwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf04512a317e507acaf54e8ed8b555443e428f30378e5752241acb5eb41c57dac
hovercard-subject-tagpull_request:4520340045
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157450/files
twitter:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
og:image:altThe grammar has two versions of almost the same parser: primary for expressions and t_primary for assignment and deletion targets. For factory().field[index], both walk through the call, attribute ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157450/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157450%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157450%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157450/files
Reloadhttps://github.com/python/cpython/pull/157450/files
Reloadhttps://github.com/python/cpython/pull/157450/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:gh-153568-simplify-target-grammarhttps://github.com/pablogsal/cpython/tree/gh-153568-simplify-target-grammar
Conversation 0 https://github.com/python/cpython/pull/157450
Commits 2 https://github.com/python/cpython/pull/157450/commits
Checks 52 https://github.com/python/cpython/pull/157450/checks
Files changed https://github.com/python/cpython/pull/157450/files
Please reload this pagehttps://github.com/python/cpython/pull/157450/files
gh-153568: Share expression parsing with assignment targets https://github.com/python/cpython/pull/157450/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/157450/files
5167fff gh-153568: Share expression parsing with assignment targets pablogsal Sep 13, 2026 https://github.com/python/cpython/pull/157450/commits/5167fff8f1bdc99b8825efef984577b23ef267e5
59e69f0 Clarify target parsing contracts and AST expectations pablogsal Sep 13, 2026 https://github.com/python/cpython/pull/157450/commits/59e69f0da29793efd198b7eceb73d7311ffa3631
Clear filters https://github.com/python/cpython/pull/157450/files
Please reload this pagehttps://github.com/python/cpython/pull/157450/files
Please reload this pagehttps://github.com/python/cpython/pull/157450/files
python.gram https://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
test_ast.py https://github.com/python/cpython/pull/157450/files#diff-a6d9c051aefcdf8f9606dd2ecc5a172a5716e2b38eff96097fc2b96528ed19d0
test_syntax.py https://github.com/python/cpython/pull/157450/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
2026-09-13-17-00-00.gh-issue-153568.target-grammar.rst https://github.com/python/cpython/pull/157450/files#diff-08114c86f30086432cfa3e77d172c38a40941c7dee0a7f7b4c6ac4ed3baee51a
action_helpers.c https://github.com/python/cpython/pull/157450/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
parser.c https://github.com/python/cpython/pull/157450/files#diff-6d39440cedc67d1ce7a0586bfb6ecb8483803448a9c93f3fae3ad0e2260e29f7
pegen.h https://github.com/python/cpython/pull/157450/files#diff-5803bf7cd8fdced0a7448e74074f36018f2206ab77ad13dc7451b1948b950852
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L308
Grammar/python.gramhttps://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
View file https://github.com/pablogsal/cpython/blob/59e69f0da29793efd198b7eceb73d7311ffa3631/Grammar/python.gram
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157450/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157450/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L203
Lib/test/test_ast/test_ast.pyhttps://github.com/python/cpython/pull/157450/files#diff-a6d9c051aefcdf8f9606dd2ecc5a172a5716e2b38eff96097fc2b96528ed19d0
View file https://github.com/pablogsal/cpython/blob/59e69f0da29793efd198b7eceb73d7311ffa3631/Lib/test/test_ast/test_ast.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157450/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157450/files#diff-a6d9c051aefcdf8f9606dd2ecc5a172a5716e2b38eff96097fc2b96528ed19d0
https://github.com/python/cpython/pull/157450/files#diff-a6d9c051aefcdf8f9606dd2ecc5a172a5716e2b38eff96097fc2b96528ed19d0
Lib/test/test_syntax.pyhttps://github.com/python/cpython/pull/157450/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
View file https://github.com/pablogsal/cpython/blob/59e69f0da29793efd198b7eceb73d7311ffa3631/Lib/test/test_syntax.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157450/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157450/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
https://github.com/python/cpython/pull/157450/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
...d/next/Core_and_Builtins/2026-09-13-17-00-00.gh-issue-153568.target-grammar.rsthttps://github.com/python/cpython/pull/157450/files#diff-08114c86f30086432cfa3e77d172c38a40941c7dee0a7f7b4c6ac4ed3baee51a
View file https://github.com/pablogsal/cpython/blob/59e69f0da29793efd198b7eceb73d7311ffa3631/Misc/NEWS.d/next/Core_and_Builtins/2026-09-13-17-00-00.gh-issue-153568.target-grammar.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157450/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/action_helpers.chttps://github.com/python/cpython/pull/157450/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
View file https://github.com/pablogsal/cpython/blob/59e69f0da29793efd198b7eceb73d7311ffa3631/Parser/action_helpers.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157450/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157450/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/157450/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/157450/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
https://github.com/python/cpython/pull/157450/files#diff-36e14ad6a0e6109f6d47a0bdf480a2d5a86135044d2f96766b280062922009e7
Please reload this pagehttps://github.com/python/cpython/pull/157450/files
Please reload this pagehttps://github.com/python/cpython/pull/157450/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.