René's URL Explorer Experiment


Title: gh-153568: Factor shared prefixes in expression rules by pablogsal · Pull Request #157437 · python/cpython · GitHub

Open Graph Title: gh-153568: Factor shared prefixes in expression rules by pablogsal · Pull Request #157437 · python/cpython

X Title: gh-153568: Factor shared prefixes in expression rules by pablogsal · Pull Request #157437 · python/cpython

Description: Several expression rules start by parsing the same thing for each choice. For a - b, the parser tries the + alternative first, then goes back and gets a again to try -. The cache saves us from parsing a from scratch, but we still pay for the extra rule call and cache lookup. This puts the shared part before the choice: get the left operand once, then check which operator follows. It does the same for tuples, boolean expressions, comparisons and powers. Parse the first expression once, then look for the optional part that follows it. When there is nothing more to match, return the expression we already have. On my machine, this makes parsing the full standard library and ten repositories about 4.7% faster overall. Codebase Python files Parsing speed Standard library 2,060 4.8% faster Django 2,932 5.5% faster pandas 1,527 4.8% faster NumPy 495 4.4% faster SciPy 999 4.6% faster scikit-learn 1,036 4.7% faster SymPy 1,607 5.6% faster Transformers 4,884 3.9% faster PyTorch 4,890 4.4% faster Home Assistant 18,731 4.7% faster mypy 442 5.5% faster The table compares this change against main at a60343ed17, using release builds without PGO or LTO. The timings include tokenization, building the AST and cleanup, without compiling bytecode or running the files. Part of #153568. Issue: gh-153568

Open Graph Description: Several expression rules start by parsing the same thing for each choice. For a - b, the parser tries the + alternative first, then goes back and gets a again to try -. The cache saves us from pars...

X Description: Several expression rules start by parsing the same thing for each choice. For a - b, the parser tries the + alternative first, then goes back and gets a again to try -. The cache saves us from pars...

Opengraph URL: https://github.com/python/cpython/pull/157437

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c734a598-7efb-aebd-bc38-635174bc2b61
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE25C:785A9:3F687B7:506ECFA:6B021695
html-safe-nonce87ef16279f12832f4615b9cfb23e1d503b48a3d292fd65bd377402740e8d73ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjVDOjc4NUE5OjNGNjg3Qjc6NTA2RUNGQTo2QjAyMTY5NSIsInZpc2l0b3JfaWQiOiI3NjE4NDg2NzU3NTAzNDA3NzY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac374286b1ac4aab2e7193b702bf8d7c6e3f82e0479f20ec32fee308dfed0e4731
hovercard-subject-tagpull_request:4519200408
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157437/files
twitter:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
og:image:altSeveral expression rules start by parsing the same thing for each choice. For a - b, the parser tries the + alternative first, then goes back and gets a again to try -. The cache saves us from pars...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157437/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157437%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157437%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157437/files
Reloadhttps://github.com/python/cpython/pull/157437/files
Reloadhttps://github.com/python/cpython/pull/157437/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:gh-153568-factor-expression-grammarhttps://github.com/pablogsal/cpython/tree/gh-153568-factor-expression-grammar
Conversation 1 https://github.com/python/cpython/pull/157437
Commits 1 https://github.com/python/cpython/pull/157437/commits
Checks 50 https://github.com/python/cpython/pull/157437/checks
Files changed https://github.com/python/cpython/pull/157437/files
Please reload this pagehttps://github.com/python/cpython/pull/157437/files
gh-153568: Factor shared prefixes in expression rules https://github.com/python/cpython/pull/157437/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/157437/files
cf5c2fe gh-153568: Factor shared prefixes in expression rules pablogsal Sep 13, 2026 https://github.com/python/cpython/pull/157437/commits/cf5c2fe001213ab81562a27b713c8b19c941e5d1
Clear filters https://github.com/python/cpython/pull/157437/files
Please reload this pagehttps://github.com/python/cpython/pull/157437/files
Please reload this pagehttps://github.com/python/cpython/pull/157437/files
python.gram https://github.com/python/cpython/pull/157437/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
test_ast.py https://github.com/python/cpython/pull/157437/files#diff-a6d9c051aefcdf8f9606dd2ecc5a172a5716e2b38eff96097fc2b96528ed19d0
2026-09-13-15-00-00.gh-issue-153568.GpF4tr.rst https://github.com/python/cpython/pull/157437/files#diff-e17915063f939529b1ee5efb360906183aa2efdf656405674ad49ff61f1a5b1b
parser.c https://github.com/python/cpython/pull/157437/files#diff-6d39440cedc67d1ce7a0586bfb6ecb8483803448a9c93f3fae3ad0e2260e29f7
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L308
Grammar/python.gramhttps://github.com/python/cpython/pull/157437/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
View file https://github.com/pablogsal/cpython/blob/cf5c2fe001213ab81562a27b713c8b19c941e5d1/Grammar/python.gram
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157437/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157437/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157437/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157437/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157437/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157437/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157437/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157437/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/157437/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L203
Lib/test/test_ast/test_ast.pyhttps://github.com/python/cpython/pull/157437/files#diff-a6d9c051aefcdf8f9606dd2ecc5a172a5716e2b38eff96097fc2b96528ed19d0
View file https://github.com/pablogsal/cpython/blob/cf5c2fe001213ab81562a27b713c8b19c941e5d1/Lib/test/test_ast/test_ast.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157437/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157437/files#diff-a6d9c051aefcdf8f9606dd2ecc5a172a5716e2b38eff96097fc2b96528ed19d0
https://github.com/python/cpython/pull/157437/files#diff-a6d9c051aefcdf8f9606dd2ecc5a172a5716e2b38eff96097fc2b96528ed19d0
Misc/NEWS.d/next/Core_and_Builtins/2026-09-13-15-00-00.gh-issue-153568.GpF4tr.rsthttps://github.com/python/cpython/pull/157437/files#diff-e17915063f939529b1ee5efb360906183aa2efdf656405674ad49ff61f1a5b1b
View file https://github.com/pablogsal/cpython/blob/cf5c2fe001213ab81562a27b713c8b19c941e5d1/Misc/NEWS.d/next/Core_and_Builtins/2026-09-13-15-00-00.gh-issue-153568.GpF4tr.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157437/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/157437/files
Please reload this pagehttps://github.com/python/cpython/pull/157437/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.