Title: gh-156233: Fix the prior author's 'overly_generic' example's Python SyntaxError, and type annotation errors by willy-b · Pull Request #157386 · python/cpython · GitHub
Open Graph Title: gh-156233: Fix the prior author's 'overly_generic' example's Python SyntaxError, and type annotation errors by willy-b · Pull Request #157386 · python/cpython
X Title: gh-156233: Fix the prior author's 'overly_generic' example's Python SyntaxError, and type annotation errors by willy-b · Pull Request #157386 · python/cpython
Description: Thanks so much Python team for everything you do. In discussion with @StanFromIreland at #156475 (comment) and @encukou at #156233 (comment) , I have opened this PR to fix the Compound Statement documentation page's 'overly_generic' example's Python SyntaxError, and type annotation errors (ParamSpec default given as a tuple (instead of List), TypeVarTuple default specified as a plain packed tuple instead of unpacked) by prior author. Re: the 'Compound Statement's overly_generic example on https://docs.python.org/3.16/reference/compound_stmts.html (archived as is at https://web.archive.org/web/20260913010111/https://docs.python.org/3.16/reference/compound_stmts.html ) (and docs for earlier Python versions, e.g. 3.13, 3.14, 3.15), this commit makes minimal changes specific to this example only to: Fix Python SyntaxError: non-default type parameter 'TypeVarWithBound' follows default type parameter for the overly_generic by moving the TypeVarwithDefault down in the list after the non-default type parameters (from cpython/Doc/reference/compound_stmts.rst Line 1852 in fe3a26f TypeVarWithDefault = int, ) Fix MyPy error: The default argument to ParamSpec must be a list expression, ellipsis, or a ParamSpec [misc] by substituting **SimpleParamSpec=[str, bytearray] instead of the invalid **SimpleParamSpec=(str, bytearray) (fixing cpython/Doc/reference/compound_stmts.rst Line 1856 in fe3a26f **SimpleParamSpec = (str, bytearray), ) to follow guidance at e.g. https://typing.python.org/en/latest/spec/generics.html#paramspec-defaults (archived as is at https://web.archive.org/web/20260913004550/https://typing.python.org/en/latest/spec/generics.html#paramspec-defaults ) Fix MyPy error: The default argument to TypeVarTuple must be an Unpacked tuple [misc] by replacing *SimpleTypeVarTuple = (int, float), with *SimpleTypeVarTuple = *tuple[int, float], (fixing cpython/Doc/reference/compound_stmts.rst Line 1855 in fe3a26f *SimpleTypeVarTuple = (int, float), ) to follow guidance at e.g. https://typing.python.org/en/latest/spec/generics.html#typevartuple-defaults (archived as is at https://web.archive.org/web/20260913004550/https://typing.python.org/en/latest/spec/generics.html#typevartuple-defaults ) Fix MyPy error: TypeVarTuple 'SimpleTypeVarTuple' is only valid with an unpack [valid-type] by replacing *e: SimpleTypeVarTuple, with *e: *SimpleTypeVarTuple, to follow guidance at e.g. https://typing.python.org/en/latest/spec/generics.html#args-as-a-type-variable-tuple (archived as is at https://web.archive.org/web/20260913004550/https://typing.python.org/en/latest/spec/generics.html#args-as-a-type-variable-tuple ) See motivating discussion at #156233 (comment) and #156233 (comment) . Should be backported from 3.16 through 3.13. Checked this example also on the lower version of Python 3.13.2 with MyPy 2.3.1 , PyreFly 1.3.0 , Pyright 1.1.414 . (Re further backports: Note the version of the page on 3.12 did not have default type parameters but probably still needs a SEPARATE fix for cpython/Doc/reference/compound_stmts.rst Line 1718 in c016c25 *d: SimpleTypeVarTuple, in that branch to unpack the tuple (in that branch SimpleTypeVarTuple doesn't have a default but is still used without unpack where an unpacked tuple is needed, so only one line needs to change)). (Note that no AI or LLM was used in the discovery of this issue or the development of this change.) Issue: gh-156233
Open Graph Description: Thanks so much Python team for everything you do. In discussion with @StanFromIreland at #156475 (comment) and @encukou at #156233 (comment) , I have opened this PR to fix the Compound Statement do...
X Description: Thanks so much Python team for everything you do. In discussion with @StanFromIreland at #156475 (comment) and @encukou at #156233 (comment) , I have opened this PR to fix the Compound Statement do...
Opengraph URL: https://github.com/python/cpython/pull/157386
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:18be1fc7-9c50-5b26-b17f-dd2dc485fc9f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BA12:23E48:3860DF:46D8AF:6B020BC3 |
| html-safe-nonce | 145991a260339113d18931e16fc90a2ec97eac7373cae7b83201e92473ca5258 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTEyOjIzRTQ4OjM4NjBERjo0NkQ4QUY6NkIwMjBCQzMiLCJ2aXNpdG9yX2lkIjoiMTA2NDUxNTQ4MDEyOTI0NDA5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1e3e202e890d4918747394e13f12650900cedbb964f6cc517a6cf33aef3b41f7 |
| hovercard-subject-tag | pull_request:4516475513 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/157386/files |
| twitter:image | https://avatars.githubusercontent.com/u/6969859?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6969859?s=400&v=4 |
| og:image:alt | Thanks so much Python team for everything you do. In discussion with @StanFromIreland at #156475 (comment) and @encukou at #156233 (comment) , I have opened this PR to fix the Compound Statement do... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width