René's URL Explorer Experiment


Title: bpo-34037: Fix test_asyncio failure and add loop.shutdown_default_executor() by aeros · Pull Request #15735 · python/cpython · GitHub

Open Graph Title: bpo-34037: Fix test_asyncio failure and add loop.shutdown_default_executor() by aeros · Pull Request #15735 · python/cpython

X Title: bpo-34037: Fix test_asyncio failure and add loop.shutdown_default_executor() by aeros · Pull Request #15735 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This PR was based heavily upon @vstinner's PR and the suggestions from @asvetlov to improve upon it: I support the idea but have a question about implementation. asyncio provides an interface ...

X Description: This PR was based heavily upon @vstinner's PR and the suggestions from @asvetlov to improve upon it: I support the idea but have a question about implementation. asyncio provides an interf...

Opengraph URL: https://github.com/python/cpython/pull/15735

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:d6428706-32e8-baf2-b112-4dfff3ebd4ef
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBAB4:B577:57907D:774882:6A4DA841
html-safe-nonce0a89df3b6eb2fc5ec6b73528b975b521f1a898fbfbc7ce7a5b052ecdfa5a374d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUI0OkI1Nzc6NTc5MDdEOjc3NDg4Mjo2QTREQTg0MSIsInZpc2l0b3JfaWQiOiIzNzA2MDc4ODA3MzcyMzcwNTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5f4ca8b62d2226cb821d5fe2ad94917893a308f0f0afd4bc29e26c66f610ad39
hovercard-subject-tagpull_request:315351870
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/15735/commits
twitter:imagehttps://opengraph.githubassets.com/b12d2aa51ca1bd42505f4e58bed798f282ffe047f130a2618c3baf95cba7f1ab/python/cpython/pull/15735
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b12d2aa51ca1bd42505f4e58bed798f282ffe047f130a2618c3baf95cba7f1ab/python/cpython/pull/15735
og:image:altThis PR was based heavily upon @vstinner's PR and the suggestions from @asvetlov to improve upon it: I support the idea but have a question about implementation. asyncio provides an interface ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaeros
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release47723578ce6819210724ef064c858fce6d3115a3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/15735/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15735%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15735%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/15735/commits
Reloadhttps://github.com/python/cpython/pull/15735/commits
Reloadhttps://github.com/python/cpython/pull/15735/commits
Please reload this pagehttps://github.com/python/cpython/pull/15735/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/15735/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
asvetlovhttps://github.com/asvetlov
python:masterhttps://github.com/python/cpython/tree/master
aeros:bpo-34037https://github.com/aeros/cpython/tree/bpo-34037
Conversationhttps://github.com/python/cpython/pull/15735
Commits27 (27)https://github.com/python/cpython/pull/15735/commits
Checkshttps://github.com/python/cpython/pull/15735/checks
Files changedhttps://github.com/python/cpython/pull/15735/files
bpo-34037: Fix test_asyncio failure and add loop.shutdown_default_executor()https://github.com/python/cpython/pull/15735/commits#top
asvetlovhttps://github.com/asvetlov
python:masterhttps://github.com/python/cpython/tree/master
aeros:bpo-34037https://github.com/aeros/cpython/tree/bpo-34037
Add flag BaseEventLoop._executor_shutdown_calledhttps://github.com/python/cpython/pull/15735/commits/6ed9465e909efab02095e73d60a07f4cbe3b0aaf
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
6ed9465https://github.com/python/cpython/pull/15735/commits/6ed9465e909efab02095e73d60a07f4cbe3b0aaf
https://github.com/python/cpython/tree/6ed9465e909efab02095e73d60a07f4cbe3b0aaf
Add abstract method for loop.shutdown_default_executor()https://github.com/python/cpython/pull/15735/commits/8608e97fac0a894de13a05feca39b5bcf714db16
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
8608e97https://github.com/python/cpython/pull/15735/commits/8608e97fac0a894de13a05feca39b5bcf714db16
https://github.com/python/cpython/tree/8608e97fac0a894de13a05feca39b5bcf714db16
Add BaseEventLoop method shutdown_default_executor()https://github.com/python/cpython/pull/15735/commits/7f39c4acea0d073b48c6defff81ae3ded6c1d54f
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
7f39c4ahttps://github.com/python/cpython/pull/15735/commits/7f39c4acea0d073b48c6defff81ae3ded6c1d54f
https://github.com/python/cpython/tree/7f39c4acea0d073b48c6defff81ae3ded6c1d54f
Remove whitespacehttps://github.com/python/cpython/pull/15735/commits/09a94588af5f27a818135d1f9bde0640862a5be8
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
09a9458https://github.com/python/cpython/pull/15735/commits/09a94588af5f27a818135d1f9bde0640862a5be8
https://github.com/python/cpython/tree/09a94588af5f27a818135d1f9bde0640862a5be8
Add BaseEventLoop internal method _check_executor_shutdown()https://github.com/python/cpython/pull/15735/commits/c12cf4ff387ca057dcd29ca023783e00fa0fe059
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
c12cf4fhttps://github.com/python/cpython/pull/15735/commits/c12cf4ff387ca057dcd29ca023783e00fa0fe059
https://github.com/python/cpython/tree/c12cf4ff387ca057dcd29ca023783e00fa0fe059
Adjust docstring for abstract method loop.shutdown_default_executorhttps://github.com/python/cpython/pull/15735/commits/afa09a5d590c5ff397a4c25bb36885b7806158fa
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
afa09a5https://github.com/python/cpython/pull/15735/commits/afa09a5d590c5ff397a4c25bb36885b7806158fa
https://github.com/python/cpython/tree/afa09a5d590c5ff397a4c25bb36885b7806158fa
Rename method _check_executor_shutdown() to _check_default_executor()https://github.com/python/cpython/pull/15735/commits/3303753b77c7b8868446070331323170a311ccd8
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
3303753https://github.com/python/cpython/pull/15735/commits/3303753b77c7b8868446070331323170a311ccd8
https://github.com/python/cpython/tree/3303753b77c7b8868446070331323170a311ccd8
Add default executor check to loop.run_in_executor()https://github.com/python/cpython/pull/15735/commits/b877e76bc77bb2196f7b480fcd917703553e3d1b
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
b877e76https://github.com/python/cpython/pull/15735/commits/b877e76bc77bb2196f7b480fcd917703553e3d1b
https://github.com/python/cpython/tree/b877e76bc77bb2196f7b480fcd917703553e3d1b
Implement loop.shutdown_default_executors() in asyncio.run()https://github.com/python/cpython/pull/15735/commits/1a29d83b21014b39714a10a8f565b2e31072a3fa
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
1a29d83https://github.com/python/cpython/pull/15735/commits/1a29d83b21014b39714a10a8f565b2e31072a3fa
https://github.com/python/cpython/tree/1a29d83b21014b39714a10a8f565b2e31072a3fa
Remove empty linehttps://github.com/python/cpython/pull/15735/commits/6bde87c5f493b4878c3504755b9050f30c920da2
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
6bde87chttps://github.com/python/cpython/pull/15735/commits/6bde87c5f493b4878c3504755b9050f30c920da2
https://github.com/python/cpython/tree/6bde87c5f493b4878c3504755b9050f30c920da2
Shorten `loop.shutdown_default_executor()` docstringhttps://github.com/python/cpython/pull/15735/commits/1e4a858a73544742f6d96910ff5cb2a0e255a649
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
1e4a858https://github.com/python/cpython/pull/15735/commits/1e4a858a73544742f6d96910ff5cb2a0e255a649
https://github.com/python/cpython/tree/1e4a858a73544742f6d96910ff5cb2a0e255a649
Add _shutdown_default_executor() to reduce duplicate codehttps://github.com/python/cpython/pull/15735/commits/8a4a285c6b6ca3682d93666c9fbb1b3bf17d1f8b
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
8a4a285https://github.com/python/cpython/pull/15735/commits/8a4a285c6b6ca3682d93666c9fbb1b3bf17d1f8b
https://github.com/python/cpython/tree/8a4a285c6b6ca3682d93666c9fbb1b3bf17d1f8b
Update documentationhttps://github.com/python/cpython/pull/15735/commits/f6280f7f9978a70abbc3a62f23ffcce87600da64
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
f6280f7https://github.com/python/cpython/pull/15735/commits/f6280f7f9978a70abbc3a62f23ffcce87600da64
https://github.com/python/cpython/tree/f6280f7f9978a70abbc3a62f23ffcce87600da64
Convert `loop.shutdown_default_executor` into a coroutinehttps://github.com/python/cpython/pull/15735/commits/69c72440f41913c8aad04a0e6fb1638c1e0b6ed4
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
69c7244https://github.com/python/cpython/pull/15735/commits/69c72440f41913c8aad04a0e6fb1638c1e0b6ed4
https://github.com/python/cpython/tree/69c72440f41913c8aad04a0e6fb1638c1e0b6ed4
Add internal method `_do_shutdown()` and fix flag in `shutdown_default_executor()https://github.com/python/cpython/pull/15735/commits/76089205f143cb24e201ca83dced9b4c8d9a97e9
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
7608920https://github.com/python/cpython/pull/15735/commits/76089205f143cb24e201ca83dced9b4c8d9a97e9
https://github.com/python/cpython/tree/76089205f143cb24e201ca83dced9b4c8d9a97e9
Update docstrings to reflect changes to `loop.shutdown_default_executor`https://github.com/python/cpython/pull/15735/commits/93ddce2b58ad5e768e0ae6ff3990da3fcaeb0dde
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
93ddce2https://github.com/python/cpython/pull/15735/commits/93ddce2b58ad5e768e0ae6ff3990da3fcaeb0dde
https://github.com/python/cpython/tree/93ddce2b58ad5e768e0ae6ff3990da3fcaeb0dde
Misc fixes for `loop._do_shutdown()`https://github.com/python/cpython/pull/15735/commits/895cad071a7a511d5b2829c68a14629e4a879244
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
895cad0https://github.com/python/cpython/pull/15735/commits/895cad071a7a511d5b2829c68a14629e4a879244
https://github.com/python/cpython/tree/895cad071a7a511d5b2829c68a14629e4a879244
Fix whitespace in `asyncio-eventloop.rst`https://github.com/python/cpython/pull/15735/commits/94e7af41fdf4721f9e6533e9cd8edbfe127cec9d
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
94e7af4https://github.com/python/cpython/pull/15735/commits/94e7af41fdf4721f9e6533e9cd8edbfe127cec9d
https://github.com/python/cpython/tree/94e7af41fdf4721f9e6533e9cd8edbfe127cec9d
Update `asyncio.run()` for `loop.shutdown_default_executor()` coroutine improvementhttps://github.com/python/cpython/pull/15735/commits/7e4980ce8f26241b6bcc45451466b80e173d1e86
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
7e4980chttps://github.com/python/cpython/pull/15735/commits/7e4980ce8f26241b6bcc45451466b80e173d1e86
https://github.com/python/cpython/tree/7e4980ce8f26241b6bcc45451466b80e173d1e86
Fix `loop.shutdown_default_executor()` and whitespacehttps://github.com/python/cpython/pull/15735/commits/626117d7b8e81beddb2b72b50bd2ebfb484ead63
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
626117dhttps://github.com/python/cpython/pull/15735/commits/626117d7b8e81beddb2b72b50bd2ebfb484ead63
https://github.com/python/cpython/tree/626117d7b8e81beddb2b72b50bd2ebfb484ead63
Delete accidentally committed temp filehttps://github.com/python/cpython/pull/15735/commits/5340a5c84dabaefaa4091035aea472b4f2e64547
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
5340a5chttps://github.com/python/cpython/pull/15735/commits/5340a5c84dabaefaa4091035aea472b4f2e64547
https://github.com/python/cpython/tree/5340a5c84dabaefaa4091035aea472b4f2e64547
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/15735/commits/260cace386c5ecef1e82a9a11c91e7c60b0f60c5
https://github.com/apps/blurb-it
blurb-it[bot]https://github.com/python/cpython/commits?author=blurb-it%5Bbot%5D
260cacehttps://github.com/python/cpython/pull/15735/commits/260cace386c5ecef1e82a9a11c91e7c60b0f60c5
https://github.com/python/cpython/tree/260cace386c5ecef1e82a9a11c91e7c60b0f60c5
Adjust wording in Misc/NEWS entryhttps://github.com/python/cpython/pull/15735/commits/d2bc6d0083c2a0ff448dc5cab7bd4ebfb84ce62b
aeroshttps://github.com/python/cpython/commits?author=aeros
d2bc6d0https://github.com/python/cpython/pull/15735/commits/d2bc6d0083c2a0ff448dc5cab7bd4ebfb84ce62b
https://github.com/python/cpython/tree/d2bc6d0083c2a0ff448dc5cab7bd4ebfb84ce62b
Adjust wording in doc for loop.shutdown_default_executor()https://github.com/python/cpython/pull/15735/commits/8820584a64ae50c0a84bb61861ce79e85dfe25cc
aeroshttps://github.com/python/cpython/commits?author=aeros
8820584https://github.com/python/cpython/pull/15735/commits/8820584a64ae50c0a84bb61861ce79e85dfe25cc
https://github.com/python/cpython/tree/8820584a64ae50c0a84bb61861ce79e85dfe25cc
Merge branch 'bpo-34037' of https://github.com/aeros167/cpython into bpo-34037https://github.com/python/cpython/pull/15735/commits/7fe0fb1cde4edf9a35c43767f7db23da810b6eaf
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
7fe0fb1https://github.com/python/cpython/pull/15735/commits/7fe0fb1cde4edf9a35c43767f7db23da810b6eaf
https://github.com/python/cpython/tree/7fe0fb1cde4edf9a35c43767f7db23da810b6eaf
Fix doc for loop.shutdown_default_executor()https://github.com/python/cpython/pull/15735/commits/dbc08ae5bac719634ee3c22fa65e0d5915ca48f1
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
dbc08aehttps://github.com/python/cpython/pull/15735/commits/dbc08ae5bac719634ee3c22fa65e0d5915ca48f1
https://github.com/python/cpython/tree/dbc08ae5bac719634ee3c22fa65e0d5915ca48f1
Add "Patch by" to news entryhttps://github.com/python/cpython/pull/15735/commits/fbae3ec0bd6dd967369a2dbaedfcd10931e2df18
https://github.com/aeros
aeroshttps://github.com/python/cpython/commits?author=aeros
fbae3echttps://github.com/python/cpython/pull/15735/commits/fbae3ec0bd6dd967369a2dbaedfcd10931e2df18
https://github.com/python/cpython/tree/fbae3ec0bd6dd967369a2dbaedfcd10931e2df18
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.