René's URL Explorer Experiment


Title: [3.15] gh-156002: Keep reading through monkey-patched zipfile decompressors (GH-157180) by encukou · Pull Request #157268 · python/cpython · GitHub

Open Graph Title: [3.15] gh-156002: Keep reading through monkey-patched zipfile decompressors (GH-157180) by encukou · Pull Request #157268 · python/cpython

X Title: [3.15] gh-156002: Keep reading through monkey-patched zipfile decompressors (GH-157180) by encukou · Pull Request #157268 · python/cpython

Description: GH-156003 made ZipExtFile._read1() call decompress(data, max_length) on non-deflate decompressors and consult needs_input before reading more. A decompressor installed by monkey-patching _get_decompressor() (as projects like zipfile-zstd, zipfile-deflate64, ... do) may support neither, and every read through it then failed with AttributeError. Make LZMADecompressor.needs_input public to simplify implementation. Make the needs_input attribute optional. If decompress() fails with TypeError, try again with one argument. Add tests for future changes, so we can make informed decisions about breaking monkey-patchers. (cherry picked from commit e2311cf) The backport omits emitting a DeprecationWarning. Issue: gh-156002

Open Graph Description: GH-156003 made ZipExtFile._read1() call decompress(data, max_length) on non-deflate decompressors and consult needs_input before reading more. A decompressor installed by monkey-patching _get_decom...

X Description: GH-156003 made ZipExtFile._read1() call decompress(data, max_length) on non-deflate decompressors and consult needs_input before reading more. A decompressor installed by monkey-patching _get_decom...

Opengraph URL: https://github.com/python/cpython/pull/157268

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bf05d63b-6b28-8bf5-16ec-c7e8c17cf91d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB1B4:3A8E64:17A671D:1F4C1A8:6B020BBB
html-safe-nonce4cb6719aa4ed2e078fcb0ffbb65fc6ffe0f37c11bc4e5801cd34d28f792e023b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUI0OjNBOEU2NDoxN0E2NzFEOjFGNEMxQTg6NkIwMjBCQkIiLCJ2aXNpdG9yX2lkIjoiNzc1NzI4MjMxOTM0NTUxOTU0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2a78f639d6bf5bca62c9d10a301abbbb093401197ed4052b7188f0daef7b1b66
hovercard-subject-tagpull_request:4496406129
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157268/files
twitter:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
og:image:altGH-156003 made ZipExtFile._read1() call decompress(data, max_length) on non-deflate decompressors and consult needs_input before reading more. A decompressor installed by monkey-patching _get_decom...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157268/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157268%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157268%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157268/files
Reloadhttps://github.com/python/cpython/pull/157268/files
Reloadhttps://github.com/python/cpython/pull/157268/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
hugovkhttps://github.com/hugovk
python:3.15https://github.com/python/cpython/tree/3.15
encukou:backport-e2311cf-3.15https://github.com/encukou/cpython/tree/backport-e2311cf-3.15
Conversation 4 https://github.com/python/cpython/pull/157268
Commits 1 https://github.com/python/cpython/pull/157268/commits
Checks 60 https://github.com/python/cpython/pull/157268/checks
Files changed 3 https://github.com/python/cpython/pull/157268/files
[3.15] gh-156002: Keep reading through monkey-patched zipfile decompressors (GH-157180) https://github.com/python/cpython/pull/157268/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/157268/files
355f1cc [3.15] gh-156002: Keep reading through monkey-patched zipfile decompr… rasmusfaber Sep 10, 2026 https://github.com/python/cpython/pull/157268/commits/355f1cc490c83ce47388665cba6275f6055b58fe
Clear filters https://github.com/python/cpython/pull/157268/files
Please reload this pagehttps://github.com/python/cpython/pull/157268/files
Please reload this pagehttps://github.com/python/cpython/pull/157268/files
test_core.py https://github.com/python/cpython/pull/157268/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
__init__.py https://github.com/python/cpython/pull/157268/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
2026-09-08-13-06-29.gh-issue-156002.vmOC8T.rst https://github.com/python/cpython/pull/157268/files#diff-5ba1114a0f20700d8d2c68b98634753dcdc8a0211985989feca6f23bdef7bd3d
Lib/test/test_zipfile/test_core.pyhttps://github.com/python/cpython/pull/157268/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
View file https://github.com/encukou/cpython/blob/355f1cc490c83ce47388665cba6275f6055b58fe/Lib/test/test_zipfile/test_core.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157268/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157268/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
https://github.com/python/cpython/pull/157268/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
Lib/zipfile/__init__.pyhttps://github.com/python/cpython/pull/157268/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
View file https://github.com/encukou/cpython/blob/355f1cc490c83ce47388665cba6275f6055b58fe/Lib/zipfile/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157268/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157268/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/157268/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/157268/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/157268/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/157268/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/157268/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/157268/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
Misc/NEWS.d/next/Library/2026-09-08-13-06-29.gh-issue-156002.vmOC8T.rsthttps://github.com/python/cpython/pull/157268/files#diff-5ba1114a0f20700d8d2c68b98634753dcdc8a0211985989feca6f23bdef7bd3d
View file https://github.com/encukou/cpython/blob/355f1cc490c83ce47388665cba6275f6055b58fe/Misc/NEWS.d/next/Library/2026-09-08-13-06-29.gh-issue-156002.vmOC8T.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157268/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/157268/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.