| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f740fbcc-4053-1e5d-013e-e9e341fa4189 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 901E:209C20:50B0E:6E118:6A5462C3 |
| html-safe-nonce | 0ac9bab8c99a2b081d1342ac711665c0c3db0403f55bbbe800153234e6b4cc06 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDFFOjIwOUMyMDo1MEIwRTo2RTExODo2QTU0NjJDMyIsInZpc2l0b3JfaWQiOiI1NzM3MTEyMDMzMjQ3Mzg4MzU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 795e041d7a1ffc0f4f4edfc46b63b13e40b5641ba30b704d4e7369bd784554e8 |
| hovercard-subject-tag | pull_request:315205555 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/15725/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8f8294e731b0792b44cfb3fb5ce8314a0a7dc43bfbd022d607793c7900da056d/python/cpython/pull/15725 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8f8294e731b0792b44cfb3fb5ce8314a0a7dc43bfbd022d607793c7900da056d/python/cpython/pull/15725 |
| og:image:alt | Unlike other APIs that steal references, PyModule_AddObject only does it on success. However, most calls throughout the codebase don't manually Py_DECREF on failure as required by the implement... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | brandtbucher |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6d28624802c2f7d9500239dd6870ed7031b7353b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/15725#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15725 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15725 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/15725 |
| Reload | https://github.com/python/cpython/pull/15725 |
| Reload | https://github.com/python/cpython/pull/15725 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| matrixise | https://github.com/matrixise |
| python:master | https://github.com/python/cpython/tree/master |
| brandtbucher:safe-add-object | https://github.com/brandtbucher/cpython/tree/safe-add-object |
| Conversation | https://github.com/python/cpython/pull/15725 |
| Commits7 (7) | https://github.com/python/cpython/pull/15725/commits |
| Checks | https://github.com/python/cpython/pull/15725/checks |
| Files changed | https://github.com/python/cpython/pull/15725/files |
| bpo-26868: Fix example usage of PyModule_AddObject. | https://github.com/python/cpython/pull/15725#top |
| matrixise | https://github.com/matrixise |
| python:master | https://github.com/python/cpython/tree/master |
| brandtbucher:safe-add-object | https://github.com/brandtbucher/cpython/tree/safe-add-object |
|
| https://github.com/brandtbucher |
| brandtbucher | https://github.com/brandtbucher |
| Sep 7, 2019 | https://github.com/python/cpython/pull/15725#issue-490650352 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| https://bugs.python.org/issue26868 | https://bugs.python.org/issue26868 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| brandtbucher | https://github.com/brandtbucher |
| September 7, 2019 07:53 | https://github.com/python/cpython/pull/15725#commits-pushed-90ae263 |
|
| https://github.com/brandtbucher |
| Add a note to the PyModule_AddObject docs. | https://github.com/python/cpython/pull/15725/commits/90ae263033c616efa907b5eafdb5814ae4e2060a |
| 90ae263 | https://github.com/python/cpython/pull/15725/commits/90ae263033c616efa907b5eafdb5814ae4e2060a |
|
| https://github.com/brandtbucher |
| Correct example usages of PyModule_AddObject. | https://github.com/python/cpython/pull/15725/commits/4b08887dac35a9afaf135de2f55d845547be1e7f |
| 4b08887 | https://github.com/python/cpython/pull/15725/commits/4b08887dac35a9afaf135de2f55d845547be1e7f |
|
| https://github.com/brandtbucher |
| Whitespace. | https://github.com/python/cpython/pull/15725/commits/aef02b877a552f8b4d7a7f87f5b531f2c920aeb7 |
| aef02b8 | https://github.com/python/cpython/pull/15725/commits/aef02b877a552f8b4d7a7f87f5b531f2c920aeb7 |
|
| https://github.com/brandtbucher |
| Clean up wording. | https://github.com/python/cpython/pull/15725/commits/474a266df3a4c6ae69d4aecb549d6feac0113b5f |
| 474a266 | https://github.com/python/cpython/pull/15725/commits/474a266df3a4c6ae69d4aecb549d6feac0113b5f |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Sep 7, 2019 | https://github.com/python/cpython/pull/15725#event-2616277572 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Sep 7, 2019 | https://github.com/python/cpython/pull/15725#event-2616277578 |
| https://github.com/brandtbucher |
| brandtbucher | https://github.com/brandtbucher |
|
needs backport to 3.7
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22 |
|
docs
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Adocs |
| Sep 7, 2019 | https://github.com/python/cpython/pull/15725#event-2616277919 |
|
| https://github.com/apps/blurb-it |
| 📜🤖 Added by blurb_it. | https://github.com/python/cpython/pull/15725/commits/a0058237c63ccdb522bb9f4b2f8f8f1b7646828c |
| a005823 | https://github.com/python/cpython/pull/15725/commits/a0058237c63ccdb522bb9f4b2f8f8f1b7646828c |
| https://github.com/brandtbucher |
| brandtbucher | https://github.com/brandtbucher |
| Sep 7, 2019 | https://github.com/python/cpython/pull/15725#issuecomment-529120129 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Sep 7, 2019
| https://github.com/python/cpython/pull/15725#pullrequestreview-285186101 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15725/files/a0058237c63ccdb522bb9f4b2f8f8f1b7646828c |
| Doc/c-api/module.rst | https://github.com/python/cpython/pull/15725/files/a0058237c63ccdb522bb9f4b2f8f8f1b7646828c#diff-31dfed5b80337a659e56d1d58ddd7f02cb92bd1ae845ae655bec8dd20f5674c8 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/c-api/module.rst | https://github.com/python/cpython/pull/15725/files/a0058237c63ccdb522bb9f4b2f8f8f1b7646828c#diff-31dfed5b80337a659e56d1d58ddd7f02cb92bd1ae845ae655bec8dd20f5674c8 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/c-api/module.rst | https://github.com/python/cpython/pull/15725/files/a0058237c63ccdb522bb9f4b2f8f8f1b7646828c#diff-31dfed5b80337a659e56d1d58ddd7f02cb92bd1ae845ae655bec8dd20f5674c8 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/extending/extending.rst | https://github.com/python/cpython/pull/15725/files/a0058237c63ccdb522bb9f4b2f8f8f1b7646828c#diff-c8029375131ddc13f3113a9eb67810de9dcf954277b4bf193d4220d6834741b3 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/extending/extending.rst | https://github.com/python/cpython/pull/15725/files/a0058237c63ccdb522bb9f4b2f8f8f1b7646828c#diff-c8029375131ddc13f3113a9eb67810de9dcf954277b4bf193d4220d6834741b3 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/extending/extending.rst | https://github.com/python/cpython/pull/15725/files/a0058237c63ccdb522bb9f4b2f8f8f1b7646828c#diff-c8029375131ddc13f3113a9eb67810de9dcf954277b4bf193d4220d6834741b3 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/includes/sublist.c | https://github.com/python/cpython/pull/15725/files/a0058237c63ccdb522bb9f4b2f8f8f1b7646828c#diff-4fa9c4b5aebaf7ff463e7170e32fcb89f0dd1ef03a87fbd61710f2f4cf0dc0b3 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| https://github.com/Yhg1s |
| Yhg1s | https://github.com/Yhg1s |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15725#event-2618740130 |
| https://github.com/brandtbucher |
| brandtbucher | https://github.com/brandtbucher |
|
Sep 9, 2019
| https://github.com/python/cpython/pull/15725#ref-pullrequest-489781386 |
|
bpo-38037: Fix reference counters in signal module
#15701
| https://github.com/python/cpython/pull/15701 |
|
| https://github.com/brandtbucher |
| First code review. | https://github.com/python/cpython/pull/15725/commits/bb345d994148c7626ad19dd045045ce1469882b0 |
| bb345d9 | https://github.com/python/cpython/pull/15725/commits/bb345d994148c7626ad19dd045045ce1469882b0 |
| https://github.com/brandtbucher |
| brandtbucher | https://github.com/brandtbucher |
| Sep 9, 2019 | https://github.com/python/cpython/pull/15725#issuecomment-529594487 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Sep 10, 2019
| https://github.com/python/cpython/pull/15725#pullrequestreview-285988847 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15725/files/bb345d994148c7626ad19dd045045ce1469882b0 |
| Doc/extending/extending.rst | https://github.com/python/cpython/pull/15725/files/bb345d994148c7626ad19dd045045ce1469882b0#diff-c8029375131ddc13f3113a9eb67810de9dcf954277b4bf193d4220d6834741b3 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Sep 10, 2019 | https://github.com/python/cpython/pull/15725#discussion_r322617418 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| brandtbucher | https://github.com/brandtbucher |
| Sep 10, 2019 | https://github.com/python/cpython/pull/15725#discussion_r322777326 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| matrixise | https://github.com/matrixise |
| Sep 11, 2019 | https://github.com/python/cpython/pull/15725#discussion_r323458904 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| https://github.com/ghost |
| ghost | https://github.com/ghost |
| Sep 11, 2019 | https://github.com/python/cpython/pull/15725#issuecomment-530208479 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| https://github.com/matrixise |
| matrixise | https://github.com/matrixise |
|
Sep 12, 2019
| https://github.com/python/cpython/pull/15725#pullrequestreview-287260622 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15725/files/bb345d994148c7626ad19dd045045ce1469882b0 |
| matrixise | https://github.com/matrixise |
| https://github.com/python/cpython/pull/15725#pullrequestreview-287260622 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/extending/extending.rst | https://github.com/python/cpython/pull/15725/files/bb345d994148c7626ad19dd045045ce1469882b0#diff-c8029375131ddc13f3113a9eb67810de9dcf954277b4bf193d4220d6834741b3 |
| matrixise | https://github.com/matrixise |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#discussion_r323611166 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/extending/newtypes_tutorial.rst | https://github.com/python/cpython/pull/15725/files/bb345d994148c7626ad19dd045045ce1469882b0#diff-9c878c16f54b6d3bc875b4edf60bdd4f26a2c5ee4b773dded4ae57dd3a80e3ae |
| matrixise | https://github.com/matrixise |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#discussion_r323611273 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/extending/newtypes_tutorial.rst | https://github.com/python/cpython/pull/15725/files/bb345d994148c7626ad19dd045045ce1469882b0#diff-9c878c16f54b6d3bc875b4edf60bdd4f26a2c5ee4b773dded4ae57dd3a80e3ae |
| matrixise | https://github.com/matrixise |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#discussion_r323611344 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/includes/custom.c | https://github.com/python/cpython/pull/15725/files/bb345d994148c7626ad19dd045045ce1469882b0#diff-5ab47b3bf39fac130be5e5855e0b3f82a0341055a3579e793a1ac4ca4f20d57b |
| matrixise | https://github.com/matrixise |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#discussion_r323611394 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/includes/custom2.c | https://github.com/python/cpython/pull/15725/files/bb345d994148c7626ad19dd045045ce1469882b0#diff-205fa8c16a258a2116b12e38bfc69b88b8cf2c6412ce0cc256f5d3e48cb165cf |
| matrixise | https://github.com/matrixise |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#discussion_r323611447 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/includes/custom3.c | https://github.com/python/cpython/pull/15725/files/bb345d994148c7626ad19dd045045ce1469882b0#diff-3ee128974bffae61ed301477efba310dd1b4a1a646fe24acdb08a5ff3a03ddc0 |
| matrixise | https://github.com/matrixise |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#discussion_r323611485 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/includes/custom4.c | https://github.com/python/cpython/pull/15725/files/bb345d994148c7626ad19dd045045ce1469882b0#diff-40da1923100408b1114041ee458362ce4e301ba5bb6fa7e84a3ba2ad5668129b |
| matrixise | https://github.com/matrixise |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#discussion_r323611519 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| Doc/includes/sublist.c | https://github.com/python/cpython/pull/15725/files/bb345d994148c7626ad19dd045045ce1469882b0#diff-4fa9c4b5aebaf7ff463e7170e32fcb89f0dd1ef03a87fbd61710f2f4cf0dc0b3 |
| matrixise | https://github.com/matrixise |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#discussion_r323611568 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| https://github.com/matrixise |
| matrixise | https://github.com/matrixise |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#event-2628267769 |
|
| https://github.com/matrixise |
| Add < 0 in the tests with PyModule_AddObject | https://github.com/python/cpython/pull/15725/commits/37b6b37e6cab098c42cd461241fc491d7df7589e |
| 37b6b37 | https://github.com/python/cpython/pull/15725/commits/37b6b37e6cab098c42cd461241fc491d7df7589e |
| https://github.com/matrixise |
| matrixise | https://github.com/matrixise |
|
Sep 12, 2019
| https://github.com/python/cpython/pull/15725#pullrequestreview-287379359 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15725/files/37b6b37e6cab098c42cd461241fc491d7df7589e |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#event-2628917730 |
| https://github.com/matrixise |
| matrixise | https://github.com/matrixise |
|
Sep 12, 2019
| https://github.com/python/cpython/pull/15725#pullrequestreview-287381276 |
|
View reviewed changes
| https://github.com/python/cpython/pull/15725/files/37b6b37e6cab098c42cd461241fc491d7df7589e |
| matrixise | https://github.com/matrixise |
| https://github.com/python/cpython/pull/15725#pullrequestreview-287381276 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| https://github.com/matrixise |
| matrixise | https://github.com/matrixise |
| 224b8aa | https://github.com/python/cpython/commit/224b8aaa7e8f67f748e8b7b6a4a77a25f6554651 |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#event-2628931330 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#issuecomment-530796771 |
| @matrixise | https://github.com/matrixise |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#issuecomment-530796772 |
| @brandtbucher | https://github.com/brandtbucher |
| @matrixise | https://github.com/matrixise |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#event-2628931449 |
| miss-islington | https://github.com/miss-islington |
|
Sep 12, 2019
| https://github.com/python/cpython/pull/15725#ref-commit-9891db1 |
|
| https://github.com/brandtbucher |
|
| https://github.com/miss-islington |
| bpo-26868: Fix example usage of PyModule_AddObject. ( | https://github.com/miss-islington/cpython/commit/9891db10352a2b37f386000f944ad2c788cd4484 |
| pythonGH-15725 | https://github.com/python/cpython/pull/15725 |
| ) | https://github.com/miss-islington/cpython/commit/9891db10352a2b37f386000f944ad2c788cd4484 |
| 9891db1 | https://github.com/miss-islington/cpython/commit/9891db10352a2b37f386000f944ad2c788cd4484 |
| 224b8aa | https://github.com/miss-islington/cpython/commit/224b8aaa7e8f67f748e8b7b6a4a77a25f6554651 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#issuecomment-530796854 |
| GH-16037 | https://github.com/python/cpython/pull/16037 |
| 3.8 branch | https://github.com/python/cpython/tree/3.8 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.8
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22 |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#event-2628931896 |
| miss-islington | https://github.com/miss-islington |
|
Sep 12, 2019
| https://github.com/python/cpython/pull/15725#ref-commit-370d6b9 |
|
| https://github.com/brandtbucher |
|
| https://github.com/miss-islington |
| bpo-26868: Fix example usage of PyModule_AddObject. ( | https://github.com/miss-islington/cpython/commit/370d6b97205a7e64e8ffc6232188f03d31388e8f |
| pythonGH-15725 | https://github.com/python/cpython/pull/15725 |
| ) | https://github.com/miss-islington/cpython/commit/370d6b97205a7e64e8ffc6232188f03d31388e8f |
| 370d6b9 | https://github.com/miss-islington/cpython/commit/370d6b97205a7e64e8ffc6232188f03d31388e8f |
| 224b8aa | https://github.com/miss-islington/cpython/commit/224b8aaa7e8f67f748e8b7b6a4a77a25f6554651 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.7
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22 |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#event-2628932227 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#issuecomment-530796892 |
| GH-16038 | https://github.com/python/cpython/pull/16038 |
| 3.7 branch | https://github.com/python/cpython/tree/3.7 |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| miss-islington | https://github.com/miss-islington |
|
Sep 12, 2019
| https://github.com/python/cpython/pull/15725#ref-commit-535863e |
|
| https://github.com/miss-islington |
|
| https://github.com/brandtbucher |
| bpo-26868 | https://bugs.python.org/issue?@action=redirect&bpo=26868 |
| : Fix example usage of PyModule_AddObject. ( | https://github.com/python/cpython/commit/535863e3f599a6ad829204d83f144c91e44de443 |
| GH-15725 | https://github.com/python/cpython/pull/15725 |
| ) | https://github.com/python/cpython/commit/535863e3f599a6ad829204d83f144c91e44de443 |
| 535863e | https://github.com/python/cpython/commit/535863e3f599a6ad829204d83f144c91e44de443 |
| 224b8aa | https://github.com/python/cpython/commit/224b8aaa7e8f67f748e8b7b6a4a77a25f6554651 |
| miss-islington | https://github.com/miss-islington |
|
Sep 12, 2019
| https://github.com/python/cpython/pull/15725#ref-commit-c8d1338 |
|
| https://github.com/miss-islington |
|
| https://github.com/brandtbucher |
| bpo-26868 | https://bugs.python.org/issue?@action=redirect&bpo=26868 |
| : Fix example usage of PyModule_AddObject. ( | https://github.com/python/cpython/commit/c8d1338441114fbc504625bc66607e7996018a5d |
| GH-15725 | https://github.com/python/cpython/pull/15725 |
| ) | https://github.com/python/cpython/commit/c8d1338441114fbc504625bc66607e7996018a5d |
| c8d1338 | https://github.com/python/cpython/commit/c8d1338441114fbc504625bc66607e7996018a5d |
| 224b8aa | https://github.com/python/cpython/commit/224b8aaa7e8f67f748e8b7b6a4a77a25f6554651 |
| https://github.com/brandtbucher |
| brandtbucher | https://github.com/brandtbucher |
| Sep 12, 2019 | https://github.com/python/cpython/pull/15725#issuecomment-530824570 |
| @matrixise | https://github.com/matrixise |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
| https://github.com/brandtbucher |
| brandtbucher | https://github.com/brandtbucher |
| September 12, 2019 13:26 | https://github.com/python/cpython/pull/15725#event-2629165980 |
| https://github.com/berkerpeksag |
| berkerpeksag | https://github.com/berkerpeksag |
|
Oct 29, 2022
| https://github.com/python/cpython/pull/15725#ref-issue-1198951397 |
|
Document PyModule_AddObject's behavior on error
#71055
| https://github.com/python/cpython/issues/71055 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15725 |
|
| https://github.com/serhiy-storchaka |
|
serhiy-storchaka
| https://github.com/serhiy-storchaka |
|
| https://github.com/python/cpython/pull/15725/files/bb345d994148c7626ad19dd045045ce1469882b0 |
|
| https://github.com/matrixise |
|
matrixise
| https://github.com/matrixise |
|
| https://github.com/python/cpython/pull/15725/files/37b6b37e6cab098c42cd461241fc491d7df7589e |
|
| https://github.com/matrixise |
|
matrixise
| https://github.com/matrixise |
|
docs
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Adocs |
| Please reload this page | https://github.com/python/cpython/pull/15725 |
|
| https://github.com/brandtbucher |
|
| https://github.com/bedevere-bot |
|
| https://github.com/miss-islington |
|
| https://github.com/matrixise |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/Yhg1s |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |