René's URL Explorer Experiment


Title: gh-129813: Check size in PyBytesWriter_FinishWithSize() by vstinner · Pull Request #157226 · python/cpython · GitHub

Open Graph Title: gh-129813: Check size in PyBytesWriter_FinishWithSize() by vstinner · Pull Request #157226 · python/cpython

X Title: gh-129813: Check size in PyBytesWriter_FinishWithSize() by vstinner · Pull Request #157226 · python/cpython

Description: Reject size larger than the allocated size. Also, check negative size in PyBytesWriter_FinishWithSize() to always raise ValueError. Previously, the function raised SystemError or ValueError depending on the code path. Replace _PyBytesWriter_GetAllocated() optimization with _PyBytesWriter_ResizeToAllocated() to update the writer size to its allocated size. Issue: gh-129813

Open Graph Description: Reject size larger than the allocated size. Also, check negative size in PyBytesWriter_FinishWithSize() to always raise ValueError. Previously, the function raised SystemError or ValueError dependi...

X Description: Reject size larger than the allocated size. Also, check negative size in PyBytesWriter_FinishWithSize() to always raise ValueError. Previously, the function raised SystemError or ValueError dependi...

Opengraph URL: https://github.com/python/cpython/pull/157226

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4ea4eb84-63b9-2f21-99d6-ae393e839d1c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB394:29FFA9:3B38507:4AFADE6:6B01FC35
html-safe-noncea1a7d28af18769fa3c50dd20b4ddac21fec1bcbbd340a2f8223ef0cf41b66f6b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzk0OjI5RkZBOTozQjM4NTA3OjRBRkFERTY6NkIwMUZDMzUiLCJ2aXNpdG9yX2lkIjoiMzI0MjAwMzY3OTQ2NDc4MjkwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7e886f9c71e897df7f5f84842c7283136b9e819ae3959ce79c3f34a26acf0f83
hovercard-subject-tagpull_request:4487457716
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157226/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altReject size larger than the allocated size. Also, check negative size in PyBytesWriter_FinishWithSize() to always raise ValueError. Previously, the function raised SystemError or ValueError dependi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157226/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157226%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157226%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157226/files
Reloadhttps://github.com/python/cpython/pull/157226/files
Reloadhttps://github.com/python/cpython/pull/157226/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:writer_sizehttps://github.com/vstinner/cpython/tree/writer_size
Conversation 5 https://github.com/python/cpython/pull/157226
Commits 5 https://github.com/python/cpython/pull/157226/commits
Checks 51 https://github.com/python/cpython/pull/157226/checks
Files changed https://github.com/python/cpython/pull/157226/files
Please reload this pagehttps://github.com/python/cpython/pull/157226/files
gh-129813: Check size in PyBytesWriter_FinishWithSize() https://github.com/python/cpython/pull/157226/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/157226/files
07185df gh-129813: Check size in PyBytesWriter_FinishWithSize() vstinner Sep 9, 2026 https://github.com/python/cpython/pull/157226/commits/07185dfe86fb7c795e9a47f11e2de8ffef10d3a1
b9da2ce Update test_capi vstinner Sep 9, 2026 https://github.com/python/cpython/pull/157226/commits/b9da2ced4322980c86d1cf81c082d640d395c9cf
d572dad Fix memory leak vstinner Sep 9, 2026 https://github.com/python/cpython/pull/157226/commits/d572dadc491960e2e7b7ac643d279bdf4959b7c4
2091c90 Add tests on the Pointer API vstinner Sep 9, 2026 https://github.com/python/cpython/pull/157226/commits/2091c90ed47b116202141d63eead495dfbbaf630
c810e97 Avoid redundant checks in FinishWithPointer() vstinner Sep 9, 2026 https://github.com/python/cpython/pull/157226/commits/c810e97ab81a531edaadecccf41be8fe554f5841
Clear filters https://github.com/python/cpython/pull/157226/files
Please reload this pagehttps://github.com/python/cpython/pull/157226/files
Please reload this pagehttps://github.com/python/cpython/pull/157226/files
test_bytes.py https://github.com/python/cpython/pull/157226/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
bytes.c https://github.com/python/cpython/pull/157226/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
bytesobject.c https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
Lib/test/test_capi/test_bytes.pyhttps://github.com/python/cpython/pull/157226/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
View file https://github.com/vstinner/cpython/blob/c810e97ab81a531edaadecccf41be8fe554f5841/Lib/test/test_capi/test_bytes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157226/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157226/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/157226/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/157226/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/157226/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/157226/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/157226/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
Modules/_testcapi/bytes.chttps://github.com/python/cpython/pull/157226/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
View file https://github.com/vstinner/cpython/blob/c810e97ab81a531edaadecccf41be8fe554f5841/Modules/_testcapi/bytes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157226/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157226/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
https://github.com/python/cpython/pull/157226/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
https://github.com/python/cpython/pull/157226/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
Objects/bytesobject.chttps://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
View file https://github.com/vstinner/cpython/blob/c810e97ab81a531edaadecccf41be8fe554f5841/Objects/bytesobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157226/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
https://github.com/python/cpython/pull/157226/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
Please reload this pagehttps://github.com/python/cpython/pull/157226/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.