René's URL Explorer Experiment


Title: gh-156002: Keep reading through third-party zipfile decompressors by rasmusfaber · Pull Request #157180 · python/cpython · GitHub

Open Graph Title: gh-156002: Keep reading through third-party zipfile decompressors by rasmusfaber · Pull Request #157180 · python/cpython

X Title: gh-156002: Keep reading through third-party zipfile decompressors by rasmusfaber · Pull Request #157180 · python/cpython

Description: Follow-up to GH-156003, as discussed in #156002 (comment). The change to bound decompression made ZipExtFile._read1() call decompress(data, max_length) on non-deflate decompressors and check needs_input. Many third-party decompressors (zipfile-zstd, zipfile-deflate64, and others) that are installed by replacing _get_decompressor() (zipfile-zstd, zipfile-deflate64, ...) do not support those, and end up failing with AttributeError: ... has no attribute '_needs_input'. This PR: gives _decompressor_needs_input() a default argument for decompressors that report neither needs_input nor _needs_input (no three-state return); decides once per decompressor instance, when ZipExtFile creates it (construction and seek()), whether it takes the bounded path: only decompressors that report needs_input do, which is all of the stdlib ones. Anything else is read unbounded, exactly as before GH-156003; adds a test with a fake third-party compression method whose decompressor has a one-argument decompress() and no needs_input; it fails with the AttributeError above without the fix. Verified with the real packages by applying the same three hunks to the 3.13 backport (#156738): a Deflate64 archive written by 7-Zip reads through zipfile-deflate64, and a Zstandard member reads through zipfile-zstd, on Python 3.13.15 where both currently fail. test_zipfile, test_zstd, test_zipimport, test_zipapp and test_shutil pass on a debug build of main with _zstd enabled; the *BoundedDecompressTests still pass for every stdlib method. Should ride along with the open backports #156737–#156741. Claude Fable 5.1 and GPT-6 Astra both reviewed and gave input, as well as drafted PR description and commit messages. Issue: gh-156002

Open Graph Description: Follow-up to GH-156003, as discussed in #156002 (comment). The change to bound decompression made ZipExtFile._read1() call decompress(data, max_length) on non-deflate decompressors and check needs_...

X Description: Follow-up to GH-156003, as discussed in #156002 (comment). The change to bound decompression made ZipExtFile._read1() call decompress(data, max_length) on non-deflate decompressors and check needs_...

Opengraph URL: https://github.com/python/cpython/pull/157180

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d3389b18-b5d9-19f6-d26a-ceabb8ff7b96
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDFB8:3DCD28:17E1CAB:1FA3830:6B020C1A
html-safe-nonce635abbd6729e65daa64e7e309457240eee73b02c39ceaed33265670b4ef025ca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkI4OjNEQ0QyODoxN0UxQ0FCOjFGQTM4MzA6NkIwMjBDMUEiLCJ2aXNpdG9yX2lkIjoiNDIwMzQ0NTYxNjM0NjUzMjg5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac50b315db1b9545e850f7ce110349d50d26ae445b0110883bd1e159f78b58889d
hovercard-subject-tagpull_request:4474573838
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157180/files
twitter:imagehttps://avatars.githubusercontent.com/u/2798829?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2798829?s=400&v=4
og:image:altFollow-up to GH-156003, as discussed in #156002 (comment). The change to bound decompression made ZipExtFile._read1() call decompress(data, max_length) on non-deflate decompressors and check needs_...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157180/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157180%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157180%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157180/files
Reloadhttps://github.com/python/cpython/pull/157180/files
Reloadhttps://github.com/python/cpython/pull/157180/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
rasmusfaber:gh-156002-third-party-decompressorshttps://github.com/rasmusfaber/cpython/tree/gh-156002-third-party-decompressors
Conversation 7 https://github.com/python/cpython/pull/157180
Commits 5 https://github.com/python/cpython/pull/157180/commits
Checks 60 https://github.com/python/cpython/pull/157180/checks
Files changed https://github.com/python/cpython/pull/157180/files
Please reload this pagehttps://github.com/python/cpython/pull/157180/files
gh-156002: Keep reading through third-party zipfile decompressors https://github.com/python/cpython/pull/157180/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/157180/files
77c81d7 gh-156002: Keep reading through third-party zipfile decompressors rasmusfaber Sep 8, 2026 https://github.com/python/cpython/pull/157180/commits/77c81d798953a62a689e29cf833ccfcf66671765
3c2b602 Rewind in the third-party decompressor test; wrap two long lines rasmusfaber Sep 8, 2026 https://github.com/python/cpython/pull/157180/commits/3c2b6023c8847136467a32381397f3e9d3554676
26d3267 Rename tests; check that the "compression" happened encukou Sep 9, 2026 https://github.com/python/cpython/pull/157180/commits/26d3267297896f82249d550cd4dc58109c043237
2146494 Make LZMADecompressor.needs_input public; simplify implementation encukou Sep 9, 2026 https://github.com/python/cpython/pull/157180/commits/214649445c65189cfe09fed29833ddcb1777644d
1431f15 Fix typos and other nits. rasmusfaber Sep 9, 2026 https://github.com/python/cpython/pull/157180/commits/1431f15a21e2bd4b4e114beef55f1ff34fab2dc0
Clear filters https://github.com/python/cpython/pull/157180/files
Please reload this pagehttps://github.com/python/cpython/pull/157180/files
Please reload this pagehttps://github.com/python/cpython/pull/157180/files
_py_warnings.py https://github.com/python/cpython/pull/157180/files#diff-b842f439dd72c6160fec74021d37a3ea7fef8e6786d8829512f04518645e1d00
test_core.py https://github.com/python/cpython/pull/157180/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
__init__.py https://github.com/python/cpython/pull/157180/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
2026-09-08-13-06-29.gh-issue-156002.vmOC8T.rst https://github.com/python/cpython/pull/157180/files#diff-5ba1114a0f20700d8d2c68b98634753dcdc8a0211985989feca6f23bdef7bd3d
Lib/_py_warnings.pyhttps://github.com/python/cpython/pull/157180/files#diff-b842f439dd72c6160fec74021d37a3ea7fef8e6786d8829512f04518645e1d00
View file https://github.com/rasmusfaber/cpython/blob/1431f15a21e2bd4b4e114beef55f1ff34fab2dc0/Lib/_py_warnings.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157180/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157180/files#diff-b842f439dd72c6160fec74021d37a3ea7fef8e6786d8829512f04518645e1d00
https://github.com/python/cpython/pull/157180/files#diff-b842f439dd72c6160fec74021d37a3ea7fef8e6786d8829512f04518645e1d00
https://github.com/python/cpython/pull/157180/files#diff-b842f439dd72c6160fec74021d37a3ea7fef8e6786d8829512f04518645e1d00
Lib/test/test_zipfile/test_core.pyhttps://github.com/python/cpython/pull/157180/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
View file https://github.com/rasmusfaber/cpython/blob/1431f15a21e2bd4b4e114beef55f1ff34fab2dc0/Lib/test/test_zipfile/test_core.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157180/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157180/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
https://github.com/python/cpython/pull/157180/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
https://github.com/python/cpython/pull/157180/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
https://github.com/python/cpython/pull/157180/files#diff-3f7f7f9e251efe3ca7872e540c7840c85d508fc11150926df502ced996b98e9f
Lib/zipfile/__init__.pyhttps://github.com/python/cpython/pull/157180/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
View file https://github.com/rasmusfaber/cpython/blob/1431f15a21e2bd4b4e114beef55f1ff34fab2dc0/Lib/zipfile/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157180/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157180/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/157180/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/157180/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/157180/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/157180/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/157180/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/157180/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
Misc/NEWS.d/next/Library/2026-09-08-13-06-29.gh-issue-156002.vmOC8T.rsthttps://github.com/python/cpython/pull/157180/files#diff-5ba1114a0f20700d8d2c68b98634753dcdc8a0211985989feca6f23bdef7bd3d
View file https://github.com/rasmusfaber/cpython/blob/1431f15a21e2bd4b4e114beef55f1ff34fab2dc0/Misc/NEWS.d/next/Library/2026-09-08-13-06-29.gh-issue-156002.vmOC8T.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157180/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/157180/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.