René's URL Explorer Experiment


Title: [3.14] gh-123018: Keep the libedit history file header when truncating (GH-157165) by miss-islington · Pull Request #157173 · python/cpython · GitHub

Open Graph Title: [3.14] gh-123018: Keep the libedit history file header when truncating (GH-157165) by miss-islington · Pull Request #157173 · python/cpython

X Title: [3.14] gh-123018: Keep the libedit history file header when truncating (GH-157165) by miss-islington · Pull Request #157173 · python/cpython

Description: libedit's history_truncate_file() keeps the last N lines of the file, which drops the "HiStOrY_V2" header line that its own write_history() emits and that its read_history() requires. So on a libedit build, readline.write_history_file() or readline.append_history_file() after readline.set_history_length() produced a file that readline.read_history_file() rejected with EINVAL. Under the libedit emulation, truncate the file ourselves and keep the header, resolving the default "~/.history" the same way libedit does. Apple's libedit fork already preserves the header, so the workaround is not compiled on macOS. (cherry picked from commit 2638785) Co-authored-by: Gregory P. Smith 68491+gpshead@users.noreply.github.com Issue: gh-123018

Open Graph Description: libedit's history_truncate_file() keeps the last N lines of the file, which drops the "HiStOrY_V2" header line that its own write_history() emits and that its read_history() requires....

X Description: libedit's history_truncate_file() keeps the last N lines of the file, which drops the "HiStOrY_V2" header line that its own write_history() emits and that its read_history...

Opengraph URL: https://github.com/python/cpython/pull/157173

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0d3d7d9e-3788-62a5-36c3-3d373a4f6ab1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA3A:842EC:35C26C1:47A5B6F:6B020B6F
html-safe-noncee70dd4ead9a06826abdec1a072efc6b5f46b29c5a78f79e44ff148ef7fb67531
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTNBOjg0MkVDOjM1QzI2QzE6NDdBNUI2Rjo2QjAyMEI2RiIsInZpc2l0b3JfaWQiOiI0NDk2OTg4NDAzMTg2OTI4NDk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd8bf682fd0f213f5f421262fa1d64e1a73bc3aea43748350a527b9e98d5db70a
hovercard-subject-tagpull_request:4471147087
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157173/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altlibedit's history_truncate_file() keeps the last N lines of the file, which drops the "HiStOrY_V2" header line that its own write_history() emits and that its read_history() requires....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157173/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157173%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157173%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157173/files
Reloadhttps://github.com/python/cpython/pull/157173/files
Reloadhttps://github.com/python/cpython/pull/157173/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-2638785-3.14https://github.com/miss-islington/cpython/tree/backport-2638785-3.14
Conversation 0 https://github.com/python/cpython/pull/157173
Commits 1 https://github.com/python/cpython/pull/157173/commits
Checks 48 https://github.com/python/cpython/pull/157173/checks
Files changed https://github.com/python/cpython/pull/157173/files
Please reload this pagehttps://github.com/python/cpython/pull/157173/files
[3.14] gh-123018: Keep the libedit history file header when truncating (GH-157165) https://github.com/python/cpython/pull/157173/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/157173/files
176ea2f gh-123018: Keep the libedit history file header when truncating (GH-1… gpshead Sep 8, 2026 https://github.com/python/cpython/pull/157173/commits/176ea2f485f8a200b7004b219b3368a0cbb73b6f
Clear filters https://github.com/python/cpython/pull/157173/files
Please reload this pagehttps://github.com/python/cpython/pull/157173/files
Please reload this pagehttps://github.com/python/cpython/pull/157173/files
test_readline.py https://github.com/python/cpython/pull/157173/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
2026-09-08-04-10-00.gh-issue-123018.hV2kQe.rst https://github.com/python/cpython/pull/157173/files#diff-9d999812680695d16fae2078a188b3273aa359d1c289885904710f78c2322c6f
readline.c https://github.com/python/cpython/pull/157173/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
Lib/test/test_readline.pyhttps://github.com/python/cpython/pull/157173/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
View file https://github.com/miss-islington/cpython/blob/176ea2f485f8a200b7004b219b3368a0cbb73b6f/Lib/test/test_readline.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157173/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157173/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
https://github.com/python/cpython/pull/157173/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
Misc/NEWS.d/next/Library/2026-09-08-04-10-00.gh-issue-123018.hV2kQe.rsthttps://github.com/python/cpython/pull/157173/files#diff-9d999812680695d16fae2078a188b3273aa359d1c289885904710f78c2322c6f
View file https://github.com/miss-islington/cpython/blob/176ea2f485f8a200b7004b219b3368a0cbb73b6f/Misc/NEWS.d/next/Library/2026-09-08-04-10-00.gh-issue-123018.hV2kQe.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157173/{{ revealButtonHref }}
Modules/readline.chttps://github.com/python/cpython/pull/157173/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
View file https://github.com/miss-islington/cpython/blob/176ea2f485f8a200b7004b219b3368a0cbb73b6f/Modules/readline.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157173/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157173/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
https://github.com/python/cpython/pull/157173/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
https://github.com/python/cpython/pull/157173/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
https://github.com/python/cpython/pull/157173/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
https://github.com/python/cpython/pull/157173/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
https://github.com/python/cpython/pull/157173/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
https://github.com/python/cpython/pull/157173/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
https://github.com/python/cpython/pull/157173/files#diff-c132c341140255d60e7d57d6d94ceb0b8fa364efac5bdbbd344e2c977c805144
Please reload this pagehttps://github.com/python/cpython/pull/157173/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.