René's URL Explorer Experiment


Title: gh-157161: Fix test_rollover_based_on_st_birthtime_only on slow machines by iamsharduld · Pull Request #157162 · python/cpython · GitHub

Open Graph Title: gh-157161: Fix test_rollover_based_on_st_birthtime_only on slow machines by iamsharduld · Pull Request #157162 · python/cpython

X Title: gh-157161: Fix test_rollover_based_on_st_birthtime_only on slow machines by iamsharduld · Pull Request #157162 · python/cpython

Description: The test looks for the rotated file by trying the timestamps of the last 5 seconds. The rotated file is named after the creation time of the log file (rolloverAt - interval, where rolloverAt was computed from the file's creation time), so it can only be found if the whole test took less than 5 seconds. Its nominal duration is 4.2 seconds of sleeps plus three handler set-ups, and on the failing CI job (diagnostics quoted in the issue) it took 6.07 seconds, so the file named after second 45 was never checked from second 51. This derives the search window from the time the test actually took, plus two seconds: one because the log file is created in setUp(), slightly before the test starts, and one for the one-second resolution of the names. Verified: With a 1.2 s slowdown injected into each add_record() (a 7.8 s test), the current test fails with exactly the CI message, No rotated files found, went back 5 seconds; with this change it passes. Without the slowdown it passes repeatedly, and the whole test_logging module passes with -u walltime. The June change in GH-150954 widened the window by one timestamp; this makes it follow the actual duration so that no fixed value needs to be tuned again. Issue: gh-157161

Open Graph Description: The test looks for the rotated file by trying the timestamps of the last 5 seconds. The rotated file is named after the creation time of the log file (rolloverAt - interval, where rolloverAt was co...

X Description: The test looks for the rotated file by trying the timestamps of the last 5 seconds. The rotated file is named after the creation time of the log file (rolloverAt - interval, where rolloverAt was co...

Opengraph URL: https://github.com/python/cpython/pull/157162

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9fcdb307-5821-4683-4cef-336c78b7e12f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCAB6:34DB8F:3252833:4345D84:6B01FF6A
html-safe-nonce8566568d6549b667f5aa5e431bb555497b88375eec436e837dc5c2a63e99a63c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUI2OjM0REI4RjozMjUyODMzOjQzNDVEODQ6NkIwMUZGNkEiLCJ2aXNpdG9yX2lkIjoiOTExNTQ5MTk4MjExNzA0NDA3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac58bb569c98fcacbcdea8ed4d8e04dd9615c2789becb506955ccd20d3c69c179f
hovercard-subject-tagpull_request:4470372141
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157162/files
twitter:imagehttps://avatars.githubusercontent.com/u/8417988?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8417988?s=400&v=4
og:image:altThe test looks for the rotated file by trying the timestamps of the last 5 seconds. The rotated file is named after the creation time of the log file (rolloverAt - interval, where rolloverAt was co...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157162/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157162%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157162%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157162/files
Reloadhttps://github.com/python/cpython/pull/157162/files
Reloadhttps://github.com/python/cpython/pull/157162/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
iamsharduldhttps://github.com/iamsharduld
python:mainhttps://github.com/python/cpython/tree/main
iamsharduld:fix-logging-birthtime-testhttps://github.com/iamsharduld/cpython/tree/fix-logging-birthtime-test
Conversation 7 https://github.com/python/cpython/pull/157162
Commits 3 https://github.com/python/cpython/pull/157162/commits
Checks 44 https://github.com/python/cpython/pull/157162/checks
Files changed https://github.com/python/cpython/pull/157162/files
Please reload this pagehttps://github.com/python/cpython/pull/157162/files
gh-157161: Fix test_rollover_based_on_st_birthtime_only on slow machines https://github.com/python/cpython/pull/157162/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/157162/files
34d838a gh-157161: Fix test_rollover_based_on_st_birthtime_only on slow machines iamsharduld Sep 8, 2026 https://github.com/python/cpython/pull/157162/commits/34d838a6e8a4196ad726484d2168da6921d742ab
dffb770 Address review: name the margin and explain the two additions iamsharduld Sep 9, 2026 https://github.com/python/cpython/pull/157162/commits/dffb770380cda5ab185e60acdf3808c429365981
4e22320 Remove the NEWS entry iamsharduld Sep 9, 2026 https://github.com/python/cpython/pull/157162/commits/4e2232075f6b74a2c2a24f644fa55ed4bbe8cbc7
Clear filters https://github.com/python/cpython/pull/157162/files
Please reload this pagehttps://github.com/python/cpython/pull/157162/files
Please reload this pagehttps://github.com/python/cpython/pull/157162/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L537
Lib/test/test_logging.pyhttps://github.com/python/cpython/pull/157162/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
View file https://github.com/python/cpython/blob/4e2232075f6b74a2c2a24f644fa55ed4bbe8cbc7/Lib/test/test_logging.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157162/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157162/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
https://github.com/python/cpython/pull/157162/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
https://github.com/python/cpython/pull/157162/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
Please reload this pagehttps://github.com/python/cpython/pull/157162/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.