Title: gh-157157: Make test_taskgroup_cancel_keeps_outer_cancellation deterministic by iamsharduld · Pull Request #157158 · python/cpython · GitHub
Open Graph Title: gh-157157: Make test_taskgroup_cancel_keeps_outer_cancellation deterministic by iamsharduld · Pull Request #157158 · python/cpython
X Title: gh-157157: Make test_taskgroup_cancel_keeps_outer_cancellation deterministic by iamsharduld · Pull Request #157158 · python/cpython
Description: Fixes the timing dependence described in the issue: the test cancelled the parent task from outside after await asyncio.sleep(0.01), and lost the cancellation message whenever the loop stalled for more than 10 ms before the body task first ran (the mechanism, and a reproducer that stalls the loop with time.sleep(), are in the issue). The test now synchronizes on two events instead of sleeping. The child signals from its finally block that the group is cancelling, which by then has cancelled the parent task and is waiting for the child, and waits there until the test releases it. Only then does the test cancel the parent task from outside. The ordering is fixed by the callback queue, not by time, so it holds on any build speed and for both task implementations. Checked: The rewritten test passes for TestTaskGroup and TestEagerTaskTaskGroup, 10 of 10 repeated runs, and the whole test_asyncio.test_taskgroups module passes. With the gh-155433 fix reverted locally, the rewritten test still fails in both classes (CancelledError not raised), so it keeps guarding the bug it was written for. The event-based ordering was also verified in a standalone harness with the same 20 ms loop stall that makes the current test fail. Since the original test was added by the gh-155433 fix, this likely wants the same backports. Issue: gh-157157
Open Graph Description: Fixes the timing dependence described in the issue: the test cancelled the parent task from outside after await asyncio.sleep(0.01), and lost the cancellation message whenever the loop stalled for ...
X Description: Fixes the timing dependence described in the issue: the test cancelled the parent task from outside after await asyncio.sleep(0.01), and lost the cancellation message whenever the loop stalled for ...
Opengraph URL: https://github.com/python/cpython/pull/157158
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f7201fc6-a141-35a1-9483-4264632a248f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A780:3D97C8:36D29AA:48E61B0:6B020B27 |
| html-safe-nonce | fa1057a4eb5dd73ad007227e3ff7023b4d56fa3d7c29b3ce5d224acd5ae4c7e0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzgwOjNEOTdDODozNkQyOUFBOjQ4RTYxQjA6NkIwMjBCMjciLCJ2aXNpdG9yX2lkIjoiOTE1NDU1MDkwNDMzMzE0MjgyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3458c064f53844867d882fe06539c6b1a281a8613b3ed774d08ad0a50a324d18 |
| hovercard-subject-tag | pull_request:4470188453 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/157158/files |
| twitter:image | https://avatars.githubusercontent.com/u/8417988?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8417988?s=400&v=4 |
| og:image:alt | Fixes the timing dependence described in the issue: the test cancelled the parent task from outside after await asyncio.sleep(0.01), and lost the cancellation message whenever the loop stalled for ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width