René's URL Explorer Experiment


Title: gh-156933: Widen narrow integer results in ctypes callbacks by lazerg · Pull Request #157045 · python/cpython · GitHub

Open Graph Title: gh-156933: Widen narrow integer results in ctypes callbacks by lazerg · Pull Request #157045 · python/cpython

X Title: gh-156933: Widen narrow integer results in ctypes callbacks by lazerg · Pull Request #157045 · python/cpython

Description: _CallPythonObject() only wrote restype->size bytes into the closure's result buffer, leaving the unused high-order bits of the ffi_arg-sized register untouched. libffi's ffi_prep_closure_loc() documents that integral types narrower than a machine register must be widened to fill it, sign-extending signed types. On architectures that always read the full register for narrow return values (s390x), this leaves garbage in the high bits, which broke libclang callbacks used by cindex.py. The fix widens narrow integer results into a register-sized buffer before writing them back, sign- or zero-extending depending on the type, replacing the old big-endian-only pointer offset that didn't actually widen anything. Fixes #156933. Issue: gh-156933

Open Graph Description: _CallPythonObject() only wrote restype->size bytes into the closure's result buffer, leaving the unused high-order bits of the ffi_arg-sized register untouched. libffi's ffi_prep_closure...

X Description: _CallPythonObject() only wrote restype->size bytes into the closure's result buffer, leaving the unused high-order bits of the ffi_arg-sized register untouched. libffi's ffi_...

Opengraph URL: https://github.com/python/cpython/pull/157045

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e2a55bdf-e211-ccb3-e386-26ae5607e91e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8ED4:19E4BB:3F59820:50B6778:6B021E79
html-safe-nonce2e1972c7b1af6349170d7568d5f812085957119332fe8b61e76fa3354be44a84
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUQ0OjE5RTRCQjozRjU5ODIwOjUwQjY3Nzg6NkIwMjFFNzkiLCJ2aXNpdG9yX2lkIjoiNjExMDQzMTA0OTE2NjQzNDQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbe7273f6b3a733a3bd96added16240d12ca22e5bb51f4b8bc37d2f3f3d3d2bfe
hovercard-subject-tagpull_request:4457860838
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157045/files
twitter:imagehttps://avatars.githubusercontent.com/u/20501725?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20501725?s=400&v=4
og:image:alt_CallPythonObject() only wrote restype->size bytes into the closure's result buffer, leaving the unused high-order bits of the ffi_arg-sized register untouched. libffi's ffi_prep_closure...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157045/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157045%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157045%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157045/files
Reloadhttps://github.com/python/cpython/pull/157045/files
Reloadhttps://github.com/python/cpython/pull/157045/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ZeroIntensityhttps://github.com/ZeroIntensity
python:mainhttps://github.com/python/cpython/tree/main
lazerg:fix/issue-156933-ctypes-callback-widenhttps://github.com/lazerg/cpython/tree/fix/issue-156933-ctypes-callback-widen
Conversation 32 https://github.com/python/cpython/pull/157045
Commits 6 https://github.com/python/cpython/pull/157045/commits
Checks 69 https://github.com/python/cpython/pull/157045/checks
Files changed https://github.com/python/cpython/pull/157045/files
Please reload this pagehttps://github.com/python/cpython/pull/157045/files
gh-156933: Widen narrow integer results in ctypes callbacks https://github.com/python/cpython/pull/157045/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/157045/files
72a218b gh-156933: Widen narrow integer results in ctypes callbacks lazerg Sep 6, 2026 https://github.com/python/cpython/pull/157045/commits/72a218b93a538cfe0bf079a74f03401a504c178f
ebf7568 Add test for widened narrow int callback results lazerg Sep 25, 2026 https://github.com/python/cpython/pull/157045/commits/ebf756899ec9383fd99a02a71cedb06b16ac79c6
9338911 Only run the widening test on s390x lazerg Sep 25, 2026 https://github.com/python/cpython/pull/157045/commits/933891109a29e37a10937606e44cf779bd82ac57
d54ca1f Address review comments lazerg Sep 27, 2026 https://github.com/python/cpython/pull/157045/commits/d54ca1f6f1f0c4de4b99abe5ce2ee29e84377ae9
6490b5f Use wrap_dll_function in the widening test lazerg Sep 27, 2026 https://github.com/python/cpython/pull/157045/commits/6490b5f46e77593791142e4f8dd5623abd5f562b
5693c85 Merge branch 'main' into fix/issue-156933-ctypes-callback-widen ZeroIntensity Sep 27, 2026 https://github.com/python/cpython/pull/157045/commits/5693c85301daa4736fd5248f5042274d414d4423
Clear filters https://github.com/python/cpython/pull/157045/files
Please reload this pagehttps://github.com/python/cpython/pull/157045/files
Please reload this pagehttps://github.com/python/cpython/pull/157045/files
test_callbacks.py https://github.com/python/cpython/pull/157045/files#diff-23e4c416aa48510fd9837e1f68c38ee3b975251726ec1519b1abdd90d462b239
2026-09-07-00-21-31.gh-issue-156933.OalCjC.rst https://github.com/python/cpython/pull/157045/files#diff-a0971cda722e0e8845db390ec591067e7081c5457d148b647f8ab675d6636348
_ctypes_test.c https://github.com/python/cpython/pull/157045/files#diff-1e8f35693c2fa62ceeba89a62ec7635326339a5fc022ab03146276e3bebae3dd
callbacks.c https://github.com/python/cpython/pull/157045/files#diff-706e65ee28911740bf638707e19578b8182e57c6a8a9a4a91105d825f95a139d
Lib/test/test_ctypes/test_callbacks.pyhttps://github.com/python/cpython/pull/157045/files#diff-23e4c416aa48510fd9837e1f68c38ee3b975251726ec1519b1abdd90d462b239
View file https://github.com/lazerg/cpython/blob/5693c85301daa4736fd5248f5042274d414d4423/Lib/test/test_ctypes/test_callbacks.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157045/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157045/files#diff-23e4c416aa48510fd9837e1f68c38ee3b975251726ec1519b1abdd90d462b239
https://github.com/python/cpython/pull/157045/files#diff-23e4c416aa48510fd9837e1f68c38ee3b975251726ec1519b1abdd90d462b239
https://github.com/python/cpython/pull/157045/files#diff-23e4c416aa48510fd9837e1f68c38ee3b975251726ec1519b1abdd90d462b239
Misc/NEWS.d/next/Library/2026-09-07-00-21-31.gh-issue-156933.OalCjC.rsthttps://github.com/python/cpython/pull/157045/files#diff-a0971cda722e0e8845db390ec591067e7081c5457d148b647f8ab675d6636348
View file https://github.com/lazerg/cpython/blob/5693c85301daa4736fd5248f5042274d414d4423/Misc/NEWS.d/next/Library/2026-09-07-00-21-31.gh-issue-156933.OalCjC.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157045/{{ revealButtonHref }}
Modules/_ctypes/_ctypes_test.chttps://github.com/python/cpython/pull/157045/files#diff-1e8f35693c2fa62ceeba89a62ec7635326339a5fc022ab03146276e3bebae3dd
View file https://github.com/lazerg/cpython/blob/5693c85301daa4736fd5248f5042274d414d4423/Modules/_ctypes/_ctypes_test.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157045/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157045/files#diff-1e8f35693c2fa62ceeba89a62ec7635326339a5fc022ab03146276e3bebae3dd
https://github.com/python/cpython/pull/157045/files#diff-1e8f35693c2fa62ceeba89a62ec7635326339a5fc022ab03146276e3bebae3dd
Modules/_ctypes/callbacks.chttps://github.com/python/cpython/pull/157045/files#diff-706e65ee28911740bf638707e19578b8182e57c6a8a9a4a91105d825f95a139d
View file https://github.com/lazerg/cpython/blob/5693c85301daa4736fd5248f5042274d414d4423/Modules/_ctypes/callbacks.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157045/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157045/files#diff-706e65ee28911740bf638707e19578b8182e57c6a8a9a4a91105d825f95a139d
https://github.com/python/cpython/pull/157045/files#diff-706e65ee28911740bf638707e19578b8182e57c6a8a9a4a91105d825f95a139d
https://github.com/python/cpython/pull/157045/files#diff-706e65ee28911740bf638707e19578b8182e57c6a8a9a4a91105d825f95a139d
https://github.com/python/cpython/pull/157045/files#diff-706e65ee28911740bf638707e19578b8182e57c6a8a9a4a91105d825f95a139d
https://github.com/python/cpython/pull/157045/files#diff-706e65ee28911740bf638707e19578b8182e57c6a8a9a4a91105d825f95a139d
Please reload this pagehttps://github.com/python/cpython/pull/157045/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.