René's URL Explorer Experiment


Title: bpo-15088 : Remove PyGen_NeedsFinalizing() by nanjekyejoannah · Pull Request #15702 · python/cpython · GitHub

Open Graph Title: bpo-15088 : Remove PyGen_NeedsFinalizing() by nanjekyejoannah · Pull Request #15702 · python/cpython

X Title: bpo-15088 : Remove PyGen_NeedsFinalizing() by nanjekyejoannah · Pull Request #15702 · python/cpython

Description: I made PyGen_NeedsFinalizing() internal instead of deleting the logic all together much as the function is not called anywhere in the codebase. Should I have done the later? @vstinner @pitrou Edit: We decided to remove it all together. https://bugs.python.org/issue15088

Open Graph Description: I made PyGen_NeedsFinalizing() internal instead of deleting the logic all together much as the function is not called anywhere in the codebase. Should I have done the later? @vstinner @pitrou Edit:...

X Description: I made PyGen_NeedsFinalizing() internal instead of deleting the logic all together much as the function is not called anywhere in the codebase. Should I have done the later? @vstinner @pitrou Edit:...

Opengraph URL: https://github.com/python/cpython/pull/15702

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:294fbefb-ceb6-c5ab-3c5f-42419c0c111e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF9E:286F17:143B1F4:1BE1B6A:6A4DEB13
html-safe-noncedd1a2f49c281c0a3b043b819371a22388afa1186263cbb686ecabe4c40b74efc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjlFOjI4NkYxNzoxNDNCMUY0OjFCRTFCNkE6NkE0REVCMTMiLCJ2aXNpdG9yX2lkIjoiNTExNzU1NDMyOTI1OTk5Mzg3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace4b11f8c3576f5700801fc4c64a07c95a6bb39bf841b41bccdaf1e861d3a28bb
hovercard-subject-tagpull_request:314527767
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/15702/files
twitter:imagehttps://avatars.githubusercontent.com/u/33177550?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/33177550?s=400&v=4
og:image:altI made PyGen_NeedsFinalizing() internal instead of deleting the logic all together much as the function is not called anywhere in the codebase. Should I have done the later? @vstinner @pitrou Edit:...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/15702/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15702%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15702%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/15702/files
Reloadhttps://github.com/python/cpython/pull/15702/files
Reloadhttps://github.com/python/cpython/pull/15702/files
Please reload this pagehttps://github.com/python/cpython/pull/15702/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/15702/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
nanjekyejoannah:issue15088https://github.com/nanjekyejoannah/cpython/tree/issue15088
Conversation 16 https://github.com/python/cpython/pull/15702
Commits 10 https://github.com/python/cpython/pull/15702/commits
Checks 0 https://github.com/python/cpython/pull/15702/checks
Files changed https://github.com/python/cpython/pull/15702/files
Please reload this pagehttps://github.com/python/cpython/pull/15702/files
bpo-15088 : Remove PyGen_NeedsFinalizing() https://github.com/python/cpython/pull/15702/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/15702/files
46c15d6 Remove PyGen_NeedsFinalizing() nanjekyejoannah Sep 5, 2019 https://github.com/python/cpython/pull/15702/commits/46c15d6ca665da149523ea66b8f2c49a404c52d4
4a0d82f 📜🤖 Added by blurb_it. blurb-it[bot] Sep 5, 2019 https://github.com/python/cpython/pull/15702/commits/4a0d82fab4e7bbd6819973cef40b2970fb41822f
e9e0347 Update news nanjekyejoannah Sep 5, 2019 https://github.com/python/cpython/pull/15702/commits/e9e0347239ae605ff7ea495a6b10bf060d60d14c
bfde748 Merge branch 'issue15088' of https://github.com/nanjekyejoannah/cpyth… nanjekyejoannah Sep 5, 2019 https://github.com/python/cpython/pull/15702/commits/bfde748fba7204d074e32f811474dd315b629eb1
775e796 Deprecate PyGen_NeedsFinalizing() nanjekyejoannah Sep 5, 2019 https://github.com/python/cpython/pull/15702/commits/775e796a094897d744cd9c574f6bb58400ab25af
6671811 Remove the C function PyGen_NeedsFinalizing nanjekyejoannah Sep 5, 2019 https://github.com/python/cpython/pull/15702/commits/6671811fd629460b5eca57ce14a2a9339908c27a
8186611 come clean nanjekyejoannah Sep 5, 2019 https://github.com/python/cpython/pull/15702/commits/8186611099005f85a13556ef017626dd23a83d2c
a58af5e Merge branch 'master' of https://github.com/python/cpython into issue… nanjekyejoannah Sep 5, 2019 https://github.com/python/cpython/pull/15702/commits/a58af5e587118e50ec0a31f3411a4b91ea3eecb4
729b48e resolve merge conflict nanjekyejoannah Sep 5, 2019 https://github.com/python/cpython/pull/15702/commits/729b48ed2ab5f9c745f18a6ddb01a26f404e82c2
4dd10ac Update documentation nanjekyejoannah Sep 6, 2019 https://github.com/python/cpython/pull/15702/commits/4dd10ac137ebd9714c001bbfc2e3e3ad2af0ffd1
Clear filters https://github.com/python/cpython/pull/15702/files
Please reload this pagehttps://github.com/python/cpython/pull/15702/files
Please reload this pagehttps://github.com/python/cpython/pull/15702/files
3.9.rst https://github.com/python/cpython/pull/15702/files#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36
genobject.h https://github.com/python/cpython/pull/15702/files#diff-9e18ef320c69b6c5e1aa36a755b3610d898e2940ddc3bd34cee6e585425dff89
2019-09-05-14-17-21.bpo-15088.plt8Em.rst https://github.com/python/cpython/pull/15702/files#diff-50d6e147a2f1333416854ce717ca2ee671186a22e7a5430b519b081547752212
genobject.c https://github.com/python/cpython/pull/15702/files#diff-2a0c449b68605ebd0872fd232e60ce7e838a77782a6d2e364764f99514fb508a
ceval.c https://github.com/python/cpython/pull/15702/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
Doc/whatsnew/3.9.rsthttps://github.com/python/cpython/pull/15702/files#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36
View file https://github.com/nanjekyejoannah/cpython/blob/4dd10ac137ebd9714c001bbfc2e3e3ad2af0ffd1/Doc/whatsnew/3.9.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15702/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15702/files#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36
https://github.com/python/cpython/pull/15702/files#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36
Include/genobject.hhttps://github.com/python/cpython/pull/15702/files#diff-9e18ef320c69b6c5e1aa36a755b3610d898e2940ddc3bd34cee6e585425dff89
View file https://github.com/nanjekyejoannah/cpython/blob/4dd10ac137ebd9714c001bbfc2e3e3ad2af0ffd1/Include/genobject.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15702/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15702/files#diff-9e18ef320c69b6c5e1aa36a755b3610d898e2940ddc3bd34cee6e585425dff89
https://github.com/python/cpython/pull/15702/files#diff-9e18ef320c69b6c5e1aa36a755b3610d898e2940ddc3bd34cee6e585425dff89
Misc/NEWS.d/next/C API/2019-09-05-14-17-21.bpo-15088.plt8Em.rsthttps://github.com/python/cpython/pull/15702/files#diff-50d6e147a2f1333416854ce717ca2ee671186a22e7a5430b519b081547752212
View file https://github.com/nanjekyejoannah/cpython/blob/4dd10ac137ebd9714c001bbfc2e3e3ad2af0ffd1/Misc/NEWS.d/next/C%20API/2019-09-05-14-17-21.bpo-15088.plt8Em.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15702/{{ revealButtonHref }}
Objects/genobject.chttps://github.com/python/cpython/pull/15702/files#diff-2a0c449b68605ebd0872fd232e60ce7e838a77782a6d2e364764f99514fb508a
View file https://github.com/nanjekyejoannah/cpython/blob/4dd10ac137ebd9714c001bbfc2e3e3ad2af0ffd1/Objects/genobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15702/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15702/files#diff-2a0c449b68605ebd0872fd232e60ce7e838a77782a6d2e364764f99514fb508a
https://github.com/python/cpython/pull/15702/files#diff-2a0c449b68605ebd0872fd232e60ce7e838a77782a6d2e364764f99514fb508a
Python/ceval.chttps://github.com/python/cpython/pull/15702/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
View file https://github.com/nanjekyejoannah/cpython/blob/4dd10ac137ebd9714c001bbfc2e3e3ad2af0ffd1/Python/ceval.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15702/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15702/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com/python/cpython/pull/15702/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.