René's URL Explorer Experiment


Title: gh-157006: Clear PYTHON* env vars in test_embed · Pull Request #157010 · python/cpython · GitHub

Open Graph Title: gh-157006: Clear PYTHON* env vars in test_embed · Pull Request #157010 · python/cpython

X Title: gh-157006: Clear PYTHON* env vars in test_embed · Pull Request #157010 · python/cpython

Description: My test_embed was failing because VS Code's shell integration sets PYTHONSTARTUP in the environment. The embedded interpreter picks it up and runs the startup script, which prints extra text before the expected "ok! Py_RunMain() returned 123", causing the assertion to fail. Detailed root cause analysis: VS Code shell integration sets PYTHONSTARTUP to a script that prints something like "Ctrl click to launch VS Code Native REPL". When test_embed runs _testembed via run_embedded_interpreter(), the method passes env=None to subprocess.Popen, which inherits the full parent environment. The embedded interpreter then sees PYTHONSTARTUP and executes the startup script before running the actual test code. The startup script's output is prepended to stdout, so check_program_exitcode() receives: "Ctrl click to launch VS Code Native REPL\nok! Py_RunMain() returned 123" instead of the expected: "ok! Py_RunMain() returned 123" The assertion self.assertEqual(out.rstrip(), 'ok! Py_RunMain() returned 123') then fails. This only affects tests that go through run_embedded_interpreter() without passing an explicit env. Tests that already call remove_python_envvars() (e.g., the config snapshot tests around line 878) are not affected. There is also a secondary issue in test_init_run_main_startup_exitcode: it builds its env from dict(os.environ), which copies the parent's PYTHONSTARTUP before overriding it with the test's own startup file. If the parent's PYTHONSTARTUP script produces output, it would also pollute the test's expected output. Changes: run_embedded_interpreter(): when env is None, default to remove_python_envvars() instead of inheriting os.environ. This strips all PYTHON* variables (PYTHONSTARTUP, PYTHONPATH, PYTHONHOME, etc.) that could affect the embedded interpreter's behavior. This is consistent with how other tests in the same file already isolate themselves from the parent environment. test_init_run_main_startup_exitcode: changed dict(os.environ) to remove_python_envvars() as the base env, then sets PYTHONSTARTUP to the test's own startup file. This ensures the test is fully isolated from whatever PYTHON* vars the runner happens to have. Closes #157006 Note: this is a resubmission of #157008. The description on that PR was a rough draft that I hadn't finished polishing when it was closed. Note: AI tools were used only to assist in problem analysis. The fix and code changes were determined and verified independently. Issue: gh-157006

Open Graph Description: My test_embed was failing because VS Code's shell integration sets PYTHONSTARTUP in the environment. The embedded interpreter picks it up and runs the startup script, which prints extra text be...

X Description: My test_embed was failing because VS Code's shell integration sets PYTHONSTARTUP in the environment. The embedded interpreter picks it up and runs the startup script, which prints extra tex...

Opengraph URL: https://github.com/python/cpython/pull/157010

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dcc0942d-1c12-6be6-3e96-38a56ccd5341
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5B4:1D86C4:3E0A540:4ECD6E8:6B020FFA
html-safe-noncec1c386d370dfb07bf8df0007c8482da15ae5ff16bead8e82bab72e487170c194
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUI0OjFEODZDNDozRTBBNTQwOjRFQ0Q2RTg6NkIwMjBGRkEiLCJ2aXNpdG9yX2lkIjoiMzI0NzA0OTMwMzk2NDkxMzY1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8b22c12b3910cd0025565e45541788f1aea8b2591dfe01c0f66b4a5a65a7c093
hovercard-subject-tagpull_request:4453192335
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/157010/files
twitter:imagehttps://avatars.githubusercontent.com/u/10137?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10137?s=400&v=4
og:image:altMy test_embed was failing because VS Code's shell integration sets PYTHONSTARTUP in the environment. The embedded interpreter picks it up and runs the startup script, which prints extra text be...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/157010/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157010%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F157010%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/157010/files
Reloadhttps://github.com/python/cpython/pull/157010/files
Reloadhttps://github.com/python/cpython/pull/157010/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ghosthttps://github.com/ghost
python:mainhttps://github.com/python/cpython/tree/main
don012rac3:gh-157006-fix-test-embed-v2https://github.com/don012rac3/cpython/tree/gh-157006-fix-test-embed-v2
Conversation 0 https://github.com/python/cpython/pull/157010
Commits 1 https://github.com/python/cpython/pull/157010/commits
Checks 153 https://github.com/python/cpython/pull/157010/checks
Files changed https://github.com/python/cpython/pull/157010/files
Please reload this pagehttps://github.com/python/cpython/pull/157010/files
gh-157006: Clear PYTHON* env vars in test_embed https://github.com/python/cpython/pull/157010/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/157010/files
2a1e48f gh-157006: Clear PYTHONSTARTUP and other PYTHON* env vars in test_embed Sep 5, 2026 https://github.com/python/cpython/pull/157010/commits/2a1e48fabcc696ade1aac9ac6c6c4a4fc980e365
Clear filters https://github.com/python/cpython/pull/157010/files
Please reload this pagehttps://github.com/python/cpython/pull/157010/files
Please reload this pagehttps://github.com/python/cpython/pull/157010/files
test_embed.py https://github.com/python/cpython/pull/157010/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
2026-09-06-12-00-00.gh-issue-157006.Xk9mPq.rst https://github.com/python/cpython/pull/157010/files#diff-7f5a1b11a2977c4d21acfbe0dcec1975b72240af2119d336b7d93b2eb9a34420
Lib/test/test_embed.pyhttps://github.com/python/cpython/pull/157010/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
View file https://github.com/don012rac3/cpython/blob/2a1e48fabcc696ade1aac9ac6c6c4a4fc980e365/Lib/test/test_embed.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157010/{{ revealButtonHref }}
https://github.com/python/cpython/pull/157010/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
https://github.com/python/cpython/pull/157010/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
https://github.com/python/cpython/pull/157010/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
https://github.com/python/cpython/pull/157010/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
Misc/NEWS.d/next/Tests/2026-09-06-12-00-00.gh-issue-157006.Xk9mPq.rsthttps://github.com/python/cpython/pull/157010/files#diff-7f5a1b11a2977c4d21acfbe0dcec1975b72240af2119d336b7d93b2eb9a34420
View file https://github.com/don012rac3/cpython/blob/2a1e48fabcc696ade1aac9ac6c6c4a4fc980e365/Misc/NEWS.d/next/Tests/2026-09-06-12-00-00.gh-issue-157006.Xk9mPq.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/157010/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/157010/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.