René's URL Explorer Experiment


Title: bpo-38037: Fix reference counters in signal module · Pull Request #15701 · python/cpython · GitHub

Open Graph Title: bpo-38037: Fix reference counters in signal module · Pull Request #15701 · python/cpython

X Title: bpo-38037: Fix reference counters in signal module · Pull Request #15701 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Only 3.8 and 3.9 branches are affected. https://bugs.python.org/issue38037

X Description: Only 3.8 and 3.9 branches are affected. https://bugs.python.org/issue38037

Opengraph URL: https://github.com/python/cpython/pull/15701

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d02b30ab-e57e-112b-9f4b-2cd8ea524719
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8A2:276C3B:2288216:31E4E58:6A550A3C
html-safe-noncec90d902feb8e3f07b4271764daa9d1a992ccbc12c91c2001e87f82c4f9b9878e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEEyOjI3NkMzQjoyMjg4MjE2OjMxRTRFNTg6NkE1NTBBM0MiLCJ2aXNpdG9yX2lkIjoiMzk4MTI1ODE0MDU0NTI1NTk5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac81c04ea087271a36ab35da1d78267c98b41f0a45d7d645a88326d2bc07eafd7d
hovercard-subject-tagpull_request:314526411
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/15701/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/718492857d657e2ebf84c4e9bdef68233ca21bdb6379dfe70e185d98149e0fe6/python/cpython/pull/15701
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/718492857d657e2ebf84c4e9bdef68233ca21bdb6379dfe70e185d98149e0fe6/python/cpython/pull/15701
og:image:altOnly 3.8 and 3.9 branches are affected. https://bugs.python.org/issue38037
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None682d273eacb2ac51680c6eb9c0b270f029f7ce74c32090f319083c34497e28a5
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0f2adbaa4b43ea302b02981f637a782ae92ed6dc
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/15701#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15701
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15701
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/15701
Reloadhttps://github.com/python/cpython/pull/15701
Reloadhttps://github.com/python/cpython/pull/15701
Please reload this pagehttps://github.com/python/cpython/pull/15701
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/15701
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
ghosthttps://github.com/ghost
masterhttps://github.com/python/cpython/tree/master
Conversationhttps://github.com/python/cpython/pull/15701
Commits6 (6)https://github.com/python/cpython/pull/15701/commits
Checkshttps://github.com/python/cpython/pull/15701/checks
Files changedhttps://github.com/python/cpython/pull/15701/files
bpo-38037: Fix reference counters in signal modulehttps://github.com/python/cpython/pull/15701#top
ghosthttps://github.com/ghost
masterhttps://github.com/python/cpython/tree/master
https://github.com/ghost
ghosthttps://github.com/ghost
Sep 5, 2019https://github.com/python/cpython/pull/15701#issue-489781386
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://bugs.python.org/issue38037https://bugs.python.org/issue38037
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/wjssz
Fix ref leaks in signal modulehttps://github.com/python/cpython/pull/15701/commits/3b768dbbb2a7965157f89404aa6c5fdcce3ffbc4
3b768dbhttps://github.com/python/cpython/pull/15701/commits/3b768dbbb2a7965157f89404aa6c5fdcce3ffbc4
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 5, 2019https://github.com/python/cpython/pull/15701#event-2610803988
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 5, 2019https://github.com/python/cpython/pull/15701#event-2610804163
https://github.com/wjssz
add another onehttps://github.com/python/cpython/pull/15701/commits/27beec8bf75c8e583aae947ec1ef422637ffd5e6
27beec8https://github.com/python/cpython/pull/15701/commits/27beec8bf75c8e583aae947ec1ef422637ffd5e6
https://github.com/nanjekyejoannah
nanjekyejoannahhttps://github.com/nanjekyejoannah
berkerpeksaghttps://github.com/berkerpeksag
September 5, 2019 15:22https://github.com/python/cpython/pull/15701#event-2611123953
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Sep 5, 2019https://github.com/python/cpython/pull/15701#event-2612621381
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Sep 5, 2019 https://github.com/python/cpython/pull/15701#pullrequestreview-284596405
View reviewed changes https://github.com/python/cpython/pull/15701/files/27beec8bf75c8e583aae947ec1ef422637ffd5e6
brandtbucherhttps://github.com/brandtbucher
https://github.com/python/cpython/pull/15701#pullrequestreview-284596405
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 5, 2019https://github.com/python/cpython/pull/15701#event-2612734593
https://github.com/ghost
ghosthttps://github.com/ghost
Sep 6, 2019https://github.com/python/cpython/pull/15701#issuecomment-528691389
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/python/cpython/blob/3.8/Python/modsupport.c#L654https://github.com/python/cpython/blob/3.8/Python/modsupport.c#L654
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/ghost
ghosthttps://github.com/ghost
Sep 6, 2019https://github.com/python/cpython/pull/15701#issuecomment-528708201
9541bd3https://github.com/python/cpython/commit/9541bd321a94f13dc41163a5d7a1a847816fac84
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Sep 6, 2019https://github.com/python/cpython/pull/15701#event-2613187064
https://github.com/wjssz
remove a local variable xhttps://github.com/python/cpython/pull/15701/commits/c3a436bb369c7535aa579473dfeb23a7fd06f950
c3a436bhttps://github.com/python/cpython/pull/15701/commits/c3a436bb369c7535aa579473dfeb23a7fd06f950
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Sep 6, 2019https://github.com/python/cpython/pull/15701#issuecomment-528734487
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/python/cpython/blob/3.8/Python/modsupport.c#L654https://github.com/python/cpython/blob/3.8/Python/modsupport.c#L654
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Sep 6, 2019https://github.com/python/cpython/pull/15701#issuecomment-528743948
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://bugs.python.org/issue34037https://bugs.python.org/issue34037
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/wjssz
Py_DECREF if PyModule_AddObject failshttps://github.com/python/cpython/pull/15701/commits/a0f335c74c2e8a6544b75f30c1791d0a7c3d41a8
a0f335chttps://github.com/python/cpython/pull/15701/commits/a0f335c74c2e8a6544b75f30c1791d0a7c3d41a8
https://github.com/ghost
ghosthttps://github.com/ghost
Sep 6, 2019https://github.com/python/cpython/pull/15701#issuecomment-528832021
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 6, 2019 https://github.com/python/cpython/pull/15701#pullrequestreview-284941082
View reviewed changes https://github.com/python/cpython/pull/15701/files/a0f335c74c2e8a6544b75f30c1791d0a7c3d41a8
Modules/signalmodule.chttps://github.com/python/cpython/pull/15701/files/a0f335c74c2e8a6544b75f30c1791d0a7c3d41a8#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 6, 2019 https://github.com/python/cpython/pull/15701#pullrequestreview-284944402
View reviewed changes https://github.com/python/cpython/pull/15701/files/a0f335c74c2e8a6544b75f30c1791d0a7c3d41a8
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/15701#pullrequestreview-284944402
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@nanjekyejoannahhttps://github.com/nanjekyejoannah
Please reload this pagehttps://github.com/python/cpython/pull/15701
Misc/NEWS.d/next/Library/2019-09-05-22-09-38.bpo-38037.xA66nY.rsthttps://github.com/python/cpython/pull/15701/files/a0f335c74c2e8a6544b75f30c1791d0a7c3d41a8#diff-d0c88715e3a4ccb6e41f65b2baeeca9f1be1890595137e0321480472bb83fa76
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 6, 2019https://github.com/python/cpython/pull/15701#event-2614780463
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Sep 6, 2019 https://github.com/python/cpython/pull/15701#pullrequestreview-284945281
View reviewed changes https://github.com/python/cpython/pull/15701/files/a0f335c74c2e8a6544b75f30c1791d0a7c3d41a8
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Sep 6, 2019https://github.com/python/cpython/pull/15701#issuecomment-528911235
Please reload this pagehttps://github.com/python/cpython/pull/15701
@vstinnerhttps://github.com/vstinner
https://bugs.python.org/issue26868https://bugs.python.org/issue26868
Please reload this pagehttps://github.com/python/cpython/pull/15701
September 7, 2019 10:05https://github.com/python/cpython/pull/15701#commits-pushed-211fb1a
https://github.com/vstinner
update News Entryhttps://github.com/python/cpython/pull/15701/commits/211fb1a0d44cecf2db3763f9f04a38df2b552846
211fb1ahttps://github.com/python/cpython/pull/15701/commits/211fb1a0d44cecf2db3763f9f04a38df2b552846
https://github.com/wjssz
add {...} to if blockshttps://github.com/python/cpython/pull/15701/commits/1bebb4db87cdbcfb4c6558da0dd55961141ba041
1bebb4dhttps://github.com/python/cpython/pull/15701/commits/1bebb4db87cdbcfb4c6558da0dd55961141ba041
https://github.com/ghost
ghosthttps://github.com/ghost
Sep 7, 2019https://github.com/python/cpython/pull/15701#issuecomment-529064808
Please reload this pagehttps://github.com/python/cpython/pull/15701
Sep 7, 2019https://github.com/python/cpython/pull/15701#event-2615946809
https://github.com/ghost
ghosthttps://github.com/ghost
Sep 7, 2019https://github.com/python/cpython/pull/15701#issuecomment-529080587
Please reload this pagehttps://github.com/python/cpython/pull/15701
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/nanjekyejoannah
nanjekyejoannahhttps://github.com/nanjekyejoannah
Sep 9, 2019 https://github.com/python/cpython/pull/15701#pullrequestreview-284980635
View reviewed changes https://github.com/python/cpython/pull/15701/files/a0f335c74c2e8a6544b75f30c1791d0a7c3d41a8
nanjekyejoannahhttps://github.com/nanjekyejoannah
https://github.com/python/cpython/pull/15701#pullrequestreview-284980635
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://bugs.python.org/issue24011https://bugs.python.org/issue24011
6782b14https://github.com/python/cpython/commit/6782b14bcba612e4a39e41992c77306217b91e30
Please reload this pagehttps://github.com/python/cpython/pull/15701
Modules/signalmodule.chttps://github.com/python/cpython/pull/15701/files/a0f335c74c2e8a6544b75f30c1791d0a7c3d41a8#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
Please reload this pagehttps://github.com/python/cpython/pull/15701
Modules/signalmodule.chttps://github.com/python/cpython/pull/15701/files/a0f335c74c2e8a6544b75f30c1791d0a7c3d41a8#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/nanjekyejoannah
nanjekyejoannahhttps://github.com/nanjekyejoannah
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529266773
https://bugs.python.org/issue24011https://bugs.python.org/issue24011
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/ghost
ghosthttps://github.com/ghost
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529335344
issue24011https://bugs.python.org/issue24011
@tiranhttps://github.com/tiran
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529380078
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529380700
@vstinnerhttps://github.com/vstinner
https://bugs.python.org/issue26868https://bugs.python.org/issue26868
https://docs.python.org/dev/c-api/module.html?highlight=pymodule_addobject#c.PyModule_AddObjecthttps://docs.python.org/dev/c-api/module.html?highlight=pymodule_addobject#c.PyModule_AddObject
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529381494
@nanjekyejoannahhttps://github.com/nanjekyejoannah
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/nanjekyejoannah
nanjekyejoannahhttps://github.com/nanjekyejoannah
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529382279
@vstinnerhttps://github.com/vstinner
@animalizehttps://github.com/animalize
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529394027
@vstinnerhttps://github.com/vstinner
@animalizehttps://github.com/animalize
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529398590
@animalizehttps://github.com/animalize
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/nanjekyejoannah
nanjekyejoannahhttps://github.com/nanjekyejoannah
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529399050
Please reload this pagehttps://github.com/python/cpython/pull/15701
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/nanjekyejoannah
nanjekyejoannahhttps://github.com/nanjekyejoannah
Sep 9, 2019 https://github.com/python/cpython/pull/15701#pullrequestreview-285405387
View reviewed changes https://github.com/python/cpython/pull/15701/files/1bebb4db87cdbcfb4c6558da0dd55961141ba041
https://github.com/ghost
ghosthttps://github.com/ghost
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529413334
@animalizehttps://github.com/animalize
#15753https://github.com/python/cpython/pull/15753
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529483341
Please reload this pagehttps://github.com/python/cpython/pull/15701
#15753https://github.com/python/cpython/pull/15753
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 9, 2019https://github.com/python/cpython/pull/15701#event-2618754720
September 9, 2019 14:23https://github.com/python/cpython/pull/15701#event-2618890532
https://github.com/ghost
ghosthttps://github.com/ghost
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529505859
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Sep 9, 2019https://github.com/python/cpython/pull/15701#issuecomment-529542669
https://docs.python.org/dev/c-api/module.html?highlight=pymodule_addobject#c.PyModule_AddObjecthttps://docs.python.org/dev/c-api/module.html?highlight=pymodule_addobject#c.PyModule_AddObject
#15725https://github.com/python/cpython/pull/15725
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15701
https://github.com/berkerpeksag
berkerpeksag https://github.com/berkerpeksag
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/15701
https://github.com/brandtbucher
https://github.com/nanjekyejoannah
https://github.com/vstinner
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com/wjssz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.