René's URL Explorer Experiment


Title: gh-154511: Consolidate IDLE's mouse wheel handling in util by serhiy-storchaka · Pull Request #156974 · python/cpython · GitHub

Open Graph Title: gh-154511: Consolidate IDLE's mouse wheel handling in util by serhiy-storchaka · Pull Request #156974 · python/cpython

X Title: gh-154511: Consolidate IDLE's mouse wheel handling in util by serhiy-storchaka · Pull Request #156974 · python/cpython

Description: An alternative to #154512. wheel_event moves from idlelib.tree to idlelib.util, with its test, and gains two neighbours: x11_buttons(widget), which tells whether Tk reports a wheel rotation to that widget as /, as it does on X11 before Tk 8.7, or as , and bind_wheel(widget, func), which binds whichever of them Tk sends. The editor, the tree and test_sidebar use these instead of working out the windowing system themselves. x11_buttons takes a widget because the windowing system is a property of the display, which only a widget knows. As a module-level constant it would need a root at import time, and util must not create one: pyshell imports fix_win_hidpi from it and calls it before any Tk operation, run.py imports it in the user process, and test_idle currently runs headless. For the same reason util still imports tkinter only inside the function that needs a name from it. wheel_event now reads the direction from the event, by number for a button and by delta for a wheel, rather than from the platform, so it stays right whichever event arrives. The fix_ functions that util already had are tested too; they were only called, never checked, by the setUpClass of other test modules. fix_win_hidpi runs in a subprocess, as DPI awareness is process-wide and cannot be undone. The unneeded / bindings in sidebar.py are left for a later PR, as in gh-154511. Issue: gh-154511

Open Graph Description: An alternative to #154512. wheel_event moves from idlelib.tree to idlelib.util, with its test, and gains two neighbours: x11_buttons(widget), which tells whether Tk reports a wheel rotation to that...

X Description: An alternative to #154512. wheel_event moves from idlelib.tree to idlelib.util, with its test, and gains two neighbours: x11_buttons(widget), which tells whether Tk reports a wheel rotation to that...

Opengraph URL: https://github.com/python/cpython/pull/156974

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0afd45a2-682a-6b4f-2788-46172eac97d9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB94C:2454CC:399C816:4918980:6B01FB9C
html-safe-nonce7ee9e942bc48aa46aa7c5a3db16a8d6e3772d4c519eab2770682d8eabfaef248
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTRDOjI0NTRDQzozOTlDODE2OjQ5MTg5ODA6NkIwMUZCOUMiLCJ2aXNpdG9yX2lkIjoiMjU0Mjk3NzcyODkwMzI0ODc5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac58d48f0776f288fe0b5731be67ac04ea08c81b3d69e85c4ff2e077559e01a93c
hovercard-subject-tagpull_request:4449971363
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156974/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altAn alternative to #154512. wheel_event moves from idlelib.tree to idlelib.util, with its test, and gains two neighbours: x11_buttons(widget), which tells whether Tk reports a wheel rotation to that...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156974/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156974%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156974%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156974/files
Reloadhttps://github.com/python/cpython/pull/156974/files
Reloadhttps://github.com/python/cpython/pull/156974/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:idle-mousewheel-utilhttps://github.com/serhiy-storchaka/cpython/tree/idle-mousewheel-util
Conversation 5 https://github.com/python/cpython/pull/156974
Commits 1 https://github.com/python/cpython/pull/156974/commits
Checks 67 https://github.com/python/cpython/pull/156974/checks
Files changed https://github.com/python/cpython/pull/156974/files
Please reload this pagehttps://github.com/python/cpython/pull/156974/files
gh-154511: Consolidate IDLE's mouse wheel handling in util https://github.com/python/cpython/pull/156974/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/156974/files
98213fc gh-154511: Consolidate IDLE's mouse wheel handling in util serhiy-storchaka Sep 5, 2026 https://github.com/python/cpython/pull/156974/commits/98213fcefa936e07dc8dbfd611b2a5b150fa6322
Clear filters https://github.com/python/cpython/pull/156974/files
Please reload this pagehttps://github.com/python/cpython/pull/156974/files
Please reload this pagehttps://github.com/python/cpython/pull/156974/files
editor.py https://github.com/python/cpython/pull/156974/files#diff-0ebe4cdabcc123ccaae0e7cb5fcc54423a11b82957a8f972db70e98a1e847ae4
test_sidebar.py https://github.com/python/cpython/pull/156974/files#diff-8ba244944042d0a84a2030682a806bbb7e708e7a0046bdb5687adf32c84826fc
test_tree.py https://github.com/python/cpython/pull/156974/files#diff-09f6b3e2c43d4848b2115af8c90df5257ee7648679563330ce673ba38bfd4ca7
test_util.py https://github.com/python/cpython/pull/156974/files#diff-c1a894cc047a296cd849d18d5690513a4e7ad46d851bf324a696ac8f14132798
tree.py https://github.com/python/cpython/pull/156974/files#diff-b216f690a9863f8c4f635e8b5f850065263bbd2f1e30a30a9d4f821680e9cecd
util.py https://github.com/python/cpython/pull/156974/files#diff-a1ba7a47c4d49cdd552857a7f757a01b898ed7029e35d31b511170cd9a3e9b2e
2026-09-05-16-00-00.gh-issue-154511.hV2wQn.rst https://github.com/python/cpython/pull/156974/files#diff-560ea03adc66e50ebd836c5815b87430f62c6147bcbe90be6c72db33e21f8da4
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L508
Lib/idlelib/editor.pyhttps://github.com/python/cpython/pull/156974/files#diff-0ebe4cdabcc123ccaae0e7cb5fcc54423a11b82957a8f972db70e98a1e847ae4
View file https://github.com/serhiy-storchaka/cpython/blob/98213fcefa936e07dc8dbfd611b2a5b150fa6322/Lib/idlelib/editor.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156974/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156974/files#diff-0ebe4cdabcc123ccaae0e7cb5fcc54423a11b82957a8f972db70e98a1e847ae4
https://github.com/python/cpython/pull/156974/files#diff-0ebe4cdabcc123ccaae0e7cb5fcc54423a11b82957a8f972db70e98a1e847ae4
https://github.com/python/cpython/pull/156974/files#diff-0ebe4cdabcc123ccaae0e7cb5fcc54423a11b82957a8f972db70e98a1e847ae4
https://github.com/python/cpython/pull/156974/files#diff-0ebe4cdabcc123ccaae0e7cb5fcc54423a11b82957a8f972db70e98a1e847ae4
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L508
Lib/idlelib/idle_test/test_sidebar.pyhttps://github.com/python/cpython/pull/156974/files#diff-8ba244944042d0a84a2030682a806bbb7e708e7a0046bdb5687adf32c84826fc
View file https://github.com/serhiy-storchaka/cpython/blob/98213fcefa936e07dc8dbfd611b2a5b150fa6322/Lib/idlelib/idle_test/test_sidebar.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156974/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156974/files#diff-8ba244944042d0a84a2030682a806bbb7e708e7a0046bdb5687adf32c84826fc
https://github.com/python/cpython/pull/156974/files#diff-8ba244944042d0a84a2030682a806bbb7e708e7a0046bdb5687adf32c84826fc
https://github.com/python/cpython/pull/156974/files#diff-8ba244944042d0a84a2030682a806bbb7e708e7a0046bdb5687adf32c84826fc
https://github.com/python/cpython/pull/156974/files#diff-8ba244944042d0a84a2030682a806bbb7e708e7a0046bdb5687adf32c84826fc
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L508
Lib/idlelib/idle_test/test_tree.pyhttps://github.com/python/cpython/pull/156974/files#diff-09f6b3e2c43d4848b2115af8c90df5257ee7648679563330ce673ba38bfd4ca7
View file https://github.com/serhiy-storchaka/cpython/blob/98213fcefa936e07dc8dbfd611b2a5b150fa6322/Lib/idlelib/idle_test/test_tree.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156974/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156974/files#diff-09f6b3e2c43d4848b2115af8c90df5257ee7648679563330ce673ba38bfd4ca7
https://github.com/python/cpython/pull/156974/files#diff-09f6b3e2c43d4848b2115af8c90df5257ee7648679563330ce673ba38bfd4ca7
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L508
Lib/idlelib/idle_test/test_util.pyhttps://github.com/python/cpython/pull/156974/files#diff-c1a894cc047a296cd849d18d5690513a4e7ad46d851bf324a696ac8f14132798
View file https://github.com/serhiy-storchaka/cpython/blob/98213fcefa936e07dc8dbfd611b2a5b150fa6322/Lib/idlelib/idle_test/test_util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156974/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L508
Lib/idlelib/tree.pyhttps://github.com/python/cpython/pull/156974/files#diff-b216f690a9863f8c4f635e8b5f850065263bbd2f1e30a30a9d4f821680e9cecd
View file https://github.com/serhiy-storchaka/cpython/blob/98213fcefa936e07dc8dbfd611b2a5b150fa6322/Lib/idlelib/tree.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156974/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156974/files#diff-b216f690a9863f8c4f635e8b5f850065263bbd2f1e30a30a9d4f821680e9cecd
https://github.com/python/cpython/pull/156974/files#diff-b216f690a9863f8c4f635e8b5f850065263bbd2f1e30a30a9d4f821680e9cecd
https://github.com/python/cpython/pull/156974/files#diff-b216f690a9863f8c4f635e8b5f850065263bbd2f1e30a30a9d4f821680e9cecd
https://github.com/python/cpython/pull/156974/files#diff-b216f690a9863f8c4f635e8b5f850065263bbd2f1e30a30a9d4f821680e9cecd
https://github.com/python/cpython/pull/156974/files#diff-b216f690a9863f8c4f635e8b5f850065263bbd2f1e30a30a9d4f821680e9cecd
https://github.com/python/cpython/pull/156974/files#diff-b216f690a9863f8c4f635e8b5f850065263bbd2f1e30a30a9d4f821680e9cecd
https://github.com/python/cpython/pull/156974/files#diff-b216f690a9863f8c4f635e8b5f850065263bbd2f1e30a30a9d4f821680e9cecd
https://github.com/python/cpython/pull/156974/files#diff-b216f690a9863f8c4f635e8b5f850065263bbd2f1e30a30a9d4f821680e9cecd
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L508
Lib/idlelib/util.pyhttps://github.com/python/cpython/pull/156974/files#diff-a1ba7a47c4d49cdd552857a7f757a01b898ed7029e35d31b511170cd9a3e9b2e
View file https://github.com/serhiy-storchaka/cpython/blob/98213fcefa936e07dc8dbfd611b2a5b150fa6322/Lib/idlelib/util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156974/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156974/files#diff-a1ba7a47c4d49cdd552857a7f757a01b898ed7029e35d31b511170cd9a3e9b2e
Misc/NEWS.d/next/IDLE/2026-09-05-16-00-00.gh-issue-154511.hV2wQn.rsthttps://github.com/python/cpython/pull/156974/files#diff-560ea03adc66e50ebd836c5815b87430f62c6147bcbe90be6c72db33e21f8da4
View file https://github.com/serhiy-storchaka/cpython/blob/98213fcefa936e07dc8dbfd611b2a5b150fa6322/Misc/NEWS.d/next/IDLE/2026-09-05-16-00-00.gh-issue-154511.hV2wQn.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156974/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/156974/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.