René's URL Explorer Experiment


Title: gh-156942: Raise the exception where the marshalling error is detected by serhiy-storchaka · Pull Request #156944 · python/cpython · GitHub

Open Graph Title: gh-156942: Raise the exception where the marshalling error is detected by serhiy-storchaka · Pull Request #156944 · python/cpython

X Title: gh-156942: Raise the exception where the marshalling error is detected by serhiy-storchaka · Pull Request #156944 · python/cpython

Description: The writer now raises the exception where the error is detected, instead of recording an error code and converting it into an exception at the end. WFILE.error becomes a flag saying that an exception has been raised, w_set_exception() and all error codes except one are removed. The exception which was already raised is no longer replaced: BufferError for a non-contiguous buffer, TypeError for uncomparable set items, MemoryError for a failed allocation, and the exception raised while marshalling a set item are propagated as they are. Messages which were ValueError("unmarshallable object") now name the type of the object and, if the type is only supported by newer data formats, the required version. The error paths were mostly untested, so the tests for them are added, and the existing tests now check the error message. Issue: gh-156942

Open Graph Description: The writer now raises the exception where the error is detected, instead of recording an error code and converting it into an exception at the end. WFILE.error becomes a flag saying that an excepti...

X Description: The writer now raises the exception where the error is detected, instead of recording an error code and converting it into an exception at the end. WFILE.error becomes a flag saying that an excepti...

Opengraph URL: https://github.com/python/cpython/pull/156944

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6aa0a1fb-fc62-651e-92df-aacd0b86a60e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC7C:323204:1A235CC:22705F4:6B021845
html-safe-nonce676728795deb3083534877b53347feddeaa343ec5a255781e98bee7c19b3c6d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzdDOjMyMzIwNDoxQTIzNUNDOjIyNzA1RjQ6NkIwMjE4NDUiLCJ2aXNpdG9yX2lkIjoiMzQ0ODUxMTM3OTY4NjA5MzQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac30df75323eb801fb114dd848ea0c552911810ab8b25eb806a25ecc564a1cf98e
hovercard-subject-tagpull_request:4443687680
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156944/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altThe writer now raises the exception where the error is detected, instead of recording an error code and converting it into an exception at the end. WFILE.error becomes a flag saying that an excepti...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156944/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156944%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156944%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156944/files
Reloadhttps://github.com/python/cpython/pull/156944/files
Reloadhttps://github.com/python/cpython/pull/156944/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:marshal-write-errorshttps://github.com/serhiy-storchaka/cpython/tree/marshal-write-errors
Conversation 6 https://github.com/python/cpython/pull/156944
Commits 3 https://github.com/python/cpython/pull/156944/commits
Checks 53 https://github.com/python/cpython/pull/156944/checks
Files changed https://github.com/python/cpython/pull/156944/files
Please reload this pagehttps://github.com/python/cpython/pull/156944/files
gh-156942: Raise the exception where the marshalling error is detected https://github.com/python/cpython/pull/156944/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/156944/files
f39262d gh-156942: Raise the exception where the marshalling error is detected serhiy-storchaka Sep 4, 2026 https://github.com/python/cpython/pull/156944/commits/f39262d51ba271f6b686c5d4bea826f6e19bedb2
09be169 Merge remote-tracking branch 'upstream/main' into marshal-write-errors serhiy-storchaka Sep 18, 2026 https://github.com/python/cpython/pull/156944/commits/09be16924f2f586f82a86ccafa2c89639604dbc0
ebf552c Replace the remaining error codes with a flag serhiy-storchaka Sep 18, 2026 https://github.com/python/cpython/pull/156944/commits/ebf552c6a6cb1a9a1fdd96b8c1d24ad0b25f5223
Clear filters https://github.com/python/cpython/pull/156944/files
Please reload this pagehttps://github.com/python/cpython/pull/156944/files
Please reload this pagehttps://github.com/python/cpython/pull/156944/files
test_marshal.py https://github.com/python/cpython/pull/156944/files#diff-1fe4807b1dca21cdea56d77bb55db8e2639506879b3aab04bcefbab5ef0f9cb0
test_marshal.py https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
2026-09-04-16-12-30.gh-issue-156942.Qk7Rw2.rst https://github.com/python/cpython/pull/156944/files#diff-a9f15ee18ab8df700edc55075aff8013a6e6172c01c36f1e5fa0a6c4f8103f94
marshal.c https://github.com/python/cpython/pull/156944/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
Lib/test/test_capi/test_marshal.pyhttps://github.com/python/cpython/pull/156944/files#diff-1fe4807b1dca21cdea56d77bb55db8e2639506879b3aab04bcefbab5ef0f9cb0
View file https://github.com/serhiy-storchaka/cpython/blob/ebf552c6a6cb1a9a1fdd96b8c1d24ad0b25f5223/Lib/test/test_capi/test_marshal.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156944/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156944/files#diff-1fe4807b1dca21cdea56d77bb55db8e2639506879b3aab04bcefbab5ef0f9cb0
https://github.com/python/cpython/pull/156944/files#diff-1fe4807b1dca21cdea56d77bb55db8e2639506879b3aab04bcefbab5ef0f9cb0
https://github.com/python/cpython/pull/156944/files#diff-1fe4807b1dca21cdea56d77bb55db8e2639506879b3aab04bcefbab5ef0f9cb0
https://github.com/python/cpython/pull/156944/files#diff-1fe4807b1dca21cdea56d77bb55db8e2639506879b3aab04bcefbab5ef0f9cb0
Lib/test/test_marshal.pyhttps://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
View file https://github.com/serhiy-storchaka/cpython/blob/ebf552c6a6cb1a9a1fdd96b8c1d24ad0b25f5223/Lib/test/test_marshal.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156944/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/python/cpython/pull/156944/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
Misc/NEWS.d/next/Core_and_Builtins/2026-09-04-16-12-30.gh-issue-156942.Qk7Rw2.rsthttps://github.com/python/cpython/pull/156944/files#diff-a9f15ee18ab8df700edc55075aff8013a6e6172c01c36f1e5fa0a6c4f8103f94
View file https://github.com/serhiy-storchaka/cpython/blob/ebf552c6a6cb1a9a1fdd96b8c1d24ad0b25f5223/Misc/NEWS.d/next/Core_and_Builtins/2026-09-04-16-12-30.gh-issue-156942.Qk7Rw2.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156944/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/156944/files
Please reload this pagehttps://github.com/python/cpython/pull/156944/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.