| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f7fde6fc-1ae5-99c5-4fe4-acb14ea23901 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D31A:19B6A2:1249215:1831862:6B01E99A |
| html-safe-nonce | 88a5951e9f1404e8078cd7acdc8970eb67d0951e1a9c49f7d95be024cb4936f9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzFBOjE5QjZBMjoxMjQ5MjE1OjE4MzE4NjI6NkIwMUU5OUEiLCJ2aXNpdG9yX2lkIjoiMzY2MzYwNjA2NTkwMTIwMTgxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f3fe80b2eb20bf7981655d939012f8db01a3744d9293e8df398852936dd4a98e |
| hovercard-subject-tag | pull_request:4443652160 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/156943/files |
| twitter:image | https://avatars.githubusercontent.com/u/194129?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/194129?s=400&v=4 |
| og:image:alt | Reserve one byte in PyBytesWriter used as a canary byte: set it to a special value. PyBytesWriter_Finish() checks if the canary byte has been overriden. Add a test on the feature.
Update buffer ove... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/156943/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156943%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156943%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/156943/files |
| Reload | https://github.com/python/cpython/pull/156943/files |
| Reload | https://github.com/python/cpython/pull/156943/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| vstinner | https://github.com/vstinner |
| python:main | https://github.com/python/cpython/tree/main |
| vstinner:writer_canary | https://github.com/vstinner/cpython/tree/writer_canary |
|
Conversation
9
| https://github.com/python/cpython/pull/156943 |
|
Commits
12
| https://github.com/python/cpython/pull/156943/commits |
|
Checks
52
| https://github.com/python/cpython/pull/156943/checks |
|
Files changed
| https://github.com/python/cpython/pull/156943/files |
| Please reload this page | https://github.com/python/cpython/pull/156943/files |
|
gh-156939: Detect buffer overflow in PyBytesWriter in debug mode
| https://github.com/python/cpython/pull/156943/files#top |
|
Show all changes
12 commits
| https://github.com/python/cpython/pull/156943/files |
|
89a8ac9
gh-156939: Detect buffer overflow in PyBytesWriter in debug mode
vstinner Sep 9, 2026
| https://github.com/python/cpython/pull/156943/commits/89a8ac91f07851c8cb554bb9a4b1126523616c44 |
|
95e3701
Skip test_canary_byte on release build
vstinner Sep 9, 2026
| https://github.com/python/cpython/pull/156943/commits/95e37016f1ac0792495b9a10ce413c271c9b6357 |
|
0dbd2cc
Cleanup test_canary_byte()
vstinner Sep 9, 2026
| https://github.com/python/cpython/pull/156943/commits/0dbd2cc2855e901dcc8995d2829320509233b22a |
|
1f1d878
Merge branch 'main' into writer_canary
vstinner Sep 10, 2026
| https://github.com/python/cpython/pull/156943/commits/1f1d878dee663ff4e18781f1783f1b15605a2e15 |
|
c81cbd7
Merge branch 'main' into writer_canary
vstinner Sep 12, 2026
| https://github.com/python/cpython/pull/156943/commits/c81cbd7797fb96c5df2d51bf917ca540b40c8e5c |
|
7994e4e
Rewrite canary byte test in Python
vstinner Sep 12, 2026
| https://github.com/python/cpython/pull/156943/commits/7994e4ef758f91e9d213c1cacd4ed240055913d8 |
|
19fdcb4
Change fatal error message
vstinner Sep 12, 2026
| https://github.com/python/cpython/pull/156943/commits/19fdcb40ea031556e80d283be95b3a1d0c4af7b1 |
|
1084787
Merge branch 'main' into writer_canary
vstinner Sep 12, 2026
| https://github.com/python/cpython/pull/156943/commits/108478750de22381e3cc71e27950d143f799996b |
|
dc79819
gh-156939: Do no modify writer->size directly in UCS1 encoder
vstinner Sep 12, 2026
| https://github.com/python/cpython/pull/156943/commits/dc79819cc59108c7c8198253cad92d2a8e4eefd2 |
|
e14b81c
Update get_data() tests for canary byte
vstinner Sep 12, 2026
| https://github.com/python/cpython/pull/156943/commits/e14b81ceeae25e4ada8a61bd82656dbdaf7c9642 |
|
e029931
Skip canary byte tests on release build
vstinner Sep 12, 2026
| https://github.com/python/cpython/pull/156943/commits/e0299319be85c15af72dee645a20614300b5853e |
|
276c315
Add test_grow_error()
vstinner Sep 12, 2026
| https://github.com/python/cpython/pull/156943/commits/276c315b30a8eca713d2e47a6cca9ed741b710e6 |
|
Clear filters
| https://github.com/python/cpython/pull/156943/files |
| Please reload this page | https://github.com/python/cpython/pull/156943/files |
| Please reload this page | https://github.com/python/cpython/pull/156943/files |
|
test_bytes.py
| https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045 |
|
2026-09-04-16-41-07.gh-issue-156939.bKaQuE.rst
| https://github.com/python/cpython/pull/156943/files#diff-a38f4509d07f9bb9f903539e616f4b1c09be263020dc18eb616ff1fc3fe45015 |
|
bytes.c
| https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5 |
|
fcntlmodule.c
| https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5 |
|
bytesobject.c
| https://github.com/python/cpython/pull/156943/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51 |
|
unicodeobject.c
| https://github.com/python/cpython/pull/156943/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a |
| Lib/test/test_capi/test_bytes.py | https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045 |
|
View file
| https://github.com/vstinner/cpython/blob/276c315b30a8eca713d2e47a6cca9ed741b710e6/Lib/test/test_capi/test_bytes.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/156943/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045 |
|
| https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045 |
|
| https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045 |
|
| https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045 |
|
| https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045 |
|
| https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045 |
|
| https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045 |
|
| https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045 |
|
| https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045 |
|
| https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045 |
| Misc/NEWS.d/next/C_API/2026-09-04-16-41-07.gh-issue-156939.bKaQuE.rst | https://github.com/python/cpython/pull/156943/files#diff-a38f4509d07f9bb9f903539e616f4b1c09be263020dc18eb616ff1fc3fe45015 |
|
View file
| https://github.com/vstinner/cpython/blob/276c315b30a8eca713d2e47a6cca9ed741b710e6/Misc/NEWS.d/next/C_API/2026-09-04-16-41-07.gh-issue-156939.bKaQuE.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/156943/{{ revealButtonHref }} |
| Modules/_testcapi/bytes.c | https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5 |
|
View file
| https://github.com/vstinner/cpython/blob/276c315b30a8eca713d2e47a6cca9ed741b710e6/Modules/_testcapi/bytes.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/156943/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5 |
| Modules/fcntlmodule.c | https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5 |
|
View file
| https://github.com/vstinner/cpython/blob/276c315b30a8eca713d2e47a6cca9ed741b710e6/Modules/fcntlmodule.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/156943/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5 |
|
| https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5 |
| Please reload this page | https://github.com/python/cpython/pull/156943/files |
| Please reload this page | https://github.com/python/cpython/pull/156943/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |