René's URL Explorer Experiment


Title: gh-156939: Detect buffer overflow in PyBytesWriter in debug mode by vstinner · Pull Request #156943 · python/cpython · GitHub

Open Graph Title: gh-156939: Detect buffer overflow in PyBytesWriter in debug mode by vstinner · Pull Request #156943 · python/cpython

X Title: gh-156939: Detect buffer overflow in PyBytesWriter in debug mode by vstinner · Pull Request #156943 · python/cpython

Description: Reserve one byte in PyBytesWriter used as a canary byte: set it to a special value. PyBytesWriter_Finish() checks if the canary byte has been overriden. Add a test on the feature. Update buffer overflow check in fcntl: allocate extra guard bytes in the writer and then truncate these bytes. Issue: gh-156939

Open Graph Description: Reserve one byte in PyBytesWriter used as a canary byte: set it to a special value. PyBytesWriter_Finish() checks if the canary byte has been overriden. Add a test on the feature. Update buffer ove...

X Description: Reserve one byte in PyBytesWriter used as a canary byte: set it to a special value. PyBytesWriter_Finish() checks if the canary byte has been overriden. Add a test on the feature. Update buffer ove...

Opengraph URL: https://github.com/python/cpython/pull/156943

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f7fde6fc-1ae5-99c5-4fe4-acb14ea23901
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD31A:19B6A2:1249215:1831862:6B01E99A
html-safe-nonce88a5951e9f1404e8078cd7acdc8970eb67d0951e1a9c49f7d95be024cb4936f9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzFBOjE5QjZBMjoxMjQ5MjE1OjE4MzE4NjI6NkIwMUU5OUEiLCJ2aXNpdG9yX2lkIjoiMzY2MzYwNjA2NTkwMTIwMTgxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf3fe80b2eb20bf7981655d939012f8db01a3744d9293e8df398852936dd4a98e
hovercard-subject-tagpull_request:4443652160
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156943/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altReserve one byte in PyBytesWriter used as a canary byte: set it to a special value. PyBytesWriter_Finish() checks if the canary byte has been overriden. Add a test on the feature. Update buffer ove...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156943/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156943%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156943%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156943/files
Reloadhttps://github.com/python/cpython/pull/156943/files
Reloadhttps://github.com/python/cpython/pull/156943/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:writer_canaryhttps://github.com/vstinner/cpython/tree/writer_canary
Conversation 9 https://github.com/python/cpython/pull/156943
Commits 12 https://github.com/python/cpython/pull/156943/commits
Checks 52 https://github.com/python/cpython/pull/156943/checks
Files changed https://github.com/python/cpython/pull/156943/files
Please reload this pagehttps://github.com/python/cpython/pull/156943/files
gh-156939: Detect buffer overflow in PyBytesWriter in debug mode https://github.com/python/cpython/pull/156943/files#top
Show all changes 12 commits https://github.com/python/cpython/pull/156943/files
89a8ac9 gh-156939: Detect buffer overflow in PyBytesWriter in debug mode vstinner Sep 9, 2026 https://github.com/python/cpython/pull/156943/commits/89a8ac91f07851c8cb554bb9a4b1126523616c44
95e3701 Skip test_canary_byte on release build vstinner Sep 9, 2026 https://github.com/python/cpython/pull/156943/commits/95e37016f1ac0792495b9a10ce413c271c9b6357
0dbd2cc Cleanup test_canary_byte() vstinner Sep 9, 2026 https://github.com/python/cpython/pull/156943/commits/0dbd2cc2855e901dcc8995d2829320509233b22a
1f1d878 Merge branch 'main' into writer_canary vstinner Sep 10, 2026 https://github.com/python/cpython/pull/156943/commits/1f1d878dee663ff4e18781f1783f1b15605a2e15
c81cbd7 Merge branch 'main' into writer_canary vstinner Sep 12, 2026 https://github.com/python/cpython/pull/156943/commits/c81cbd7797fb96c5df2d51bf917ca540b40c8e5c
7994e4e Rewrite canary byte test in Python vstinner Sep 12, 2026 https://github.com/python/cpython/pull/156943/commits/7994e4ef758f91e9d213c1cacd4ed240055913d8
19fdcb4 Change fatal error message vstinner Sep 12, 2026 https://github.com/python/cpython/pull/156943/commits/19fdcb40ea031556e80d283be95b3a1d0c4af7b1
1084787 Merge branch 'main' into writer_canary vstinner Sep 12, 2026 https://github.com/python/cpython/pull/156943/commits/108478750de22381e3cc71e27950d143f799996b
dc79819 gh-156939: Do no modify writer->size directly in UCS1 encoder vstinner Sep 12, 2026 https://github.com/python/cpython/pull/156943/commits/dc79819cc59108c7c8198253cad92d2a8e4eefd2
e14b81c Update get_data() tests for canary byte vstinner Sep 12, 2026 https://github.com/python/cpython/pull/156943/commits/e14b81ceeae25e4ada8a61bd82656dbdaf7c9642
e029931 Skip canary byte tests on release build vstinner Sep 12, 2026 https://github.com/python/cpython/pull/156943/commits/e0299319be85c15af72dee645a20614300b5853e
276c315 Add test_grow_error() vstinner Sep 12, 2026 https://github.com/python/cpython/pull/156943/commits/276c315b30a8eca713d2e47a6cca9ed741b710e6
Clear filters https://github.com/python/cpython/pull/156943/files
Please reload this pagehttps://github.com/python/cpython/pull/156943/files
Please reload this pagehttps://github.com/python/cpython/pull/156943/files
test_bytes.py https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
2026-09-04-16-41-07.gh-issue-156939.bKaQuE.rst https://github.com/python/cpython/pull/156943/files#diff-a38f4509d07f9bb9f903539e616f4b1c09be263020dc18eb616ff1fc3fe45015
bytes.c https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
fcntlmodule.c https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5
bytesobject.c https://github.com/python/cpython/pull/156943/files#diff-f6d440aad34e1c4535c0d898c0197a95490766c745991caace6f64b5dd1ece51
unicodeobject.c https://github.com/python/cpython/pull/156943/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
Lib/test/test_capi/test_bytes.pyhttps://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
View file https://github.com/vstinner/cpython/blob/276c315b30a8eca713d2e47a6cca9ed741b710e6/Lib/test/test_capi/test_bytes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156943/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
https://github.com/python/cpython/pull/156943/files#diff-5b29d0835c3c1469d1e43c597f343df1bf422de8dbdcd6003b12a04957836045
Misc/NEWS.d/next/C_API/2026-09-04-16-41-07.gh-issue-156939.bKaQuE.rsthttps://github.com/python/cpython/pull/156943/files#diff-a38f4509d07f9bb9f903539e616f4b1c09be263020dc18eb616ff1fc3fe45015
View file https://github.com/vstinner/cpython/blob/276c315b30a8eca713d2e47a6cca9ed741b710e6/Misc/NEWS.d/next/C_API/2026-09-04-16-41-07.gh-issue-156939.bKaQuE.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156943/{{ revealButtonHref }}
Modules/_testcapi/bytes.chttps://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
View file https://github.com/vstinner/cpython/blob/276c315b30a8eca713d2e47a6cca9ed741b710e6/Modules/_testcapi/bytes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156943/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
https://github.com/python/cpython/pull/156943/files#diff-a5c352908f36b865db77e2bb248245ed218f8f21e83896c1cdbe43db3ae062b5
Modules/fcntlmodule.chttps://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5
View file https://github.com/vstinner/cpython/blob/276c315b30a8eca713d2e47a6cca9ed741b710e6/Modules/fcntlmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156943/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5
https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5
https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5
https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5
https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5
https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5
https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5
https://github.com/python/cpython/pull/156943/files#diff-74b3ddb13f1d0fefd76b03b088a2d3acb5a718d22b63a84f06a20f5812ffc4b5
Please reload this pagehttps://github.com/python/cpython/pull/156943/files
Please reload this pagehttps://github.com/python/cpython/pull/156943/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.