René's URL Explorer Experiment


Title: gh-156939: Detect buffer overflow in PyBytesWriter in debug mode by vstinner · Pull Request #156943 · python/cpython · GitHub

Open Graph Title: gh-156939: Detect buffer overflow in PyBytesWriter in debug mode by vstinner · Pull Request #156943 · python/cpython

X Title: gh-156939: Detect buffer overflow in PyBytesWriter in debug mode by vstinner · Pull Request #156943 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Reserve one byte in PyBytesWriter used as a canary byte: set it to a special value. PyBytesWriter_Finish() checks if the canary byte has been overriden. Add a test on the feature. Update buffer ove...

X Description: Reserve one byte in PyBytesWriter used as a canary byte: set it to a special value. PyBytesWriter_Finish() checks if the canary byte has been overriden. Add a test on the feature. Update buffer ove...

Opengraph URL: https://github.com/python/cpython/pull/156943

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:29e7de08-0e4d-5fa2-bfad-ac1fc441c487
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA584:313081:1201C1B:17C9DD2:6B01E431
html-safe-nonce11253e664dcd3d8428998d2d7b986838477c39dcc9002ec189a8e308f1a04dce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTg0OjMxMzA4MToxMjAxQzFCOjE3QzlERDI6NkIwMUU0MzEiLCJ2aXNpdG9yX2lkIjoiMjU3ODQ5NTYxODA4NzUxMTA4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4e3c07bed04bf97012204920c317bd1f351f86fd5ef4b86086c5b839248b2b68
hovercard-subject-tagpull_request:4443652160
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/156943/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f1dd3c6ad915d0bdcbde075c4a5975c31668ce219fdb0aa02a234900f0e4293e/python/cpython/pull/156943
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f1dd3c6ad915d0bdcbde075c4a5975c31668ce219fdb0aa02a234900f0e4293e/python/cpython/pull/156943
og:image:altReserve one byte in PyBytesWriter used as a canary byte: set it to a special value. PyBytesWriter_Finish() checks if the canary byte has been overriden. Add a test on the feature. Update buffer ove...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/156943#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156943
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156943
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156943
Reloadhttps://github.com/python/cpython/pull/156943
Reloadhttps://github.com/python/cpython/pull/156943
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:writer_canaryhttps://github.com/vstinner/cpython/tree/writer_canary
Conversationhttps://github.com/python/cpython/pull/156943
Commits12 (12)https://github.com/python/cpython/pull/156943/commits
Checkshttps://github.com/python/cpython/pull/156943/checks
Files changedhttps://github.com/python/cpython/pull/156943/files
gh-156939: Detect buffer overflow in PyBytesWriter in debug modehttps://github.com/python/cpython/pull/156943#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:writer_canaryhttps://github.com/vstinner/cpython/tree/writer_canary
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 4, 2026https://github.com/python/cpython/pull/156943#issue-5349505804
Please reload this pagehttps://github.com/python/cpython/pull/156943
C API: Detect buffer overflow in PyBytesWriter #156939https://github.com/python/cpython/issues/156939
Please reload this pagehttps://github.com/python/cpython/pull/156943
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 4, 2026 https://github.com/python/cpython/pull/156943#ref-issue-5349122777
C API: Detect buffer overflow in PyBytesWriter #156939 https://github.com/python/cpython/issues/156939
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 7, 2026https://github.com/python/cpython/pull/156943#issuecomment-5572937873
Please reload this pagehttps://github.com/python/cpython/pull/156943
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 7, 2026https://github.com/python/cpython/pull/156943#issuecomment-5573020346
Please reload this pagehttps://github.com/python/cpython/pull/156943
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 7, 2026https://github.com/python/cpython/pull/156943#issuecomment-5573140926
Please reload this pagehttps://github.com/python/cpython/pull/156943
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 7, 2026 https://github.com/python/cpython/pull/156943#ref-pullrequest-5377909349
gh-156939: Fix memory corruption check in fcntl #157103 https://github.com/python/cpython/pull/157103
https://github.com/vstinner
pythongh-156939https://github.com/python/cpython/issues/156939
: Detect buffer overflow in PyBytesWriter in debug modehttps://github.com/python/cpython/pull/156943/commits/89a8ac91f07851c8cb554bb9a4b1126523616c44
89a8ac9https://github.com/python/cpython/pull/156943/commits/89a8ac91f07851c8cb554bb9a4b1126523616c44
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
force-pushedhttps://github.com/python/cpython/compare/42640e3b0ff85a3498473b41d21ce175b34c7809..89a8ac91f07851c8cb554bb9a4b1126523616c44
42640e3https://github.com/python/cpython/commit/42640e3b0ff85a3498473b41d21ce175b34c7809
89a8ac9https://github.com/python/cpython/commit/89a8ac91f07851c8cb554bb9a4b1126523616c44
Compare https://github.com/python/cpython/compare/42640e3b0ff85a3498473b41d21ce175b34c7809..89a8ac91f07851c8cb554bb9a4b1126523616c44
September 9, 2026 19:38https://github.com/python/cpython/pull/156943#event-30854335915
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 9, 2026 https://github.com/python/cpython/pull/156943#ref-pullrequest-5377963365
gh-156939: Fix xmlcharrefreplace() buffer overflow #157109 https://github.com/python/cpython/pull/157109
https://github.com/vstinner
Skip test_canary_byte on release buildhttps://github.com/python/cpython/pull/156943/commits/95e37016f1ac0792495b9a10ce413c271c9b6357
95e3701https://github.com/python/cpython/pull/156943/commits/95e37016f1ac0792495b9a10ce413c271c9b6357
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 9, 2026https://github.com/python/cpython/pull/156943#issuecomment-5607795486
gh-157071https://github.com/python/cpython/pull/157071
gh-157109https://github.com/python/cpython/pull/157109
Please reload this pagehttps://github.com/python/cpython/pull/156943
https://github.com/vstinner
Cleanup test_canary_byte()https://github.com/python/cpython/pull/156943/commits/0dbd2cc2855e901dcc8995d2829320509233b22a
0dbd2cchttps://github.com/python/cpython/pull/156943/commits/0dbd2cc2855e901dcc8995d2829320509233b22a
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
topic-C-API https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-C-API
Sep 9, 2026https://github.com/python/cpython/pull/156943#event-30855780463
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
September 9, 2026 20:42https://github.com/python/cpython/pull/156943#event-30857813711
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 9, 2026https://github.com/python/cpython/pull/156943#event-30857816549
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 9, 2026https://github.com/python/cpython/pull/156943#issuecomment-5608468676
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/156943
https://github.com/vstinner
Merge branch 'main' into writer_canaryhttps://github.com/python/cpython/pull/156943/commits/1f1d878dee663ff4e18781f1783f1b15605a2e15
1f1d878https://github.com/python/cpython/pull/156943/commits/1f1d878dee663ff4e18781f1783f1b15605a2e15
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 11, 2026 https://github.com/python/cpython/pull/156943#ref-pullrequest-5406304114
gh-157242: Fix PyBytesWriter_Resize() on MemoryError #157243 https://github.com/python/cpython/pull/157243
vstinnerhttps://github.com/vstinner
September 12, 2026 19:21https://github.com/python/cpython/pull/156943#commits-pushed-c81cbd7
https://github.com/vstinner
Merge branch 'main' into writer_canaryhttps://github.com/python/cpython/pull/156943/commits/c81cbd7797fb96c5df2d51bf917ca540b40c8e5c
c81cbd7https://github.com/python/cpython/pull/156943/commits/c81cbd7797fb96c5df2d51bf917ca540b40c8e5c
https://github.com/vstinner
Rewrite canary byte test in Pythonhttps://github.com/python/cpython/pull/156943/commits/7994e4ef758f91e9d213c1cacd4ed240055913d8
7994e4ehttps://github.com/python/cpython/pull/156943/commits/7994e4ef758f91e9d213c1cacd4ed240055913d8
https://github.com/vstinner
Change fatal error messagehttps://github.com/python/cpython/pull/156943/commits/19fdcb40ea031556e80d283be95b3a1d0c4af7b1
19fdcb4https://github.com/python/cpython/pull/156943/commits/19fdcb40ea031556e80d283be95b3a1d0c4af7b1
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
September 12, 2026 17:46https://github.com/python/cpython/pull/156943#event-31028545296
vstinnerhttps://github.com/vstinner
September 12, 2026 22:16https://github.com/python/cpython/pull/156943#commits-pushed-1084787
https://github.com/vstinner
Merge branch 'main' into writer_canaryhttps://github.com/python/cpython/pull/156943/commits/108478750de22381e3cc71e27950d143f799996b
1084787https://github.com/python/cpython/pull/156943/commits/108478750de22381e3cc71e27950d143f799996b
https://github.com/vstinner
pythongh-156939https://github.com/python/cpython/issues/156939
: Do no modify writer->size directly in UCS1 encoderhttps://github.com/python/cpython/pull/156943/commits/dc79819cc59108c7c8198253cad92d2a8e4eefd2
dc79819https://github.com/python/cpython/pull/156943/commits/dc79819cc59108c7c8198253cad92d2a8e4eefd2
https://github.com/vstinner
Update get_data() tests for canary bytehttps://github.com/python/cpython/pull/156943/commits/e14b81ceeae25e4ada8a61bd82656dbdaf7c9642
e14b81chttps://github.com/python/cpython/pull/156943/commits/e14b81ceeae25e4ada8a61bd82656dbdaf7c9642
https://github.com/vstinner
Skip canary byte tests on release buildhttps://github.com/python/cpython/pull/156943/commits/e0299319be85c15af72dee645a20614300b5853e
e029931https://github.com/python/cpython/pull/156943/commits/e0299319be85c15af72dee645a20614300b5853e
https://github.com/vstinner
Add test_grow_error()https://github.com/python/cpython/pull/156943/commits/276c315b30a8eca713d2e47a6cca9ed741b710e6
276c315https://github.com/python/cpython/pull/156943/commits/276c315b30a8eca713d2e47a6cca9ed741b710e6
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
12a1de1https://github.com/python/cpython/commit/12a1de1a4e22732700cf7d8fd75ebff4b6e0513d
Sep 13, 2026https://github.com/python/cpython/pull/156943#event-31037897104
Please reload this pagehttps://github.com/python/cpython/pull/156943
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
September 13, 2026 00:28https://github.com/python/cpython/pull/156943#event-31037897514
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 13, 2026https://github.com/python/cpython/pull/156943#event-31037898222
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 13, 2026https://github.com/python/cpython/pull/156943#issuecomment-5649689784
Please reload this pagehttps://github.com/python/cpython/pull/156943
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 13, 2026https://github.com/python/cpython/pull/156943#issuecomment-5649704060
gh-157383https://github.com/python/cpython/pull/157383
Please reload this pagehttps://github.com/python/cpython/pull/156943
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 13, 2026https://github.com/python/cpython/pull/156943#issuecomment-5649799352
12a1de1https://github.com/python/cpython/commit/12a1de1a4e22732700cf7d8fd75ebff4b6e0513d
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/#/builders/1594/builds/5913https://buildbot.python.org/#/builders/1594/builds/5913
12a1de1https://github.com/python/cpython/commit/12a1de1a4e22732700cf7d8fd75ebff4b6e0513d
https://buildbot.python.org/#/builders/1594/builds/5913https://buildbot.python.org/#/builders/1594/builds/5913
Please reload this pagehttps://github.com/python/cpython/pull/156943
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 13, 2026https://github.com/python/cpython/pull/156943#issuecomment-5650057135
12a1de1https://github.com/python/cpython/commit/12a1de1a4e22732700cf7d8fd75ebff4b6e0513d
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/#/builders/1591/builds/5239https://buildbot.python.org/#/builders/1591/builds/5239
12a1de1https://github.com/python/cpython/commit/12a1de1a4e22732700cf7d8fd75ebff4b6e0513d
https://buildbot.python.org/#/builders/1591/builds/5239https://buildbot.python.org/#/builders/1591/builds/5239
Please reload this pagehttps://github.com/python/cpython/pull/156943
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 13, 2026 https://github.com/python/cpython/pull/156943#ref-pullrequest-5436777994
gh-156939: Detect buffer overflow in bytearray #157382 https://github.com/python/cpython/pull/157382
johnslavikhttps://github.com/johnslavik
Sep 14, 2026 https://github.com/python/cpython/pull/156943#ref-commit-39d7d43
https://github.com/vstinner
https://github.com/johnslavik
pythongh-156939https://github.com/python/cpython/issues/156939
: Detect buffer overflow in PyBytesWriter in debug mode (https://github.com/johnslavik/cpython/commit/39d7d4316fc768333deb805709bdb662b9caea4e
39d7d43https://github.com/johnslavik/cpython/commit/39d7d4316fc768333deb805709bdb662b9caea4e
python#156943https://github.com/python/cpython/pull/156943
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156943
Please reload this pagehttps://github.com/python/cpython/pull/156943
topic-C-API https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-C-API
Please reload this pagehttps://github.com/python/cpython/pull/156943
https://github.com/vstinner
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.