René's URL Explorer Experiment


Title: gh-156894: Fix the position of syntax errors which cover a range by serhiy-storchaka · Pull Request #156901 · python/cpython · GitHub

Open Graph Title: gh-156894: Fix the position of syntax errors which cover a range by serhiy-storchaka · Pull Request #156901 · python/cpython

X Title: gh-156894: Fix the position of syntax errors which cover a range by serhiy-storchaka · Pull Request #156901 · python/cpython

Description: SyntaxError.offset and end_offset are columns in characters, but all callers of _PyTokenizer_syntaxerror_known_range() pass columns in bytes, so the reported position drifts by one column per preceding non-ASCII character: >>> compile("abcd = 00010", "", "exec") # before and after File "", line 1 abcd = 00010 ^^^ >>> compile("αβγδ = 00010", "", "exec") # before File "", line 1 αβγδ = 00010 ^ >>> compile("αβγδ = 00010", "", "exec") # after File "", line 1 αβγδ = 00010 ^^^ The conversion is done in _syntaxerror_range(), so all three call sites are fixed at once, and the -1 case is unaffected: it already counts characters. test_tokenize.test_tolerant_incompatible_prefix_position_after_non_ascii asserted the column in bytes, so its expected value changes from 6 to 5. Issue: gh-156894

Open Graph Description: SyntaxError.offset and end_offset are columns in characters, but all callers of _PyTokenizer_syntaxerror_known_range() pass columns in bytes, so the reported position drifts by one column per prece...

X Description: SyntaxError.offset and end_offset are columns in characters, but all callers of _PyTokenizer_syntaxerror_known_range() pass columns in bytes, so the reported position drifts by one column per prece...

Opengraph URL: https://github.com/python/cpython/pull/156901

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:be1c7c95-09d8-68d9-ada0-95d7a67348e9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id94D6:24645:150D37C:1BC8FDC:6B01F899
html-safe-nonce2419122e720c710f030eed276cb304327501c8a7893a46f613ee60720b6b8105
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEQ2OjI0NjQ1OjE1MEQzN0M6MUJDOEZEQzo2QjAxRjg5OSIsInZpc2l0b3JfaWQiOiIyODEwODI4NDE2NTE1OTYzMDMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca94ef47b9d6573a1fcffd309b5bfb5aa225a7ff6ae49cb5aff99ca3e4008bed0
hovercard-subject-tagpull_request:4434920020
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/156901/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altSyntaxError.offset and end_offset are columns in characters, but all callers of _PyTokenizer_syntaxerror_known_range() pass columns in bytes, so the reported position drifts by one column per prece...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/156901/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156901%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156901%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156901/files
Reloadhttps://github.com/python/cpython/pull/156901/files
Reloadhttps://github.com/python/cpython/pull/156901/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:fix-156894-range-offsetshttps://github.com/serhiy-storchaka/cpython/tree/fix-156894-range-offsets
Conversation 9 https://github.com/python/cpython/pull/156901
Commits 2 https://github.com/python/cpython/pull/156901/commits
Checks 64 https://github.com/python/cpython/pull/156901/checks
Files changed https://github.com/python/cpython/pull/156901/files
Please reload this pagehttps://github.com/python/cpython/pull/156901/files
gh-156894: Fix the position of syntax errors which cover a range https://github.com/python/cpython/pull/156901/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/156901/files
a1065a9 gh-156894: Fix the position of syntax errors which cover a range serhiy-storchaka Sep 3, 2026 https://github.com/python/cpython/pull/156901/commits/a1065a9392967d024c69039b85d4101b8dcf1a45
14f49de Add test cases with combining characters serhiy-storchaka Sep 4, 2026 https://github.com/python/cpython/pull/156901/commits/14f49deda74496805d83d53beeb23d7827b7cb5b
Clear filters https://github.com/python/cpython/pull/156901/files
Please reload this pagehttps://github.com/python/cpython/pull/156901/files
Please reload this pagehttps://github.com/python/cpython/pull/156901/files
test_exceptions.py https://github.com/python/cpython/pull/156901/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
test_tokenize.py https://github.com/python/cpython/pull/156901/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
2026-09-03-15-20-00.gh-issue-156894.Rt9Bx4.rst https://github.com/python/cpython/pull/156901/files#diff-843a86ef575e70d3536be7b278b270567a7a7cd55e58aacd8fc6ef4a4b3a22e6
helpers.c https://github.com/python/cpython/pull/156901/files#diff-2f9c676ca7974a32907e7c98153e5942c869a80c67d2fd075acb5b589b45eddb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L247
Lib/test/test_exceptions.pyhttps://github.com/python/cpython/pull/156901/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
View file https://github.com/serhiy-storchaka/cpython/blob/14f49deda74496805d83d53beeb23d7827b7cb5b/Lib/test/test_exceptions.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156901/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156901/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
grayjkhttps://github.com/grayjk
Sep 3, 2026https://github.com/python/cpython/pull/156901/files#r3927002047
Please reload this pagehttps://github.com/python/cpython/pull/156901/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/156901/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 4, 2026https://github.com/python/cpython/pull/156901/files#r3932626684
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/156901/files
https://github.com/python/cpython/pull/156901/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L311
Lib/test/test_tokenize.pyhttps://github.com/python/cpython/pull/156901/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
View file https://github.com/serhiy-storchaka/cpython/blob/14f49deda74496805d83d53beeb23d7827b7cb5b/Lib/test/test_tokenize.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156901/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156901/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
https://github.com/python/cpython/pull/156901/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
Misc/NEWS.d/next/Core_and_Builtins/2026-09-03-15-20-00.gh-issue-156894.Rt9Bx4.rsthttps://github.com/python/cpython/pull/156901/files#diff-843a86ef575e70d3536be7b278b270567a7a7cd55e58aacd8fc6ef4a4b3a22e6
View file https://github.com/serhiy-storchaka/cpython/blob/14f49deda74496805d83d53beeb23d7827b7cb5b/Misc/NEWS.d/next/Core_and_Builtins/2026-09-03-15-20-00.gh-issue-156894.Rt9Bx4.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156901/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L313
Parser/tokenizer/helpers.chttps://github.com/python/cpython/pull/156901/files#diff-2f9c676ca7974a32907e7c98153e5942c869a80c67d2fd075acb5b589b45eddb
View file https://github.com/serhiy-storchaka/cpython/blob/14f49deda74496805d83d53beeb23d7827b7cb5b/Parser/tokenizer/helpers.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/156901/{{ revealButtonHref }}
https://github.com/python/cpython/pull/156901/files#diff-2f9c676ca7974a32907e7c98153e5942c869a80c67d2fd075acb5b589b45eddb
https://github.com/python/cpython/pull/156901/files#diff-2f9c676ca7974a32907e7c98153e5942c869a80c67d2fd075acb5b589b45eddb
https://github.com/python/cpython/pull/156901/files#diff-2f9c676ca7974a32907e7c98153e5942c869a80c67d2fd075acb5b589b45eddb
Please reload this pagehttps://github.com/python/cpython/pull/156901/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.