René's URL Explorer Experiment


Title: gh-156865: struct.pack() check for overflows for Zf type by skirpichev · Pull Request #156868 · python/cpython · GitHub

Open Graph Title: gh-156865: struct.pack() check for overflows for Zf type by skirpichev · Pull Request #156868 · python/cpython

X Title: gh-156865: struct.pack() check for overflows for Zf type by skirpichev · Pull Request #156868 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Issue: Overflows happened silently in array.array setters for 'e', 'f' and 'Zf' format types #156865

X Description: Issue: Overflows happened silently in array.array setters for 'e', 'f' and 'Zf' format types #156865

Opengraph URL: https://github.com/python/cpython/pull/156868

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:456a7ce3-cad7-46ef-cb59-3e8b9612fedf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCFEC:A99C2:43357C1:5542723:6B02151D
html-safe-nonce45a67d7623bcc9a3f1fb75dfb59b617beae071ac125ed0d9627db3bc79c220e7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkVDOkE5OUMyOjQzMzU3QzE6NTU0MjcyMzo2QjAyMTUxRCIsInZpc2l0b3JfaWQiOiI2OTU2ODQ5MDA4MzU0NjYxNjYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3f2b04aea4912cd7be3282695b5a2579ca5dc695b587a5b13a7494a61aa74eb1
hovercard-subject-tagpull_request:4428258767
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/156868/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/71b57303bfb25d6f4dfc2f4e4da3ac2bba1e804a3769b638a058bf1c07a4118d/python/cpython/pull/156868
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/71b57303bfb25d6f4dfc2f4e4da3ac2bba1e804a3769b638a058bf1c07a4118d/python/cpython/pull/156868
og:image:altIssue: Overflows happened silently in array.array setters for 'e', 'f' and 'Zf' format types #156865
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameskirpichev
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/156868#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156868
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156868
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/156868
Reloadhttps://github.com/python/cpython/pull/156868
Reloadhttps://github.com/python/cpython/pull/156868
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
skirpichev:overflows-in-Zf/156867https://github.com/skirpichev/cpython/tree/overflows-in-Zf/156867
Conversationhttps://github.com/python/cpython/pull/156868
Commits6 (6)https://github.com/python/cpython/pull/156868/commits
Checkshttps://github.com/python/cpython/pull/156868/checks
Files changedhttps://github.com/python/cpython/pull/156868/files
gh-156865: struct.pack() check for overflows for Zf typehttps://github.com/python/cpython/pull/156868#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
skirpichev:overflows-in-Zf/156867https://github.com/skirpichev/cpython/tree/overflows-in-Zf/156867
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
Sep 3, 2026https://github.com/python/cpython/pull/156868#issue-5331138974
Please reload this pagehttps://github.com/python/cpython/pull/156868
Overflows happened silently in array.array setters for 'e', 'f' and 'Zf' format types #156865https://github.com/python/cpython/issues/156865
Please reload this pagehttps://github.com/python/cpython/pull/156868
https://github.com/skirpichev
pythongh-156867https://github.com/python/cpython/issues/156867
: struct.pack() check for overflows for Zf typehttps://github.com/python/cpython/pull/156868/commits/b3e8b3371d93451b0186cd28506e3c8b96186c37
b3e8b33https://github.com/python/cpython/pull/156868/commits/b3e8b3371d93451b0186cd28506e3c8b96186c37
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 3, 2026 https://github.com/python/cpython/pull/156868#ref-issue-5331027735
struct.pack() doesn't checks overflows for native 'Zf' format type #156867 https://github.com/python/cpython/issues/156867
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 3, 2026https://github.com/python/cpython/pull/156868#event-30456664992
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
vstinnerhttps://github.com/vstinner
September 3, 2026 01:38https://github.com/python/cpython/pull/156868#event-30456669680
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.15
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.15
Sep 3, 2026https://github.com/python/cpython/pull/156868#event-30456677207
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
Sep 3, 2026https://github.com/python/cpython/pull/156868#event-30483223558
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 3, 2026 https://github.com/python/cpython/pull/156868#ref-issue-5330471171
Overflows happened silently in array.array setters for 'e', 'f' and 'Zf' format types #156865 https://github.com/python/cpython/issues/156865
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Sep 3, 2026https://github.com/python/cpython/pull/156868#event-30488683674
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 18, 2026 https://github.com/python/cpython/pull/156868#pullrequestreview-5249508507
View reviewed changes https://github.com/python/cpython/pull/156868/files/b3e8b3371d93451b0186cd28506e3c8b96186c37
Modules/_struct.chttps://github.com/python/cpython/pull/156868/files/b3e8b3371d93451b0186cd28506e3c8b96186c37#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
Please reload this pagehttps://github.com/python/cpython/pull/156868
Lib/test/test_struct.pyhttps://github.com/python/cpython/pull/156868/files/b3e8b3371d93451b0186cd28506e3c8b96186c37#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
Please reload this pagehttps://github.com/python/cpython/pull/156868
skirpichevhttps://github.com/skirpichev
September 19, 2026 02:48https://github.com/python/cpython/pull/156868#commits-pushed-9201d77
https://github.com/skirpichev
https://github.com/vstinner
Update Lib/test/test_struct.pyhttps://github.com/python/cpython/pull/156868/commits/9201d773c6ed7b49ae9ee3c81993e055e1557bf2
9201d77https://github.com/python/cpython/pull/156868/commits/9201d773c6ed7b49ae9ee3c81993e055e1557bf2
https://github.com/skirpichev
Merge branch 'master' into overflows-in-Zf/156867https://github.com/python/cpython/pull/156868/commits/33ab0fd414da1bd697be9d52b0f43c97e5312e30
33ab0fdhttps://github.com/python/cpython/pull/156868/commits/33ab0fd414da1bd697be9d52b0f43c97e5312e30
https://github.com/skirpichev
address review: ensure buffer unmodified on overflowhttps://github.com/python/cpython/pull/156868/commits/cc09ac82b2c7eb0a2b396d36c3f44c565f81cf80
cc09ac8https://github.com/python/cpython/pull/156868/commits/cc09ac82b2c7eb0a2b396d36c3f44c565f81cf80
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
vstinnerhttps://github.com/vstinner
September 19, 2026 00:00https://github.com/python/cpython/pull/156868#event-31425980852
https://github.com/skirpichev
+ fix bp/lp_float_complex + indentationhttps://github.com/python/cpython/pull/156868/commits/901201f10629047e6f2b24594ae230e18ef77ba3
901201fhttps://github.com/python/cpython/pull/156868/commits/901201f10629047e6f2b24594ae230e18ef77ba3
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 23, 2026 https://github.com/python/cpython/pull/156868#pullrequestreview-5291664962
View reviewed changes https://github.com/python/cpython/pull/156868/files/901201f10629047e6f2b24594ae230e18ef77ba3
Lib/test/test_struct.pyhttps://github.com/python/cpython/pull/156868/files/901201f10629047e6f2b24594ae230e18ef77ba3#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
Please reload this pagehttps://github.com/python/cpython/pull/156868
https://github.com/skirpichev
https://github.com/vstinner
Apply suggestion fromhttps://github.com/python/cpython/pull/156868/commits/465944bc3714c86c6753e36a12cfa40f5245e9d7
@vstinnerhttps://github.com/vstinner
465944bhttps://github.com/python/cpython/pull/156868/commits/465944bc3714c86c6753e36a12cfa40f5245e9d7
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
0b447bahttps://github.com/python/cpython/commit/0b447baeaac43723be7d4903d90f22780cc7e374
Sep 24, 2026https://github.com/python/cpython/pull/156868#event-31740612396
Please reload this pagehttps://github.com/python/cpython/pull/156868
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 24, 2026https://github.com/python/cpython/pull/156868#event-31740616094
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 24, 2026https://github.com/python/cpython/pull/156868#issuecomment-5810715655
Please reload this pagehttps://github.com/python/cpython/pull/156868
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
September 24, 2026 08:42https://github.com/python/cpython/pull/156868#event-31741117654
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F156868
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/156868/files/901201f10629047e6f2b24594ae230e18ef77ba3
Please reload this pagehttps://github.com/python/cpython/pull/156868
Please reload this pagehttps://github.com/python/cpython/pull/156868
https://github.com/skirpichev
https://github.com/vstinner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.